)]}'
{"id":"openstack%2Fpython-magnumclient~393586","triplet_id":"openstack%2Fpython-magnumclient~master~I039492dec445c8aa7f0cb39f7922b016f6ac42c3","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1639119","hashtags":[],"change_id":"I039492dec445c8aa7f0cb39f7922b016f6ac42c3","subject":"Fix: Creation of cluster without floating ip","status":"ABANDONED","created":"2016-11-04 04:42:35.000000000","updated":"2016-11-23 06:40:38.000000000","total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2f200b7d8ff0ea685e930c391aca2eeabde4c3ec","_number":393586,"virtual_id_number":393586,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":-1,"date":"2016-11-22 16:31:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"date":"2016-11-04 09:29:47.000000000","_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},{"value":-1,"date":"2016-11-04 06:42:07.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":-1,"date":"2016-11-22 04:04:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"date":"2016-11-08 17:44:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-11-07 20:20:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":-1,"date":"2016-11-08 18:04:39.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":-1,"date":"2016-11-10 06:31:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"date":"2016-11-07 21:51:21.000000000","_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-04 06:42:07.000000000","updated_by":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"reviewer":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"state":"REVIEWER"},{"updated":"2016-11-07 20:20:04.000000000","updated_by":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"reviewer":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"state":"REVIEWER"},{"updated":"2016-11-07 21:51:21.000000000","updated_by":{"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},"reviewer":{"_account_id":23297,"name":"Tushar Karkera","email":"tushar.karkera@dell.com"},"state":"REVIEWER"},{"updated":"2016-11-08 17:44:26.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2016-11-08 18:04:39.000000000","updated_by":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"reviewer":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"state":"REVIEWER"},{"updated":"2016-11-10 06:31:48.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2016-11-22 04:04:41.000000000","updated_by":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"reviewer":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"state":"REVIEWER"},{"updated":"2016-11-22 16:31:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"47257504cc422bcd6b13d024c9d133c9bdfadf10","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-04 04:42:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8a8f6c4c44a360ba40e65766b8885865a291ad71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-04 04:46:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/86/393586/1/check/gate-python-magnumclient-docs-ubuntu-xenial/635075d//doc/build/html/ : SUCCESS in 3m 45s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/86/393586/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/1b64281/ : SUCCESS in 2m 06s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/86/393586/1/check/gate-python-magnumclient-python27-ubuntu-xenial/3db358b/ : SUCCESS in 2m 07s\n- gate-python-magnumclient-python34 http://logs.openstack.org/86/393586/1/check/gate-python-magnumclient-python34/dde4d89/ : SUCCESS in 2m 44s\n- gate-python-magnumclient-python35 http://logs.openstack.org/86/393586/1/check/gate-python-magnumclient-python35/c28d481/ : SUCCESS in 2m 40s","accounts_in_message":[],"_revision_number":1},{"id":"6d79a9ca67d1796150b1a3fb0a752d6faa24cee5","author":{"_account_id":12385,"name":"Motohiro/Yuanying Otsuka","email":"yuanying@fraction.jp","username":"yuanying"},"date":"2016-11-04 06:42:07.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"597a93744c063aa596bbae5e3afe1a756b382d6a","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-04 09:29:47.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"5065e026e064e24f67faf6d249bb9157ecc9697d","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2016-11-04 09:31:37.000000000","message":"Patch Set 1: Code-Review+2\n\nWill test later, LGTM though.","accounts_in_message":[],"_revision_number":1},{"id":"02ab25c4bfd75f2907439a829fa0852aa25062c5","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-07 20:20:04.000000000","message":"Patch Set 1: Code-Review-1\n\nThis patch is confusing. As per the IRC conversion between tango, swatson, and I, I propose the flag should remain as --floating-ip-enabled, with action\u003d\u0027store_true\u0027 and default\u003dFalse.","accounts_in_message":[],"_revision_number":1},{"id":"9e211b2a24047fcd24786746d1415f93fc98c17a","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2016-11-07 20:53:03.000000000","message":"Patch Set 1:\n\nThe normal cases are tls_disabled and master_lb_enabled.\n\n* The default case for tls_disabled is (to have tls) so tls_disabled\u003dfalse and\n* for LB is (to not have LB) master_lb_enabled\u003dfalse.\n\nIn the above cases, when you don\u0027t pass the flag the client sends false.\n\nFor fips,  the field is floating_ip_enabled and the default is (to have fips). Since the default action is to have, we should have done it like in tls. Having the field floating_ip_disabled and defaulting to false. Then, when you pass the flag --floating-ip-disabled, the client send true and results disabling fips.\n\nAlternatively, the client on create could work like in update where you set the value of the boolean. (floating_ip_enabled\u003dtrue or false). I don\u0027t know if any openstack client does this.\n\nBottom line, we did a strange selection on the field given the default option and the client now is even more strange.\n\nIf we do default\u003dfalse and stores\u003dtrue, we change the default behavior which is to have fips.\n\nBTW, in this cycle we agreed to make this type enum, with three modes :)","accounts_in_message":[],"_revision_number":1},{"id":"443176b721997511e642db868c3b260e82963a85","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-08 03:35:20.000000000","message":"Patch Set 1:\n\n\u003c\u003c\u003c This patch is confusing. As per the IRC conversion between tango, swatson, and I, I propose the flag should remain as --floating-ip-enabled, with action\u003d\u0027store_true\u0027 and default\u003dFalse.\n\n\u003e\u003e\u003e @Drago, Doing suggested change will change the default behaviour (floating ip enabled on server side), And after the change suggested by you, users have to pass --floating-ip-enabled while creating cluster-template to get the default behaviour. So, it doesn\u0027t seems OK.\n\nYes, if changing the default behaviour on server side, then it can be done. But as far i checked the discussion on the patch for enabling floating ip, it was decided to make default enabling floating ip.\nBut if it is required to change the default behaviour i can change it.\nAnd i think that will require alternative way to access cluster nodes(through ip netns)\nAnd as Spyros mentioned, for this cycle enums(all, master,workers) for enabling/disabling fip are targeted with nodegroups implementation i think. So, can consider what changes are planned there.\n\nAnd As Spyros pointed, all points are valid and i thought for all of them and came up with this patch.\n\n\u003c\u003cAlternatively, the client on create could work like in update where you set the value of the boolean. (floating_ip_enabled\u003dtrue or false). I don\u0027t know if any openstack client does this.\n\nOnly this i thought of to keep the same param: floating-ip-enabled,\nbut that require Extra arg(False) to disable, that i thought of is not good for boolean values and decided to give end user the keyword that makes more sense to him.\n\nSo i would like to now your final opinion on what to change and then i will proceed with your suggestions.","accounts_in_message":[],"_revision_number":1},{"id":"5e3522bd497403c76eef7d3c17db76b6eb1177d8","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-08 04:27:14.000000000","message":"Patch Set 1:\n\nI checked the IRC and found:\n\u003ctonanhngo\u003e It\u0027s a trade-off we have to consider, changing the behavior for the better and risking surprising the user.\n\u003ctonanhngo\u003e But in general, I think the default should be the path of least resistance.\n\nSo, should change default behaviour and update the release notes. May be it can be discussed in open session in weekely meeting.","accounts_in_message":[],"_revision_number":1},{"id":"3511e99fba203d71b93337d8e001e938b9ba2216","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-08 13:02:52.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n\u003e \u003e\u003e\u003e @Drago, Doing suggested change will change the default\n \u003e behaviour (floating ip enabled on server side), And after the\n \u003e change suggested by you, users have to pass --floating-ip-enabled\n \u003e while creating cluster-template to get the default behaviour. So,\n \u003e it doesn\u0027t seems OK.\n \u003e \n \u003e Yes, if changing the default behaviour on server side\n\nGood point. I think the client\u0027s default should match the default server side too.\n\nI have provided comments because even though the logic in this patch does this, it\u0027s confusing to read.\n\nSomething else to consider: the latest client does not work with older versions of magnum, such as Mitaka, because it sends parameters such as floating_ip_enabled no matter what. Perhaps in the absence of --floating-ip-disabled, the client should not include the floating_ip_enabled parameter in the request? This way it still uses the server\u0027s default. On that note, would it then make sense to also include --floating-ip-enabled, so that the user could explicitly set the flag? This would be ideal in a future case where operators will probably be able to configure ClusterTemplate defaults themselves.","accounts_in_message":[],"_revision_number":1},{"id":"20d93572099245d0887ade3ea3cad9795cc3de23","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2016-11-08 14:45:59.000000000","message":"Patch Set 1:\n\nBoth options work fine. +2 for me for both cases.","accounts_in_message":[],"_revision_number":1},{"id":"0ee9b9498c88f3e4fe06c661244b70c6e7554abd","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2016-11-08 17:44:26.000000000","message":"Patch Set 1: -Code-Review\n\n@yatin, I think we can use the enum type now and then add the third option for fips only on master nodes.\n\nhttps://review.openstack.org/#/c/395095","accounts_in_message":[],"_revision_number":1},{"id":"ea75f46d57ef05b9855e1b1975317e41a03ae7f9","author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"date":"2016-11-08 18:04:39.000000000","message":"Patch Set 1: Code-Review-1\n\nSpyros is correct, per the discussion in the design session at the Summit we need to provide 3 choices so enum is necessary.","accounts_in_message":[],"_revision_number":1},{"id":"cad95342b7e6b2c67814b573d2f45be38e62ea42","author":{"_account_id":9591,"name":"Ton Ngo","email":"ton@us.ibm.com","username":"tango"},"date":"2016-11-08 18:53:00.000000000","message":"Patch Set 1:\n\nSince this bug exists in the Newton stable branch, maybe we should fix the boolean option there and put the new enum option in master.","accounts_in_message":[],"_revision_number":1},{"id":"03218582fe791ca5410c81ea2002309fb04ac19f","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-09 03:57:54.000000000","message":"Patch Set 1:\n\nThanks Spyros, Drago, yuanying and Ton\nI will revise the patches for stable/newton(boolean one) and master(enum approach) after checking the proposed change on magnum,\n as mentioned in comments.","accounts_in_message":[],"_revision_number":1},{"id":"89e976b9342b496f3ba15ba0f4a707c1f8a6b733","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-09 05:41:48.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nstable/newton patch: https://review.openstack.org/#/c/395400/\n\n@Drago,\n\n\u003c\u003c Something else to consider: the latest client does not work with older versions of magnum, such as Mitaka, because it sends parameters such as floating_ip_enabled no matter what. Perhaps in the absence of --floating-ip-disabled, the client should not include the floating_ip_enabled parameter in the request? This way it still uses the server\u0027s default. On that note, would it then make sense to also include --floating-ip-enabled, so that the user could explicitly set the flag? This would be ideal in a future case where operators will probably be able to configure ClusterTemplate defaults themselves.\n\nI think your concern is valid and is for other parameters also like master_lb_enabled. Should this be handled here(and in patch against stable/newton) or require other patch for all such parameters.\nOr you need to include that in the nodegroup bp.","accounts_in_message":[],"_revision_number":1},{"id":"6890bb4f6b3992a5af0536c1fa4647d97bef8c69","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-09 15:53:10.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"800f29468f5e3f16236decac0a0ddca9723cde7f","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-09 15:58:33.000000000","message":"Patch Set 1:\n\n@yatin\n\n \u003e I think your concern is valid and is for other parameters also like\n \u003e master_lb_enabled. Should this be handled here(and in patch against\n \u003e stable/newton) or require other patch for all such parameters.\n \u003e Or you need to include that in the nodegroup bp.\n\nThis would not have any effect until operator-specified defaults are implemented. It might make ClusterTemplate creation easier when the user wants to use --no-defaults (see the spec), but I don\u0027t think it\u0027s strictly tied to the NodeGroups API.","accounts_in_message":[],"_revision_number":1},{"id":"b054c588b11d68836d05e4c16715beeb2d161b94","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-10 04:59:58.000000000","message":"Patch Set 1:\n\n@Drago,\n\n\u003c\u003c\u003c This would not have any effect until operator-specified defaults are implemented. It might make ClusterTemplate creation easier when the user wants to use --no-defaults (see the spec), but I don\u0027t think it\u0027s strictly tied to the NodeGroups API.\n\nOk, so, its not required to include in this patch. I will also go through the spec.","accounts_in_message":[],"_revision_number":1},{"id":"ed070b1e14decdc21d1d6d0f39e057343a844e20","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2016-11-10 06:31:48.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"fdc58edb413704599f0764b4e3660eb95ae0a034","author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"date":"2016-11-22 04:04:41.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e3fb5be9ac9e036178e7a1ec3b1e08629ef97a21","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-22 05:17:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2247564b1e65df2d07a6eaf0287f49ec8951196a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 16:31:10.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"8d9449d3e09ac5e5222590d50d222bee7fd12d51","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-23 06:38:44.000000000","message":"Patch Set 1:\n\nWill resume post \n[WIP] Convert floating_ip_enabled from boolean to enum\n\nhttps://review.openstack.org/#/c/395095/","accounts_in_message":[],"_revision_number":1},{"id":"64079d8956eff6496f3ce02cc1a6c59f457d59e5","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-23 06:40:38.000000000","message":"Abandoned\n\nAbandon till completion of following:- \n[WIP] Convert floating_ip_enabled from boolean to enum\nhttps://review.openstack.org/#/c/395095/","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"23e20c02748098234390f025aa0040fc96babf8b","revisions":{"23e20c02748098234390f025aa0040fc96babf8b":{"kind":"REWORK","_number":1,"created":"2016-11-04 04:42:35.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/86/393586/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/86/393586/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/86/393586/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/86/393586/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/86/393586/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/86/393586/1"}}},"commit":{"parents":[{"commit":"9058f9022b92b2359fd552960ea848cbe539ba04","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/9058f9022b92b2359fd552960ea848cbe539ba04"}]}],"author":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-04 04:31:52.000000000","tz":330},"committer":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-04 04:32:35.000000000","tz":330},"subject":"Fix: Creation of cluster without floating ip","message":"Fix: Creation of cluster without floating ip\n\nCurrenlty passing the parameter --floating-ip-enabled while\ncreating cluster template has no effect.\nBy default cluster is created with floating ip enabled, so user\nshould have a way to disable it.\nThis patch renames the parameter --floating-ip-enabled to\n--floating-ip-disabled.\nUser can now pass --floating-ip-disabled while creating cluster\ntemplate to disable floating ip.\n\nChange-Id: I039492dec445c8aa7f0cb39f7922b016f6ac42c3\nCloses-Bug: #1639119\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/23e20c02748098234390f025aa0040fc96babf8b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/23e20c02748098234390f025aa0040fc96babf8b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}