)]}'
{"id":"openstack%2Fpython-magnumclient~397099","triplet_id":"openstack%2Fpython-magnumclient~master~I706b362509f6a59be13df8d9c132e4f4b68e0060","project":"openstack/python-magnumclient","branch":"master","topic":"bp/magnumclient-ut-coverage","hashtags":[],"change_id":"I706b362509f6a59be13df8d9c132e4f4b68e0060","subject":"Use assert_called_*/assert_not_called to verify mock calls","status":"MERGED","created":"2016-11-14 10:11:11.000000000","updated":"2016-11-21 17:42:31.000000000","submitted":"2016-11-21 17:42:31.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"470c83a0df522caa2c2b066ff305744dfacd9d73","_number":397099,"virtual_id_number":397099,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":2,"date":"2016-11-21 17:42:31.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"recommended":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"all":[{"value":1,"date":"2016-11-18 21:24:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-21 17:35:51.000000000","_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":2,"date":"2016-11-18 14:08:09.000000000","_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"all":[{"value":0,"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-11-21 17:35:51.000000000","_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-18 14:08:09.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2016-11-18 21:24:24.000000000","updated_by":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"reviewer":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"state":"REVIEWER"},{"updated":"2016-11-21 17:35:51.000000000","updated_by":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"reviewer":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"state":"REVIEWER"},{"updated":"2016-11-21 17:42:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"21cca1221523b16608767c0d9c422fad477d877b","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-14 10:11:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d8e70e4299f551c814354c3487efb6e7e00b5f2c","author":{"_account_id":23613,"name":"NEC Cinder CI","email":"nec-cinder-ci@istorage.jp.nec.com","username":"nec-cinder-ci","tags":["SERVICE_USER"]},"date":"2016-11-14 10:11:42.000000000","message":"Patch Set 1:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"36820d12e2d68ebd20024876c8662c961b7c85bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-14 10:15:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/397099/1/check/gate-python-magnumclient-docs-ubuntu-xenial/3770578//doc/build/html/ : SUCCESS in 3m 40s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/99/397099/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/3e9f8be/ : SUCCESS in 2m 34s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/99/397099/1/check/gate-python-magnumclient-python27-ubuntu-xenial/93e31c0/ : SUCCESS in 3m 59s\n- gate-python-magnumclient-python34 http://logs.openstack.org/99/397099/1/check/gate-python-magnumclient-python34/ae72edb/ : SUCCESS in 3m 03s\n- gate-python-magnumclient-python35 http://logs.openstack.org/99/397099/1/check/gate-python-magnumclient-python35/696e70f/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":1},{"id":"2790c1e299474d73a0b6ab9110c89b4f78116f69","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2016-11-18 14:08:09.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e6cb0a7acc672039b08922e62f48e78131be7d01","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-18 21:24:24.000000000","message":"Patch Set 1: Code-Review+1\n\nThis patch looks fine. There\u0027s not a lot of duplication.","accounts_in_message":[],"_revision_number":1},{"id":"b80dfe2cde76ede2bf7ebadaa9d5337a2ca80d40","author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"date":"2016-11-21 17:35:51.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"8abc16004e22a26ab1798c1970628501056b858b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-21 17:36:06.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d166bd34b2888694b9694d4b670cad006e218a2a","date":"2016-11-21 17:42:31.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"945987395af9f00e8f68c5bc37493dbe06eaf4ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-21 17:42:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/397099/1/gate/gate-python-magnumclient-docs-ubuntu-xenial/3a9c2b0//doc/build/html/ : SUCCESS in 4m 53s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/99/397099/1/gate/gate-python-magnumclient-pep8-ubuntu-xenial/c2e0ae8/ : SUCCESS in 5m 26s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/99/397099/1/gate/gate-python-magnumclient-python27-ubuntu-xenial/59bc231/ : SUCCESS in 3m 42s\n- gate-python-magnumclient-python34 http://logs.openstack.org/99/397099/1/gate/gate-python-magnumclient-python34/054f645/ : SUCCESS in 3m 14s\n- gate-python-magnumclient-python35 http://logs.openstack.org/99/397099/1/gate/gate-python-magnumclient-python35/406bde3/ : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"bafc850379b1e290914ea5e7050cb97d66130b2d","revisions":{"bafc850379b1e290914ea5e7050cb97d66130b2d":{"kind":"REWORK","_number":1,"created":"2016-11-14 10:11:11.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/99/397099/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/99/397099/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/397099/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/397099/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/397099/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/99/397099/1"}}},"commit":{"parents":[{"commit":"4b63c12e7f786956d356ab438a071274f8792645","subject":"Merge \"Increase UT coverage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4b63c12e7f786956d356ab438a071274f8792645"}]}],"author":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-14 10:05:41.000000000","tz":330},"committer":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-14 10:05:46.000000000","tz":330},"subject":"Use assert_called_*/assert_not_called to verify mock calls","message":"Use assert_called_*/assert_not_called to verify mock calls\n\nCurrently assertTrue and assertFalse are used to check\nwheter a mock method is called. It is not checked whether\nmock method is called with correct set of arguments.\nWith this patch following modules uses assert_called_* and\nassert_not_called instead of assertTrue and assertFalse.\n\n- magnumclient/tests/v1/test_certificates_shell.py\n- magnumclient/tests/v1/test_mservices_shell.py\n\nAlso, renamed \"file_mock\" to \"mock_file\" for consistent\nmock naming in the modules.\n\nChange-Id: I706b362509f6a59be13df8d9c132e4f4b68e0060\nPartially-Implements: blueprint magnumclient-ut-coverage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/bafc850379b1e290914ea5e7050cb97d66130b2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/bafc850379b1e290914ea5e7050cb97d66130b2d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}