)]}'
{"id":"openstack%2Fpython-magnumclient~398069","triplet_id":"openstack%2Fpython-magnumclient~master~I8b848d068bd08512d8c1fc716bb1b6e6d892137c","project":"openstack/python-magnumclient","branch":"master","topic":"bp/magnumclient-ut-coverage","hashtags":[],"change_id":"I8b848d068bd08512d8c1fc716bb1b6e6d892137c","subject":"Use assert_called_*/assert_not_called to verify mock calls","status":"MERGED","created":"2016-11-16 03:47:52.000000000","updated":"2016-11-22 16:31:00.000000000","submitted":"2016-11-22 16:31:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d1ee9c3e69ad557c4da51f20c729b50b9dc8f1bf","_number":398069,"virtual_id_number":398069,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":2,"date":"2016-11-22 16:31:00.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"recommended":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"all":[{"value":1,"date":"2016-11-22 08:01:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-11-22 16:24:02.000000000","_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":2,"date":"2016-11-18 14:06:34.000000000","_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"all":[{"value":0,"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-11-22 16:24:02.000000000","_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-18 14:06:34.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2016-11-22 08:01:37.000000000","updated_by":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"reviewer":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"state":"REVIEWER"},{"updated":"2016-11-22 16:24:02.000000000","updated_by":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"reviewer":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"state":"REVIEWER"},{"updated":"2016-11-22 16:31:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"2fd48017cf9f164f084e0d4e205cc913c6eed058","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-16 03:47:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"add8ad608d8a97a235768bc32582265873ca084e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-16 03:51:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/398069/1/check/gate-python-magnumclient-docs-ubuntu-xenial/8edf648//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/69/398069/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/ca7a666/ : SUCCESS in 2m 50s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/69/398069/1/check/gate-python-magnumclient-python27-ubuntu-xenial/0cea206/ : SUCCESS in 2m 27s\n- gate-python-magnumclient-python34 http://logs.openstack.org/69/398069/1/check/gate-python-magnumclient-python34/8a190c3/ : SUCCESS in 3m 00s\n- gate-python-magnumclient-python35 http://logs.openstack.org/69/398069/1/check/gate-python-magnumclient-python35/b09d794/ : SUCCESS in 2m 24s","accounts_in_message":[],"_revision_number":1},{"id":"e580029a57f8c071f50ce73fdbe4ed9b19273733","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-16 03:53:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c0096352fa06701c02cb72b7a82a025e62faaa31","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-16 03:56:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/398069/2/check/gate-python-magnumclient-docs-ubuntu-xenial/7d7c7c1//doc/build/html/ : SUCCESS in 2m 18s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/69/398069/2/check/gate-python-magnumclient-pep8-ubuntu-xenial/77c50ba/ : SUCCESS in 2m 55s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/69/398069/2/check/gate-python-magnumclient-python27-ubuntu-xenial/259cf44/ : SUCCESS in 3m 02s\n- gate-python-magnumclient-python34 http://logs.openstack.org/69/398069/2/check/gate-python-magnumclient-python34/5a8734e/ : SUCCESS in 2m 56s\n- gate-python-magnumclient-python35 http://logs.openstack.org/69/398069/2/check/gate-python-magnumclient-python35/59711b2/ : SUCCESS in 2m 25s","accounts_in_message":[],"_revision_number":2},{"id":"ed4ccfc63454086b3153cf25d386342dbaea2377","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2016-11-18 14:06:34.000000000","message":"Patch Set 2: Code-Review+2\n\nThanks Yatin!","accounts_in_message":[],"_revision_number":2},{"id":"7ec6b0159eff5195d49239a76d9525c34e0450e5","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-18 21:25:04.000000000","message":"Patch Set 2: Code-Review-1\n\nSame feedback as https://review.openstack.org/#/c/398778/","accounts_in_message":[],"_revision_number":2},{"id":"cf4522ab7b6527460881ebad2664fb5488764502","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2016-11-21 03:37:33.000000000","message":"Patch Set 2:\n\n@Drago, Please suggest as per comments over other patch(https://review.openstack.org/#/c/398778/).","accounts_in_message":[],"_revision_number":2},{"id":"513e38acab3a16740121af8d524219a3204be4eb","author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"date":"2016-11-22 08:01:37.000000000","message":"Patch Set 2: Code-Review+1\n\nChanging my vote for this patch for the same reason as the other patch. LGTM.","accounts_in_message":[],"_revision_number":2},{"id":"1448f27986ae0d8d06d5866281fd2f583575c71c","author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"date":"2016-11-22 16:24:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"717634e9dce92d7e8ab64e32a0d65b92d85c4673","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 16:24:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7bd3def355eb1fe4eecb9af5960284c6ff75117f","date":"2016-11-22 16:31:00.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"1fa6c9d9600d3e4d20b4b20d7f6495b990576ade","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 16:31:00.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/69/398069/2/gate/gate-python-magnumclient-docs-ubuntu-xenial/837ba3c//doc/build/html/ : SUCCESS in 3m 52s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/69/398069/2/gate/gate-python-magnumclient-pep8-ubuntu-xenial/b0ee844/ : SUCCESS in 3m 46s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/69/398069/2/gate/gate-python-magnumclient-python27-ubuntu-xenial/baf8453/ : SUCCESS in 3m 23s\n- gate-python-magnumclient-python34 http://logs.openstack.org/69/398069/2/gate/gate-python-magnumclient-python34/8bb8c90/ : SUCCESS in 3m 04s\n- gate-python-magnumclient-python35 http://logs.openstack.org/69/398069/2/gate/gate-python-magnumclient-python35/db68edb/ : SUCCESS in 3m 45s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cb12dc0232760ff406440b2c9308acae5deb6814","revisions":{"2bf80bab6c71238f0d442e5678cb4d17b3157620":{"kind":"REWORK","_number":1,"created":"2016-11-16 03:47:52.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/69/398069/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/69/398069/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/1"}}},"commit":{"parents":[{"commit":"51b26ec9f63d8ef8cf77fec9454c5f60b0640c1a","subject":"Merge \"Renames *-id parameters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/51b26ec9f63d8ef8cf77fec9454c5f60b0640c1a"}]}],"author":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-16 03:39:12.000000000","tz":330},"committer":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-16 03:47:00.000000000","tz":330},"subject":"Use assert_called_*/assert_not_called to verify mock calls","message":"Use assert_called_*/assert_not_called to verify mock calls\n\nCurrently assertTrue and assertFalse are used to check\nwheter a mock method is called. It is not checked whether\nmock method is called with correct set of arguments.\nWith this patch following modules uses assert_called_* and\nassert_not_called instead of assertTrue and assertFalse.\n\n- magnumclient/tests/v1/test_bays_shell.py\n- magnumclient/tests/v1/test_clusters_shell.py\n\nChange-Id: I8b848d068bd08512d8c1fc716bb1b6e6d892137c\nPartially-Implements: blueprint magnumclient-ut-coverage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/2bf80bab6c71238f0d442e5678cb4d17b3157620"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/2bf80bab6c71238f0d442e5678cb4d17b3157620"}]},"branch":"refs/heads/master"},"cb12dc0232760ff406440b2c9308acae5deb6814":{"kind":"REWORK","_number":2,"created":"2016-11-16 03:53:35.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/69/398069/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/69/398069/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/69/398069/2"}}},"commit":{"parents":[{"commit":"51b26ec9f63d8ef8cf77fec9454c5f60b0640c1a","subject":"Merge \"Renames *-id parameters\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/51b26ec9f63d8ef8cf77fec9454c5f60b0640c1a"}]}],"author":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-16 03:39:12.000000000","tz":330},"committer":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2016-11-16 03:53:20.000000000","tz":330},"subject":"Use assert_called_*/assert_not_called to verify mock calls","message":"Use assert_called_*/assert_not_called to verify mock calls\n\nCurrently assertTrue and assertFalse are used to check\nwheter a mock method is called. It is not checked whether\nmock method is called with correct set of arguments.\nWith this patch following modules uses assert_called_* and\nassert_not_called instead of assertTrue and assertFalse.\n\n- magnumclient/tests/v1/test_bays_shell.py\n- magnumclient/tests/v1/test_clusters_shell.py\n\nChange-Id: I8b848d068bd08512d8c1fc716bb1b6e6d892137c\nPartially-Implements: blueprint magnumclient-ut-coverage\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/cb12dc0232760ff406440b2c9308acae5deb6814"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/cb12dc0232760ff406440b2c9308acae5deb6814"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}