)]}'
{"magnumclient/tests/v1/test_bays_shell.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"683d14bb0a8a8d75c0d373cafff000e894a4e790","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        with mock.patch.dict(\u0027os.environ\u0027, {\u0027SHELL\u0027: \u0027csh\u0027}):"},{"line_number":357,"context_line":"            self._test_arg_success(\u0027bay-config xxx\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self.assertTrue(mock_exists.called)"},{"line_number":360,"context_line":"        mock_bay.assert_called_once_with(\u0027xxx\u0027)"},{"line_number":361,"context_line":"        mock_bm.assert_called_once_with(\u0027x\u0027)"},{"line_number":362,"context_line":"        mock_cert_get.assert_called_once_with(cluster_uuid\u003d\u0027x\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_2273de81","line":359,"updated":"2016-12-14 05:16:23.000000000","message":"Please use assert_called and assert_not_called like: https://review.openstack.org/#/c/398069/\n\nAny specific reason for not using of mock_cert_create","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"252433120841e533c6886ba9863951b1b66d7583","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        with mock.patch.dict(\u0027os.environ\u0027, {\u0027SHELL\u0027: \u0027csh\u0027}):"},{"line_number":357,"context_line":"            self._test_arg_success(\u0027bay-config xxx\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self.assertTrue(mock_exists.called)"},{"line_number":360,"context_line":"        mock_bay.assert_called_once_with(\u0027xxx\u0027)"},{"line_number":361,"context_line":"        mock_bm.assert_called_once_with(\u0027x\u0027)"},{"line_number":362,"context_line":"        mock_cert_get.assert_called_once_with(cluster_uuid\u003d\u0027x\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_3b8a20c0","line":359,"in_reply_to":"1a6eadb0_2273de81","updated":"2016-12-14 09:20:01.000000000","message":"mock_exists will be called many times, IMO it\u0027s better to check called without input args. Mock assert_called_* requires input args, so can you show me some ways to use assert_called_* without args? My best solution is mock_exists.assert_called_with(mock.ANY), and it make no sense.\n\nThanks for reminding, I have added check for mock_cert_create.","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d9ca69b8d17be6f88e7815b0fc5f53670cb70a00","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        with mock.patch.dict(\u0027os.environ\u0027, {\u0027SHELL\u0027: \u0027csh\u0027}):"},{"line_number":357,"context_line":"            self._test_arg_success(\u0027bay-config xxx\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self.assertTrue(mock_exists.called)"},{"line_number":360,"context_line":"        mock_bay.assert_called_once_with(\u0027xxx\u0027)"},{"line_number":361,"context_line":"        mock_bm.assert_called_once_with(\u0027x\u0027)"},{"line_number":362,"context_line":"        mock_cert_get.assert_called_once_with(cluster_uuid\u003d\u0027x\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_ca700ea7","line":359,"in_reply_to":"1a6eadb0_3b8a20c0","updated":"2016-12-16 03:54:42.000000000","message":"\u003c\u003c assert_called_* requires input args, so can you show me some ways to use assert_called_* without args\n\njust use mock_assert_called(), it works","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"683d14bb0a8a8d75c0d373cafff000e894a4e790","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                             mock_cert_create,"},{"line_number":373,"context_line":"                                             mock_exists):"},{"line_number":374,"context_line":"        cert \u003d FakeCert(pem\u003d\u0027foo bar\u0027)"},{"line_number":375,"context_line":"        mock_exists.return_value \u003d False"},{"line_number":376,"context_line":"        mock_bay.return_value \u003d FakeBay(status\u003d\u0027CREATE_COMPLETE\u0027,"},{"line_number":377,"context_line":"                                        info\u003d{\u0027name\u0027: \u0027Kluster\u0027,"},{"line_number":378,"context_line":"                                              \u0027api_address\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_226e7e2f","line":375,"updated":"2016-12-14 05:16:23.000000000","message":"Shouldn\u0027t we consider mock_exists to return True as well.","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"252433120841e533c6886ba9863951b1b66d7583","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                             mock_cert_create,"},{"line_number":373,"context_line":"                                             mock_exists):"},{"line_number":374,"context_line":"        cert \u003d FakeCert(pem\u003d\u0027foo bar\u0027)"},{"line_number":375,"context_line":"        mock_exists.return_value \u003d False"},{"line_number":376,"context_line":"        mock_bay.return_value \u003d FakeBay(status\u003d\u0027CREATE_COMPLETE\u0027,"},{"line_number":377,"context_line":"                                        info\u003d{\u0027name\u0027: \u0027Kluster\u0027,"},{"line_number":378,"context_line":"                                              \u0027api_address\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_5f1a676f","line":375,"in_reply_to":"1a6eadb0_226e7e2f","updated":"2016-12-14 09:20:01.000000000","message":"no, we should add more test case with mock_exists\u0027s side_effect go with a series of mock_call for catching exception.\nmock_exists return_value \u003d True will cause behave abnormal.","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"d9ca69b8d17be6f88e7815b0fc5f53670cb70a00","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                             mock_cert_create,"},{"line_number":373,"context_line":"                                             mock_exists):"},{"line_number":374,"context_line":"        cert \u003d FakeCert(pem\u003d\u0027foo bar\u0027)"},{"line_number":375,"context_line":"        mock_exists.return_value \u003d False"},{"line_number":376,"context_line":"        mock_bay.return_value \u003d FakeBay(status\u003d\u0027CREATE_COMPLETE\u0027,"},{"line_number":377,"context_line":"                                        info\u003d{\u0027name\u0027: \u0027Kluster\u0027,"},{"line_number":378,"context_line":"                                              \u0027api_address\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_0a6766e9","line":375,"in_reply_to":"1a6eadb0_5f1a676f","updated":"2016-12-16 03:54:42.000000000","message":"Yes, i mean to add new tests only.","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"683d14bb0a8a8d75c0d373cafff000e894a4e790","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        mock_cert_create.return_value \u003d cert"},{"line_number":382,"context_line":"        mock_bm.return_value \u003d test_baymodels_shell.\\"},{"line_number":383,"context_line":"            FakeBayModel(coe\u003d\u0027kubernetes\u0027)"},{"line_number":384,"context_line":"        with mock.patch.dict(\u0027os.environ\u0027, {\u0027SHELL\u0027: \u0027csh\u0027}):"},{"line_number":385,"context_line":"            self._test_arg_success(\u0027bay-config xxx\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        self.assertTrue(mock_exists.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_6259565a","line":384,"updated":"2016-12-14 05:16:23.000000000","message":"what for non csh shell.","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"252433120841e533c6886ba9863951b1b66d7583","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        mock_cert_create.return_value \u003d cert"},{"line_number":382,"context_line":"        mock_bm.return_value \u003d test_baymodels_shell.\\"},{"line_number":383,"context_line":"            FakeBayModel(coe\u003d\u0027kubernetes\u0027)"},{"line_number":384,"context_line":"        with mock.patch.dict(\u0027os.environ\u0027, {\u0027SHELL\u0027: \u0027csh\u0027}):"},{"line_number":385,"context_line":"            self._test_arg_success(\u0027bay-config xxx\u0027)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        self.assertTrue(mock_exists.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_ff6973bf","line":384,"in_reply_to":"1a6eadb0_6259565a","updated":"2016-12-14 09:20:01.000000000","message":"ok, will find another way to check.","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"683d14bb0a8a8d75c0d373cafff000e894a4e790","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        self.assertTrue(mock_exists.called)"},{"line_number":388,"context_line":"        mock_bay.assert_called_once_with(\u0027xxx\u0027)"},{"line_number":389,"context_line":"        mock_bm.assert_called_once_with(\u0027x\u0027)"},{"line_number":390,"context_line":"        mock_cert_get.assert_called_once_with(cluster_uuid\u003d\u0027x\u0027)"},{"line_number":391,"context_line":"        self.assertTrue(mock_cert_create.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_360ddf37","line":389,"updated":"2016-12-14 05:16:23.000000000","message":"It would be better if we can pass the name or uuid(which ever used during validataion) while creating Fake resources so that while validating we can use those and not use \"x\".","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"252433120841e533c6886ba9863951b1b66d7583","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        self.assertTrue(mock_exists.called)"},{"line_number":388,"context_line":"        mock_bay.assert_called_once_with(\u0027xxx\u0027)"},{"line_number":389,"context_line":"        mock_bm.assert_called_once_with(\u0027x\u0027)"},{"line_number":390,"context_line":"        mock_cert_get.assert_called_once_with(cluster_uuid\u003d\u0027x\u0027)"},{"line_number":391,"context_line":"        self.assertTrue(mock_cert_create.called)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_7f9c83c0","line":389,"in_reply_to":"1a6eadb0_360ddf37","updated":"2016-12-14 09:20:01.000000000","message":"Done","commit_id":"f74f8189384b83b13edcb21dc36b70eb9a5f17b6"}]}