)]}'
{"id":"openstack%2Fpython-magnumclient~422399","triplet_id":"openstack%2Fpython-magnumclient~master~I57eb1d49b5157958f9c5f6d89a613896300fdb6e","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1647254","hashtags":[],"change_id":"I57eb1d49b5157958f9c5f6d89a613896300fdb6e","subject":"Fix: swarm cluster-config, bay-config with tls_disabled","status":"MERGED","created":"2017-01-19 05:48:36.000000000","updated":"2017-01-20 16:30:19.000000000","submitted":"2017-01-20 16:30:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"be59205cf9296c4067eb50498cb7e6cc1d9e0cb7","_number":422399,"virtual_id_number":422399,"owner":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":2,"date":"2017-01-20 16:30:19.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":2,"date":"2017-01-20 16:26:31.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":2,"date":"2017-01-20 15:59:08.000000000","_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":1,"date":"2017-01-20 16:26:31.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-20 15:59:08.000000000","updated_by":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"reviewer":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"state":"REVIEWER"},{"updated":"2017-01-20 16:26:31.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2017-01-20 16:30:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"260dff9172f4d34a96aea554f8e589044e4f8ffc","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-01-19 05:48:36.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"45c4487cf25db09de1892c4175a1d930e9c55d9a","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-01-19 05:49:35.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/newton as commit d4cf6cbf0fd4765954184ec116003cf098d072d9","accounts_in_message":[],"_revision_number":1},{"id":"2bd0ff6e6ded553d2c2009d6296bbb34ddcec787","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-19 05:55:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/422399/1/check/gate-python-magnumclient-docs-ubuntu-xenial/a63da76//doc/build/html/ : SUCCESS in 3m 01s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/99/422399/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/fa22700/ : SUCCESS in 2m 28s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/99/422399/1/check/gate-python-magnumclient-python27-ubuntu-xenial/b98cce8/ : SUCCESS in 3m 42s\n- gate-python-magnumclient-python35 http://logs.openstack.org/99/422399/1/check/gate-python-magnumclient-python35/de4efb6/ : SUCCESS in 2m 25s","accounts_in_message":[],"_revision_number":1},{"id":"9bf38888c457c293a6ad985ebda7f48f8ea7c22d","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-01-19 06:54:51.000000000","message":"Patch Set 1:\n\nshould we change bay-config commands in ocata?","accounts_in_message":[],"_revision_number":1},{"id":"63a3843516f0311d2674678fd076aee9f9e5e304","author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"date":"2017-01-19 21:06:08.000000000","message":"Patch Set 1:\n\n\u003e should we change bay-config commands in ocata?\n\nsince this is a fix, I think bay should be updated as well.","accounts_in_message":[],"_revision_number":1},{"id":"e70086a598ee8ffeba0b343428d14db23b9100f6","author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"date":"2017-01-19 21:12:06.000000000","message":"Patch Set 1: Code-Review-1\n\nbay_shell.py config_bay_swarm needs to be updated as well","accounts_in_message":[],"_revision_number":1},{"id":"1b2fff27f4cb5b292f3db0795c5539a81cf74958","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-01-20 05:45:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"eec337f800324cfb63a0149fcf9c4ba76f073726","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-20 05:50:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/422399/2/check/gate-python-magnumclient-docs-ubuntu-xenial/5e73a5b//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/99/422399/2/check/gate-python-magnumclient-pep8-ubuntu-xenial/54dd49a/ : SUCCESS in 3m 54s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/99/422399/2/check/gate-python-magnumclient-python27-ubuntu-xenial/0149b75/ : SUCCESS in 3m 51s\n- gate-python-magnumclient-python35 http://logs.openstack.org/99/422399/2/check/gate-python-magnumclient-python35/c2fc79a/ : SUCCESS in 1m 58s","accounts_in_message":[],"_revision_number":2},{"id":"1030474b30ab34b58686637c1acfa9372e4c07d6","author":{"_account_id":21469,"name":"Jaycen Grant","email":"jaycen.v.grant@intel.com","username":"jvgrant"},"date":"2017-01-20 15:59:08.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d38a44377299e435e5827003153be170273c7996","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2017-01-20 16:26:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c9a0ed8b2dccd5c7f0218f0873438e2f0534c513","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-20 16:26:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"4d197dd79681e6ea0995570a9b10bba4e7d09999","date":"2017-01-20 16:30:19.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"e29c916101b2fbff3017d3d55ef48c0556f9904a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-20 16:30:19.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/99/422399/2/gate/gate-python-magnumclient-docs-ubuntu-xenial/97ac3f8//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/99/422399/2/gate/gate-python-magnumclient-pep8-ubuntu-xenial/e5c8c13/ : SUCCESS in 3m 21s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/99/422399/2/gate/gate-python-magnumclient-python27-ubuntu-xenial/03ae720/ : SUCCESS in 2m 25s\n- gate-python-magnumclient-python35 http://logs.openstack.org/99/422399/2/gate/gate-python-magnumclient-python35/b18e216/ : SUCCESS in 3m 26s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b68ce22fd13c4af291683b833b79be0affe07351","revisions":{"f3cdf4e30f2378e5db8d9d3a700d4a471b477ebe":{"kind":"REWORK","_number":1,"created":"2017-01-19 05:48:36.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/99/422399/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/99/422399/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/1"}}},"commit":{"parents":[{"commit":"f2657df98d59083974d6e0983c14497a8f8012d6","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f2657df98d59083974d6e0983c14497a8f8012d6"}]}],"author":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2017-01-19 05:44:25.000000000","tz":330},"committer":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2017-01-19 05:44:28.000000000","tz":330},"subject":"Fix: swarm cluster-config with tls_disabled","message":"Fix: swarm cluster-config with tls_disabled\n\nmagnum cluster-config for swarm cluster didn\u0027t work\nwith tls_disabled.\n\nWith this patch following is done:-\nif tls_disabled then set DOCKER_TLS_VERIFY\u003d\"\"\nif not tls_disabled then set DOCKER_TLS_VERIFY\u003dTrue\n\nChange-Id: I57eb1d49b5157958f9c5f6d89a613896300fdb6e\nCloses-Bug: #1647254\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f3cdf4e30f2378e5db8d9d3a700d4a471b477ebe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f3cdf4e30f2378e5db8d9d3a700d4a471b477ebe"}]},"branch":"refs/heads/master"},"b68ce22fd13c4af291683b833b79be0affe07351":{"kind":"REWORK","_number":2,"created":"2017-01-20 05:45:31.000000000","uploader":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"ref":"refs/changes/99/422399/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/99/422399/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/99/422399/2"}}},"commit":{"parents":[{"commit":"f2657df98d59083974d6e0983c14497a8f8012d6","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f2657df98d59083974d6e0983c14497a8f8012d6"}]}],"author":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2017-01-19 05:44:25.000000000","tz":330},"committer":{"name":"yatin","email":"yatin.karel@nectechnologies.in","date":"2017-01-20 05:44:15.000000000","tz":330},"subject":"Fix: swarm cluster-config, bay-config with tls_disabled","message":"Fix: swarm cluster-config, bay-config with tls_disabled\n\nmagnum cluster-config, bay-config for swarm cluster\ndidn\u0027t work with tls_disabled.\n\nWith this patch following is done:-\nif tls_disabled then set DOCKER_TLS_VERIFY\u003d\"\"\nif not tls_disabled then set DOCKER_TLS_VERIFY\u003dTrue\n\nChange-Id: I57eb1d49b5157958f9c5f6d89a613896300fdb6e\nCloses-Bug: #1647254\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b68ce22fd13c4af291683b833b79be0affe07351"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b68ce22fd13c4af291683b833b79be0affe07351"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}