)]}'
{"magnumclient/common/httpclient.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e31357cb2ff8ea8cb92cc2fb581ead3361759493","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          \u0027debuginfo\u0027: error_body[\u0027message\u0027]}"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            error_body \u003d body_json[\u0027errors\u0027][0]"},{"line_number":54,"context_line":"            raw_msg \u003d error_body[\u0027title\u0027]"},{"line_number":55,"context_line":"            error_json \u003d {\u0027faultstring\u0027: error_body[\u0027title\u0027]}"},{"line_number":56,"context_line":"            if \u0027detail\u0027 in error_body:"},{"line_number":57,"context_line":"                error_json[\u0027debuginfo\u0027] \u003d error_body[\u0027detail\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_77b95be9","side":"PARENT","line":54,"updated":"2017-01-26 05:57:38.000000000","message":"What\u0027s the reason of removing base code in coverage patch, is this related?","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"21cb3ff5db60a56ec5a6ebf1354eccecff4896d4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          \u0027debuginfo\u0027: error_body[\u0027message\u0027]}"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            error_body \u003d body_json[\u0027errors\u0027][0]"},{"line_number":54,"context_line":"            raw_msg \u003d error_body[\u0027title\u0027]"},{"line_number":55,"context_line":"            error_json \u003d {\u0027faultstring\u0027: error_body[\u0027title\u0027]}"},{"line_number":56,"context_line":"            if \u0027detail\u0027 in error_body:"},{"line_number":57,"context_line":"                error_json[\u0027debuginfo\u0027] \u003d error_body[\u0027detail\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_7a14e2f4","side":"PARENT","line":54,"in_reply_to":"3a461143_17601735","updated":"2017-01-26 06:38:39.000000000","message":"Means unrelated.","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e578a2f710a53490384e9fc94ad0324e9cfee954","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          \u0027debuginfo\u0027: error_body[\u0027message\u0027]}"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            error_body \u003d body_json[\u0027errors\u0027][0]"},{"line_number":54,"context_line":"            raw_msg \u003d error_body[\u0027title\u0027]"},{"line_number":55,"context_line":"            error_json \u003d {\u0027faultstring\u0027: error_body[\u0027title\u0027]}"},{"line_number":56,"context_line":"            if \u0027detail\u0027 in error_body:"},{"line_number":57,"context_line":"                error_json[\u0027debuginfo\u0027] \u003d error_body[\u0027detail\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_17601735","side":"PARENT","line":54,"in_reply_to":"3a461143_77b95be9","updated":"2017-01-26 06:09:44.000000000","message":"just cleaning this because this variable is no more used in any part below","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"c90d378d44128a3ba3c5af2741e131494ecbcb69","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          \u0027debuginfo\u0027: error_body[\u0027message\u0027]}"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            error_body \u003d body_json[\u0027errors\u0027][0]"},{"line_number":54,"context_line":"            raw_msg \u003d error_body[\u0027title\u0027]"},{"line_number":55,"context_line":"            error_json \u003d {\u0027faultstring\u0027: error_body[\u0027title\u0027]}"},{"line_number":56,"context_line":"            if \u0027detail\u0027 in error_body:"},{"line_number":57,"context_line":"                error_json[\u0027debuginfo\u0027] \u003d error_body[\u0027detail\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_6d87ce0f","side":"PARENT","line":54,"in_reply_to":"3a461143_7a14e2f4","updated":"2017-01-26 07:23:48.000000000","message":"yatin, remove code base is another way to increase code coverage, right?\njust kidding :)","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e31357cb2ff8ea8cb92cc2fb581ead3361759493","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get_connection(self):"},{"line_number":103,"context_line":"        _class \u003d self.connection_params[0]"},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            return _class(*self.connection_params[1][0:2],"},{"line_number":106,"context_line":"                          **self.connection_params[2])"},{"line_number":107,"context_line":"        except six.moves.http_client.InvalidURL:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_b7cbc371","side":"PARENT","line":104,"updated":"2017-01-26 05:57:38.000000000","message":"ditto","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"21cb3ff5db60a56ec5a6ebf1354eccecff4896d4","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get_connection(self):"},{"line_number":103,"context_line":"        _class \u003d self.connection_params[0]"},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            return _class(*self.connection_params[1][0:2],"},{"line_number":106,"context_line":"                          **self.connection_params[2])"},{"line_number":107,"context_line":"        except six.moves.http_client.InvalidURL:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9ae7ce11","side":"PARENT","line":104,"in_reply_to":"3a461143_17ee578b","updated":"2017-01-26 06:38:39.000000000","message":"hmm Ok","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"e578a2f710a53490384e9fc94ad0324e9cfee954","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def get_connection(self):"},{"line_number":103,"context_line":"        _class \u003d self.connection_params[0]"},{"line_number":104,"context_line":"        try:"},{"line_number":105,"context_line":"            return _class(*self.connection_params[1][0:2],"},{"line_number":106,"context_line":"                          **self.connection_params[2])"},{"line_number":107,"context_line":"        except six.moves.http_client.InvalidURL:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_17ee578b","side":"PARENT","line":104,"in_reply_to":"3a461143_b7cbc371","updated":"2017-01-26 06:09:44.000000000","message":"in L77, we used urlparse for parsing the URI in standard way, that\u0027s why we will never got InvalidURL exception here.\n\nIMO, remove unused/never reach code part also increase code coverage","commit_id":"d8d54392af0d73408023be9ff244751cd95b8d1e"}]}
