)]}'
{"magnumclient/shell.py":[{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"d1811c52d869111d3940c757eda88c6f75b0ba4a","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            api_major_version \u003d versions[0]"},{"line_number":542,"context_line":"            return (api_major_version, magnum_api_version)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def _check_auth_info(self, args):"},{"line_number":545,"context_line":"        if not cliutils.isunauthenticated(args.func):"},{"line_number":546,"context_line":"            if (not (args.os_token and"},{"line_number":547,"context_line":"                     (args.os_auth_url or args.os_endpoint_override)) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_0f983b69","line":544,"range":{"start_line":544,"start_character":8,"end_line":544,"end_character":24},"updated":"2017-02-15 23:12:26.000000000","message":"-1 is for this: I think that this method would make more sense if the isunauthenticated conditional was moved out into main. Otherwise, the method is really only checking the auth info if the function needs it.\n\nNit: I think this could be more descriptive. Something like ensure_authenticatable.","commit_id":"3bd64fd5e4a1bb6299d64ed93e43d2e9e65cdaba"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"831c4ba45597de0d93c0a00458aea3a29a82d134","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            api_major_version \u003d versions[0]"},{"line_number":542,"context_line":"            return (api_major_version, magnum_api_version)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def _check_auth_info(self, args):"},{"line_number":545,"context_line":"        if not cliutils.isunauthenticated(args.func):"},{"line_number":546,"context_line":"            if (not (args.os_token and"},{"line_number":547,"context_line":"                     (args.os_auth_url or args.os_endpoint_override)) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_6f24570c","line":544,"range":{"start_line":544,"start_character":8,"end_line":544,"end_character":24},"in_reply_to":"fa31d9ce_0f983b69","updated":"2017-02-15 23:17:21.000000000","message":"The reason I used \"ensure\" is to convey that the method can throw an error, which I don\u0027t think is as obvious with \"check\".","commit_id":"3bd64fd5e4a1bb6299d64ed93e43d2e9e65cdaba"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"2c1c27a51e532c1dedc7da3ffd43129257d5bc52","unresolved":false,"context_lines":[{"line_number":541,"context_line":"            api_major_version \u003d versions[0]"},{"line_number":542,"context_line":"            return (api_major_version, magnum_api_version)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def _check_auth_info(self, args):"},{"line_number":545,"context_line":"        if not cliutils.isunauthenticated(args.func):"},{"line_number":546,"context_line":"            if (not (args.os_token and"},{"line_number":547,"context_line":"                     (args.os_auth_url or args.os_endpoint_override)) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_8c4a5554","line":544,"range":{"start_line":544,"start_character":8,"end_line":544,"end_character":24},"in_reply_to":"fa31d9ce_6f24570c","updated":"2017-02-16 15:24:05.000000000","message":"I went with _ensure_auth_info because it doesn\u0027t check if we can authenticate, just if we have all the info to possibly authenticate.","commit_id":"3bd64fd5e4a1bb6299d64ed93e43d2e9e65cdaba"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"d1811c52d869111d3940c757eda88c6f75b0ba4a","unresolved":false,"context_lines":[{"line_number":542,"context_line":"            return (api_major_version, magnum_api_version)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def _check_auth_info(self, args):"},{"line_number":545,"context_line":"        if not cliutils.isunauthenticated(args.func):"},{"line_number":546,"context_line":"            if (not (args.os_token and"},{"line_number":547,"context_line":"                     (args.os_auth_url or args.os_endpoint_override)) and"},{"line_number":548,"context_line":"                not args.os_cloud"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_8f026bb2","line":545,"range":{"start_line":545,"start_character":11,"end_line":545,"end_character":52},"updated":"2017-02-15 23:12:26.000000000","message":"Nit: Confusing double-negative. Would be nice if there was a cliutils.is_authenticated method.","commit_id":"3bd64fd5e4a1bb6299d64ed93e43d2e9e65cdaba"}]}