)]}'
{"magnumclient/tests/v1/test_clusters_shell.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"940ab7dddb0d6c60cd1ff6ee732b20b89a7ab932","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @mock.patch(\u0027magnumclient.v1.clusters.ClusterManager.create\u0027)"},{"line_number":307,"context_line":"    def test_cluster_create_failure_duplicate_name(self, mock_create):"},{"line_number":308,"context_line":"        self._test_arg_failure(\u0027cluster-create foo --name bar\u0027,"},{"line_number":309,"context_line":"                               self._mandatory_arg_error)"},{"line_number":310,"context_line":"        mock_create.assert_not_called()"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @mock.patch(\u0027magnumclient.v1.clusters.ClusterManager.delete\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_66799593","line":309,"range":{"start_line":309,"start_character":31,"end_line":309,"end_character":56},"updated":"2017-02-21 07:06:21.000000000","message":"duplicate_args would be raised when both(--name and positional name) are passed.","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"39d229e53b2784eaf268b29fbe2b04c10d756ad8","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @mock.patch(\u0027magnumclient.v1.clusters.ClusterManager.create\u0027)"},{"line_number":307,"context_line":"    def test_cluster_create_failure_duplicate_name(self, mock_create):"},{"line_number":308,"context_line":"        self._test_arg_failure(\u0027cluster-create foo --name bar\u0027,"},{"line_number":309,"context_line":"                               self._mandatory_arg_error)"},{"line_number":310,"context_line":"        mock_create.assert_not_called()"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @mock.patch(\u0027magnumclient.v1.clusters.ClusterManager.delete\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_75a66611","line":309,"range":{"start_line":309,"start_character":31,"end_line":309,"end_character":56},"in_reply_to":"da36d5c6_66799593","updated":"2017-02-22 19:18:45.000000000","message":"They are both passed here.  \"foo\" is the positional name.  \"bar\" is the optional name.","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"77e8e0067eb0a7072243602dd8f03d4942f55f40","unresolved":false,"context_lines":[{"line_number":306,"context_line":"    @mock.patch(\u0027magnumclient.v1.clusters.ClusterManager.create\u0027)"},{"line_number":307,"context_line":"    def test_cluster_create_failure_duplicate_name(self, mock_create):"},{"line_number":308,"context_line":"        self._test_arg_failure(\u0027cluster-create foo --name bar\u0027,"},{"line_number":309,"context_line":"                               self._mandatory_arg_error)"},{"line_number":310,"context_line":"        mock_create.assert_not_called()"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"    @mock.patch(\u0027magnumclient.v1.clusters.ClusterManager.delete\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_b2135db7","line":309,"range":{"start_line":309,"start_character":31,"end_line":309,"end_character":56},"in_reply_to":"da36d5c6_75a66611","updated":"2017-02-23 18:21:23.000000000","message":"Yes, i understood that. These both are not mandatory. So instead you should check \u0027cluster-create foo --name bar --cluster-template xxx\u0027 and this should result in duplicate_error. \n\nIt looks like there is some issue with the Unit Test cases as they are not failing, i think this test should have failed, will look into it.\n\nWe can merge this patch and revisit with the fix for this test case/other test cases if found.","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"}],"magnumclient/tests/v1/test_clustertemplates_shell.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"940ab7dddb0d6c60cd1ff6ee732b20b89a7ab932","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    def test_cluster_template_create_failure_few_arg(self, mock_create):"},{"line_number":488,"context_line":"        self._test_arg_failure(\u0027cluster-template-create \u0027"},{"line_number":489,"context_line":"                               \u0027--name test\u0027, self._mandatory_arg_error)"},{"line_number":490,"context_line":"        mock_create.assert_not_called()"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self._test_arg_failure(\u0027cluster-template-create \u0027"},{"line_number":493,"context_line":"                               \u0027foo --name test\u0027, self._mandatory_arg_error)"},{"line_number":494,"context_line":"        mock_create.assert_not_called()"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        self._test_arg_failure(\u0027cluster-template-create \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_86a5a905","line":493,"range":{"start_line":490,"start_character":8,"end_line":493,"end_character":76},"updated":"2017-02-21 07:06:21.000000000","message":"create seperate test for this(duplicate args same as done for cluster), this test contains _few_args test cases.","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"39d229e53b2784eaf268b29fbe2b04c10d756ad8","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    def test_cluster_template_create_failure_few_arg(self, mock_create):"},{"line_number":488,"context_line":"        self._test_arg_failure(\u0027cluster-template-create \u0027"},{"line_number":489,"context_line":"                               \u0027--name test\u0027, self._mandatory_arg_error)"},{"line_number":490,"context_line":"        mock_create.assert_not_called()"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self._test_arg_failure(\u0027cluster-template-create \u0027"},{"line_number":493,"context_line":"                               \u0027foo --name test\u0027, self._mandatory_arg_error)"},{"line_number":494,"context_line":"        mock_create.assert_not_called()"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"        self._test_arg_failure(\u0027cluster-template-create \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_3c676d4e","line":493,"range":{"start_line":490,"start_character":8,"end_line":493,"end_character":76},"in_reply_to":"da36d5c6_86a5a905","updated":"2017-02-22 19:18:45.000000000","message":"Done","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"}],"magnumclient/v1/cluster_templates_shell.py":[{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"e51c482170c0c7318e48235a7c79718e0b6131ff","unresolved":false,"context_lines":[{"line_number":47,"context_line":"           dest\u003d\u0027image\u0027,"},{"line_number":48,"context_line":"           required\u003dTrue,"},{"line_number":49,"context_line":"           metavar\u003d\u0027\u003cimage\u003e\u0027,"},{"line_number":50,"context_line":"           help\u003dutils.deprecation_message("},{"line_number":51,"context_line":"               \u0027The name or UUID of the base image to customize for the \u0027"},{"line_number":52,"context_line":"               \u0027Cluster.\u0027, \u0027image\u0027))"},{"line_number":53,"context_line":"@utils.arg(\u0027--image\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_429acf15","line":50,"updated":"2017-02-20 17:12:26.000000000","message":"It looks like this can be used to print a deprecation warning in the help.","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"52b9f537f50f6da2a32e4d326746b0c1529bac19","unresolved":false,"context_lines":[{"line_number":47,"context_line":"           dest\u003d\u0027image\u0027,"},{"line_number":48,"context_line":"           required\u003dTrue,"},{"line_number":49,"context_line":"           metavar\u003d\u0027\u003cimage\u003e\u0027,"},{"line_number":50,"context_line":"           help\u003dutils.deprecation_message("},{"line_number":51,"context_line":"               \u0027The name or UUID of the base image to customize for the \u0027"},{"line_number":52,"context_line":"               \u0027Cluster.\u0027, \u0027image\u0027))"},{"line_number":53,"context_line":"@utils.arg(\u0027--image\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_13e90b1b","line":50,"in_reply_to":"da36d5c6_1d883a22","updated":"2017-02-20 18:44:19.000000000","message":"Done","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"},{"author":{"_account_id":15123,"name":"Drago","email":"drago.rosson@rackspace.com","username":"Drago"},"change_message_id":"af40d8a701adb320f17bf4f6e7c142cd52d4f2ba","unresolved":false,"context_lines":[{"line_number":47,"context_line":"           dest\u003d\u0027image\u0027,"},{"line_number":48,"context_line":"           required\u003dTrue,"},{"line_number":49,"context_line":"           metavar\u003d\u0027\u003cimage\u003e\u0027,"},{"line_number":50,"context_line":"           help\u003dutils.deprecation_message("},{"line_number":51,"context_line":"               \u0027The name or UUID of the base image to customize for the \u0027"},{"line_number":52,"context_line":"               \u0027Cluster.\u0027, \u0027image\u0027))"},{"line_number":53,"context_line":"@utils.arg(\u0027--image\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_1d883a22","line":50,"in_reply_to":"da36d5c6_3d3c1e93","updated":"2017-02-20 17:34:28.000000000","message":"Alright. The other deprecation messages don\u0027t print \"WARNING\" in the help, but only when a deprecated flag is used. Could you change that so --name doesn\u0027t either?","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"},{"author":{"_account_id":7253,"name":"Jason Dunsmore","email":"jasondunsmore@gmail.com","username":"jbd"},"change_message_id":"cb196b29581d17de865cffc806dba2f7d1d3f729","unresolved":false,"context_lines":[{"line_number":47,"context_line":"           dest\u003d\u0027image\u0027,"},{"line_number":48,"context_line":"           required\u003dTrue,"},{"line_number":49,"context_line":"           metavar\u003d\u0027\u003cimage\u003e\u0027,"},{"line_number":50,"context_line":"           help\u003dutils.deprecation_message("},{"line_number":51,"context_line":"               \u0027The name or UUID of the base image to customize for the \u0027"},{"line_number":52,"context_line":"               \u0027Cluster.\u0027, \u0027image\u0027))"},{"line_number":53,"context_line":"@utils.arg(\u0027--image\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da36d5c6_3d3c1e93","line":50,"in_reply_to":"da36d5c6_429acf15","updated":"2017-02-20 17:27:41.000000000","message":"That is for the case where one optional parameter is being deprecated in favor of another optional parameter.  In this case, it\u0027s being replaced with a positional parameter.  Since this is likely a one-off, I don\u0027t think it\u0027s worth modifying the parameter deprecation system.","commit_id":"ff6734e1b4b1558055b79597872e5e662f501644"}]}