)]}'
{"magnumclient/osc/v1/cluster_templates.py":[{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"20b27a5c8841f7409960c5c009e960dc16d346ec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from osc_lib import utils"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"\u0027\u0027\u0027"},{"line_number":24,"context_line":"    cluster-template-update"},{"line_number":25,"context_line":"\u0027\u0027\u0027"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_4f268f17","line":23,"updated":"2017-02-28 22:45:04.000000000","message":"Forgot to remove this comment before git review. Will remove for next patch","commit_id":"864a4c251324803161deb37b88c1c5bbb4165a20"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"20b27a5c8841f7409960c5c009e960dc16d346ec","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(CreateClusterTemplate, self).get_parser(prog_name)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \u0027name\u0027,"},{"line_number":36,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":37,"context_line":"            help\u003d_(\u0027Name of the cluster template to create.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_af4b8baf","line":34,"updated":"2017-02-28 22:45:04.000000000","message":"The fact OSC uses argparse pretty literally means we can\u0027t require named arguments without them being positional or without verifying their values in take_action. This also causes the problem of those values appearing optional in help text. As of now, any required arguments (in the case of CT create: name, coe, image, external-network) are all positional and cannot be named individually on the command line","commit_id":"864a4c251324803161deb37b88c1c5bbb4165a20"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"ca600c0ba8230de72a18b711a45a29b19f9d3a8c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(CreateClusterTemplate, self).get_parser(prog_name)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \u0027name\u0027,"},{"line_number":36,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":37,"context_line":"            help\u003d_(\u0027Name of the cluster template to create.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba2be162_41b023de","line":34,"in_reply_to":"ba2be162_af4b8baf","updated":"2017-02-28 23:15:49.000000000","message":"Disregard this, I had a brainfart","commit_id":"864a4c251324803161deb37b88c1c5bbb4165a20"}],"magnumclient/osc/v1/clusters.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"30f7781d01092d041965267854e72b331f598497","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        parser.add_argument(\u0027name\u0027,\r"},{"line_number":33,"context_line":"                            metavar\u003d\u0027\u003cname\u003e\u0027,\r"},{"line_number":34,"context_line":"                            help\u003d\u0027Name of the cluster to create.\u0027)\r"},{"line_number":35,"context_line":"        parser.add_argument(\u0027cluster_template\u0027,\r"},{"line_number":36,"context_line":"                            metavar\u003d\u0027\u003ccluster_template\u003e\u0027,\r"},{"line_number":37,"context_line":"                            help\u003d\u0027ID or name of the cluster template.\u0027)\r"},{"line_number":38,"context_line":"        parser.add_argument(\u0027--keypair\u0027,\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_97befdab","line":35,"updated":"2017-02-27 09:53:59.000000000","message":"dashes","commit_id":"d53c78bb5a2852cab0334fba9e20febef86fcdd4"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"e31b12b0fed2fa853fd030ec5f56fdb040a60a59","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        parser.add_argument(\u0027name\u0027,\r"},{"line_number":33,"context_line":"                            metavar\u003d\u0027\u003cname\u003e\u0027,\r"},{"line_number":34,"context_line":"                            help\u003d\u0027Name of the cluster to create.\u0027)\r"},{"line_number":35,"context_line":"        parser.add_argument(\u0027cluster_template\u0027,\r"},{"line_number":36,"context_line":"                            metavar\u003d\u0027\u003ccluster_template\u003e\u0027,\r"},{"line_number":37,"context_line":"                            help\u003d\u0027ID or name of the cluster template.\u0027)\r"},{"line_number":38,"context_line":"        parser.add_argument(\u0027--keypair\u0027,\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_f57ac376","line":35,"in_reply_to":"da36d5c6_97befdab","updated":"2017-02-27 22:42:53.000000000","message":"Done","commit_id":"d53c78bb5a2852cab0334fba9e20febef86fcdd4"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"30f7781d01092d041965267854e72b331f598497","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            default\u003dNone,\r"},{"line_number":40,"context_line":"                            metavar\u003d\u0027\u003ckeypair\u003e\u0027,\r"},{"line_number":41,"context_line":"                            help\u003d\u0027UUID or name of the keypair to use.\u0027)\r"},{"line_number":42,"context_line":"        parser.add_argument(\u0027--node_count\u0027,\r"},{"line_number":43,"context_line":"                            type\u003dint,\r"},{"line_number":44,"context_line":"                            default\u003d1,\r"},{"line_number":45,"context_line":"                            metavar\u003d\u0027\u003cnode_count\u003e\u0027,\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_97299d9d","line":42,"range":{"start_line":42,"start_character":31,"end_line":42,"end_character":41},"updated":"2017-02-27 09:53:59.000000000","message":"What is the policy here? Are we going to add the args with underscores for consistency? For example, in server create you do --key-name but in server show it\u0027s key_name","commit_id":"d53c78bb5a2852cab0334fba9e20febef86fcdd4"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"e31b12b0fed2fa853fd030ec5f56fdb040a60a59","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            default\u003dNone,\r"},{"line_number":40,"context_line":"                            metavar\u003d\u0027\u003ckeypair\u003e\u0027,\r"},{"line_number":41,"context_line":"                            help\u003d\u0027UUID or name of the keypair to use.\u0027)\r"},{"line_number":42,"context_line":"        parser.add_argument(\u0027--node_count\u0027,\r"},{"line_number":43,"context_line":"                            type\u003dint,\r"},{"line_number":44,"context_line":"                            default\u003d1,\r"},{"line_number":45,"context_line":"                            metavar\u003d\u0027\u003cnode_count\u003e\u0027,\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"da36d5c6_7eedd5ee","line":42,"range":{"start_line":42,"start_character":31,"end_line":42,"end_character":41},"in_reply_to":"da36d5c6_97299d9d","updated":"2017-02-27 22:42:53.000000000","message":"That was an oversight. Fixed in next patch","commit_id":"d53c78bb5a2852cab0334fba9e20febef86fcdd4"}]}