)]}'
{"magnumclient/shell.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"14d0f40de8bd24cd176b27436b075d683a6faa39","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        return parser"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def _add_bash_completion_subparser(self, subparsers):"},{"line_number":465,"context_line":"        subparser \u003d ("},{"line_number":466,"context_line":"            subparsers.add_parser(\u0027bash_completion\u0027,"},{"line_number":467,"context_line":"                                  add_help\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_bc9b3417","side":"PARENT","line":464,"updated":"2017-03-10 05:37:00.000000000","message":"I am not sure right now why it was added earlier. May be it was for given to support both _ and - in subcommands.\nIf yes, do all openstack python clients are removing this support?","commit_id":"7937f06a64eb7d6795989b24b50a4fc4cc3c1aa5"},{"author":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"change_message_id":"262784854e33ac19531849a08be87698acdd99c5","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        return parser"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def _add_bash_completion_subparser(self, subparsers):"},{"line_number":465,"context_line":"        subparser \u003d ("},{"line_number":466,"context_line":"            subparsers.add_parser(\u0027bash_completion\u0027,"},{"line_number":467,"context_line":"                                  add_help\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_cb1e330b","side":"PARENT","line":464,"in_reply_to":"9a30ddce_bc9b3417","updated":"2017-03-11 15:01:59.000000000","message":"but no \"bash_completion\" in \"magnum --help\", so i think \"bash_completion\" is excess.","commit_id":"7937f06a64eb7d6795989b24b50a4fc4cc3c1aa5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"abcbef01276c47ec6f04a8cf18e5fa3b31eb99ce","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        return parser"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    def _add_bash_completion_subparser(self, subparsers):"},{"line_number":465,"context_line":"        subparser \u003d ("},{"line_number":466,"context_line":"            subparsers.add_parser(\u0027bash_completion\u0027,"},{"line_number":467,"context_line":"                                  add_help\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_a6c3f488","side":"PARENT","line":464,"in_reply_to":"9a30ddce_cb1e330b","updated":"2017-06-05 05:19:14.000000000","message":"yesh bash_completionbash-completion will not be returned in magnum --help, it\u0027s just used by bash completion script: https://github.com/openstack/python-magnumclient/blob/master/tools/magnum.bash_completion","commit_id":"7937f06a64eb7d6795989b24b50a4fc4cc3c1aa5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"14d0f40de8bd24cd176b27436b075d683a6faa39","unresolved":false,"context_lines":[{"line_number":464,"context_line":"            # I prefer to be hyphen-separated instead of underscores."},{"line_number":465,"context_line":"            command \u003d attr[3:].replace(\u0027_\u0027, \u0027-\u0027)"},{"line_number":466,"context_line":"            callback \u003d getattr(actions_module, attr)"},{"line_number":467,"context_line":"            if command \u003d\u003d \u0027bash-completion\u0027:"},{"line_number":468,"context_line":"                callback \u003d self.do_bash_completion"},{"line_number":469,"context_line":"            desc \u003d callback.__doc__ or \u0027\u0027"},{"line_number":470,"context_line":"            action_help \u003d desc.strip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_dc9c6810","line":467,"updated":"2017-03-10 05:37:00.000000000","message":"Is this required, i think it would work without 467-468","commit_id":"f29b48c9cc9b09ff6bdc207130177e9f3973f742"},{"author":{"_account_id":21515,"name":"LiChunlin","email":"lichl@hotmail.com","username":"ForestLee"},"change_message_id":"262784854e33ac19531849a08be87698acdd99c5","unresolved":false,"context_lines":[{"line_number":464,"context_line":"            # I prefer to be hyphen-separated instead of underscores."},{"line_number":465,"context_line":"            command \u003d attr[3:].replace(\u0027_\u0027, \u0027-\u0027)"},{"line_number":466,"context_line":"            callback \u003d getattr(actions_module, attr)"},{"line_number":467,"context_line":"            if command \u003d\u003d \u0027bash-completion\u0027:"},{"line_number":468,"context_line":"                callback \u003d self.do_bash_completion"},{"line_number":469,"context_line":"            desc \u003d callback.__doc__ or \u0027\u0027"},{"line_number":470,"context_line":"            action_help \u003d desc.strip()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_0b15abe3","line":467,"in_reply_to":"9a30ddce_dc9c6810","updated":"2017-03-11 15:01:59.000000000","message":"yes, i fixed.","commit_id":"f29b48c9cc9b09ff6bdc207130177e9f3973f742"}]}