)]}'
{"magnumclient/v1/cluster_templates_shell.py":[{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"67d84029c2740b10d19241ba69b3685ce8feeaa2","unresolved":false,"context_lines":[{"line_number":178,"context_line":"           help\u003d_(\u0027Indicates whether created Clusters should have a \u0027"},{"line_number":179,"context_line":"                  \u0027floating ip or not.\u0027),"},{"line_number":180,"context_line":"           type\u003dlambda v: strutils.bool_from_string(v, True),"},{"line_number":181,"context_line":"           default\u003dTrue)"},{"line_number":182,"context_line":"def do_cluster_template_create(cs, args):"},{"line_number":183,"context_line":"    \"\"\"Create a cluster template.\"\"\""},{"line_number":184,"context_line":"    args.command \u003d \u0027cluster-template-create\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_30a9ed7a","line":181,"updated":"2017-03-31 19:30:31.000000000","message":"If I\u0027m interpreting the purpose of this flag correctly, the fix really just needs to be setting \"default\u003dFalse\", no?\n\nThat way a user can supply the flag to store as True, otherwise they can leave it off to leave it False","commit_id":"7fa70e5f50af22bd0be672d0f8a8d7cd05a925ef"},{"author":{"_account_id":7230,"name":"Vijendar Komalla","email":"vijendar.komalla@rackspace.com","username":"vijendar"},"change_message_id":"571251d349894700f33c900d112aefa21661d13d","unresolved":false,"context_lines":[{"line_number":178,"context_line":"           help\u003d_(\u0027Indicates whether created Clusters should have a \u0027"},{"line_number":179,"context_line":"                  \u0027floating ip or not.\u0027),"},{"line_number":180,"context_line":"           type\u003dlambda v: strutils.bool_from_string(v, True),"},{"line_number":181,"context_line":"           default\u003dTrue)"},{"line_number":182,"context_line":"def do_cluster_template_create(cs, args):"},{"line_number":183,"context_line":"    \"\"\"Create a cluster template.\"\"\""},{"line_number":184,"context_line":"    args.command \u003d \u0027cluster-template-create\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_f0f4a55d","line":181,"in_reply_to":"dfeb2761_30a9ed7a","updated":"2017-03-31 19:40:24.000000000","message":"you are right, but current(/expected) behavior is that if user does not provide any value, \u0027True\u0027 is assumed. If we go with your suggestion, user experience will change(who are using default behavior need to explicitly pass the switch).\n\nIf default value \u0027False\u0027 makes sense (from the user experience point of view), I am OK with you suggestion.\n\nI would like to hear others thoughts on this.","commit_id":"7fa70e5f50af22bd0be672d0f8a8d7cd05a925ef"},{"author":{"_account_id":21660,"name":"Stephen Watson","email":"stephen.watson@intel.com","username":"swatson"},"change_message_id":"aff9ebdcb8b7957f27750a91de05217e4328619b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"           help\u003d_(\u0027Indicates whether created Clusters should have a \u0027"},{"line_number":179,"context_line":"                  \u0027floating ip or not.\u0027),"},{"line_number":180,"context_line":"           type\u003dlambda v: strutils.bool_from_string(v, True),"},{"line_number":181,"context_line":"           default\u003dTrue)"},{"line_number":182,"context_line":"def do_cluster_template_create(cs, args):"},{"line_number":183,"context_line":"    \"\"\"Create a cluster template.\"\"\""},{"line_number":184,"context_line":"    args.command \u003d \u0027cluster-template-create\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_7c0e1d8e","line":181,"in_reply_to":"dfeb2761_f0f4a55d","updated":"2017-04-02 05:12:26.000000000","message":"The best option would likely be renaming this flag to \"--floating-ip-disabled\", but then we have other issues relating to compatibility and deprecation.","commit_id":"7fa70e5f50af22bd0be672d0f8a8d7cd05a925ef"}]}