)]}'
{"id":"openstack%2Fpython-magnumclient~459906","triplet_id":"openstack%2Fpython-magnumclient~master~I9146c6d58b80016fb232db916110e7489155d153","project":"openstack/python-magnumclient","branch":"master","topic":"bp/coe-version","hashtags":[],"change_id":"I9146c6d58b80016fb232db916110e7489155d153","subject":"Cluster coe-version should be fixed in command line","status":"ABANDONED","created":"2017-04-26 01:48:38.000000000","updated":"2020-03-31 09:35:24.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4c55983a6e2bdfad217d245afa850d89f4aecb3e","_number":459906,"virtual_id_number":459906,"owner":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"date":"2017-05-04 05:54:28.000000000","_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":-1,"date":"2017-07-28 09:47:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"value":-1,"date":"2017-05-03 13:58:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-03 13:58:37.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"state":"REVIEWER"},{"updated":"2017-07-28 09:47:04.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"}],"messages":[{"id":"ae9a36b29ba1704188fdbf49dff21ad32b06c62a","author":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"date":"2017-04-26 01:48:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4757b5e00f14eb05dba90c4896f3437d17b663e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-26 01:53:20.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/06/459906/1/check/gate-python-magnumclient-docs-ubuntu-xenial/38adb05//doc/build/html/ : SUCCESS in 3m 53s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/06/459906/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/5d18f28/ : SUCCESS in 4m 28s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/06/459906/1/check/gate-python-magnumclient-python27-ubuntu-xenial/162fb34/ : FAILURE in 2m 13s\n- gate-python-magnumclient-python35 http://logs.openstack.org/06/459906/1/check/gate-python-magnumclient-python35/28dfbc9/ : FAILURE in 2m 19s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/06/459906/1/check/python-magnumclient-coverage-ubuntu-xenial-nv/bbc0251/ : FAILURE in 2m 29s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"37e5dda6c81747df49b656f75deca1b1c5d1e384","author":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"date":"2017-04-26 05:48:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0ac5a27d50e4363d03a3c6afb71bc1c70e4fdda2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-26 05:52:56.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/06/459906/2/check/gate-python-magnumclient-docs-ubuntu-xenial/8bbafb6//doc/build/html/ : SUCCESS in 4m 26s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/06/459906/2/check/gate-python-magnumclient-pep8-ubuntu-xenial/182a11b/ : SUCCESS in 2m 39s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/06/459906/2/check/gate-python-magnumclient-python27-ubuntu-xenial/58e9576/ : SUCCESS in 2m 16s\n- gate-python-magnumclient-python35 http://logs.openstack.org/06/459906/2/check/gate-python-magnumclient-python35/084ac40/ : SUCCESS in 2m 10s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/06/459906/2/check/python-magnumclient-coverage-ubuntu-xenial-nv/4b113fb/ : SUCCESS in 2m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4374d4e6716a45d93c7e4ff5f2a8ee5f2112345c","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-05-03 13:58:37.000000000","message":"Patch Set 2: Code-Review-1\n\nI can\u0027t get what is achieved with this patch(update coe_version), as coe_version is mapped with different parameters in driver like kube_version, swarm_version and i don\u0027t think setting this parameter via magnumclient will change coe_version in deployed cluster. Have you tried this patch, what\u0027s the effect of this?\n\nIf you have series of patches then can you please update in the blueprint so that i can understand.","accounts_in_message":[],"_revision_number":2},{"id":"b615186cac2e3392da4b983ac3b4e63b70c51492","author":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"date":"2017-05-04 05:54:28.000000000","message":"Patch Set 2:\n\n\u003e I can\u0027t get what is achieved with this patch(update coe_version),\n \u003e as coe_version is mapped with different parameters in driver like\n \u003e kube_version, swarm_version and i don\u0027t think setting this\n \u003e parameter via magnumclient will change coe_version in deployed\n \u003e cluster. Have you tried this patch, what\u0027s the effect of this?\n \u003e \n \u003e If you have series of patches then can you please update in the\n \u003e blueprint so that i can understand.\n\nIt isn\u0027t changing the coe-version of deployed cluster, but fix the coe-version when creating cluster. The api code should also be changed. https://review.openstack.org/#/c/459498/","accounts_in_message":[],"_revision_number":2},{"id":"f613154e15d7e4d2ea01b2b33c8c41dca4a15d15","author":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"date":"2017-06-05 09:26:40.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"6a6e5c1f113b8978190cd8ad4c464c54c5e43fc4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-05 09:33:29.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/06/459906/2/check/gate-python-magnumclient-docs-ubuntu-xenial/3dc3b7c//doc/build/html/ : SUCCESS in 5m 05s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/06/459906/2/check/gate-python-magnumclient-pep8-ubuntu-xenial/5ef750d/ : SUCCESS in 3m 05s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/06/459906/2/check/gate-python-magnumclient-python27-ubuntu-xenial/44cb4dd/ : SUCCESS in 3m 06s\n- gate-python-magnumclient-python35 http://logs.openstack.org/06/459906/2/check/gate-python-magnumclient-python35/cb7c910/ : SUCCESS in 3m 15s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/06/459906/2/check/python-magnumclient-coverage-ubuntu-xenial-nv/ee3b14e/ : SUCCESS in 4m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"ebe30f820a95ff2eb60e2cbedd8ee247ea01d8c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-16 14:09:28.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"64a2a8565218469898af91581231c2161cd4ebed","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2017-07-28 09:47:04.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027m doing work on this with an upgrade command. We must not allow change of the coe version with the update command.","accounts_in_message":[],"_revision_number":2},{"id":"e41fe5a2e345b27a5dd72712bb668f214e37b69c","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-12-18 02:44:17.000000000","message":"Removed reviewer Jenkins with the following votes:\n\n* Verified-1 by Jenkins (3)\n","accounts_in_message":[],"_revision_number":2},{"id":"149b4abd2dc96e8b6ba28282a0b7c74b8085b6cd","author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"date":"2020-03-31 09:35:24.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7894c26155370d442d99c9b068236c1d47188cf1","revisions":{"78f6aa35b5887e2bdc0727988d027ad859f3dd5f":{"kind":"REWORK","_number":1,"created":"2017-04-26 01:48:38.000000000","uploader":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"ref":"refs/changes/06/459906/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/06/459906/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/1"}}},"commit":{"parents":[{"commit":"a790dcedaacaa768387b9e2e5b48d86e4852383c","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/a790dcedaacaa768387b9e2e5b48d86e4852383c"}]}],"author":{"name":"coldmoment","email":"yan.zhiwei1@zte.com.cn","date":"2017-04-26 01:03:34.000000000","tz":480},"committer":{"name":"coldmoment","email":"yan.zhiwei1@zte.com.cn","date":"2017-04-26 01:10:16.000000000","tz":480},"subject":"Cluster coe-version should be fixed in command line","message":"Cluster coe-version should be fixed in command line\n\nThe \u0027coe-version\u0027 could be an optional parameter of\ncommand \u0027magnum cluster-create\u0027.\n\nChange-Id: I9146c6d58b80016fb232db916110e7489155d153\nImplements: blueprint coe-version\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/78f6aa35b5887e2bdc0727988d027ad859f3dd5f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/78f6aa35b5887e2bdc0727988d027ad859f3dd5f"}]},"branch":"refs/heads/master"},"7894c26155370d442d99c9b068236c1d47188cf1":{"kind":"REWORK","_number":2,"created":"2017-04-26 05:48:18.000000000","uploader":{"_account_id":23012,"name":"Yan Zhiwei","email":"yan.zhiwei1@zte.com.cn","username":"yanzhiwei"},"ref":"refs/changes/06/459906/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/06/459906/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/06/459906/2"}}},"commit":{"parents":[{"commit":"a790dcedaacaa768387b9e2e5b48d86e4852383c","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/a790dcedaacaa768387b9e2e5b48d86e4852383c"}]}],"author":{"name":"coldmoment","email":"yan.zhiwei1@zte.com.cn","date":"2017-04-26 01:03:34.000000000","tz":480},"committer":{"name":"coldmoment","email":"yan.zhiwei1@zte.com.cn","date":"2017-04-26 05:10:03.000000000","tz":480},"subject":"Cluster coe-version should be fixed in command line","message":"Cluster coe-version should be fixed in command line\n\nThe \u0027coe-version\u0027 could be an optional parameter of\ncommand \u0027magnum cluster-create\u0027.\n\nChange-Id: I9146c6d58b80016fb232db916110e7489155d153\nImplements: blueprint coe-version\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7894c26155370d442d99c9b068236c1d47188cf1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/7894c26155370d442d99c9b068236c1d47188cf1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}