)]}'
{"id":"openstack%2Fpython-magnumclient~471616","triplet_id":"openstack%2Fpython-magnumclient~master~Ib04a2fd4b6545bf41b14b4366c11f4d7329227e6","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"Ib04a2fd4b6545bf41b14b4366c11f4d7329227e6","subject":"Change assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2017-06-07 07:50:33.000000000","updated":"2017-06-11 16:54:05.000000000","submitted":"2017-06-11 16:54:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"633c92df9e5aa470e7bb23b1fd7a57e5cbf1ae43","_number":471616,"virtual_id_number":471616,"owner":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-06-11 16:54:05.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-06-07 10:26:56.000000000","_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":2,"date":"2017-06-11 16:47:29.000000000","_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":1,"date":"2017-06-11 16:47:29.000000000","_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-07 10:26:56.000000000","updated_by":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"reviewer":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"state":"REVIEWER"},{"updated":"2017-06-11 16:47:29.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2017-06-11 16:54:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ba1d2fd12375432fb8a8ca1aa7aab605f3efc136","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-06-07 07:50:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"03073956416ab88201f0e3ebf64c351a4247cad6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-07 07:58:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/471616/1/check/gate-python-magnumclient-docs-ubuntu-xenial/632bd32//doc/build/html/ : SUCCESS in 3m 48s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/16/471616/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/0cad5be/ : SUCCESS in 3m 04s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/16/471616/1/check/gate-python-magnumclient-python27-ubuntu-xenial/46ae6de/ : SUCCESS in 2m 33s\n- gate-python-magnumclient-python35 http://logs.openstack.org/16/471616/1/check/gate-python-magnumclient-python35/3ab37e6/ : SUCCESS in 3m 35s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/16/471616/1/check/python-magnumclient-coverage-ubuntu-xenial-nv/84f8617/ : SUCCESS in 6m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"faf9d4e1d7170a7ae09c6e0ccf366e0a65d22f32","author":{"_account_id":668,"name":"Adrian Otto","email":"aotto@aotto.com","username":"aotto"},"date":"2017-06-07 10:26:56.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"835d9b8927f316037cfdeab0e0af7a8059962645","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2017-06-11 16:47:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"fddc35c51501748cfc100ea3af3ddabfa07f1f42","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-11 16:47:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1775b029c39021132ac5f36bda2d50c042a6c436","date":"2017-06-11 16:54:05.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"d6751f4a315bbf4f983028f1e55aa2bd14a9bd91","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-11 16:54:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/16/471616/1/gate/gate-python-magnumclient-docs-ubuntu-xenial/8d02a5e//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/16/471616/1/gate/gate-python-magnumclient-pep8-ubuntu-xenial/30c4789/ : SUCCESS in 2m 42s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/16/471616/1/gate/gate-python-magnumclient-python27-ubuntu-xenial/91d6025/ : SUCCESS in 2m 45s\n- gate-python-magnumclient-python35 http://logs.openstack.org/16/471616/1/gate/gate-python-magnumclient-python35/b65a2f1/ : SUCCESS in 6m 19s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"96c304b9b71d64d7a68a390a8a3e12f4cf1f9983","revisions":{"96c304b9b71d64d7a68a390a8a3e12f4cf1f9983":{"kind":"REWORK","_number":1,"created":"2017-06-07 07:50:33.000000000","uploader":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"ref":"refs/changes/16/471616/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/16/471616/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/16/471616/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/16/471616/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/16/471616/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/16/471616/1"}}},"commit":{"parents":[{"commit":"821e29f6d7b77ddc671f674cbca44f04d4c7d2c7","subject":"Merge \"Magnum client suport insecure_registry\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/821e29f6d7b77ddc671f674cbca44f04d4c7d2c7"}]}],"author":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-06-07 07:49:24.000000000","tz":420},"committer":{"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","date":"2017-06-07 07:49:53.000000000","tz":420},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nSome of tests use different method of assertTrue(isinstance(A, B)).\nThe correct way is to use assertIsInstance(A,B) provided by testtools.\n\nChange-Id: Ib04a2fd4b6545bf41b14b4366c11f4d7329227e6\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/96c304b9b71d64d7a68a390a8a3e12f4cf1f9983"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/96c304b9b71d64d7a68a390a8a3e12f4cf1f9983"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
