)]}'
{"id":"openstack%2Fpython-magnumclient~480239","triplet_id":"openstack%2Fpython-magnumclient~master~I510ff10d708a237be0cb88d3ff7094d7c81f5875","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1702314","hashtags":[],"change_id":"I510ff10d708a237be0cb88d3ff7094d7c81f5875","subject":"Don\u0027t set a default for docker_volume_size","status":"MERGED","created":"2017-07-04 15:36:47.000000000","updated":"2017-07-05 06:22:40.000000000","submitted":"2017-07-05 06:22:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ead6c2546009ea5e6f523001abab57af88709287","_number":480239,"virtual_id_number":480239,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":2,"date":"2017-07-05 06:22:40.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":2,"date":"2017-07-04 16:06:29.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-05 06:18:16.000000000","_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":1,"date":"2017-07-04 16:39:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-07-05 06:18:16.000000000","_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-04 16:06:29.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2017-07-04 16:39:56.000000000","updated_by":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"reviewer":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"state":"REVIEWER"},{"updated":"2017-07-05 06:18:16.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"state":"REVIEWER"},{"updated":"2017-07-05 06:22:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9a8b00d0cba4cc3da4f4d7ad4ee69d1f6c9a0ed7","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2017-07-04 15:36:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"beae6ad38cddddd20ffa01d024dfe4f2cb30a071","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2017-07-04 15:37:26.000000000","message":"Patch Set 1:\n\nbay too","accounts_in_message":[],"_revision_number":1},{"id":"9c69f2155da8d0ca4b196e51a705fd77ecd3969c","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2017-07-04 15:44:53.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"a104c63a111cd98710b88456c2db14802a037d87","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-04 15:44:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/39/480239/1/check/gate-python-magnumclient-docs-ubuntu-xenial/dc81c6d//doc/build/html/ : SUCCESS in 3m 32s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/39/480239/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/281a284/ : SUCCESS in 5m 29s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/39/480239/1/check/gate-python-magnumclient-python27-ubuntu-xenial/8e5e1be/ : SUCCESS in 2m 28s\n- gate-python-magnumclient-python35 http://logs.openstack.org/39/480239/1/check/gate-python-magnumclient-python35/6627f71/ : SUCCESS in 6m 31s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/39/480239/1/check/python-magnumclient-coverage-ubuntu-xenial-nv/b75689e/ : SUCCESS in 2m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"22474dca6b28a44d6eaa77c09969fafeb2a76420","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2017-07-04 15:45:28.000000000","message":"Patch Set 2:\n\n\u003e bay too\n\nAs discussed on IRC, there is no bay support in the client currently.","accounts_in_message":[],"_revision_number":2},{"id":"df75072b3fb0e627ec7172fd27ce0e8dc46b3739","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-04 15:52:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/39/480239/2/check/gate-python-magnumclient-docs-ubuntu-xenial/07ccaa4//doc/build/html/ : SUCCESS in 4m 12s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/39/480239/2/check/gate-python-magnumclient-pep8-ubuntu-xenial/ed5b080/ : SUCCESS in 5m 18s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/39/480239/2/check/gate-python-magnumclient-python27-ubuntu-xenial/39a52a3/ : SUCCESS in 2m 43s\n- gate-python-magnumclient-python35 http://logs.openstack.org/39/480239/2/check/gate-python-magnumclient-python35/d2493d2/ : SUCCESS in 4m 51s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/39/480239/2/check/python-magnumclient-coverage-ubuntu-xenial-nv/a224d19/ : SUCCESS in 5m 51s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9be6cfff2c810101a40eaaacc7d2fe0d389ca1ff","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2017-07-04 16:06:29.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7d299eb4b1f678820401ca7ca3007afeea2ca706","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2017-07-04 16:39:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d307229f3599db3c351ee669d5b61091e55caaff","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-07-05 06:18:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"98915c11930bb5098fe9f754ddff942664727506","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-05 06:18:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"4a3ae0de1ac5d09bdefa592a4b24e7960c198f83","date":"2017-07-05 06:22:40.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"cbad3dffe016f1694e37afbc911ad1cbbdfee883","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-05 06:22:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/39/480239/2/gate/gate-python-magnumclient-docs-ubuntu-xenial/eb29f44//doc/build/html/ : SUCCESS in 4m 05s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/39/480239/2/gate/gate-python-magnumclient-pep8-ubuntu-xenial/1b84094/ : SUCCESS in 2m 55s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/39/480239/2/gate/gate-python-magnumclient-python27-ubuntu-xenial/fa440a2/ : SUCCESS in 3m 20s\n- gate-python-magnumclient-python35 http://logs.openstack.org/39/480239/2/gate/gate-python-magnumclient-python35/e390bce/ : SUCCESS in 3m 31s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"899e6c2303fd93ae2303a64fa0c0e69febb5b925","revisions":{"c5d2f711cd644d858298a82501d97e383b689e68":{"kind":"REWORK","_number":1,"created":"2017-07-04 15:36:47.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/39/480239/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/39/480239/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/1"}}},"commit":{"parents":[{"commit":"babbdb70838034df74101d520a3a06564f9bf94f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/babbdb70838034df74101d520a3a06564f9bf94f"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2017-07-04 15:32:19.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2017-07-04 15:36:44.000000000","tz":60},"subject":"Don\u0027t set a default for docker_volume_size","message":"Don\u0027t set a default for docker_volume_size\n\nWhen creating clusters, we should only pass the docker_volume_size\nparameter to the magnum API if it was specified by the user. If not,\nomitting it allows the API to set a default based on the cluster\ntemplate.\n\nChange-Id: I510ff10d708a237be0cb88d3ff7094d7c81f5875\nCloses-Bug: #1702314\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c5d2f711cd644d858298a82501d97e383b689e68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c5d2f711cd644d858298a82501d97e383b689e68"}]},"branch":"refs/heads/master"},"899e6c2303fd93ae2303a64fa0c0e69febb5b925":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-07-04 15:44:53.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/39/480239/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/39/480239/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/39/480239/2"}}},"commit":{"parents":[{"commit":"babbdb70838034df74101d520a3a06564f9bf94f","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/babbdb70838034df74101d520a3a06564f9bf94f"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2017-07-04 15:32:19.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2017-07-04 15:43:35.000000000","tz":60},"subject":"Don\u0027t set a default for docker_volume_size","message":"Don\u0027t set a default for docker_volume_size\n\nWhen creating clusters, we should only pass the docker_volume_size\nparameter to the magnum API if it was specified by the user. If not,\nomitting it allows the API to set a default based on the cluster\ntemplate.\n\nChange-Id: I510ff10d708a237be0cb88d3ff7094d7c81f5875\nCloses-Bug: #1702314\nRelated-Bug: #1635244\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/899e6c2303fd93ae2303a64fa0c0e69febb5b925"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/899e6c2303fd93ae2303a64fa0c0e69febb5b925"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}