)]}'
{"id":"openstack%2Fpython-magnumclient~491372","triplet_id":"openstack%2Fpython-magnumclient~master~I45c58df5c7457aec419074e4719ef63fb7a0d0b9","project":"openstack/python-magnumclient","branch":"master","hashtags":[],"change_id":"I45c58df5c7457aec419074e4719ef63fb7a0d0b9","subject":"Replace six.iteritems() with dict.items() in python-magnumclient","status":"MERGED","created":"2017-08-07 07:00:23.000000000","updated":"2018-02-26 11:52:14.000000000","submitted":"2018-02-26 11:40:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"491372-1519645229983-cb5e92b7","meta_rev_id":"2e9a47b6024b232aea4e2c8b39827e9207bc11e3","_number":491372,"virtual_id_number":491372,"owner":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2018-02-26 11:40:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":2,"date":"2018-02-26 11:22:37.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-02-26 11:22:37.000000000","_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":1,"date":"2018-02-26 11:22:41.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-08-07 07:06:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-08-20 05:51:50.000000000","updated_by":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"reviewer":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"state":"REVIEWER"},{"updated":"2018-02-26 11:22:41.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2018-02-26 11:40:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4d28131a3806dbd0fc8441b6680d2f9c3f8e9c0d","author":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"date":"2017-08-07 07:00:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f121cd19de44c233e9a6c2dd3a30d3e23fba61e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-08-07 07:06:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-magnumclient-docs-ubuntu-xenial http://docs-draft.openstack.org/72/491372/1/check/gate-python-magnumclient-docs-ubuntu-xenial/c5ab933//doc/build/html/ : SUCCESS in 3m 56s\n- gate-python-magnumclient-pep8-ubuntu-xenial http://logs.openstack.org/72/491372/1/check/gate-python-magnumclient-pep8-ubuntu-xenial/a354f1d/ : SUCCESS in 3m 44s\n- gate-python-magnumclient-python27-ubuntu-xenial http://logs.openstack.org/72/491372/1/check/gate-python-magnumclient-python27-ubuntu-xenial/254ba31/ : SUCCESS in 4m 34s\n- gate-python-magnumclient-python35 http://logs.openstack.org/72/491372/1/check/gate-python-magnumclient-python35/991be8d/ : SUCCESS in 3m 23s\n- python-magnumclient-coverage-ubuntu-xenial-nv http://logs.openstack.org/72/491372/1/check/python-magnumclient-coverage-ubuntu-xenial-nv/2e7d8ac/ : SUCCESS in 3m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1943555415b30b180597525d54a99e2ebae1ab3e","author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"date":"2017-08-20 05:51:50.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9f58d13bb5e8ae7546ba8ac1db1f939c40d5bd79","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-01-29 10:13:49.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"aa0a704112c28dbcb674f10aa59e3f92ac9f4848","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-02-26 11:22:37.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"2316162ffdecf597cb1262f6226f0f9f994e1fca","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-02-26 11:22:41.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"78ab1350431234f6f5258fc525592a0e38c3c54e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-26 11:32:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/72/491372/2/check/openstack-tox-pep8/1ece6d9/ : SUCCESS in 4m 37s\n- openstack-tox-py27 http://logs.openstack.org/72/491372/2/check/openstack-tox-py27/17dcb25/ : SUCCESS in 4m 05s\n- openstack-tox-py35 http://logs.openstack.org/72/491372/2/check/openstack-tox-py35/007e1db/ : SUCCESS in 3m 53s\n- build-openstack-sphinx-docs http://logs.openstack.org/72/491372/2/check/build-openstack-sphinx-docs/bb86a94/html/ : SUCCESS in 4m 26s\n- openstack-tox-cover http://logs.openstack.org/72/491372/2/check/openstack-tox-cover/7bdeac3/cover/ : SUCCESS in 4m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f224c4278713070c0878579ff4d17f243fcccab1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-26 11:32:20.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"980cd7d176928fa6b30ea8c1daa7ae1f90fba833","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-26 11:40:29.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"0312aa22be464ecd3bd5b37b53ea2247abaac957","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-26 11:40:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/72/491372/2/gate/openstack-tox-pep8/d921e2b/ : SUCCESS in 3m 59s\n- openstack-tox-py27 http://logs.openstack.org/72/491372/2/gate/openstack-tox-py27/b89bdfe/ : SUCCESS in 3m 59s\n- openstack-tox-py35 http://logs.openstack.org/72/491372/2/gate/openstack-tox-py35/63ead0c/ : SUCCESS in 3m 57s\n- build-openstack-sphinx-docs http://logs.openstack.org/72/491372/2/gate/build-openstack-sphinx-docs/bbe0db9/html/ : SUCCESS in 3m 49s","accounts_in_message":[],"_revision_number":2},{"id":"795f9ba540afae89812b44d689aa3206b373b52d","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-02-26 11:49:18.000000000","message":"Created a revert of this change as I0b9b241c7940f231c07419cad3674c1486a8418b","accounts_in_message":[],"_revision_number":2},{"id":"2e9a47b6024b232aea4e2c8b39827e9207bc11e3","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-02-26 11:52:14.000000000","message":"Patch Set 2:\n\nI really missed that, it is merged elsewhere already","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4f35b15ad92a6fe07505b994f0d11c5983a99dc9","revisions":{"a0b339b0b1982b164041ae32e853d97ead681aa0":{"kind":"REWORK","_number":1,"created":"2017-08-07 07:00:23.000000000","uploader":{"_account_id":25432,"name":"yanghuichan","email":"yanghc@fiberhome.com","username":"yanghuichan"},"ref":"refs/changes/72/491372/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/72/491372/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/1"}}},"commit":{"parents":[{"commit":"f501b618fb344b36d2771ac4921746125e1a0871","subject":"Remove log translations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f501b618fb344b36d2771ac4921746125e1a0871"}]}],"author":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-07 06:59:36.000000000","tz":480},"committer":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-07 07:00:20.000000000","tz":480},"subject":"Replace six.iteritems() with dict.items() in python-magnumclient","message":"Replace six.iteritems() with dict.items() in python-magnumclient\n\n1.As mentioned in [1], we should avoid using six.iteritems\nto achieve iterators. We can use dict.items instead, as it\nwill return iterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be negligible,\nsee the link [2].\n[1] https://wiki.openstack.org/wiki/Python3#Common_patterns\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I45c58df5c7457aec419074e4719ef63fb7a0d0b9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/a0b339b0b1982b164041ae32e853d97ead681aa0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/a0b339b0b1982b164041ae32e853d97ead681aa0"}]},"branch":"refs/heads/master"},"4f35b15ad92a6fe07505b994f0d11c5983a99dc9":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2018-02-26 11:22:37.000000000","uploader":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"ref":"refs/changes/72/491372/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/72/491372/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/72/491372/2"}}},"commit":{"parents":[{"commit":"c165071ff8fee67adbc6bf9acee0368cdebf5503","subject":"Now cluster-template-update works for \"labels\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/c165071ff8fee67adbc6bf9acee0368cdebf5503"}]}],"author":{"name":"yanghuichan","email":"yanghc@fiberhome.com","date":"2017-08-07 06:59:36.000000000","tz":480},"committer":{"name":"Spyros Trigazis (strigazi)","email":"strigazi@gmail.com","date":"2018-02-26 11:22:37.000000000","tz":0},"subject":"Replace six.iteritems() with dict.items() in python-magnumclient","message":"Replace six.iteritems() with dict.items() in python-magnumclient\n\n1.As mentioned in [1], we should avoid using six.iteritems\nto achieve iterators. We can use dict.items instead, as it\nwill return iterators in PY3 as well. And dict.items/keys\nwill more readable.\n2.In py2, the performance about list should be negligible,\nsee the link [2].\n[1] https://wiki.openstack.org/wiki/Python3#Common_patterns\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I45c58df5c7457aec419074e4719ef63fb7a0d0b9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4f35b15ad92a6fe07505b994f0d11c5983a99dc9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/4f35b15ad92a6fe07505b994f0d11c5983a99dc9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
