)]}'
{"id":"openstack%2Fpython-magnumclient~517558","triplet_id":"openstack%2Fpython-magnumclient~master~I4c51b6f2f2d48681530f7369dfd8cfc1126f9d76","project":"openstack/python-magnumclient","branch":"master","topic":"517558","hashtags":[],"change_id":"I4c51b6f2f2d48681530f7369dfd8cfc1126f9d76","subject":"Replace six.iteritems() with .items()","status":"MERGED","created":"2017-11-03 07:28:14.000000000","updated":"2017-12-05 10:42:14.000000000","submitted":"2017-12-05 10:42:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"517558-1512470534553-9cedb2f7","meta_rev_id":"8adb209e249a08a8c7e0c9248f208f59eadc4d0c","_number":517558,"virtual_id_number":517558,"owner":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},{"value":0,"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":2,"date":"2017-12-05 10:42:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"recommended":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"all":[{"value":1,"date":"2017-11-10 04:33:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},{"value":1,"date":"2017-11-22 09:56:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},{"value":2,"date":"2017-12-05 08:24:27.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":2,"date":"2017-12-05 10:34:26.000000000","_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":1,"date":"2017-12-05 07:48:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"all":[{"value":0,"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},{"value":0,"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":1,"date":"2017-12-05 10:34:26.000000000","_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},{"value":0,"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"value":0,"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-11-10 04:33:41.000000000","updated_by":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"reviewer":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"state":"REVIEWER"},{"updated":"2017-11-22 09:56:11.000000000","updated_by":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"reviewer":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"state":"REVIEWER"},{"updated":"2017-12-05 07:48:35.000000000","updated_by":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"reviewer":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"state":"REVIEWER"},{"updated":"2017-12-05 08:24:27.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2017-12-05 10:34:26.000000000","updated_by":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"reviewer":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"state":"REVIEWER"},{"updated":"2017-12-05 10:42:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0b7ff5f70b5f273d82faf46147e38c13ab225067","author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"date":"2017-11-03 07:28:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"23cbc96309dd299d0fb9485d6e60293cbdd6af8e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-03 07:47:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/58/517558/1/check/openstack-tox-pep8/e9f2fc5/ : FAILURE in 4m 56s\n- openstack-tox-py27 http://logs.openstack.org/58/517558/1/check/openstack-tox-py27/030b1c3/ : SUCCESS in 5m 39s\n- openstack-tox-py35 http://logs.openstack.org/58/517558/1/check/openstack-tox-py35/918a912/ : SUCCESS in 5m 37s\n- build-openstack-sphinx-docs http://logs.openstack.org/58/517558/1/check/build-openstack-sphinx-docs/76db62f/html/ : SUCCESS in 5m 42s\n- openstack-tox-cover http://logs.openstack.org/58/517558/1/check/openstack-tox-cover/8267335/cover/ : SUCCESS in 4m 35s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9af07529061a075d8854096eb2d8a5474649813b","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-11-03 08:01:15.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e4a61baee59cc9abb5e06016712c1b07b86ac364","author":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"date":"2017-11-10 03:39:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e7b45f8c57e7922ee074fb6cef5d79f065860baa","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-10 03:49:19.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/58/517558/2/check/openstack-tox-pep8/aa0826f/ : SUCCESS in 4m 21s\n- openstack-tox-py27 http://logs.openstack.org/58/517558/2/check/openstack-tox-py27/9c81495/ : SUCCESS in 5m 46s\n- openstack-tox-py35 http://logs.openstack.org/58/517558/2/check/openstack-tox-py35/15cc138/ : SUCCESS in 4m 15s\n- build-openstack-sphinx-docs http://logs.openstack.org/58/517558/2/check/build-openstack-sphinx-docs/7dac226/html/ : SUCCESS in 4m 24s\n- openstack-tox-cover http://logs.openstack.org/58/517558/2/check/openstack-tox-cover/991721c/cover/ : SUCCESS in 5m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f7093aaabbe32eb09e707a66cf5132b176257aad","author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"date":"2017-11-10 04:33:41.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"5021c2334df8a02e56127c349ce09de1062a1292","author":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"date":"2017-11-22 09:56:11.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, Thanks for patch","accounts_in_message":[],"_revision_number":2},{"id":"c3a0a98c5201c7536772096570028dfa4a5da6db","author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"date":"2017-12-05 07:48:35.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e4ea446fdab4cc2a29c7c2a51032cfda92aae00c","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2017-12-05 08:24:27.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7177be6b0d6c2ece5cbf336fcc6f519503b5a2ec","author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"date":"2017-12-05 10:34:26.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"29e0c90a37b625561fd8d26f9686c0063ff0d931","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 10:34:41.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"94575d8614967e0944fb241bd43642719dcc926d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 10:42:14.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/58/517558/2/gate/openstack-tox-pep8/34e261d/ : SUCCESS in 5m 08s\n- openstack-tox-py27 http://logs.openstack.org/58/517558/2/gate/openstack-tox-py27/f19a946/ : SUCCESS in 6m 17s\n- openstack-tox-py35 http://logs.openstack.org/58/517558/2/gate/openstack-tox-py35/af5c753/ : SUCCESS in 3m 54s\n- build-openstack-sphinx-docs http://logs.openstack.org/58/517558/2/gate/build-openstack-sphinx-docs/a9936fd/html/ : SUCCESS in 6m 25s","accounts_in_message":[],"_revision_number":2},{"id":"ca0922a95e4755ffdbad60700f649860aadbf4c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-12-05 10:42:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e49dcb1995062e24d44a0691d6b8c0d8d1b7f64f","revisions":{"91a503a37d7e3cecd1efa11befcd0a50fbf735ed":{"kind":"REWORK","_number":1,"created":"2017-11-03 07:28:14.000000000","uploader":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"ref":"refs/changes/58/517558/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/58/517558/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/1"}}},"commit":{"parents":[{"commit":"056e57deba44e6671110d8b5916fd588f0c12e64","subject":"Merge \"OSC: Remove unused files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/056e57deba44e6671110d8b5916fd588f0c12e64"}]}],"author":{"name":"rajat29","email":"rajat.sharma@nectechnologies.in","date":"2017-11-03 07:25:57.000000000","tz":330},"committer":{"name":"rajat29","email":"rajat.sharma@nectechnologies.in","date":"2017-11-03 07:28:10.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid usingg\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I4c51b6f2f2d48681530f7369dfd8cfc1126f9d76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/91a503a37d7e3cecd1efa11befcd0a50fbf735ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/91a503a37d7e3cecd1efa11befcd0a50fbf735ed"}]},"branch":"refs/heads/master"},"e49dcb1995062e24d44a0691d6b8c0d8d1b7f64f":{"kind":"REWORK","_number":2,"created":"2017-11-10 03:39:53.000000000","uploader":{"_account_id":25571,"name":"Rajat Sharma","email":"rajat.sharma@india.nec.com","username":"rajat29"},"ref":"refs/changes/58/517558/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/58/517558/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/58/517558/2"}}},"commit":{"parents":[{"commit":"056e57deba44e6671110d8b5916fd588f0c12e64","subject":"Merge \"OSC: Remove unused files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/056e57deba44e6671110d8b5916fd588f0c12e64"}]}],"author":{"name":"rajat29","email":"rajat.sharma@nectechnologies.in","date":"2017-11-03 07:25:57.000000000","tz":330},"committer":{"name":"rajat29","email":"rajat.sharma@nectechnologies.in","date":"2017-11-10 03:39:49.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid usingg\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I4c51b6f2f2d48681530f7369dfd8cfc1126f9d76\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/e49dcb1995062e24d44a0691d6b8c0d8d1b7f64f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/e49dcb1995062e24d44a0691d6b8c0d8d1b7f64f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
