)]}'
{"id":"openstack%2Fpython-magnumclient~582955","triplet_id":"openstack%2Fpython-magnumclient~master~I595d243bc9f30d813af06aad46a9037afe383ab5","project":"openstack/python-magnumclient","branch":"master","topic":"story/1774643","hashtags":[],"change_id":"I595d243bc9f30d813af06aad46a9037afe383ab5","subject":"[k8s] Add embed certs to config","status":"MERGED","created":"2018-07-16 13:36:17.000000000","updated":"2018-08-09 08:21:28.000000000","submitted":"2018-08-09 08:21:28.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"582955-1533802888711-13fc9a10","meta_rev_id":"782ad0a10a5187b3f9900a1ff1c6969699236ca4","_number":582955,"virtual_id_number":582955,"owner":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"value":2,"date":"2018-08-09 08:21:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":2,"date":"2018-08-09 08:09:10.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":1,"date":"2018-08-09 08:09:10.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"value":0,"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},{"value":0,"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-18 10:10:12.000000000","updated_by":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"reviewer":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"state":"REVIEWER"},{"updated":"2018-07-27 19:59:09.000000000","updated_by":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"reviewer":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"state":"REVIEWER"},{"updated":"2018-07-27 21:40:59.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2018-07-30 16:02:40.000000000","updated_by":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"reviewer":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"state":"REVIEWER"},{"updated":"2018-08-09 08:09:10.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2018-08-09 08:21:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ae04a08c089e82073314be13cc52014f7dbd1607","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-16 13:36:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"120987e1e33e3a22618a326d6e065905f8556976","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 14:10:17.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/1/check/openstack-tox-pep8/85c5290/ : FAILURE in 4m 30s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/1/check/openstack-tox-py27/099594c/ : FAILURE in 6m 09s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/1/check/openstack-tox-py35/723c138/ : FAILURE in 6m 18s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/1/check/build-openstack-sphinx-docs/e5b60a6/html/ : SUCCESS in 6m 23s\n- openstack-tox-cover http://logs.openstack.org/55/582955/1/check/openstack-tox-cover/af8c134/ : FAILURE in 6m 34s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/1/check/openstack-tox-lower-constraints/a74edc4/ : FAILURE in 6m 33s","accounts_in_message":[],"_revision_number":1},{"id":"9639a28140fa8ac2706c59b115e2781db2fbf18a","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-17 09:58:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4268d3d88f871b634d828c53e192042e4c86714b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-17 11:13:13.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/2/check/openstack-tox-pep8/7caac71/ : SUCCESS in 6m 11s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/2/check/openstack-tox-py27/b6d9166/ : FAILURE in 6m 21s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/2/check/openstack-tox-py35/323dd36/ : FAILURE in 4m 58s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/2/check/build-openstack-sphinx-docs/bfd4892/html/ : SUCCESS in 7m 49s\n- openstack-tox-cover http://logs.openstack.org/55/582955/2/check/openstack-tox-cover/c0ea523/ : FAILURE in 7m 40s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/2/check/openstack-tox-lower-constraints/e8da4a6/ : FAILURE in 8m 11s","accounts_in_message":[],"_revision_number":2},{"id":"ed2c87c91817f171bcf273194c94446506ef1ee6","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-17 13:22:39.000000000","message":"Patch Set 2:\n\nyou need to update:\nhttps://github.com/openstack/python-magnumclient/blob/master/magnumclient/v1/clusters_shell.py\nhttps://github.com/openstack/python-magnumclient/blob/master/magnumclient/v1/bays_shell.py\n\nI\u0027ll check whether we can remove them","accounts_in_message":[],"_revision_number":2},{"id":"f361abfa08585937c6b9e8cefcde52df6ea5e88d","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-18 09:22:29.000000000","message":"Patch Set 2:\n\n\u003e you need to update:\n \u003e https://github.com/openstack/python-magnumclient/blob/master/magnumclient/v1/clusters_shell.py\n \u003e https://github.com/openstack/python-magnumclient/blob/master/magnumclient/v1/bays_shell.py\n \u003e \n \u003e I\u0027ll check whether we can remove them\n\nCan we keep updates on OSC only from now on? This would make sense?","accounts_in_message":[],"_revision_number":2},{"id":"bf6970a331c61badbd7934e6342310f7c2ff8ef9","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-18 09:37:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9f0f35d78573dd1ea93c759effd923b455a57c87","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-18 10:05:36.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/3/check/openstack-tox-pep8/829c488/ : FAILURE in 5m 26s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/3/check/openstack-tox-py27/af34f33/ : SUCCESS in 4m 47s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/3/check/openstack-tox-py35/bf9cdc9/ : SUCCESS in 5m 13s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/3/check/build-openstack-sphinx-docs/80067bb/html/ : SUCCESS in 9m 42s\n- openstack-tox-cover http://logs.openstack.org/55/582955/3/check/openstack-tox-cover/b3a3b9d/ : FAILURE in 5m 45s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/3/check/openstack-tox-lower-constraints/07ede32/ : SUCCESS in 6m 00s","accounts_in_message":[],"_revision_number":3},{"id":"f73a296ea6e309a4d02fcc3e0b03a658673e452c","author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"date":"2018-07-18 10:10:12.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nSome Nits. Thanks","accounts_in_message":[],"_revision_number":3},{"id":"69b009a4d8308f14eb7b3548ba3092e8ce4f8332","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-18 12:20:03.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"056c31e9e7d31e6fe48780b5d4a4a8e45b480ea4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-18 12:39:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/4/check/openstack-tox-pep8/fa38ac4/ : SUCCESS in 5m 31s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/4/check/openstack-tox-py27/c62bf5b/ : SUCCESS in 5m 58s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/4/check/openstack-tox-py35/cb058fe/ : SUCCESS in 5m 04s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/4/check/build-openstack-sphinx-docs/e8b1c85/html/ : SUCCESS in 5m 04s\n- openstack-tox-cover http://logs.openstack.org/55/582955/4/check/openstack-tox-cover/e64e839/ : FAILURE in 6m 13s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/4/check/openstack-tox-lower-constraints/e7cf681/ : SUCCESS in 6m 06s","accounts_in_message":[],"_revision_number":4},{"id":"2e0b7c8a80ff87734ba46532799be15f6c59ed75","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-18 21:58:41.000000000","message":"Patch Set 4: Code-Review-1\n\nkubernetes uses the terminology --embed-certs. I think --include_certs might be a little confusing since they always include certs anyways\n\nReference:\nhttps://github.com/kelseyhightower/kubernetes-the-hard-way/blob/master/docs/05-kubernetes-configuration-files.md","accounts_in_message":[],"_revision_number":4},{"id":"6239293dcd12c4bb3c1d206b207aa9fa6a92e6fa","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-18 21:59:02.000000000","message":"Patch Set 4:\n\notherwise awesome patch, looking forward to it being merged. \u003d]","accounts_in_message":[],"_revision_number":4},{"id":"f27a5041564b595bdc0733d6a52b2b5379a06812","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2018-07-18 22:27:35.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"31cb0e8f30a203bc79acc4c8847d6d811bfab73a","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2018-07-18 22:39:52.000000000","message":"Patch Set 4:\n\n(1 comment)\n\n\u003e kubernetes uses the terminology --embed-certs. I think\n \u003e --include_certs might be a little confusing since they always\n \u003e include certs anyways\n \u003e \n \u003e Reference:\n \u003e https://github.com/kelseyhightower/kubernetes-the-hard-way/blob/master/docs/05-kubernetes-configuration-files.md\n\n+1 on something more descriptive, since we are including the certs one way or another either way.","accounts_in_message":[],"_revision_number":4},{"id":"9336e8f08cb6b96288cc2a6fa320d646b0081f39","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-19 00:48:31.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"d7133c1823b9598594378970ed295911bd01536d","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-19 13:12:59.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"5cbbebd1ad000bab4abb5df03468643e57dfc794","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-19 15:57:43.000000000","message":"Patch Set 4:\n\n+1 yeah i hadnt noticed yet that they werent base64","accounts_in_message":[],"_revision_number":4},{"id":"25a9ed81f6eaa2304077fa051085adb2a6a94c3a","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-20 06:56:55.000000000","message":"Patch Set 4:\n\nTo summarize on the changes, you would prefer --embed-certs which will trigger the embedding of the certs in the config file, is this it? Default false as in kubernetes? And always writing the certificate files as before?\n\nThe flag i was adding was to manage the output of the certs in separate files, while always embedding them in the config. So an alternative would be to call the flag --output-certs, default to True to mimic the current behavior, and always embed?","accounts_in_message":[],"_revision_number":4},{"id":"46f95e1bf850503e21293ee8a5fc71451c2b0bbb","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-20 16:36:50.000000000","message":"Patch Set 4:\n\n\u003e To summarize on the changes, you would prefer --embed-certs which\n \u003e will trigger the embedding of the certs in the config file, is this\n \u003e it? \n\nTo hopefully be more clear, I think these are the situations in mind:\n\n1) if user does not use --embed-certs then automatically --output-certs (current behavior)\n2) if  user does not use --embed-certs and --output-certs specified (same result as above) (current behavior)\n3) if --embed-certs and not --output-certs, only provide embedded \n4) if --embed-certs and --output-certs requested then embed them and output files","accounts_in_message":[],"_revision_number":4},{"id":"bd56aa6934933943bd40013756cff59e2e7d37be","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-23 11:08:43.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"c46090850479dd6b14d880f4becd9d928027722d","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-23 11:15:03.000000000","message":"Patch Set 5:\n\n\u003e \u003e To summarize on the changes, you would prefer --embed-certs which\n \u003e \u003e will trigger the embedding of the certs in the config file, is\n \u003e this\n \u003e \u003e it?\n \u003e \n \u003e To hopefully be more clear, I think these are the situations in\n \u003e mind:\n \u003e \n \u003e 1) if user does not use --embed-certs then automatically\n \u003e --output-certs (current behavior)\n \u003e 2) if  user does not use --embed-certs and --output-certs specified\n \u003e (same result as above) (current behavior)\n \u003e 3) if --embed-certs and not --output-certs, only provide embedded\n \u003e 4) if --embed-certs and --output-certs requested then embed them\n \u003e and output files\n\nThis sounds good, but I chose a slightly different logic to simplify the default options. Let me know what you think.\n\nWhat we would like is for users to get (by default) embed certs without having to pass extra options, and no output certs to not pollute the local dirs. I pushed a change with options:\n\n--output-certs (boolean, store_true, default false)\n--no-embed-certs (boolean, store_true, default false)\n\nSo:\n* openstack coe cluster config \u003ccluster\u003e : gives embed, no output certs\n* openstack coe cluster config --output-certs \u003ccluster\u003e : same, but giving extra output files\n* openstack coe cluster config --no-embed-certs \u003ccluster\u003e : if for some reason users would want a config without embed certs\n\n\nThe only thing is to add in the release notes that the default behavior changes as by default there will be no output cert files. I think this is worth it though, the default is much better without the files.","accounts_in_message":[],"_revision_number":5},{"id":"5bd43715b7ea397a9acb10f87fc4f86fd8ef0656","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-23 11:25:00.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/5/check/openstack-tox-pep8/5d8e5b6/ : SUCCESS in 8m 19s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/5/check/openstack-tox-py27/da8508f/ : SUCCESS in 6m 08s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/5/check/openstack-tox-py35/044a686/ : SUCCESS in 6m 04s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/5/check/build-openstack-sphinx-docs/b061f70/html/ : SUCCESS in 5m 11s\n- openstack-tox-cover http://logs.openstack.org/55/582955/5/check/openstack-tox-cover/cf7b999/ : FAILURE in 5m 37s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/5/check/openstack-tox-lower-constraints/13d1455/ : SUCCESS in 5m 27s","accounts_in_message":[],"_revision_number":5},{"id":"54987fdb17b26674eb11f7e075eb1cd135b7c4cd","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-24 12:11:11.000000000","message":"Patch Set 5:\n\n\u003e \u003e \u003e To summarize on the changes, you would prefer --embed-certs\n \u003e which\n \u003e \u003e \u003e will trigger the embedding of the certs in the config file, is\n \u003e \u003e this\n \u003e \u003e \u003e it?\n \u003e \u003e\n \u003e \u003e To hopefully be more clear, I think these are the situations in\n \u003e \u003e mind:\n \u003e \u003e\n \u003e \u003e 1) if user does not use --embed-certs then automatically\n \u003e \u003e --output-certs (current behavior)\n \u003e \u003e 2) if  user does not use --embed-certs and --output-certs\n \u003e specified\n \u003e \u003e (same result as above) (current behavior)\n \u003e \u003e 3) if --embed-certs and not --output-certs, only provide embedded\n \u003e \u003e 4) if --embed-certs and --output-certs requested then embed them\n \u003e \u003e and output files\n \u003e \n \u003e This sounds good, but I chose a slightly different logic to\n \u003e simplify the default options. Let me know what you think.\n \u003e \n \u003e What we would like is for users to get (by default) embed certs\n \u003e without having to pass extra options, and no output certs to not\n \u003e pollute the local dirs. I pushed a change with options:\n \u003e \n \u003e --output-certs (boolean, store_true, default false)\n \u003e --no-embed-certs (boolean, store_true, default false)\n \u003e \n \u003e So:\n \u003e * openstack coe cluster config \u003ccluster\u003e : gives embed, no output\n \u003e certs\nlgtm\n\n \u003e * openstack coe cluster config --output-certs \u003ccluster\u003e : same, but\n \u003e giving extra output files\nlgtm\n \u003e * openstack coe cluster config --no-embed-certs \u003ccluster\u003e : if for\n \u003e some reason users would want a config without embed certs\nthe certs files are not referenced in kubeconfig and the certs files do not exist, is this expected?\nopenstack coe cluster config \u003ccluster\u003e --no-embed-certs --output-certs\nthe cert files are written but kubecofig looks like this:\napiVersion: v1\nclusters:\n- cluster:\n    server: https://172.24.4.8:6443\n  name: kube\ncontexts:\n- context:\n    cluster: kube\n    user: kube\n  name: kube\ncurrent-context: kube\nkind: Config\npreferences: {}\nusers:\n- name: kube\u0027\n\nWe need to have the admin user and the certs like this I think:\napiVersion: v1\nclusters:\n- cluster:\n    certificate-authority: /opt/stack/cluster/kube/ca.pem\n    server: https://172.24.4.8:6443\n  name: kube\ncontexts:\n- context:\n    cluster: kube\n    user: admin\n  name: default\ncurrent-context: default\nkind: Config\npreferences: {}\nusers:\n- name: admin\n  user:\n    client-certificate: /opt/stack/cluster/kube/cert.pem\n    client-key: /opt/stack/cluster/kube/key.pem\n\n\n\n \u003e \n \u003e \n \u003e The only thing is to add in the release notes that the default\n \u003e behavior changes as by default there will be no output cert files.\n \u003e I think this is worth it though, the default is much better without\n \u003e the files.\n\nIMO the first two options are enough.","accounts_in_message":[],"_revision_number":5},{"id":"3db8690e4da91b6fc71c6632a13c573e4959220c","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-24 12:14:55.000000000","message":"Patch Set 5:\n\n\u003e \u003e \u003e To summarize on the changes, you would prefer --embed-certs\n \u003e which\n \u003e \u003e \u003e will trigger the embedding of the certs in the config file, is\n \u003e \u003e this\n \u003e \u003e \u003e it?\n \u003e \u003e\n \u003e \u003e To hopefully be more clear, I think these are the situations in\n \u003e \u003e mind:\n \u003e \u003e\n \u003e \u003e 1) if user does not use --embed-certs then automatically\n \u003e \u003e --output-certs (current behavior)\n \u003e \u003e 2) if  user does not use --embed-certs and --output-certs\n \u003e specified\n \u003e \u003e (same result as above) (current behavior)\n \u003e \u003e 3) if --embed-certs and not --output-certs, only provide embedded\n \u003e \u003e 4) if --embed-certs and --output-certs requested then embed them\n \u003e \u003e and output files\n \u003e \n \u003e This sounds good, but I chose a slightly different logic to\n \u003e simplify the default options. Let me know what you think.\n \u003e \n \u003e What we would like is for users to get (by default) embed certs\n \u003e without having to pass extra options, and no output certs to not\n \u003e pollute the local dirs. I pushed a change with options:\n \u003e \n \u003e --output-certs (boolean, store_true, default false)\n \u003e --no-embed-certs (boolean, store_true, default false)\n \u003e \n \u003e So:\n \u003e * openstack coe cluster config \u003ccluster\u003e : gives embed, no output\n \u003e certs\n\nlgtm\n\n \u003e * openstack coe cluster config --output-certs \u003ccluster\u003e : same, but\n \u003e giving extra output files\n\nlgtm\n\n \u003e * openstack coe cluster config --no-embed-certs \u003ccluster\u003e : if for\n \u003e some reason users would want a config without embed certs\n \n\nthe certs files are not referenced in kubeconfig and the certs files do not exist, is this expected?\nopenstack coe cluster config \u003ccluster\u003e --no-embed-certs --output-certs\nthe cert files are written but kubecofig looks like this:\napiVersion: v1\nclusters:\n- cluster:\n    server: https://172.24.4.8:6443\n  name: kube\ncontexts:\n- context:\n    cluster: kube\n    user: kube\n  name: kube\ncurrent-context: kube\nkind: Config\npreferences: {}\nusers:\n- name: kube\u0027\n\nWe need to have the admin user and the certs like this I think:\napiVersion: v1\nclusters:\n- cluster:\n    certificate-authority: /opt/stack/cluster/kube/ca.pem\n    server: https://172.24.4.8:6443\n  name: kube\ncontexts:\n- context:\n    cluster: kube\n    user: admin\n  name: default\ncurrent-context: default\nkind: Config\npreferences: {}\nusers:\n- name: admin\n  user:\n    client-certificate: /opt/stack/cluster/kube/cert.pem\n    client-key: /opt/stack/cluster/kube/key.pem\n\n \u003e \n \u003e The only thing is to add in the release notes that the default\n \u003e behavior changes as by default there will be no output cert files.\n \u003e I think this is worth it though, the default is much better without\n \u003e the files.\n\n\n\nIMO the first two options are enough.","accounts_in_message":[],"_revision_number":5},{"id":"cafb236f2cf033c2f6bdcd04489216d9c08769be","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-24 19:21:24.000000000","message":"Patch Set 5:\n\nopenstack coe cluster config \u003ccluster\u003e : gives embed, no output certs\nopenstack coe cluster config --output-certs \u003ccluster\u003e : same, but giving extra output files\n\n+1 @Spyros agreed the first 2 options are enough. I\u0027m happy with with this approach for final solution.","accounts_in_message":[],"_revision_number":5},{"id":"dec74911730ca2cbb8cef8b31a6af5ee0be6035e","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-26 14:22:29.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"adb66cca3f15b6c0ce5dbc62cb6d037be4dd4b07","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-27 08:00:32.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"c79e5a37d17ea002515de47523c5e8ffb0dcce24","author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"date":"2018-07-27 08:12:09.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"e1074f15d6d70debf8cd77a139dccecb79d17e6e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-27 08:38:10.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/7/check/openstack-tox-pep8/7f9118f/ : SUCCESS in 5m 23s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/7/check/openstack-tox-py27/38a678e/ : SUCCESS in 4m 51s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/7/check/openstack-tox-py35/b7b6d9f/ : SUCCESS in 4m 45s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/7/check/build-openstack-sphinx-docs/0d862a6/html/ : SUCCESS in 5m 10s\n- openstack-tox-cover http://logs.openstack.org/55/582955/7/check/openstack-tox-cover/d0cd7c5/ : FAILURE in 5m 31s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/7/check/openstack-tox-lower-constraints/a371dd9/ : SUCCESS in 6m 30s","accounts_in_message":[],"_revision_number":7},{"id":"52620881830b183a80097e1cc5e5e811a7ddaa68","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-27 10:34:36.000000000","message":"Patch Set 7: Code-Review+2","accounts_in_message":[],"_revision_number":7},{"id":"bc0c7dedfddecc778f89b2b56348ac29cf33bf6b","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-27 16:59:56.000000000","message":"Patch Set 7: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":7},{"id":"8c4b34bc1ca2039a05015aa9573650a11dc6dc23","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2018-07-27 19:59:09.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)\n\nGiven we\u0027re changing the default behaviour of the config command, we should add a release notes for this.","accounts_in_message":[],"_revision_number":7},{"id":"15458a4fcb1e983ffa0f685fb48c73114d7784a3","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2018-07-27 21:40:59.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)\n\n\u003e (1 comment)\n \u003e \n \u003e Given we\u0027re changing the default behaviour of the config command,\n \u003e we should add a release notes for this.\n\nI agree - release notes would be good.","accounts_in_message":[],"_revision_number":7},{"id":"046ce7f8d6ea65a679163909adf0b30b0e4518b2","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-07-28 07:55:06.000000000","message":"Patch Set 7:\n\nrelease notes patch https://review.openstack.org/#/c/586470/","accounts_in_message":[],"_revision_number":7},{"id":"af86d13086ab1ec2b3b58d0ffabce4b5def4712f","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2018-07-29 23:30:49.000000000","message":"Patch Set 7:\n\nOh, I didn\u0027t realize we\u0027re using the Magnum server side release note for client side as well. But I think we still need to fix the commit message.","accounts_in_message":[],"_revision_number":7},{"id":"4625428d8e4003ab2f787e73a358067e5ec68e29","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-07-30 16:02:40.000000000","message":"Patch Set 7: Code-Review-1\n\nagree w/ @Erik","accounts_in_message":[],"_revision_number":7},{"id":"8fdbb2394bdcc388eb152beea76f538dacfe4485","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-08-08 07:56:21.000000000","message":"Patch Set 7: -Code-Review\n\nWe need to address the comments above.","accounts_in_message":[],"_revision_number":7},{"id":"416a5ab749015868ea02ca5c75feb13688e33575","author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"date":"2018-08-09 04:18:04.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"21b0c6d2f80d690a325ce8de66599e1d730ebb33","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-09 04:32:31.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/8/check/openstack-tox-pep8/6f3be7a/ : SUCCESS in 4m 32s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/8/check/openstack-tox-py27/1e5b6ae/ : SUCCESS in 4m 15s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/8/check/openstack-tox-py35/eb53ae0/ : SUCCESS in 4m 11s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/8/check/build-openstack-sphinx-docs/c10e280/html/ : SUCCESS in 4m 33s\n- openstack-tox-cover http://logs.openstack.org/55/582955/8/check/openstack-tox-cover/74ff7f5/ : FAILURE in 4m 38s (non-voting)\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/8/check/openstack-tox-lower-constraints/ae9029d/ : SUCCESS in 4m 20s","accounts_in_message":[],"_revision_number":8},{"id":"991655614f07843060f91f2c96b9b993f1c244f0","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2018-08-09 08:09:10.000000000","message":"Patch Set 8: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":8},{"id":"4212abcc6e14112f7bab486851a5ed67698da63c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-09 08:09:22.000000000","message":"Patch Set 8: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":8},{"id":"9e9f39608cd2a42dae77e9e1d112dcf8bc183e71","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-09 08:21:28.000000000","message":"Patch Set 8: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/55/582955/8/gate/openstack-tox-pep8/b055e66/ : SUCCESS in 5m 28s\n- openstack-tox-py27 http://logs.openstack.org/55/582955/8/gate/openstack-tox-py27/d256e65/ : SUCCESS in 5m 03s\n- openstack-tox-py35 http://logs.openstack.org/55/582955/8/gate/openstack-tox-py35/ad8fca8/ : SUCCESS in 4m 38s\n- build-openstack-sphinx-docs http://logs.openstack.org/55/582955/8/gate/build-openstack-sphinx-docs/0c963e2/html/ : SUCCESS in 4m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/582955/8/gate/openstack-tox-lower-constraints/0b227b1/ : SUCCESS in 6m 43s","accounts_in_message":[],"_revision_number":8},{"id":"696b3c3c1fcc5a90bab8f0d61e946067ac31d02c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-09 08:21:28.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"48b85899a03fb82d64db8a512ec7b834e82cfba6","revisions":{"05f0796df28fc525d9d1fd68207a1cd3dbb98743":{"kind":"REWORK","_number":1,"created":"2018-07-16 13:36:17.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/1"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"subject":"[k8s] Include cluster certificates in config","message":"[k8s] Include cluster certificates in config\n\nInclude the certificate, key and ca data directly in the cluster config\nfile, instead of linking to separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/05f0796df28fc525d9d1fd68207a1cd3dbb98743"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/05f0796df28fc525d9d1fd68207a1cd3dbb98743"}]},"branch":"refs/heads/master"},"f5393a213cdfcd4f43ce3cef50c91c11bd79ae5c":{"kind":"REWORK","_number":2,"created":"2018-07-17 09:58:02.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/2"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-17 09:57:53.000000000","tz":120},"subject":"[k8s] Include cluster certificates in config","message":"[k8s] Include cluster certificates in config\n\nInclude the certificate, key and ca data directly in the cluster config\nfile, instead of linking to separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f5393a213cdfcd4f43ce3cef50c91c11bd79ae5c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/f5393a213cdfcd4f43ce3cef50c91c11bd79ae5c"}]},"branch":"refs/heads/master"},"b02feb018b7110b5fc28dc09f3948b5abfd3731c":{"kind":"REWORK","_number":3,"created":"2018-07-18 09:37:27.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/3"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-18 09:37:13.000000000","tz":120},"subject":"[k8s] Include cluster certificates in config","message":"[k8s] Include cluster certificates in config\n\nInclude the certificate, key and ca data directly in the cluster config\nfile, instead of linking to separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b02feb018b7110b5fc28dc09f3948b5abfd3731c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b02feb018b7110b5fc28dc09f3948b5abfd3731c"}]},"branch":"refs/heads/master"},"cd78ba18863ecbd8f5fd38f27cf53ed504fc79fb":{"kind":"REWORK","_number":4,"created":"2018-07-18 12:20:03.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/4"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-18 12:19:52.000000000","tz":120},"subject":"[k8s] Include cluster certificates in config","message":"[k8s] Include cluster certificates in config\n\nInclude the certificate, key and ca data directly in the cluster config\nfile, instead of linking to separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/cd78ba18863ecbd8f5fd38f27cf53ed504fc79fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/cd78ba18863ecbd8f5fd38f27cf53ed504fc79fb"}]},"branch":"refs/heads/master"},"386702db482242d995e0c64f8e448ba95fe1441c":{"kind":"REWORK","_number":5,"created":"2018-07-23 11:08:43.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/5"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-23 09:33:34.000000000","tz":120},"subject":"[k8s] Add embed certs to config","message":"[k8s] Add embed certs to config\n\nAdd embed certs to kubernetes config file to clusted config, with option\n--no-embed-certs to disable if desired.\n\nAdd option --output-certs to cluster config enabling the output of the\ncertificates files (ca, key, cert). This is for compatibility with tools\nthat require the certificates in separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/386702db482242d995e0c64f8e448ba95fe1441c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/386702db482242d995e0c64f8e448ba95fe1441c"}]},"branch":"refs/heads/master"},"5e19d3bda1603e21e9de501086f4f53a0c307720":{"kind":"REWORK","_number":6,"created":"2018-07-27 08:00:32.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/6"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-27 08:00:23.000000000","tz":120},"subject":"[k8s] Add embed certs to config","message":"[k8s] Add embed certs to config\n\nAdd embed certs to kubernetes config file to clusted config, with option\n--no-embed-certs to disable if desired.\n\nAdd option --output-certs to cluster config enabling the output of the\ncertificates files (ca, key, cert). This is for compatibility with tools\nthat require the certificates in separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5e19d3bda1603e21e9de501086f4f53a0c307720"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5e19d3bda1603e21e9de501086f4f53a0c307720"}]},"branch":"refs/heads/master"},"31cde8d09a14ff92e94e6147a33e9ebab0890537":{"kind":"REWORK","_number":7,"created":"2018-07-27 08:12:09.000000000","uploader":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"ref":"refs/changes/55/582955/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/7"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-27 08:12:02.000000000","tz":120},"subject":"[k8s] Add embed certs to config","message":"[k8s] Add embed certs to config\n\nAdd embed certs to kubernetes config file to clusted config, with option\n--no-embed-certs to disable if desired.\n\nAdd option --output-certs to cluster config enabling the output of the\ncertificates files (ca, key, cert). This is for compatibility with tools\nthat require the certificates in separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/31cde8d09a14ff92e94e6147a33e9ebab0890537"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/31cde8d09a14ff92e94e6147a33e9ebab0890537"}]},"branch":"refs/heads/master"},"48b85899a03fb82d64db8a512ec7b834e82cfba6":{"kind":"REWORK","_number":8,"created":"2018-08-09 04:18:04.000000000","uploader":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"ref":"refs/changes/55/582955/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/55/582955/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/55/582955/8"}}},"commit":{"parents":[{"commit":"5c157edc88d9c05b359e65312afc29ce0acae27b","subject":"fix tox python3 overrides","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5c157edc88d9c05b359e65312afc29ce0acae27b"}]}],"author":{"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","date":"2018-07-16 13:24:21.000000000","tz":120},"committer":{"name":"Jim Bach","email":"jabach@blizzard.com","date":"2018-08-09 04:17:35.000000000","tz":-420},"subject":"[k8s] Add embed certs to config","message":"[k8s] Add embed certs to config\n\nAdd embed certs to kubernetes config file to cluster config\n\nAdd option --output-certs to cluster config enabling the output of the\ncertificates files (ca, key, cert). This is for compatibility with tools\nthat require the certificates in separate files.\n\nChange-Id: I595d243bc9f30d813af06aad46a9037afe383ab5\nStory: 1774643\nTask: 21668\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/48b85899a03fb82d64db8a512ec7b834e82cfba6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/48b85899a03fb82d64db8a512ec7b834e82cfba6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
