)]}'
{"magnumclient/osc/v1/cluster_templates.py":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"01f624a9d60f67474dad6a59aa4172547fcac2cc","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":229,"context_line":"            default\u003dFalse,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be hidden.\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027--visible\u0027,"},{"line_number":233,"context_line":"            dest\u003d\u0027hidden\u0027,"},{"line_number":234,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":235,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be visible.\u0027))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        return parser"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_ee007a38","line":235,"range":{"start_line":231,"start_character":0,"end_line":235,"end_character":72},"updated":"2019-02-19 00:41:32.000000000","message":"I am wondering why do we need this? I thought --hidden with default False is enough?","commit_id":"ab8392c44c368356f6230c7eddda4a9b0c3f496c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"79cd9802d60a03ba07a31d2b976bb04604eadae4","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":229,"context_line":"            default\u003dFalse,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be hidden.\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027--visible\u0027,"},{"line_number":233,"context_line":"            dest\u003d\u0027hidden\u0027,"},{"line_number":234,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":235,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be visible.\u0027))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        return parser"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_c6166df2","line":235,"range":{"start_line":231,"start_character":0,"end_line":235,"end_character":72},"in_reply_to":"5fc1f717_cbaa2d84","updated":"2019-03-09 19:12:07.000000000","message":"I can see Jake\u0027s concern here. This way looks clear but may confuse some user if they know how the API is designed. Can\u0027t we just use --hidden ?","commit_id":"ab8392c44c368356f6230c7eddda4a9b0c3f496c"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"4437382e1b11e94e59bc7037a0a5ccdb64eea41a","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":229,"context_line":"            default\u003dFalse,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be hidden.\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027--visible\u0027,"},{"line_number":233,"context_line":"            dest\u003d\u0027hidden\u0027,"},{"line_number":234,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":235,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be visible.\u0027))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        return parser"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_cbaa2d84","line":235,"range":{"start_line":231,"start_character":0,"end_line":235,"end_character":72},"in_reply_to":"9fdfeff1_305baff6","updated":"2019-03-08 10:50:56.000000000","message":"Correct me if I am wrong, but a CT will be either hidden or visible (2 states)? In this case, 1 boolean flag will be enough to represent the states (--hidden True or --hidden False)?","commit_id":"ab8392c44c368356f6230c7eddda4a9b0c3f496c"},{"author":{"_account_id":9995,"name":"Ricardo Rocha","email":"rocha.porto@gmail.com","username":"rocha"},"change_message_id":"945f1eef5c5f3780f7481148ff257c9aced6b358","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":229,"context_line":"            default\u003dFalse,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be hidden.\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027--visible\u0027,"},{"line_number":233,"context_line":"            dest\u003d\u0027hidden\u0027,"},{"line_number":234,"context_line":"            action\u003d\u0027store_false\u0027,"},{"line_number":235,"context_line":"            help\u003d_(\u0027Indicates the cluster template should be visible.\u0027))"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        return parser"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_305baff6","line":235,"range":{"start_line":231,"start_character":0,"end_line":235,"end_character":72},"in_reply_to":"9fdfeff1_ee007a38","updated":"2019-02-26 08:54:54.000000000","message":"I kept the same as in floating-ip-enabled/floating-ip-disabled. I don\u0027t think there\u0027s a way to pass a value here (as in --hidden False), these are just flags storing either true or false.","commit_id":"ab8392c44c368356f6230c7eddda4a9b0c3f496c"}]}