)]}'
{"id":"openstack%2Fpython-magnumclient~635151","triplet_id":"openstack%2Fpython-magnumclient~master~I4ae2049d8a2469d0a37077bdc722481e68d7cc49","project":"openstack/python-magnumclient","branch":"master","topic":"bug/1814890","hashtags":[],"change_id":"I4ae2049d8a2469d0a37077bdc722481e68d7cc49","subject":"Fix py37 compatibility","status":"MERGED","created":"2019-02-06 13:11:44.000000000","updated":"2019-02-11 19:59:16.000000000","submitted":"2019-02-11 19:59:16.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"635151-1549915156612-bf777d59","meta_rev_id":"d6ef6ab492b137a04ade0830e332557d2f26f51f","_number":635151,"virtual_id_number":635151,"owner":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"date":"2019-02-10 13:55:05.000000000","_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"value":2,"date":"2019-02-11 19:59:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":2,"date":"2019-02-10 18:52:50.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":2,"date":"2019-02-11 19:46:19.000000000","_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-02-11 18:08:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":1,"date":"2019-02-11 19:46:19.000000000","_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-02-10 18:52:50.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2019-02-11 18:08:58.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-02-11 19:46:19.000000000","updated_by":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"reviewer":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"state":"REVIEWER"},{"updated":"2019-02-11 19:59:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"26ad5cfd0c64105f5fc0894f1cd8b5bc474a1bb7","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2019-02-06 13:11:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a7ffe55259027e37a50ad2bb8538427e22da3a3","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2019-02-06 13:14:34.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ad171f90575fe334b8de030a98cd3302aae51252","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-06 13:57:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints http://logs.openstack.org/51/635151/1/check/openstack-tox-lower-constraints/fa4864f/ : FAILURE in 32m 16s\n- openstack-tox-pep8 http://logs.openstack.org/51/635151/1/check/openstack-tox-pep8/95c7aac/ : SUCCESS in 6m 02s\n- openstack-tox-py27 http://logs.openstack.org/51/635151/1/check/openstack-tox-py27/f8a883e/ : FAILURE in 40m 02s\n- openstack-tox-py35 http://logs.openstack.org/51/635151/1/check/openstack-tox-py35/05353b3/ : FAILURE in 19m 37s\n- openstack-tox-py36 http://logs.openstack.org/51/635151/1/check/openstack-tox-py36/9c354a8/ : FAILURE in 29m 19s\n- openstack-tox-docs http://logs.openstack.org/51/635151/1/check/openstack-tox-docs/9c07a36/html/ : SUCCESS in 5m 19s\n- openstack-tox-cover http://logs.openstack.org/51/635151/1/check/openstack-tox-cover/bb48da6/ : FAILURE in 23m 31s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"47fe9684693a13f7d8ff5454a193b723add39943","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2019-02-06 14:33:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a266035334d168d1f742071b41c55eb1fe64a4ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-06 14:48:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/51/635151/2/check/openstack-tox-lower-constraints/0f7ee32/ : SUCCESS in 5m 42s\n- openstack-tox-pep8 http://logs.openstack.org/51/635151/2/check/openstack-tox-pep8/17c514c/ : SUCCESS in 8m 05s\n- openstack-tox-py27 http://logs.openstack.org/51/635151/2/check/openstack-tox-py27/70997ea/ : SUCCESS in 6m 37s\n- openstack-tox-py35 http://logs.openstack.org/51/635151/2/check/openstack-tox-py35/3660434/ : SUCCESS in 5m 00s\n- openstack-tox-py36 http://logs.openstack.org/51/635151/2/check/openstack-tox-py36/1346bed/ : SUCCESS in 5m 16s\n- openstack-tox-docs http://logs.openstack.org/51/635151/2/check/openstack-tox-docs/da69cee/html/ : SUCCESS in 5m 15s\n- openstack-tox-cover http://logs.openstack.org/51/635151/2/check/openstack-tox-cover/11fd648/ : FAILURE in 5m 32s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"d32ebf899d22b03fa9a8f736e63cfedccc610855","author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"date":"2019-02-10 13:55:05.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"ba6f0ad078080f87baefc0cd5e32d43d6ffcd596","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-10 14:04:08.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/51/635151/2/check/openstack-tox-lower-constraints/ea22b84/ : SUCCESS in 4m 14s\n- openstack-tox-pep8 http://logs.openstack.org/51/635151/2/check/openstack-tox-pep8/275834a/ : SUCCESS in 3m 45s\n- openstack-tox-py27 http://logs.openstack.org/51/635151/2/check/openstack-tox-py27/ea921d2/ : SUCCESS in 6m 13s\n- openstack-tox-py35 http://logs.openstack.org/51/635151/2/check/openstack-tox-py35/6253b66/ : SUCCESS in 4m 58s\n- openstack-tox-py36 http://logs.openstack.org/51/635151/2/check/openstack-tox-py36/b995470/ : SUCCESS in 5m 05s\n- openstack-tox-docs http://logs.openstack.org/51/635151/2/check/openstack-tox-docs/71c48b0/html/ : SUCCESS in 4m 55s\n- openstack-tox-cover http://logs.openstack.org/51/635151/2/check/openstack-tox-cover/0013257/ : FAILURE in 5m 29s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"04077fe57502c900680105067ae2c849aad49ead","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2019-02-10 18:52:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"134ca56cdbc57cc8019c7502251ec65f87e80f18","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-02-11 18:08:58.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"99e0ed3e27702640d9c86531dc7e06531fb19199","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-02-11 19:46:19.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"bafabc9ced0cd58647cedf4d773a1b7ada53d5a1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-11 19:46:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"f08bf6b54411a357077699e8e6e83ec52a8296e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-11 19:59:16.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"1f3903b533ede4ce808ac809bb9278bd895e2e4c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-02-11 19:59:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/51/635151/2/gate/openstack-tox-lower-constraints/8a95b95/ : SUCCESS in 7m 49s\n- openstack-tox-pep8 http://logs.openstack.org/51/635151/2/gate/openstack-tox-pep8/1eaedee/ : SUCCESS in 4m 49s\n- openstack-tox-py27 http://logs.openstack.org/51/635151/2/gate/openstack-tox-py27/a66d7d1/ : SUCCESS in 5m 54s\n- openstack-tox-py35 http://logs.openstack.org/51/635151/2/gate/openstack-tox-py35/826f0f1/ : SUCCESS in 5m 28s\n- openstack-tox-py36 http://logs.openstack.org/51/635151/2/gate/openstack-tox-py36/b29605f/ : SUCCESS in 7m 24s\n- openstack-tox-docs http://logs.openstack.org/51/635151/2/gate/openstack-tox-docs/647d27e/html/ : SUCCESS in 5m 44s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5deb538930d98bf83e11bfb1dacb509982226540","revisions":{"20230972bc8543bdf51eeb55b3a17797f43192f3":{"kind":"REWORK","_number":1,"created":"2019-02-06 13:11:44.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/51/635151/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/51/635151/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/1"}}},"commit":{"parents":[{"commit":"b4120a1352c57c529e7a51737512a73acedec6a2","subject":"Use oslo_serialization instead of the json module directly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b4120a1352c57c529e7a51737512a73acedec6a2"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2019-02-06 13:11:07.000000000","tz":60},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2019-02-06 13:11:07.000000000","tz":60},"subject":"Fix py37 compatibility","message":"Fix py37 compatibility\n\nUnit tests are failing under python3.7.\nGenerators which explicitly raise StopIteration can generally be\nchanged to simply return instead. This will be compatible with\nall existing Python versions.\n\nPEP Documentation for this change:\nhttps://www.python.org/dev/peps/pep-0479/\n\nChange-Id: I4ae2049d8a2469d0a37077bdc722481e68d7cc49\nCloses-Bug: #1814890\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/20230972bc8543bdf51eeb55b3a17797f43192f3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/20230972bc8543bdf51eeb55b3a17797f43192f3"}]},"branch":"refs/heads/master"},"5deb538930d98bf83e11bfb1dacb509982226540":{"kind":"REWORK","_number":2,"created":"2019-02-06 14:33:47.000000000","uploader":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"ref":"refs/changes/51/635151/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/51/635151/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/51/635151/2"}}},"commit":{"parents":[{"commit":"b4120a1352c57c529e7a51737512a73acedec6a2","subject":"Use oslo_serialization instead of the json module directly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/b4120a1352c57c529e7a51737512a73acedec6a2"}]}],"author":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2019-02-06 13:11:07.000000000","tz":60},"committer":{"name":"Michal Arbet","email":"michal.arbet@ultimum.io","date":"2019-02-06 14:22:26.000000000","tz":60},"subject":"Fix py37 compatibility","message":"Fix py37 compatibility\n\nUnit tests are failing under python3.7.\nGenerators which explicitly raise StopIteration can generally be\nchanged to simply return instead. This will be compatible with\nall existing Python versions.\n\nPEP Documentation for this change:\nhttps://www.python.org/dev/peps/pep-0479/\n\nChange-Id: I4ae2049d8a2469d0a37077bdc722481e68d7cc49\nCloses-Bug: #1814890\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5deb538930d98bf83e11bfb1dacb509982226540"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5deb538930d98bf83e11bfb1dacb509982226540"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}