)]}'
{"magnumclient/osc/v1/clusters.py":[{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d0d59f3ab75c413e48738fd5dedf88cd9aa58f99","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                  \u0027use.\u0027))"},{"line_number":77,"context_line":"        parser.add_argument(\u0027--extra-labels\u0027,"},{"line_number":78,"context_line":"                            metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2\u003d\"VALUE2A,VALUE2B\"...\u003e\u0027,"},{"line_number":79,"context_line":"                            help\u003d_(\u0027additional driver specified labels in the \u0027"},{"line_number":80,"context_line":"                                   \u0027form of key\u003dvalue\u0027"},{"line_number":81,"context_line":"                                   \u0027pairs to associate with a cluster \u0027"},{"line_number":82,"context_line":"                                   \u0027template. May be used once.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_eca9787b","line":79,"range":{"start_line":79,"start_character":47,"end_line":79,"end_character":70},"updated":"2019-08-06 08:05:17.000000000","message":"This sounds wrong to me. The labels are meant for drivers indeed but I would\u0027t call them driver specific.\n\nAdditional labels in the form of key\u003dvalue pairs to append to the cluster template labels. If a label is set in the cluster template and it is passed wuth this argument too, the value of the extra-label will be used.","commit_id":"93643e7f8cb394b2fe17cbe816d12f5da9374270"},{"author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"change_message_id":"d82b400cdc01533b4b823ae6f42ef2f77c007011","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                  \u0027use.\u0027))"},{"line_number":77,"context_line":"        parser.add_argument(\u0027--extra-labels\u0027,"},{"line_number":78,"context_line":"                            metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2\u003d\"VALUE2A,VALUE2B\"...\u003e\u0027,"},{"line_number":79,"context_line":"                            help\u003d_(\u0027additional driver specified labels in the \u0027"},{"line_number":80,"context_line":"                                   \u0027form of key\u003dvalue\u0027"},{"line_number":81,"context_line":"                                   \u0027pairs to associate with a cluster \u0027"},{"line_number":82,"context_line":"                                   \u0027template. May be used once.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a4f4a188","line":79,"range":{"start_line":79,"start_character":47,"end_line":79,"end_character":70},"in_reply_to":"7faddb67_eca9787b","updated":"2019-08-10 00:29:33.000000000","message":"ill work on a better description here too, thanks for the feedback","commit_id":"93643e7f8cb394b2fe17cbe816d12f5da9374270"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"d0d59f3ab75c413e48738fd5dedf88cd9aa58f99","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                            help\u003d_(\u0027additional driver specified labels in the \u0027"},{"line_number":80,"context_line":"                                   \u0027form of key\u003dvalue\u0027"},{"line_number":81,"context_line":"                                   \u0027pairs to associate with a cluster \u0027"},{"line_number":82,"context_line":"                                   \u0027template. May be used once.\u0027))"},{"line_number":83,"context_line":"        parser.add_argument(\u0027--labels\u0027,"},{"line_number":84,"context_line":"                            metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2\u003dVALUE2;KEY3\u003dVALUE3...\u003e\u0027,"},{"line_number":85,"context_line":"                            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8c0fa4de","line":82,"range":{"start_line":82,"start_character":46,"end_line":82,"end_character":63},"updated":"2019-08-06 08:05:17.000000000","message":"Why this? For --labels it works fine when passed many times. It makes multiline commands cleaner.\n\nWe can just add  action\u003d\u0027append\u0027,","commit_id":"93643e7f8cb394b2fe17cbe816d12f5da9374270"},{"author":{"_account_id":28411,"name":"Jim Bach","email":"jabach@blizzard.com","username":"imdigitaljim"},"change_message_id":"d82b400cdc01533b4b823ae6f42ef2f77c007011","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                            help\u003d_(\u0027additional driver specified labels in the \u0027"},{"line_number":80,"context_line":"                                   \u0027form of key\u003dvalue\u0027"},{"line_number":81,"context_line":"                                   \u0027pairs to associate with a cluster \u0027"},{"line_number":82,"context_line":"                                   \u0027template. May be used once.\u0027))"},{"line_number":83,"context_line":"        parser.add_argument(\u0027--labels\u0027,"},{"line_number":84,"context_line":"                            metavar\u003d\u0027\u003cKEY1\u003dVALUE1,KEY2\u003dVALUE2;KEY3\u003dVALUE3...\u003e\u0027,"},{"line_number":85,"context_line":"                            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e402996f","line":82,"range":{"start_line":82,"start_character":46,"end_line":82,"end_character":63},"in_reply_to":"7faddb67_8c0fa4de","updated":"2019-08-10 00:29:33.000000000","message":"ah yeah this is outdated from what we were using. They just aggregate as well, ill update this soon","commit_id":"93643e7f8cb394b2fe17cbe816d12f5da9374270"}]}