)]}'
{"id":"openstack%2Fpython-magnumclient~673395","triplet_id":"openstack%2Fpython-magnumclient~master~Ia4f1ce4be215262fc89ceac30a2edb878ebd9937","project":"openstack/python-magnumclient","branch":"master","topic":"story/2006208-36027","hashtags":[],"change_id":"Ia4f1ce4be215262fc89ceac30a2edb878ebd9937","subject":"Support network, subnet and FIP when creating cluster","status":"MERGED","created":"2019-07-30 03:45:19.000000000","updated":"2019-08-01 18:43:33.000000000","submitted":"2019-08-01 18:43:33.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673395-1564685013651-3342d8ab","meta_rev_id":"65e67d4ec4d9579f9e556d6729f681fe610f7b2c","_number":673395,"virtual_id_number":673395,"owner":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":2,"date":"2019-08-01 18:43:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"all":[{"value":2,"date":"2019-08-01 09:39:58.000000000","_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":2,"date":"2019-08-01 18:29:59.000000000","_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":1,"date":"2019-08-01 18:29:59.000000000","_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-01 09:39:58.000000000","updated_by":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"reviewer":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"state":"REVIEWER"},{"updated":"2019-08-01 18:43:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dc8998d20f0360d884ec8f94e54b2a5ee9eb7f53","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-07-30 03:45:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87ad55fa70ea3c972d7039304b34de77d88aed57","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 03:57:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints http://logs.openstack.org/95/673395/1/check/openstack-tox-lower-constraints/6e9d827/ : SUCCESS in 3m 15s\n- openstack-tox-pep8 http://logs.openstack.org/95/673395/1/check/openstack-tox-pep8/52a5ec5/ : SUCCESS in 2m 40s\n- openstack-tox-py27 http://logs.openstack.org/95/673395/1/check/openstack-tox-py27/13a2e8d/ : SUCCESS in 3m 03s\n- openstack-tox-py36 http://logs.openstack.org/95/673395/1/check/openstack-tox-py36/dc3b66d/ : SUCCESS in 2m 52s\n- openstack-tox-py37 http://logs.openstack.org/95/673395/1/check/openstack-tox-py37/ee76c16/ : SUCCESS in 3m 19s\n- openstack-tox-docs http://logs.openstack.org/95/673395/1/check/openstack-tox-docs/5c39ee8/html/ : SUCCESS in 3m 10s\n- openstack-tox-cover http://logs.openstack.org/95/673395/1/check/openstack-tox-cover/8fd94f0/cover/ : SUCCESS in 3m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"96c7e50b284166ae07a01dd82b41361a912fb434","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-07-31 08:28:10.000000000","message":"Patch Set 1:\n\n@lingxian, that\u0027s a very interesting scenario. With external routing, I think cluster creation will be timeout because the instance can\u0027t connect to the internet.\n\nBut I agree we need a change at https://github.com/openstack/magnum/blob/master/magnum/drivers/heat/template_def.py#L517 to keep the behavior be consistent. I will fix it in next PS.","accounts_in_message":[],"_revision_number":1},{"id":"a39203d07199886c5d3311e98a601a5234fe0c0a","author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"date":"2019-08-01 09:39:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a4625da9130db56baa262fdfacc9a5996be7c0ab","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2019-08-01 18:29:59.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9bb6074531f5fa172a2aae9d8a18579cba02f2a3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 18:30:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5b6491a48513a39cfc8158351b1a625cf7963333","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 18:43:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"bd6332e6267ad64273ccd24f7e587d914924f62e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-01 18:43:33.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://logs.opendev.org/95/673395/1/gate/openstack-tox-lower-constraints/6089076/ : SUCCESS in 6m 04s\n- openstack-tox-pep8 https://logs.opendev.org/95/673395/1/gate/openstack-tox-pep8/99e80bf/ : SUCCESS in 3m 31s\n- openstack-tox-py27 https://logs.opendev.org/95/673395/1/gate/openstack-tox-py27/80a8deb/ : SUCCESS in 4m 54s\n- openstack-tox-py36 https://logs.opendev.org/95/673395/1/gate/openstack-tox-py36/dcb01fc/ : SUCCESS in 3m 27s\n- openstack-tox-py37 https://logs.opendev.org/95/673395/1/gate/openstack-tox-py37/e8a219b/ : SUCCESS in 4m 16s\n- openstack-tox-docs https://logs.opendev.org/95/673395/1/gate/openstack-tox-docs/f4c8a19/html/ : SUCCESS in 4m 54s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5ad8b7dcf7b8d6b8f78612219d5b8240ff55aded","revisions":{"5ad8b7dcf7b8d6b8f78612219d5b8240ff55aded":{"kind":"REWORK","_number":1,"created":"2019-07-30 03:45:19.000000000","uploader":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"ref":"refs/changes/95/673395/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/95/673395/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/95/673395/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/95/673395/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/95/673395/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/95/673395/1"}}},"commit":{"parents":[{"commit":"d29d5cdec47fc81792e9e94dec545e39646bd039","subject":"Merge \"Support upgrade API\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/d29d5cdec47fc81792e9e94dec545e39646bd039"}]}],"author":{"name":"Feilong Wang","email":"flwang@catalyst.net.nz","date":"2019-07-30 03:36:50.000000000","tz":720},"committer":{"name":"Feilong Wang","email":"flwang@catalyst.net.nz","date":"2019-07-30 03:44:53.000000000","tz":720},"subject":"Support network, subnet and FIP when creating cluster","message":"Support network, subnet and FIP when creating cluster\n\nChange-Id: Ia4f1ce4be215262fc89ceac30a2edb878ebd9937\nTask: 36027\nStory: 2006208\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5ad8b7dcf7b8d6b8f78612219d5b8240ff55aded"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/5ad8b7dcf7b8d6b8f78612219d5b8240ff55aded"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}