)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"481c4369d9c5a9843b5f43547c6307fa293e60bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"48efb859_4dafba05","updated":"2023-02-16 06:53:43.000000000","message":"Wait, this is going to break pre 1.24 versions, right?","commit_id":"de11f40d0c632ff839e5838ed650d1821c87d8a8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a332f710dfccef4052574ffb987a5c1a7e50de11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d0f9d80d_fd98d046","in_reply_to":"48efb859_4dafba05","updated":"2023-02-16 06:54:06.000000000","message":"Ah, not really, added in 1.11","commit_id":"de11f40d0c632ff839e5838ed650d1821c87d8a8"}],"magnumclient/common/utils.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b92a17b79466babad5affcf83df95fbc2ed8a103","unresolved":true,"context_lines":[{"line_number":238,"context_line":"                   \"  user:\\n\""},{"line_number":239,"context_line":"                   \"    exec:\\n\""},{"line_number":240,"context_line":"                   \"      command: /bin/bash\\n\""},{"line_number":241,"context_line":"                   \"      apiVersion: client.authentication.k8s.io/v1beta1\\n\""},{"line_number":242,"context_line":"                   \"      args:\\n\""},{"line_number":243,"context_line":"                   \"      - -c\\n\""},{"line_number":244,"context_line":"                   \"      - \u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2f41ce1b_a52be977","line":241,"updated":"2022-11-28 07:57:33.000000000","message":"How do we achieve backwards compatibility?","commit_id":"aee3c68a0823ddd3513dded4fbe2af44a8402753"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"4347827c5ae55ed65775c4ed7116fea76341e58c","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                   \"  user:\\n\""},{"line_number":239,"context_line":"                   \"    exec:\\n\""},{"line_number":240,"context_line":"                   \"      command: /bin/bash\\n\""},{"line_number":241,"context_line":"                   \"      apiVersion: client.authentication.k8s.io/v1beta1\\n\""},{"line_number":242,"context_line":"                   \"      args:\\n\""},{"line_number":243,"context_line":"                   \"      - -c\\n\""},{"line_number":244,"context_line":"                   \"      - \u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2512980c_c4b8c1bb","line":241,"in_reply_to":"033dbc42_fe5af252","updated":"2023-02-10 05:59:37.000000000","message":"Thanks for this. From testing, this works on fcos37 and k8s v1.24.\n\nI am hoping to get consensus on what is the supported version in the next meeting. Then we can make CI do that. It seems like FCOS37 and v1.24 is achievable.","commit_id":"aee3c68a0823ddd3513dded4fbe2af44a8402753"},{"author":{"_account_id":20498,"name":"Spyros Trigazis","email":"spyridon.trigazis@cern.ch","username":"strigazi"},"change_message_id":"ba44e25cc121c30cfd52b6f84b3d23e1f282397b","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                   \"  user:\\n\""},{"line_number":239,"context_line":"                   \"    exec:\\n\""},{"line_number":240,"context_line":"                   \"      command: /bin/bash\\n\""},{"line_number":241,"context_line":"                   \"      apiVersion: client.authentication.k8s.io/v1beta1\\n\""},{"line_number":242,"context_line":"                   \"      args:\\n\""},{"line_number":243,"context_line":"                   \"      - -c\\n\""},{"line_number":244,"context_line":"                   \"      - \u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"6af94de5_811d0b54","line":241,"in_reply_to":"2512980c_c4b8c1bb","updated":"2023-02-10 10:42:06.000000000","message":"with kubectl 1.26 i also needed to add:\n interactiveMode: IfAvailable\nat the \"command:\" level. Does it work without it?","commit_id":"aee3c68a0823ddd3513dded4fbe2af44a8402753"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"ab64d8b08c0a96f3840894b1219204fc62afe37e","unresolved":true,"context_lines":[{"line_number":238,"context_line":"                   \"  user:\\n\""},{"line_number":239,"context_line":"                   \"    exec:\\n\""},{"line_number":240,"context_line":"                   \"      command: /bin/bash\\n\""},{"line_number":241,"context_line":"                   \"      apiVersion: client.authentication.k8s.io/v1beta1\\n\""},{"line_number":242,"context_line":"                   \"      args:\\n\""},{"line_number":243,"context_line":"                   \"      - -c\\n\""},{"line_number":244,"context_line":"                   \"      - \u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3d5e2047_162f29de","line":241,"in_reply_to":"2f41ce1b_a52be977","updated":"2022-11-28 21:50:05.000000000","message":"This change means Kubernetes 1.10 and earlier won\u0027t work, as `v1beta1` was added in Kubernetes 1.11 which was released in June 2018.\n\nHow far back should we try and maintain compatibility?\n\nAccording to the PTG survey( https://etherpad.opendev.org/p/oct2022-ptg-magnum ), the main contributors are not using Kubernetes 1.10 or lower.\n\n(I\u0027m keen to see Magnum with better backwards compatibility for labels like Calico, which the manifests need to change (but then break older versions). I\u0027m not sure this is such a case, is it? How do we define how far back we should support?)","commit_id":"aee3c68a0823ddd3513dded4fbe2af44a8402753"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"496b4ea548283e4bf9e019f1b30b5cf4f3db38f2","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                   \"  user:\\n\""},{"line_number":239,"context_line":"                   \"    exec:\\n\""},{"line_number":240,"context_line":"                   \"      command: /bin/bash\\n\""},{"line_number":241,"context_line":"                   \"      apiVersion: client.authentication.k8s.io/v1beta1\\n\""},{"line_number":242,"context_line":"                   \"      args:\\n\""},{"line_number":243,"context_line":"                   \"      - -c\\n\""},{"line_number":244,"context_line":"                   \"      - \u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"033dbc42_fe5af252","line":241,"in_reply_to":"3d5e2047_162f29de","updated":"2022-11-29 07:08:36.000000000","message":"That\u0027s fine - but yes, we should have a process on defining what Kubernetes releases should be supported in Antelope (and have a CI on testing them).","commit_id":"aee3c68a0823ddd3513dded4fbe2af44a8402753"},{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"b530e283e6f6c798098c1039f7089505207c78e3","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                   \"  user:\\n\""},{"line_number":239,"context_line":"                   \"    exec:\\n\""},{"line_number":240,"context_line":"                   \"      command: /bin/bash\\n\""},{"line_number":241,"context_line":"                   \"      apiVersion: client.authentication.k8s.io/v1beta1\\n\""},{"line_number":242,"context_line":"                   \"      args:\\n\""},{"line_number":243,"context_line":"                   \"      - -c\\n\""},{"line_number":244,"context_line":"                   \"      - \u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"4a0c761d_c095a474","line":241,"in_reply_to":"6af94de5_811d0b54","updated":"2023-02-10 23:16:15.000000000","message":"were you using v1beta1 or v1? from [1]\n\n The user.exec.interactiveMode field is optional in client.authentication.k8s.io/v1beta1 and required in client.authentication.k8s.io/v1\n\nThe other thing is kubectl version skew is +1/-1. So we can make this work for API 1.24 first (so only support using kubectl 1.23-1.25), and have subsequent patches for kube api 1.25 and 1.26.\n\n[1] https://kubernetes.io/docs/reference/access-authn-authz/authentication/#input-and-output-formats","commit_id":"aee3c68a0823ddd3513dded4fbe2af44a8402753"}]}
