)]}'
{"magnumclient/common/httpclient.py":[{"author":{"_account_id":8064,"name":"Jake Yip","email":"jake.yip@ardc.edu.au","username":"jake"},"change_message_id":"3d38a540c69be8e068992ebc4e18c881028fe893","unresolved":true,"context_lines":[{"line_number":328,"context_line":"class SessionClient(adapter.LegacyJsonAdapter):"},{"line_number":329,"context_line":"    \"\"\"HTTP client based on Keystone client session.\"\"\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def __init__(self, user_agent\u003dNone, logger\u003dLOG,"},{"line_number":332,"context_line":"                 api_version\u003dNone, *args, **kwargs):"},{"line_number":333,"context_line":"        self.user_agent \u003d user_agent if user_agent else USER_AGENT"},{"line_number":334,"context_line":"        self.api_version \u003d api_version if api_version else DEFAULT_API_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c0ec133_0984b0a2","line":331,"range":{"start_line":331,"start_character":34,"end_line":331,"end_character":38},"updated":"2023-10-02 00:13:35.000000000","message":"is there a reason we need to change this? why can\u0027t we keep it and the subsequent line is\n\n`self.user_agent \u003d user_agent`\n\n?","commit_id":"dae4d336d6c8dee64e45c4db8ad9b5c49f13c58f"},{"author":{"_account_id":35271,"name":"Shuai Qian","display_name":"qian.shuai","email":"qs_cloudnative@163.com","username":"iauhsnaiq"},"change_message_id":"afc5d1f02c9818eb560831d92cba4404e4f7097e","unresolved":true,"context_lines":[{"line_number":328,"context_line":"class SessionClient(adapter.LegacyJsonAdapter):"},{"line_number":329,"context_line":"    \"\"\"HTTP client based on Keystone client session.\"\"\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def __init__(self, user_agent\u003dNone, logger\u003dLOG,"},{"line_number":332,"context_line":"                 api_version\u003dNone, *args, **kwargs):"},{"line_number":333,"context_line":"        self.user_agent \u003d user_agent if user_agent else USER_AGENT"},{"line_number":334,"context_line":"        self.api_version \u003d api_version if api_version else DEFAULT_API_VERSION"}],"source_content_type":"text/x-python","patch_set":1,"id":"558a3c23_663957d1","line":331,"range":{"start_line":331,"start_character":34,"end_line":331,"end_character":38},"in_reply_to":"5c0ec133_0984b0a2","updated":"2023-10-23 08:44:52.000000000","message":"I think the original subsequent \u0027self.user_agent\u003dUSER_AGENT\u0027 is wrong, which value is always the const global var USER_AGENT, then the param user_agent, whatever value you pass, is useless.","commit_id":"dae4d336d6c8dee64e45c4db8ad9b5c49f13c58f"}]}
