)]}'
{"id":"openstack%2Fpython-magnumclient~994514","triplet_id":"openstack%2Fpython-magnumclient~master~I264ceb1388352cf071c1dd3696713b1915f02e36","project":"openstack/python-magnumclient","branch":"master","hashtags":[],"change_id":"I264ceb1388352cf071c1dd3696713b1915f02e36","subject":"Remove backward-compatibility shims from Client and legacy shell","status":"NEW","created":"2026-06-23 18:04:26.000000000","updated":"2026-06-24 05:55:22.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":false,"meta_rev_id":"5072b490b5b8f3003869dfac593f7cb985ee4f87","_number":994514,"virtual_id_number":994514,"owner":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2026-06-24 05:55:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"reviewer_updates":[{"updated":"2026-06-24 05:55:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"52b79f59a0380172152084bd12f893ddbd15e72c","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2026-06-23 18:04:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"653d864dc1fbe2d30dea0bac1c357cc089c14764","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2026-06-24 05:37:16.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"5072b490b5b8f3003869dfac593f7cb985ee4f87","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-06-24 05:55:22.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/1e6a680275cf4e93b43ac6b4a61a340f\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1c56389521a84a7d9d055e6e122b8fc0 : SUCCESS in 3m 46s (non-voting)\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cb548bb1a0ae47378b1f8d537fe0415b : FAILURE in 3m 09s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/13ff7c6c05174fcb904fca1b2d217ced : SUCCESS in 2m 44s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/ebe079b983e0414daa3ecaac5d2e58b4 : SUCCESS in 2m 03s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/ae6629d5c39944fbb055e4a2351b6a0d : SUCCESS in 4m 46s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/75aaf9bb39994ee1b0a470182b4eb16a : SUCCESS in 3m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ed8c4b485a7446db8aeef0a275d65fd3 : SUCCESS in 2m 15s\n\nWarning:\n  Comments left for invalid file magnumclient/tests/v1/test_clusters_shell.py","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"88e049d5c008e7bb9bfa9cb6be3864ea09a600cc","revisions":{"cc84ea85c208596eb86d9e9450c63d9874d8bff4":{"kind":"REWORK","_number":1,"created":"2026-06-23 18:04:26.000000000","uploader":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"ref":"refs/changes/14/994514/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/14/994514/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/1"}}},"commit":{"parents":[{"commit":"56fdd5c7d97361ace2ae0a74a446df57152cc875","subject":"Remove legacy \u0027container\u0027 service type fallback","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/56fdd5c7d97361ace2ae0a74a446df57152cc875"}]}],"author":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2026-06-23 17:27:59.000000000","tz":120},"committer":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2026-06-23 17:27:59.000000000","tz":120},"subject":"Remove backward-compatibility shims from Client and legacy shell","message":"Remove backward-compatibility shims from Client and legacy shell\n\nDrop the api_key, input_auth_token, and endpoint_type constructor\nparameters from v1/client.py that were kept only for callers that\npre-dated the keystoneauth1 migration. Remove the corresponding hidden\nargparse arguments (--os-tenant-id/name, --service_type, --endpoint-type,\n--bypass-url, --magnum_api_version) and their fallback logic from\nshell.py.\n\nChange-Id: I264ceb1388352cf071c1dd3696713b1915f02e36\nSigned-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e\nAssisted-by: Claude code \u003cclaude-sonnet-4-6\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/cc84ea85c208596eb86d9e9450c63d9874d8bff4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/cc84ea85c208596eb86d9e9450c63d9874d8bff4"}]},"branch":"refs/heads/master"},"88e049d5c008e7bb9bfa9cb6be3864ea09a600cc":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2026-06-24 05:37:16.000000000","uploader":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"ref":"refs/changes/14/994514/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-magnumclient","ref":"refs/changes/14/994514/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-magnumclient refs/changes/14/994514/2"}}},"commit":{"parents":[{"commit":"9a3ab7133590e713a6811242aa6bc4457d9b2774","subject":"Remove legacy \u0027container\u0027 service type fallback","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/9a3ab7133590e713a6811242aa6bc4457d9b2774"}]}],"author":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2026-06-23 17:27:59.000000000","tz":120},"committer":{"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","date":"2026-06-24 05:37:16.000000000","tz":0},"subject":"Remove backward-compatibility shims from Client and legacy shell","message":"Remove backward-compatibility shims from Client and legacy shell\n\nDrop the api_key, input_auth_token, and endpoint_type constructor\nparameters from v1/client.py that were kept only for callers that\npre-dated the keystoneauth1 migration. Remove the corresponding hidden\nargparse arguments (--os-tenant-id/name, --service_type, --endpoint-type,\n--bypass-url, --magnum_api_version) and their fallback logic from\nshell.py.\n\nChange-Id: I264ceb1388352cf071c1dd3696713b1915f02e36\nSigned-off-by: Michal Nasiadka \u003cmnasiadka@gmail.com\u003e\nAssisted-by: Claude code \u003cclaude-sonnet-4-6\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/88e049d5c008e7bb9bfa9cb6be3864ea09a600cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-magnumclient/commit/88e049d5c008e7bb9bfa9cb6be3864ea09a600cc"}]},"branch":"refs/heads/master","description":"Rebase","conflicts":{"base":"56fdd5c7d97361ace2ae0a74a446df57152cc875","ours":"cc84ea85c208596eb86d9e9450c63d9874d8bff4","theirs":"9a3ab7133590e713a6811242aa6bc4457d9b2774","merge_strategy":"recursive","contains_conflicts":false}}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}