)]}'
{"manilaclient/tests/unit/v1/test_shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ea5075a0be770244e464450389835754fb48b5e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        cs.shares.create(\u0027cifs\u0027, 2)"},{"line_number":106,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def test_create_public_and_private_share(self):"},{"line_number":109,"context_line":"        body \u003d {"},{"line_number":110,"context_line":"            \u0027share\u0027: {"},{"line_number":111,"context_line":"                \u0027is_public\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_59204249","line":108,"updated":"2015-03-12 13:32:38.000000000","message":"It should be two separate tests:\n\n@ddt.data(True, False):\n\ndef test_create_share_with_public_attr_defined(self, public):\n\n    body \u003d dict(is_public\u003dpublic, share_type\u003dNone, ... )\n\n    cs.shares.create(\u0027nfs\u0027, 1, is_public\u003dpublic)\n\n    cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027, body)","commit_id":"26fa2ba3fe341e579c5166ecd80a2188846ca249"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"865b8557f0a45d3d8e9a99ce407797cfef51f9be","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def test_create_cifs_share(self):"},{"line_number":105,"context_line":"        cs.shares.create(\u0027cifs\u0027, 2)"},{"line_number":106,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027)"},{"line_number":107,"context_line":"    @ddt.data(True, False)"},{"line_number":108,"context_line":"    def test_create_share_with_public_attr_defined(self, is_public):"},{"line_number":109,"context_line":"        body \u003d {"},{"line_number":110,"context_line":"            \u0027share\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_c9929a4a","line":107,"updated":"2015-03-12 16:23:41.000000000","message":"New line is lost.","commit_id":"6c48fb391fb95d3026bc5301d5c1883cd53d9dc2"}],"manilaclient/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ea5075a0be770244e464450389835754fb48b5e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    return False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def str_to_boolean(value):"},{"line_number":45,"context_line":"    if value in [\u0027True\u0027, \u0027true\u0027, \u00271\u0027, True]:"},{"line_number":46,"context_line":"        return True"},{"line_number":47,"context_line":"    elif value in [\u0027False\u0027, \u0027false\u0027, \u00270\u0027, False]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b98bfe66","line":44,"updated":"2015-03-12 13:32:38.000000000","message":"Please, use oslo_utils.strutils.bool_from_string(...) instead.","commit_id":"26fa2ba3fe341e579c5166ecd80a2188846ca249"}],"manilaclient/v1/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3e83d1cf106efde1f114d57ba7737a037d110c3","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    dest\u003d\u0027is_public\u0027,"},{"line_number":381,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":382,"context_line":"    default\u003dFalse,"},{"line_number":383,"context_line":"    help\u003d\"Add public shares from all tenants to result.\")"},{"line_number":384,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":385,"context_line":"def do_create(cs, args):"},{"line_number":386,"context_line":"    \"\"\"Creates new NAS storage (NFS, CIFS or GlusterFS).\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ab7ca321","line":383,"updated":"2015-02-23 13:50:37.000000000","message":"This is incorrect information. Here you specify whether it is public or not.","commit_id":"28ddaac4b5e5326f0dbda8ed77f5044fa2288590"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3e83d1cf106efde1f114d57ba7737a037d110c3","unresolved":false,"context_lines":[{"line_number":893,"context_line":"    metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":894,"context_line":"    default\u003dNone,"},{"line_number":895,"context_line":"    type\u003dstr,"},{"line_number":896,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":897,"context_line":"    help\u003d\u0027Public share is visible for all tenants.\u0027)"},{"line_number":898,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":899,"context_line":"def do_update(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_cb21d7fd","line":896,"updated":"2015-02-23 13:50:37.000000000","message":"why lower cases are not allowed? 1? 0?","commit_id":"28ddaac4b5e5326f0dbda8ed77f5044fa2288590"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a3e83d1cf106efde1f114d57ba7737a037d110c3","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    if args.description is not None:"},{"line_number":906,"context_line":"        kwargs[\u0027display_description\u0027] \u003d args.description"},{"line_number":907,"context_line":"    if args.is_public is not None:"},{"line_number":908,"context_line":"        kwargs[\u0027is_public\u0027] \u003d ast.literal_eval(args.is_public)"},{"line_number":909,"context_line":"    if not kwargs:"},{"line_number":910,"context_line":"        msg \u003d \"Must supply name, description or is_public value.\""},{"line_number":911,"context_line":"        raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_6b0d4b90","line":908,"updated":"2015-02-23 13:50:37.000000000","message":"Why \"action\u003d\u0027store_true\u0027\" is not used here? better to avoid usage of ast if it possible.","commit_id":"28ddaac4b5e5326f0dbda8ed77f5044fa2288590"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1ea5075a0be770244e464450389835754fb48b5e","unresolved":false,"context_lines":[{"line_number":933,"context_line":"    if args.description is not None:"},{"line_number":934,"context_line":"        kwargs[\u0027display_description\u0027] \u003d args.description"},{"line_number":935,"context_line":"    if args.is_public is not None:"},{"line_number":936,"context_line":"        kwargs[\u0027is_public\u0027] \u003d utils.str_to_boolean(args.is_public)"},{"line_number":937,"context_line":"    if not kwargs:"},{"line_number":938,"context_line":"        msg \u003d \"Must supply name, description or is_public value.\""},{"line_number":939,"context_line":"        raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b9505ed5","line":936,"updated":"2015-03-12 13:32:38.000000000","message":"Please, use oslo_utils.strutils.bool_from_string(...) instead.","commit_id":"26fa2ba3fe341e579c5166ecd80a2188846ca249"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4b0459f55a068ede1ddb26fb7055b0bcdeb3793b","unresolved":false,"context_lines":[{"line_number":920,"context_line":"    metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":921,"context_line":"    default\u003dNone,"},{"line_number":922,"context_line":"    type\u003dstr,"},{"line_number":923,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027, \u0027true\u0027, \u0027false\u0027, \u00270\u0027, \u00271\u0027, \u0027yes\u0027, \u0027no\u0027, \u0027y\u0027,"},{"line_number":924,"context_line":"             \u0027n\u0027, \u0027t\u0027, \u0027f\u0027],"},{"line_number":925,"context_line":"    help\u003d\u0027Public share is visible for all tenants.\u0027)"},{"line_number":926,"context_line":"@cliutils.service_type(\u0027share\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_bc77629e","line":923,"updated":"2015-03-12 16:28:05.000000000","message":"Need to refer to vars from strutils\n\nhttps://github.com/openstack/oslo.utils/blob/6e0b8616/oslo_utils/strutils.py#L46\n\nand\n\nhttps://github.com/openstack/oslo.utils/blob/6e0b8616/oslo_utils/strutils.py#L47\n\nto avoid possible incompatibilities.","commit_id":"6c48fb391fb95d3026bc5301d5c1883cd53d9dc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a71c12f7c5bead50a72038946ad338aa0f23d121","unresolved":false,"context_lines":[{"line_number":407,"context_line":"    dest\u003d\u0027public\u0027,"},{"line_number":408,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":409,"context_line":"    default\u003dFalse,"},{"line_number":410,"context_line":"    help\u003d\"Level of visibility for share.\")"},{"line_number":411,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":412,"context_line":"def do_create(cs, args):"},{"line_number":413,"context_line":"    \"\"\"Creates a new share (NFS, CIFS, GlusterFS or HDFS).\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_32ae9230","line":410,"updated":"2015-03-17 11:04:22.000000000","message":"Defines whether other tenants are able to see it or not.","commit_id":"1bc1e17c19ac9187e81488ba5436440261bf4ffa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a71c12f7c5bead50a72038946ad338aa0f23d121","unresolved":false,"context_lines":[{"line_number":535,"context_line":"    help\u003d\u0027Name or ID of the NAS share.\u0027)"},{"line_number":536,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":537,"context_line":"def do_show(cs, args):"},{"line_number":538,"context_line":"    \"\"\"Show details about a NAS share.\"\"\""},{"line_number":539,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":540,"context_line":"    _print_share(cs, share)"},{"line_number":541,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_bddb3320","line":538,"updated":"2015-03-17 11:04:22.000000000","message":"This one should take list with public shares, so, any tenant will be able to get share by name.","commit_id":"1bc1e17c19ac9187e81488ba5436440261bf4ffa"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a71c12f7c5bead50a72038946ad338aa0f23d121","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    \u0027--is_public\u0027,  # alias"},{"line_number":920,"context_line":"    metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":921,"context_line":"    default\u003dNone,"},{"line_number":922,"context_line":"    type\u003dstr,"},{"line_number":923,"context_line":"    help\u003d\u0027Public share is visible for all tenants.\u0027)"},{"line_number":924,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":925,"context_line":"def do_update(cs, args):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_325cd24c","line":922,"updated":"2015-03-17 11:04:22.000000000","message":"Following is lost:\n\n\"\"\"\n\naction\u003d\"single_alias\" \n\n\"\"\"\n\nIt leads to improper handling of several aliases at once.","commit_id":"1bc1e17c19ac9187e81488ba5436440261bf4ffa"}]}