)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"9733ed517a4f47e092b781cfd76a1baeec33a556","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Implementation details and unit tests were mostly adapted"},{"line_number":16,"context_line":"from Cinder and Nova access extensions."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements bp private-share-types"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iaef80b85d413d7e7bb27ebd5cccae6bea30cb446"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_b72cd89a","line":18,"updated":"2015-03-12 18:27:54.000000000","message":"Broken link. Please use the correct BP name","commit_id":"d82bfc0eae9a1a406aa9d613839b5b24fa8b53d7"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"69ed3fe3a9ac2a2a4b0c4a3439a0a80dd57ec1fa","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Implementation details and unit tests were mostly adapted"},{"line_number":16,"context_line":"from Cinder and Nova access extensions."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements bp private-share-types"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iaef80b85d413d7e7bb27ebd5cccae6bea30cb446"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_8d796184","line":18,"in_reply_to":"9a80dd14_17d20400","updated":"2015-03-13 12:38:42.000000000","message":"Done","commit_id":"d82bfc0eae9a1a406aa9d613839b5b24fa8b53d7"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"ff2cc00f794d708b1f6589e6cc4225f86b05fb20","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Implementation details and unit tests were mostly adapted"},{"line_number":16,"context_line":"from Cinder and Nova access extensions."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements bp private-share-types"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iaef80b85d413d7e7bb27ebd5cccae6bea30cb446"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_17d20400","line":18,"in_reply_to":"9a80dd14_97835455","updated":"2015-03-12 18:39:08.000000000","message":"Oh! I missed that this was a client change. Yes, we can create a BP in the client launchpad or remove the BP from the commit message. BPs are optional for client features","commit_id":"d82bfc0eae9a1a406aa9d613839b5b24fa8b53d7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b7a75cbefeb5446e2738c5f6cd022430749f88e1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Implementation details and unit tests were mostly adapted"},{"line_number":16,"context_line":"from Cinder and Nova access extensions."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Implements bp private-share-types"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Iaef80b85d413d7e7bb27ebd5cccae6bea30cb446"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a80dd14_97835455","line":18,"in_reply_to":"9a80dd14_b72cd89a","updated":"2015-03-12 18:31:03.000000000","message":"Manilaclient does not have bp for private share types at all. \n\nManila\u0027s BP are considered as different project BP and can not be used here - in manilaclient.\n\nSo, this either should be removed or BP should be created first.","commit_id":"d82bfc0eae9a1a406aa9d613839b5b24fa8b53d7"}],"manilaclient/tests/unit/v1/test_type_access.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff7b4e596a6a0eec2181114adaf2622858b0e0ab","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TypeAccessTest(utils.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_list(self):"},{"line_number":29,"context_line":"        access \u003d cs.share_type_access.list(share_type\u003d\u00273\u0027)"},{"line_number":30,"context_line":"        cs.assert_called(\u0027GET\u0027, \u0027/types/3/os-share-type-access\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_92d65ef0","line":27,"updated":"2015-03-17 10:46:08.000000000","message":"Negative test with listing of projects for public share type?","commit_id":"2de0149098b60d26be66ceeecf2412c463e3e301"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"a3d509d6d66f159fd3dcb1d1a61b5acdf60cab49","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class TypeAccessTest(utils.TestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_list(self):"},{"line_number":29,"context_line":"        access \u003d cs.share_type_access.list(share_type\u003d\u00273\u0027)"},{"line_number":30,"context_line":"        cs.assert_called(\u0027GET\u0027, \u0027/types/3/os-share-type-access\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_f434d3fc","line":27,"in_reply_to":"9a80dd14_92d65ef0","updated":"2015-03-17 16:55:38.000000000","message":"Done","commit_id":"2de0149098b60d26be66ceeecf2412c463e3e301"}],"manilaclient/v1/share_type_access.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98fc01bd1c32fc27d08392a3b431b4c4b69bc036","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ShareTypeAccess(common_base.Resource):"},{"line_number":22,"context_line":"    def __repr__(self):"},{"line_number":23,"context_line":"        return \"\u003cShareTypeAccess: %s\u003e\" % self.project_id"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareTypeAccessManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_606741eb","line":23,"updated":"2015-02-27 19:47:20.000000000","message":"Why project_id and not just \"id\"?","commit_id":"7f3290319c82c4b80d9987a34e21344f7cbc6b37"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"eedbeb9d90568a658b5083a2ad290666e37915fe","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ShareTypeAccess(common_base.Resource):"},{"line_number":22,"context_line":"    def __repr__(self):"},{"line_number":23,"context_line":"        return \"\u003cShareTypeAccess: %s\u003e\" % self.project_id"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareTypeAccessManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_369d615a","line":23,"in_reply_to":"ba7be1f8_606741eb","updated":"2015-03-03 08:52:06.000000000","message":"Done","commit_id":"7f3290319c82c4b80d9987a34e21344f7cbc6b37"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e924420c1199400691df85bcb8ef819f1b2d5d50","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from manilaclient import base"},{"line_number":18,"context_line":"from manilaclient.openstack.common.apiclient import base as common_base"},{"line_number":19,"context_line":"from manilaclient import exceptions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ShareTypeAccess(common_base.Resource):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_433fa3b5","line":19,"updated":"2015-03-17 18:06:52.000000000","message":"It is not used and PEP will fail.","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"960050192997ca5956a604cd79ebe9cea157fbe7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from manilaclient import base"},{"line_number":18,"context_line":"from manilaclient.openstack.common.apiclient import base as common_base"},{"line_number":19,"context_line":"from manilaclient import exceptions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ShareTypeAccess(common_base.Resource):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_cec6e59b","line":19,"in_reply_to":"9a80dd14_433fa3b5","updated":"2015-03-19 18:36:56.000000000","message":"Done","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5ab4d9f1de02e30cff01b6dafaae832230493b5b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_dac83a24","line":1,"updated":"2015-03-20 14:17:37.000000000","message":"This should be updated.","commit_id":"13b0ce4c6e495ba2df545a349ee5d4d243d20e03"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a0136e41ae34d65fb46bff94bd7e66857aa7ed04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_3d9a3062","line":1,"in_reply_to":"9a80dd14_dac83a24","updated":"2015-03-20 14:23:42.000000000","message":"Not really, this file is copy-paste in bigger part..","commit_id":"13b0ce4c6e495ba2df545a349ee5d4d243d20e03"}],"manilaclient/v1/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98fc01bd1c32fc27d08392a3b431b4c4b69bc036","unresolved":false,"context_lines":[{"line_number":1646,"context_line":"    \u0027name\u0027,"},{"line_number":1647,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1648,"context_line":"    help\u003d\"Name of the new share type.\")"},{"line_number":1649,"context_line":"@cliutils.arg(\u0027--is-public\u0027,"},{"line_number":1650,"context_line":"              metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":1651,"context_line":"              help\u003d\"Make type accessible to the public (default true).\","},{"line_number":1652,"context_line":"              default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_7d08ca2d","line":1649,"updated":"2015-02-27 19:47:20.000000000","message":"Need add alias \"--is_public\" and action \"single_alias\".\n\nAlso, would be good to make same indent as existing \"name\" - from new line.\n\nSame for all other occurrences.","commit_id":"7f3290319c82c4b80d9987a34e21344f7cbc6b37"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"eedbeb9d90568a658b5083a2ad290666e37915fe","unresolved":false,"context_lines":[{"line_number":1646,"context_line":"    \u0027name\u0027,"},{"line_number":1647,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1648,"context_line":"    help\u003d\"Name of the new share type.\")"},{"line_number":1649,"context_line":"@cliutils.arg(\u0027--is-public\u0027,"},{"line_number":1650,"context_line":"              metavar\u003d\u0027\u003cis-public\u003e\u0027,"},{"line_number":1651,"context_line":"              help\u003d\"Make type accessible to the public (default true).\","},{"line_number":1652,"context_line":"              default\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_56cad54f","line":1649,"in_reply_to":"ba7be1f8_7d08ca2d","updated":"2015-03-03 08:52:06.000000000","message":"Done","commit_id":"7f3290319c82c4b80d9987a34e21344f7cbc6b37"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"98fc01bd1c32fc27d08392a3b431b4c4b69bc036","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"            stype.unset_keys(list(keypair))"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"@cliutils.arg(\u0027--share-type\u0027, metavar\u003d\u0027\u003cshare_type\u003e\u0027, required\u003dTrue,"},{"line_number":1702,"context_line":"              help\u003d\"Filter results by share type name or ID.\")"},{"line_number":1703,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":1704,"context_line":"def do_type_access_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_60258109","line":1701,"updated":"2015-02-27 19:47:20.000000000","message":"--share-type is required and always first, why do you need to make it named arg? Same for all other occurrences.\n\nCommon approach within manilaclient to make required args as positional.","commit_id":"7f3290319c82c4b80d9987a34e21344f7cbc6b37"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"eedbeb9d90568a658b5083a2ad290666e37915fe","unresolved":false,"context_lines":[{"line_number":1698,"context_line":"            stype.unset_keys(list(keypair))"},{"line_number":1699,"context_line":""},{"line_number":1700,"context_line":""},{"line_number":1701,"context_line":"@cliutils.arg(\u0027--share-type\u0027, metavar\u003d\u0027\u003cshare_type\u003e\u0027, required\u003dTrue,"},{"line_number":1702,"context_line":"              help\u003d\"Filter results by share type name or ID.\")"},{"line_number":1703,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":1704,"context_line":"def do_type_access_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_9677ed01","line":1701,"in_reply_to":"ba7be1f8_60258109","updated":"2015-03-03 08:52:06.000000000","message":"Done","commit_id":"7f3290319c82c4b80d9987a34e21344f7cbc6b37"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a2375cf026590b0e6b1a6b5b5a7c1e7459200f79","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"        default \u003d None"},{"line_number":1710,"context_line":""},{"line_number":1711,"context_line":"    if args.all:"},{"line_number":1712,"context_line":"        stypes \u003d cs.share_types.list(is_public\u003dFalse)"},{"line_number":1713,"context_line":"    else:"},{"line_number":1714,"context_line":"        stypes \u003d cs.share_types.list(is_public\u003dTrue)"},{"line_number":1715,"context_line":"    _print_share_type_list(stypes, default_share_type\u003ddefault)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_928979cc","line":1712,"updated":"2015-03-13 13:44:27.000000000","message":"This confuses me.  Why should an \u0027all\u0027 parameter affect whether this command lists public shares?","commit_id":"ce17d7445e937b86a50f5b4e87e237fe7bb27400"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"aeb7a4e4a19dedb01038c8b7e08ff4cb6ba129b2","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"        default \u003d None"},{"line_number":1710,"context_line":""},{"line_number":1711,"context_line":"    if args.all:"},{"line_number":1712,"context_line":"        stypes \u003d cs.share_types.list(is_public\u003dFalse)"},{"line_number":1713,"context_line":"    else:"},{"line_number":1714,"context_line":"        stypes \u003d cs.share_types.list(is_public\u003dTrue)"},{"line_number":1715,"context_line":"    _print_share_type_list(stypes, default_share_type\u003ddefault)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_edf55451","line":1712,"in_reply_to":"9a80dd14_928979cc","updated":"2015-03-14 16:02:24.000000000","message":"I have renamed `is_public` -\u003e \u0027show_all\u0027 and now it should look clearer.\n\nBy default  cs.share_types.list() shows all share_types and it\u0027s required to solve the problem described by Valeriy earlier in the main thread of this review.","commit_id":"ce17d7445e937b86a50f5b4e87e237fe7bb27400"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff7b4e596a6a0eec2181114adaf2622858b0e0ab","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"    \"\"\"Print access information about the given share type.\"\"\""},{"line_number":1813,"context_line":"    share_type \u003d _find_share_type(cs, args.share_type)"},{"line_number":1814,"context_line":"    if share_type.is_public:"},{"line_number":1815,"context_line":"        raise exceptions.CommandError(\"Failed to get access list \""},{"line_number":1816,"context_line":"                                      \"for public share type.\")"},{"line_number":1817,"context_line":"    access_list \u003d cs.share_type_access.list(share_type)"},{"line_number":1818,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_7201eaae","line":1815,"updated":"2015-03-17 10:46:08.000000000","message":"\"Failed to get access list for public share type.\" is not correct statement. It is restricted, not failed.","commit_id":"2de0149098b60d26be66ceeecf2412c463e3e301"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"a3d509d6d66f159fd3dcb1d1a61b5acdf60cab49","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"    \"\"\"Print access information about the given share type.\"\"\""},{"line_number":1813,"context_line":"    share_type \u003d _find_share_type(cs, args.share_type)"},{"line_number":1814,"context_line":"    if share_type.is_public:"},{"line_number":1815,"context_line":"        raise exceptions.CommandError(\"Failed to get access list \""},{"line_number":1816,"context_line":"                                      \"for public share type.\")"},{"line_number":1817,"context_line":"    access_list \u003d cs.share_type_access.list(share_type)"},{"line_number":1818,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_d44b4f5d","line":1815,"in_reply_to":"9a80dd14_7201eaae","updated":"2015-03-17 16:55:38.000000000","message":"Done","commit_id":"2de0149098b60d26be66ceeecf2412c463e3e301"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff7b4e596a6a0eec2181114adaf2622858b0e0ab","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"                                      \"for public share type.\")"},{"line_number":1817,"context_line":"    access_list \u003d cs.share_type_access.list(share_type)"},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    columns \u003d [\u0027Share_type_ID\u0027, \u0027Project_ID\u0027]"},{"line_number":1820,"context_line":"    cliutils.print_list(access_list, columns)"},{"line_number":1821,"context_line":""},{"line_number":1822,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_929ade6c","line":1819,"updated":"2015-03-17 10:46:08.000000000","message":"Would be really useful to display name of share type too.","commit_id":"2de0149098b60d26be66ceeecf2412c463e3e301"},{"author":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"change_message_id":"a3d509d6d66f159fd3dcb1d1a61b5acdf60cab49","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"                                      \"for public share type.\")"},{"line_number":1817,"context_line":"    access_list \u003d cs.share_type_access.list(share_type)"},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    columns \u003d [\u0027Share_type_ID\u0027, \u0027Project_ID\u0027]"},{"line_number":1820,"context_line":"    cliutils.print_list(access_list, columns)"},{"line_number":1821,"context_line":""},{"line_number":1822,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_c11b93c8","line":1819,"in_reply_to":"9a80dd14_929ade6c","updated":"2015-03-17 16:55:38.000000000","message":"I don\u0027t think so because a user in most cases provides share_type name as the argument to this command, so it will be redundant:\n\n$ manila type-access-list private\n+--------------------------------------+----------------------------------+\n| Share_type_ID                        | Project_ID                       |\n+--------------------------------------+----------------------------------+\n| 9ba79f5f-154f-4f01-be89-c4c9f336a94c | e8ba2cd8f398423e89aeee714f524017 |\n+--------------------------------------+----------------------------------+\n\nFurthermore, I think that Share_type_ID column is also redundant for the shell command. So I will remove this column.","commit_id":"2de0149098b60d26be66ceeecf2412c463e3e301"},{"author":{"_account_id":9186,"name":"Bob Callaway","email":"bcallawa@redhat.com","username":"rcallawa"},"change_message_id":"d836b878e8b27549554c362c05e2c4b3d8224328","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"        \u0027required_extra_specs\u0027: _print_type_required_extra_specs"},{"line_number":1677,"context_line":"    }"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"    fields \u003d [\u0027ID\u0027, \u0027Name\u0027, \u0027is_default\u0027, \u0027is_public\u0027, \u0027required_extra_specs\u0027]"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"    cliutils.print_list(stypes, fields, formatters)"},{"line_number":1682,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_d4308109","line":1679,"updated":"2015-03-18 13:47:22.000000000","message":"Instead of printing a boolean \"true\" or \"false\" in the column, I\u0027d rather see the column named \"Visibility\" and the values printed \"public\" or \"private\". This is more usable and would translate more cleanly to other languages.","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"960050192997ca5956a604cd79ebe9cea157fbe7","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"        \u0027required_extra_specs\u0027: _print_type_required_extra_specs"},{"line_number":1677,"context_line":"    }"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"    fields \u003d [\u0027ID\u0027, \u0027Name\u0027, \u0027is_default\u0027, \u0027is_public\u0027, \u0027required_extra_specs\u0027]"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"    cliutils.print_list(stypes, fields, formatters)"},{"line_number":1682,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_8831450d","line":1679,"in_reply_to":"9a80dd14_d4308109","updated":"2015-03-19 18:36:56.000000000","message":"Done","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"693a0db6bd309756dfb27ea960681514d3853f07","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"    except exceptions.NotFound:"},{"line_number":1709,"context_line":"        default \u003d None"},{"line_number":1710,"context_line":""},{"line_number":1711,"context_line":"    if args.all:"},{"line_number":1712,"context_line":"        stypes \u003d cs.share_types.list(show_all\u003dTrue)"},{"line_number":1713,"context_line":"    else:"},{"line_number":1714,"context_line":"        stypes \u003d cs.share_types.list(show_all\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_0aa92424","line":1711,"updated":"2015-03-18 07:24:46.000000000","message":"What about just ```stypes \u003d cs.share_types.list(show_all\u003dargs.all) ``` ?","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"444fca8d27e79c98103322d977737d521c9009d2","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"    except exceptions.NotFound:"},{"line_number":1709,"context_line":"        default \u003d None"},{"line_number":1710,"context_line":""},{"line_number":1711,"context_line":"    if args.all:"},{"line_number":1712,"context_line":"        stypes \u003d cs.share_types.list(show_all\u003dTrue)"},{"line_number":1713,"context_line":"    else:"},{"line_number":1714,"context_line":"        stypes \u003d cs.share_types.list(show_all\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_a51afe15","line":1711,"in_reply_to":"9a80dd14_0aa92424","updated":"2015-03-18 13:01:18.000000000","message":"+1","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"960050192997ca5956a604cd79ebe9cea157fbe7","unresolved":false,"context_lines":[{"line_number":1708,"context_line":"    except exceptions.NotFound:"},{"line_number":1709,"context_line":"        default \u003d None"},{"line_number":1710,"context_line":""},{"line_number":1711,"context_line":"    if args.all:"},{"line_number":1712,"context_line":"        stypes \u003d cs.share_types.list(show_all\u003dTrue)"},{"line_number":1713,"context_line":"    else:"},{"line_number":1714,"context_line":"        stypes \u003d cs.share_types.list(show_all\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_4be3c733","line":1711,"in_reply_to":"9a80dd14_a51afe15","updated":"2015-03-19 18:36:56.000000000","message":"Done","commit_id":"c6e6db0b0ac62cc4addc3b6ae067bdca75f9ba58"}]}