)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bc2c6208ec8ce33456952142a5421dd078204f60","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add base client methods for share type extra specs operations and use them in"},{"line_number":10,"context_line":"rw functional tests."},{"line_number":11,"context_line":"This commit covers case of handling share type extra specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements bp rw-functional-tests"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1aca2d91_bc08e529","line":11,"updated":"2015-05-06 03:55:46.000000000","message":"the above line can be deleted","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"66d246467b8e6a1f487eeb8533730c63c90fa256","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add base client methods for share type extra specs operations and use them in"},{"line_number":10,"context_line":"rw functional tests."},{"line_number":11,"context_line":"This commit covers case of handling share type extra specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially implements bp rw-functional-tests"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1aca2d91_7afc7b3e","line":11,"in_reply_to":"1aca2d91_bc08e529","updated":"2015-05-06 13:16:53.000000000","message":"Done","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7a38d6a48308a6d793b8574152b5d2b3cd593526","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        \"\"\"Set key-value pair for share type.\"\"\""},{"line_number":180,"context_line":"        if not (isinstance(extra_specs, dict) and extra_specs):"},{"line_number":181,"context_line":"            raise exceptions.InvalidData("},{"line_number":182,"context_line":"                message\u003d\u0027Provided invalid exta specs - %s\u0027 % extra_specs)"},{"line_number":183,"context_line":"        cmd \u003d \u0027type-key %s set \u0027 % share_type_name_or_id"},{"line_number":184,"context_line":"        for key, value in extra_specs.items():"},{"line_number":185,"context_line":"            cmd +\u003d \u0027%(key)s\u003d%(value)s \u0027 % {\u0027key\u0027: key, \u0027value\u0027: value}"}],"source_content_type":"text/x-python","patch_set":11,"id":"3acd31a7_b577c8d3","line":182,"updated":"2015-04-29 22:49:30.000000000","message":"s/exta/extra/","commit_id":"43adfc3391765d36597bac69c282b199f6e41aea"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"7a38d6a48308a6d793b8574152b5d2b3cd593526","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \"\"\"Unset key-value pair for share type.\"\"\""},{"line_number":191,"context_line":"        if not (isinstance(extra_specs_keys, list) and extra_specs_keys):"},{"line_number":192,"context_line":"            raise exceptions.InvalidData("},{"line_number":193,"context_line":"                message\u003d\u0027Provided invalid exta specs - %s\u0027 % extra_specs_keys)"},{"line_number":194,"context_line":"        cmd \u003d \u0027type-key %s unset \u0027 % share_type_name_or_id"},{"line_number":195,"context_line":"        for key in extra_specs_keys:"},{"line_number":196,"context_line":"            cmd +\u003d \u0027%s \u0027 % key"}],"source_content_type":"text/x-python","patch_set":11,"id":"3acd31a7_00207c9a","line":193,"updated":"2015-04-29 22:49:30.000000000","message":"s/exta/extra/","commit_id":"43adfc3391765d36597bac69c282b199f6e41aea"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bc2c6208ec8ce33456952142a5421dd078204f60","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        return self.manila(cmd)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def list_all_share_type_extra_specs(self):"},{"line_number":200,"context_line":"        \"\"\"List extra specs for all share types by its Name or ID.\"\"\""},{"line_number":201,"context_line":"        extra_specs_raw \u003d self.manila(\u0027extra-specs-list\u0027)"},{"line_number":202,"context_line":"        extra_specs \u003d utils.listing(extra_specs_raw)"},{"line_number":203,"context_line":"        return extra_specs"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_fc03fd74","line":200,"updated":"2015-05-06 03:55:46.000000000","message":"not \u0027by its Name or ID.\u0027","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6699fa7d24adc5be0c7bb9ea60a0bce94b2fa856","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        return self.manila(cmd)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def list_all_share_type_extra_specs(self):"},{"line_number":200,"context_line":"        \"\"\"List extra specs for all share types by its Name or ID.\"\"\""},{"line_number":201,"context_line":"        extra_specs_raw \u003d self.manila(\u0027extra-specs-list\u0027)"},{"line_number":202,"context_line":"        extra_specs \u003d utils.listing(extra_specs_raw)"},{"line_number":203,"context_line":"        return extra_specs"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_9fc18983","line":200,"in_reply_to":"1aca2d91_fc03fd74","updated":"2015-05-06 13:15:56.000000000","message":"Done","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"}],"manilaclient/tests/functional/test_share_types.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bc2c6208ec8ce33456952142a5421dd078204f60","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.admin_client.set_share_type_extra_specs("},{"line_number":172,"context_line":"            private_st[\u0027ID\u0027], private_st_extra_specs)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # View extra specs"},{"line_number":175,"context_line":"        extra_specs \u003d self.admin_client.list_share_type_extra_specs("},{"line_number":176,"context_line":"            public_st[\u0027ID\u0027])"},{"line_number":177,"context_line":"        for k, v in public_st_extra_specs.items():"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_fced3d8f","line":174,"updated":"2015-05-06 03:55:46.000000000","message":"s/View/List/ would look better to me.","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6699fa7d24adc5be0c7bb9ea60a0bce94b2fa856","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.admin_client.set_share_type_extra_specs("},{"line_number":172,"context_line":"            private_st[\u0027ID\u0027], private_st_extra_specs)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # View extra specs"},{"line_number":175,"context_line":"        extra_specs \u003d self.admin_client.list_share_type_extra_specs("},{"line_number":176,"context_line":"            public_st[\u0027ID\u0027])"},{"line_number":177,"context_line":"        for k, v in public_st_extra_specs.items():"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_3f3715b2","line":174,"in_reply_to":"1aca2d91_fced3d8f","updated":"2015-05-06 13:15:56.000000000","message":"Done","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"bc2c6208ec8ce33456952142a5421dd078204f60","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        extra_specs \u003d self.admin_client.list_share_type_extra_specs("},{"line_number":191,"context_line":"            public_st[\u0027ID\u0027])"},{"line_number":192,"context_line":"        for k, v in public_st_extra_specs.items():"},{"line_number":193,"context_line":"            self.assertIn(\u0027%s : %s\u0027 % (k, v), extra_specs)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        extra_specs \u003d self.admin_client.list_share_type_extra_specs("},{"line_number":196,"context_line":"            private_st[\u0027ID\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_fcc65d15","line":193,"updated":"2015-05-06 03:55:46.000000000","message":"Why are you testing public again?  If you want to verify that it didn\u0027t change then probably just compare it to the previous results, but this looks like a copy/paste error to me.","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6699fa7d24adc5be0c7bb9ea60a0bce94b2fa856","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        extra_specs \u003d self.admin_client.list_share_type_extra_specs("},{"line_number":191,"context_line":"            public_st[\u0027ID\u0027])"},{"line_number":192,"context_line":"        for k, v in public_st_extra_specs.items():"},{"line_number":193,"context_line":"            self.assertIn(\u0027%s : %s\u0027 % (k, v), extra_specs)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        extra_specs \u003d self.admin_client.list_share_type_extra_specs("},{"line_number":196,"context_line":"            private_st[\u0027ID\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"1aca2d91_1ae227d6","line":193,"in_reply_to":"1aca2d91_fcc65d15","updated":"2015-05-06 13:15:56.000000000","message":"Done","commit_id":"eabe183b9e78a6ee6b88177ae384f8db0f9358a1"}]}