)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for access rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add read-only tests for access reule listing and read-write test"},{"line_number":10,"context_line":"for creation and deletion of access rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add functions \u0027get_access\u0027 and \u0027wait_for_access_status\u0027 to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_f69d335a","line":9,"updated":"2015-06-05 12:08:43.000000000","message":"s/reule/rule/","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add read-only tests for access reule listing and read-write test"},{"line_number":10,"context_line":"for creation and deletion of access rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add functions \u0027get_access\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add new exception AccessBuildErrorException to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_36bbcbc6","line":12,"updated":"2015-06-05 12:08:43.000000000","message":"Why method with listing of rules was not added? Is it planned?","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"49eba74a7c75069dc263822b8cd058dcd39658c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add read-only tests for access reule listing and read-write test"},{"line_number":10,"context_line":"for creation and deletion of access rule."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add functions \u0027get_access\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add new exception AccessBuildErrorException to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_d2bd6ad8","line":12,"in_reply_to":"3afb71cf_36bbcbc6","updated":"2015-06-08 10:53:41.000000000","message":"Done","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Add functions \u0027get_access\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add new exception AccessBuildErrorException to"},{"line_number":16,"context_line":"manilaclient/tests/functional/exceptions.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id1a5698a124bad8d68e093faa32b1ad5cccd67c7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_56dd2713","line":15,"updated":"2015-06-05 12:08:43.000000000","message":"No need to declare such things, that is easy to see by code.","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"49eba74a7c75069dc263822b8cd058dcd39658c6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Add functions \u0027get_access\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Add new exception AccessBuildErrorException to"},{"line_number":16,"context_line":"manilaclient/tests/functional/exceptions.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id1a5698a124bad8d68e093faa32b1ad5cccd67c7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_b2b42ef2","line":15,"in_reply_to":"3afb71cf_56dd2713","updated":"2015-06-08 10:53:41.000000000","message":"Done","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"33e6f8a8663338fbc37919fc09558730b196af36","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add read-write tests for access_rule."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add functions \u0027get_access\u0027, \u0027list_access\u0027 , \u0027access_allow\u0027,"},{"line_number":12,"context_line":"\u0027access_deny\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba3cc151_2abee0d4","line":11,"updated":"2015-07-04 07:54:40.000000000","message":"Remove the space before the comma.","commit_id":"4bdb59c881ce29426f1dfa964a269c0c63890393"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"33e6f8a8663338fbc37919fc09558730b196af36","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add read-write tests for access_rule."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add functions \u0027get_access\u0027, \u0027list_access\u0027 , \u0027access_allow\u0027,"},{"line_number":12,"context_line":"\u0027access_deny\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1a5698a124bad8d68e093faa32b1ad5cccd67c7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba3cc151_aacaf06c","line":12,"updated":"2015-07-04 07:54:40.000000000","message":"s/access_status/access_rule_status/","commit_id":"4bdb59c881ce29426f1dfa964a269c0c63890393"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"33e6f8a8663338fbc37919fc09558730b196af36","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add functions \u0027get_access\u0027, \u0027list_access\u0027 , \u0027access_allow\u0027,"},{"line_number":12,"context_line":"\u0027access_deny\u0027 and \u0027wait_for_access_status\u0027 to"},{"line_number":13,"context_line":"manilaclient.tests.functional.client.ManilaCLIClient."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Id1a5698a124bad8d68e093faa32b1ad5cccd67c7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba3cc151_8acdac88","line":14,"updated":"2015-07-04 07:54:40.000000000","message":"Add link to BP as in: Partially-Implements: blueprint x","commit_id":"4bdb59c881ce29426f1dfa964a269c0c63890393"}],"manilaclient/config.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"501567a5e35dcbbe19dff3fa03040cc36ed96b2c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027access_types\u0027,"},{"line_number":95,"context_line":"                default\u003d[\u0027ip\u0027, ],"},{"line_number":96,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":97,"context_line":"                     \"share access rules.\"),"},{"line_number":98,"context_line":"    cfg.ListOpt(\u0027access_levels\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_3807ff1d","line":95,"updated":"2015-06-08 11:56:49.000000000","message":"Current approach does not allow to test different access types for different share protocols. For example:\n\nIP rules for NFS protocol and USER rules for CIFS protocol. \n\nSuch possibility should exist.","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b92927c02233ca3f482afd784c98c7234c1f8010","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":97,"context_line":"                     \"access rules for nfs share.\"),"},{"line_number":98,"context_line":"    cfg.ListOpt(\u0027cifs_access_types\u0027,"},{"line_number":99,"context_line":"                default\u003d[\u0027ip\u0027, ],"},{"line_number":100,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":101,"context_line":"                     \"access rules for cifs share.\"),"},{"line_number":102,"context_line":"    cfg.ListOpt(\u0027access_levels\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_ad048149","line":99,"updated":"2015-06-09 21:30:32.000000000","message":"CIFS access rules use \u0027user\u0027.","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"2f8d0e8e276e426892b3e30ea149a98ae4f1de47","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":97,"context_line":"                     \"access rules for nfs share.\"),"},{"line_number":98,"context_line":"    cfg.ListOpt(\u0027cifs_access_types\u0027,"},{"line_number":99,"context_line":"                default\u003d[\u0027ip\u0027, ],"},{"line_number":100,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":101,"context_line":"                     \"access rules for cifs share.\"),"},{"line_number":102,"context_line":"    cfg.ListOpt(\u0027access_levels\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_c598981e","line":99,"in_reply_to":"3afb71cf_ad048149","updated":"2015-06-10 10:58:47.000000000","message":"Done","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b92927c02233ca3f482afd784c98c7234c1f8010","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                help\u003d\"List of access levels that will be used to create \""},{"line_number":105,"context_line":"                     \"share access rules\"),"},{"line_number":106,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","},{"line_number":107,"context_line":"               default\u003d\"Administrator\","},{"line_number":108,"context_line":"               help\u003d\"Username, that will be used in user tests.\"),"},{"line_number":109,"context_line":"]"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_ad8b61c2","line":107,"updated":"2015-06-09 21:30:32.000000000","message":"For a more realistic test, I suggest using a Windows domain user, such as \u0027TESTDOMAIN\\Administrator\u0027.","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"2f8d0e8e276e426892b3e30ea149a98ae4f1de47","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                help\u003d\"List of access levels that will be used to create \""},{"line_number":105,"context_line":"                     \"share access rules\"),"},{"line_number":106,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","},{"line_number":107,"context_line":"               default\u003d\"Administrator\","},{"line_number":108,"context_line":"               help\u003d\"Username, that will be used in user tests.\"),"},{"line_number":109,"context_line":"]"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_a59b5c17","line":107,"in_reply_to":"3afb71cf_ad8b61c2","updated":"2015-06-10 10:58:47.000000000","message":"Done","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"               default\u003d500,"},{"line_number":92,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027nfs_access_types\u0027,"},{"line_number":95,"context_line":"                default\u003d[\u0027ip\u0027, ],"},{"line_number":96,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":97,"context_line":"                     \"access rules for nfs share.\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_d52ef18a","line":94,"updated":"2015-06-10 17:50:17.000000000","message":"I guess, we should consider any set of share protocols, not only NFS and CIFS. In this case we need to use \"mapper\" instead of dedicated option for some protocol.\n\nCurrently Manila knows about four protocols - NFS, CIFS, GlusterFS and HDFS.","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":97,"context_line":"                     \"access rules for nfs share.\"),"},{"line_number":98,"context_line":"    cfg.ListOpt(\u0027cifs_access_types\u0027,"},{"line_number":99,"context_line":"                default\u003d[\u0027user\u0027, ],"},{"line_number":100,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":101,"context_line":"                     \"access rules for cifs share.\"),"},{"line_number":102,"context_line":"    cfg.ListOpt(\u0027access_levels\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_a329029d","line":99,"updated":"2015-06-10 17:50:17.000000000","message":"Generic driver is the most used one with this testing, so, I propose to make its value as default - \"ip\".","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                help\u003d\"List of access types that will be used to create \""},{"line_number":101,"context_line":"                     \"access rules for cifs share.\"),"},{"line_number":102,"context_line":"    cfg.ListOpt(\u0027access_levels\u0027,"},{"line_number":103,"context_line":"                default\u003d[\u0027rw\u0027, ],"},{"line_number":104,"context_line":"                help\u003d\"List of access levels that will be used to create \""},{"line_number":105,"context_line":"                     \"share access rules\"),"},{"line_number":106,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_c3807e8d","line":103,"updated":"2015-06-10 17:50:17.000000000","message":"Should be splitted by share protocols too to be able to test two access levels for one protocol and only one for some other. For example, in generic driver, both - rw and ro are supportd for NFS, but for CIFS only rw.","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                     \"share access rules\"),"},{"line_number":106,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","},{"line_number":107,"context_line":"               default\u003d\"TESTDOMAIN\\Administrator\","},{"line_number":108,"context_line":"               help\u003d\"Username, that will be used in user tests.\"),"},{"line_number":109,"context_line":"]"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# 2. Generate config"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_43436e6c","line":108,"updated":"2015-06-10 17:50:17.000000000","message":"s/user tests/share access tests for user type of access/ ?","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"               default\u003d500,"},{"line_number":92,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027access_types_mapping\u0027,"},{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_bd7e1f19","line":94,"updated":"2015-06-24 05:12:04.000000000","message":"cfg.DictOpt","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"2ae4fcbda94044b4373b437f6a3eda15f2fa7e36","unresolved":false,"context_lines":[{"line_number":91,"context_line":"               default\u003d500,"},{"line_number":92,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027access_types_mapping\u0027,"},{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_ce13f2ff","line":94,"in_reply_to":"fa32b979_bd7e1f19","updated":"2015-06-25 05:53:01.000000000","message":"cfg.DictOpt can be used for dictionary, where keys and values are strings. But here we want value to be a list of access_types. And cfg.DictOpt doesn\u0027t provide such ability. Please correct me if I\u0027m wrong.","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"07e45e1a2cf4a5553e984c7f48ac4e3d39bcce3a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"               default\u003d500,"},{"line_number":92,"context_line":"               help\u003d\"Timeout in seconds to wait for a share to become \""},{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027access_types_mapping\u0027,"},{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_eeb27693","line":94,"in_reply_to":"fa32b979_ce13f2ff","updated":"2015-06-25 06:24:38.000000000","message":"1) Values of dicts are customizable: https://github.com/openstack/oslo.config/blob/578f9f4e/oslo_config/types.py#L283\n\n2) Then, you use here approach of key-value with parsing keys from one string that contains values too. Dict will allow to parse only values separated, for example,  by comma.\n\nSo,  in conclusion, dict type is a must here.","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7608aa830a60562a1bdc8dd309d123ea7d90d10b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027access_types_mapping\u0027,"},{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e:\u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.ListOpt(\u0027access_levels_mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_c373194d","line":96,"updated":"2015-06-23 17:20:41.000000000","message":"I think s/Dictionary/List/  It\u0027s still just a fancy list.","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                    \"available.\"),"},{"line_number":94,"context_line":"    cfg.ListOpt(\u0027access_types_mapping\u0027,"},{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e:\u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.ListOpt(\u0027access_levels_mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_4e836203","line":96,"in_reply_to":"fa32b979_c373194d","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7608aa830a60562a1bdc8dd309d123ea7d90d10b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e:\u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.ListOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d[\"nfs: rw ro\", \"cifs: rw\"],"},{"line_number":101,"context_line":"                help\u003d\"Dictionary contains access levels mapping to share \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_c369d98d","line":98,"updated":"2015-06-23 17:20:41.000000000","message":"add a space after colon to match your default","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                default\u003d[\"nfs: ip\", \"cifs: ip\"],"},{"line_number":96,"context_line":"                help\u003d\"Dictionary contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e:\u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.ListOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d[\"nfs: rw ro\", \"cifs: rw\"],"},{"line_number":101,"context_line":"                help\u003d\"Dictionary contains access levels mapping to share \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_2e805ef6","line":98,"in_reply_to":"fa32b979_c369d98d","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7608aa830a60562a1bdc8dd309d123ea7d90d10b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e:\u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.ListOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d[\"nfs: rw ro\", \"cifs: rw\"],"},{"line_number":101,"context_line":"                help\u003d\"Dictionary contains access levels mapping to share \""},{"line_number":102,"context_line":"                     \"protocol. It will be used to create access rules for \""},{"line_number":103,"context_line":"                     \"shares. Format: \u0027\u003cprotocol\u003e:\u003clevel1\u003e \u003clevel2\u003e\u0027,...\"),"},{"line_number":104,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_83b751d7","line":101,"updated":"2015-06-23 17:20:41.000000000","message":"same comment about \"Dictionary\" vs \"List\".","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"},{"line_number":101,"context_line":"                help\u003d\"Dict contains access levels mapping to share \""},{"line_number":102,"context_line":"                     \"protocol. It will be used to create access rules for \""},{"line_number":103,"context_line":"                     \"shares. Format: \u0027\u003cprotocol\u003e: \u003clevel1\u003e \u003clevel2\u003e\u0027,...\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_e32a367e","line":100,"updated":"2015-07-06 17:35:42.000000000","message":"Better to use comma instead of space as separator.","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"},{"line_number":101,"context_line":"                help\u003d\"Dict contains access levels mapping to share \""},{"line_number":102,"context_line":"                     \"protocol. It will be used to create access rules for \""},{"line_number":103,"context_line":"                     \"shares. Format: \u0027\u003cprotocol\u003e: \u003clevel1\u003e \u003clevel2\u003e\u0027,...\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_6adb41ee","line":100,"in_reply_to":"ba3cc151_e32a367e","updated":"2015-07-08 10:23:04.000000000","message":"If we use comma instead of space as separator, we may get error while parsing DictOpt, as comma is expected to separate just key:value pairs.","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027ip\u0027, \u0027cifs\u0027: \u0027ip\u0027},"},{"line_number":96,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\"),"},{"line_number":99,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"},{"line_number":101,"context_line":"                help\u003d\"Dict contains access levels mapping to share \""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_2cdc8ce3","line":98,"updated":"2015-07-13 10:47:06.000000000","message":"What share protocols are allowed?","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":100,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"},{"line_number":101,"context_line":"                help\u003d\"Dict contains access levels mapping to share \""},{"line_number":102,"context_line":"                     \"protocol. It will be used to create access rules for \""},{"line_number":103,"context_line":"                     \"shares. Format: \u0027\u003cprotocol\u003e: \u003clevel1\u003e \u003clevel2\u003e\u0027,...\"),"},{"line_number":104,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","},{"line_number":105,"context_line":"               default\u003d\"TESTDOMAIN\\\\Administrator\","}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_4cd9d0f2","line":102,"updated":"2015-07-13 10:47:06.000000000","message":"ditto","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fab1c7d3c5e0727cf4f3981325e1cd1c01dc5840","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027ip\u0027, \u0027cifs\u0027: \u0027ip\u0027},"},{"line_number":96,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\""},{"line_number":99,"context_line":"                     \"Allowed share protocols: nfs, cifs, glusterfs, hdfs. \"),"},{"line_number":100,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":101,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_383150a3","line":98,"updated":"2015-08-03 17:09:21.000000000","message":"space after ...","commit_id":"e919065a2e6b8fcf0c5573244b15ac0560e733ad"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fab1c7d3c5e0727cf4f3981325e1cd1c01dc5840","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":97,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":98,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\""},{"line_number":99,"context_line":"                     \"Allowed share protocols: nfs, cifs, glusterfs, hdfs. \"),"},{"line_number":100,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":101,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"},{"line_number":102,"context_line":"                help\u003d\"Dict contains access levels mapping to share \""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_d825cc5c","line":99,"updated":"2015-08-03 17:09:21.000000000","message":"No need for space at end of last one.","commit_id":"e919065a2e6b8fcf0c5573244b15ac0560e733ad"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"fab1c7d3c5e0727cf4f3981325e1cd1c01dc5840","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                help\u003d\"Dict contains access levels mapping to share \""},{"line_number":103,"context_line":"                     \"protocol. It will be used to create access rules for \""},{"line_number":104,"context_line":"                     \"shares. Format: \u0027\u003cprotocol\u003e: \u003clevel1\u003e \u003clevel2\u003e\u0027,... \""},{"line_number":105,"context_line":"                     \"Allowed share protocols: nfs, cifs, glusterfs, hdfs. \"),"},{"line_number":106,"context_line":"    cfg.StrOpt(\"username_for_user_rules\","},{"line_number":107,"context_line":"               default\u003d\"TESTDOMAIN\\\\Administrator\","},{"line_number":108,"context_line":"               help\u003d\"Username, that will be used in share access tests for \""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a4dcd0f_f82a082c","line":105,"updated":"2015-08-03 17:09:21.000000000","message":"No need for space at end.","commit_id":"e919065a2e6b8fcf0c5573244b15ac0560e733ad"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @not_found_wrapper"},{"line_number":625,"context_line":"    def get_access(self, access_id, share_id):"},{"line_number":626,"context_line":"        access_list_raw \u003d self.manila(\u0027access-list %s\u0027 % share_id)"},{"line_number":627,"context_line":"        access_list \u003d output_parser.listing(access_list_raw)"},{"line_number":628,"context_line":"        for access in access_list:"},{"line_number":629,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_16ab2f8b","line":626,"updated":"2015-06-05 12:08:43.000000000","message":"Is it planned to add \"list_access_rules\" method?","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"49eba74a7c75069dc263822b8cd058dcd39658c6","unresolved":false,"context_lines":[{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @not_found_wrapper"},{"line_number":625,"context_line":"    def get_access(self, access_id, share_id):"},{"line_number":626,"context_line":"        access_list_raw \u003d self.manila(\u0027access-list %s\u0027 % share_id)"},{"line_number":627,"context_line":"        access_list \u003d output_parser.listing(access_list_raw)"},{"line_number":628,"context_line":"        for access in access_list:"},{"line_number":629,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_52ca9a6f","line":626,"in_reply_to":"3afb71cf_16ab2f8b","updated":"2015-06-08 10:53:41.000000000","message":"Done","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b92927c02233ca3f482afd784c98c7234c1f8010","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            if ((state \u003d\u003d \u0027deleted\u0027 and not access) or"},{"line_number":643,"context_line":"                    access[\u0027state\u0027] \u003d\u003d state):"},{"line_number":644,"context_line":"                return"},{"line_number":645,"context_line":"            elif \u0027error\u0027 in access[\u0027state\u0027].lower():"},{"line_number":646,"context_line":"                raise exceptions.AccessRuleBuildErrorException("},{"line_number":647,"context_line":"                    access\u003daccess_id)"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_cd469d7a","line":645,"updated":"2015-06-09 21:30:32.000000000","message":"Do we still need lower() here since we made all the states lowercase?","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"2f8d0e8e276e426892b3e30ea149a98ae4f1de47","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            if ((state \u003d\u003d \u0027deleted\u0027 and not access) or"},{"line_number":643,"context_line":"                    access[\u0027state\u0027] \u003d\u003d state):"},{"line_number":644,"context_line":"                return"},{"line_number":645,"context_line":"            elif \u0027error\u0027 in access[\u0027state\u0027].lower():"},{"line_number":646,"context_line":"                raise exceptions.AccessRuleBuildErrorException("},{"line_number":647,"context_line":"                    access\u003daccess_id)"},{"line_number":648,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_e57b94bc","line":645,"in_reply_to":"3afb71cf_cd469d7a","updated":"2015-06-10 10:58:47.000000000","message":"Seems that we don\u0027t need lower() here. Thank you!","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"dc8d91ef07b17413962ace94688a1c3d78904c45","unresolved":false,"context_lines":[{"line_number":635,"context_line":"        access \u003d self.get_access(access_id, share_id)"},{"line_number":636,"context_line":"        start \u003d int(time.time())"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"        while access[\u0027state\u0027] !\u003d state:"},{"line_number":639,"context_line":"            time.sleep(self.build_interval)"},{"line_number":640,"context_line":"            access \u003d self.get_access(access_id, share_id)"},{"line_number":641,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_73493cd0","line":638,"updated":"2015-06-14 02:27:56.000000000","message":"need to check for access is None","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                return access"},{"line_number":632,"context_line":"        return None"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    def access_allow(self, share_id, access_type, access_to, access_level):"},{"line_number":635,"context_line":"        raw_access \u003d self.manila("},{"line_number":636,"context_line":"            \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":637,"context_line":"            \u0027%(access_to)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_ddac43a1","line":634,"updated":"2015-06-24 05:12:04.000000000","message":"Should be wrapped with not_found_wrapper","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                return access"},{"line_number":632,"context_line":"        return None"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    def access_allow(self, share_id, access_type, access_to, access_level):"},{"line_number":635,"context_line":"        raw_access \u003d self.manila("},{"line_number":636,"context_line":"            \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":637,"context_line":"            \u0027%(access_to)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_cea692aa","line":634,"in_reply_to":"fa32b979_ddac43a1","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            })"},{"line_number":643,"context_line":"        return output_parser.details(raw_access)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    def access_deny(self, share_id, access_id):"},{"line_number":646,"context_line":"        self.manila(\u0027access-deny %(share_id)s %(access_id)s\u0027 % {"},{"line_number":647,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":648,"context_line":"            \u0027access_id\u0027: access_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_9d931b5b","line":645,"updated":"2015-06-24 05:12:04.000000000","message":"Same here","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":642,"context_line":"            })"},{"line_number":643,"context_line":"        return output_parser.details(raw_access)"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    def access_deny(self, share_id, access_id):"},{"line_number":646,"context_line":"        self.manila(\u0027access-deny %(share_id)s %(access_id)s\u0027 % {"},{"line_number":647,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":648,"context_line":"            \u0027access_id\u0027: access_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_6eb8a6c8","line":645,"in_reply_to":"fa32b979_9d931b5b","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        metadata \u003d output_parser.details(metadata_raw)"},{"line_number":622,"context_line":"        return metadata"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def list_access(self, share_id):"},{"line_number":625,"context_line":"        access_list_raw \u003d self.manila(\u0027access-list %s\u0027 % share_id)"},{"line_number":626,"context_line":"        return output_parser.listing(access_list_raw)"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_081ad917","line":624,"updated":"2015-07-06 17:35:42.000000000","message":"not_found_wrapper","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":621,"context_line":"        metadata \u003d output_parser.details(metadata_raw)"},{"line_number":622,"context_line":"        return metadata"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def list_access(self, share_id):"},{"line_number":625,"context_line":"        access_list_raw \u003d self.manila(\u0027access-list %s\u0027 % share_id)"},{"line_number":626,"context_line":"        return output_parser.listing(access_list_raw)"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_6d26fb17","line":624,"in_reply_to":"ba3cc151_081ad917","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        access_list_raw \u003d self.manila(\u0027access-list %s\u0027 % share_id)"},{"line_number":626,"context_line":"        return output_parser.listing(access_list_raw)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def get_access(self, access_id, share_id):"},{"line_number":629,"context_line":"        for access in self.list_access(share_id):"},{"line_number":630,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"},{"line_number":631,"context_line":"                return access"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_c8d2b134","line":628,"updated":"2015-07-06 17:35:42.000000000","message":"not_found_wrapper","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        access_list_raw \u003d self.manila(\u0027access-list %s\u0027 % share_id)"},{"line_number":626,"context_line":"        return output_parser.listing(access_list_raw)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"    def get_access(self, access_id, share_id):"},{"line_number":629,"context_line":"        for access in self.list_access(share_id):"},{"line_number":630,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"},{"line_number":631,"context_line":"                return access"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_4bae3fe7","line":628,"in_reply_to":"ba3cc151_c8d2b134","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        })"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def wait_for_access_rule_status(self, access_id, share_id, state\u003d\u0027active\u0027):"},{"line_number":654,"context_line":"        access \u003d self.get_access(access_id, share_id)"},{"line_number":655,"context_line":"        if not access:"},{"line_number":656,"context_line":"            if state \u003d\u003d \u0027deleted\u0027:"},{"line_number":657,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_28c1dd2e","line":654,"updated":"2015-07-06 17:35:42.000000000","message":"So, logic on lines 654-659 should be changed according to addon of \"not_found_wrapper\" to all acces rule methods.","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        })"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"    def wait_for_access_rule_status(self, access_id, share_id, state\u003d\u0027active\u0027):"},{"line_number":654,"context_line":"        access \u003d self.get_access(access_id, share_id)"},{"line_number":655,"context_line":"        if not access:"},{"line_number":656,"context_line":"            if state \u003d\u003d \u0027deleted\u0027:"},{"line_number":657,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_8d07bf1c","line":654,"in_reply_to":"ba3cc151_28c1dd2e","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        return output_parser.listing(access_list_raw)"},{"line_number":628,"context_line":""},{"line_number":629,"context_line":"    @not_found_wrapper"},{"line_number":630,"context_line":"    def get_access(self, access_id, share_id):"},{"line_number":631,"context_line":"        for access in self.list_access(share_id):"},{"line_number":632,"context_line":"            if access[\u0027id\u0027] \u003d\u003d access_id:"},{"line_number":633,"context_line":"                return access"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_191ea8ba","line":630,"updated":"2015-07-13 10:47:06.000000000","message":"Here \"access_id\" is first and \"share_id\" is second.","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        return output_parser.details(raw_access)"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    @not_found_wrapper"},{"line_number":649,"context_line":"    def access_deny(self, share_id, access_id):"},{"line_number":650,"context_line":"        self.manila(\u0027access-deny %(share_id)s %(access_id)s\u0027 % {"},{"line_number":651,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":652,"context_line":"            \u0027access_id\u0027: access_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_99d638c4","line":649,"updated":"2015-07-13 10:47:06.000000000","message":"But here vice-versa. Better to keep compatibility.","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        try:"},{"line_number":657,"context_line":"            access \u003d self.get_access(access_id, share_id)"},{"line_number":658,"context_line":"        except tempest_lib_exc.NotFound:"},{"line_number":659,"context_line":"            if state \u003d\u003d \u0027deleted\u0027:"},{"line_number":660,"context_line":"                return"},{"line_number":661,"context_line":"            raise"},{"line_number":662,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_f9fc2440","line":659,"updated":"2015-07-13 10:47:06.000000000","message":"From API point of view, we can not get access rule that is \"deleted\".\n\nSo, this method does logic that is different than \"wait for status\" it does \"wait for delete\", that should be separate method.","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":666,"context_line":"            try:"},{"line_number":667,"context_line":"                access \u003d self.get_access(access_id, share_id)"},{"line_number":668,"context_line":"            except tempest_lib_exc.NotFound:"},{"line_number":669,"context_line":"                if state \u003d\u003d \u0027deleted\u0027:"},{"line_number":670,"context_line":"                    return"},{"line_number":671,"context_line":"                raise"},{"line_number":672,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_b9953ce5","line":669,"updated":"2015-07-13 10:47:06.000000000","message":"ditto","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"}],"manilaclient/tests/functional/exceptions.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"33e6f8a8663338fbc37919fc09558730b196af36","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class AccessRuleBuildErrorException(exceptions.TempestException):"},{"line_number":48,"context_line":"    message \u003d \"Access rule %(access)s failed to create and is in ERROR state.\""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_4ac32439","line":48,"updated":"2015-07-04 07:54:40.000000000","message":"This is also used for \"failed to delete\". Maybe add params for action (and state). Or add different exception to use for the delete case.","commit_id":"4bdb59c881ce29426f1dfa964a269c0c63890393"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    message \u003d \"Share %(share)s failed to build and is in ERROR status\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class AccessRuleBuildErrorException(exceptions.TempestException):"},{"line_number":48,"context_line":"    message \u003d \"Access rule %(access)s failed to create and is in ERROR state.\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_f9c42441","line":47,"updated":"2015-07-13 10:47:06.000000000","message":"\"Build\" is not really suitable for access rules. I suggest to use word \"create\".","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"}],"manilaclient/tests/functional/test_share_access.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class ShareAccessReadOnlyTest(base.BaseTestCase):"},{"line_number":27,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":28,"context_line":"    def test_access_list(self, role):"},{"line_number":29,"context_line":"        share \u003d self.create_share(client\u003dself.clients[role],"},{"line_number":30,"context_line":"                                  cleanup_in_class\u003dTrue)"},{"line_number":31,"context_line":"        self.clients[role].manila(\u0027access-list\u0027, params\u003dshare[\u0027id\u0027])"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_96db9f1b","line":29,"updated":"2015-06-05 12:08:43.000000000","message":"This test creates share, it is not read-only.","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":34,"context_line":"@ddt.ddt"},{"line_number":35,"context_line":"class ShareAccessReadWriteTest(base.BaseTestCase):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_create_delete_access_type(self):"},{"line_number":38,"context_line":"        client \u003d self.get_admin_client()"},{"line_number":39,"context_line":"        share \u003d self.create_share(client\u003dclient)"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_1657af03","line":37,"updated":"2015-06-05 12:08:43.000000000","message":"Why \"type\" is added at the end of test name?","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":35,"context_line":"class ShareAccessReadWriteTest(base.BaseTestCase):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_create_delete_access_type(self):"},{"line_number":38,"context_line":"        client \u003d self.get_admin_client()"},{"line_number":39,"context_line":"        share \u003d self.create_share(client\u003dclient)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        raw_access \u003d client.manila("}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_7648235c","line":38,"updated":"2015-06-05 12:08:43.000000000","message":"Why do you use admin client for share creation?","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        share \u003d self.create_share(client\u003dclient)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        raw_access \u003d client.manila("},{"line_number":42,"context_line":"            \u0027access-allow  --access-level rw %(id)s ip 10.0.0.1\u0027 % {"},{"line_number":43,"context_line":"                \u0027id\u0027: share[\u0027id\u0027],"},{"line_number":44,"context_line":"            })"},{"line_number":45,"context_line":"        access \u003d output_parser.details(raw_access)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_5679a7fb","line":42,"updated":"2015-06-05 12:08:43.000000000","message":"Share access rule tests should use config options for type of access (ip, user, cert) and possibility to use some specific set of access levels - rw/ro.","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"49eba74a7c75069dc263822b8cd058dcd39658c6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        share \u003d self.create_share(client\u003dclient)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        raw_access \u003d client.manila("},{"line_number":42,"context_line":"            \u0027access-allow  --access-level rw %(id)s ip 10.0.0.1\u0027 % {"},{"line_number":43,"context_line":"                \u0027id\u0027: share[\u0027id\u0027],"},{"line_number":44,"context_line":"            })"},{"line_number":45,"context_line":"        access \u003d output_parser.details(raw_access)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_d2a44aba","line":42,"in_reply_to":"3afb71cf_5679a7fb","updated":"2015-06-08 10:53:41.000000000","message":"Done","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            })"},{"line_number":45,"context_line":"        access \u003d output_parser.details(raw_access)"},{"line_number":46,"context_line":"        client.wait_for_access_rule_status(access[\u0027id\u0027], share[\u0027id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(access[\u0027share_id\u0027], share[\u0027id\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(access[\u0027access_type\u0027], \u0027ip\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(access[\u0027access_to\u0027], \u002710.0.0.1\u0027)"},{"line_number":50,"context_line":"        self.assertEqual(access[\u0027access_level\u0027], \u0027rw\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_3652ab14","line":47,"updated":"2015-06-05 12:08:43.000000000","message":"Expected part should be for the left. Also, better to use \"get\" method to avoid KeyError exception and get expected \"AssertionError\". Same below.","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"49eba74a7c75069dc263822b8cd058dcd39658c6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            })"},{"line_number":45,"context_line":"        access \u003d output_parser.details(raw_access)"},{"line_number":46,"context_line":"        client.wait_for_access_rule_status(access[\u0027id\u0027], share[\u0027id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(access[\u0027share_id\u0027], share[\u0027id\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(access[\u0027access_type\u0027], \u0027ip\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(access[\u0027access_to\u0027], \u002710.0.0.1\u0027)"},{"line_number":50,"context_line":"        self.assertEqual(access[\u0027access_level\u0027], \u0027rw\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_b2ab0e89","line":47,"in_reply_to":"3afb71cf_3652ab14","updated":"2015-06-08 10:53:41.000000000","message":"Done","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ff9a7e0ed191471d43a00d35e1e0b9b45b531d51","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(access[\u0027access_type\u0027], \u0027ip\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(access[\u0027access_to\u0027], \u002710.0.0.1\u0027)"},{"line_number":50,"context_line":"        self.assertEqual(access[\u0027access_level\u0027], \u0027rw\u0027)"},{"line_number":51,"context_line":"        client.manila(\u0027access-deny %(share_id)s %(access_id)s\u0027 % {"},{"line_number":52,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":53,"context_line":"            \u0027access_id\u0027: access[\u0027id\u0027],"},{"line_number":54,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_36798b94","line":51,"updated":"2015-06-05 12:08:43.000000000","message":"Deny operation is not verified after execution.","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"49eba74a7c75069dc263822b8cd058dcd39658c6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(access[\u0027access_type\u0027], \u0027ip\u0027)"},{"line_number":49,"context_line":"        self.assertEqual(access[\u0027access_to\u0027], \u002710.0.0.1\u0027)"},{"line_number":50,"context_line":"        self.assertEqual(access[\u0027access_level\u0027], \u0027rw\u0027)"},{"line_number":51,"context_line":"        client.manila(\u0027access-deny %(share_id)s %(access_id)s\u0027 % {"},{"line_number":52,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":53,"context_line":"            \u0027access_id\u0027: access[\u0027id\u0027],"},{"line_number":54,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_92aed296","line":51,"in_reply_to":"3afb71cf_36798b94","updated":"2015-06-08 10:53:41.000000000","message":"Done","commit_id":"67a6893ac95378808436d3d7a6ff85bd79269bc2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"501567a5e35dcbbe19dff3fa03040cc36ed96b2c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(ShareAccessReadWriteTest, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":32,"context_line":"            client\u003dcls.get_admin_client(),"},{"line_number":33,"context_line":"            public\u003dTrue,"},{"line_number":34,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_93a814dd","line":32,"updated":"2015-06-08 11:56:49.000000000","message":"Why admin creds are used for share creation?","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"354c4f186a8c9f895e35030e5b8e923ef6da6d68","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(ShareAccessReadWriteTest, cls).setUpClass()"},{"line_number":31,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":32,"context_line":"            client\u003dcls.get_admin_client(),"},{"line_number":33,"context_line":"            public\u003dTrue,"},{"line_number":34,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_11fcebb6","line":32,"in_reply_to":"3afb71cf_93a814dd","updated":"2015-06-09 11:56:53.000000000","message":"As admin creds are used for share creation in tests by default. Actualy there\u0027s no need in this line, that\u0027s my mistake.","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"501567a5e35dcbbe19dff3fa03040cc36ed96b2c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            public\u003dTrue,"},{"line_number":34,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":37,"context_line":"    def test_list_access_rule(self, role):"},{"line_number":38,"context_line":"        self.clients[role].list_access(self.share[\u0027id\u0027])"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_13b54430","line":36,"updated":"2015-06-08 11:56:49.000000000","message":"We should not use both users, because it is very likely that they will be from different tenants.","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"354c4f186a8c9f895e35030e5b8e923ef6da6d68","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            public\u003dTrue,"},{"line_number":34,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":37,"context_line":"    def test_list_access_rule(self, role):"},{"line_number":38,"context_line":"        self.clients[role].list_access(self.share[\u0027id\u0027])"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_9160dba6","line":36,"in_reply_to":"3afb71cf_13b54430","updated":"2015-06-09 11:56:53.000000000","message":"Done","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"501567a5e35dcbbe19dff3fa03040cc36ed96b2c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_list_access_rule(self, role):"},{"line_number":38,"context_line":"        self.clients[role].list_access(self.share[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":41,"context_line":"    def test_create_delete_access_rule(self, role):"},{"line_number":42,"context_line":"        client \u003d self.clients[role]"},{"line_number":43,"context_line":"        share \u003d self.create_share(client\u003dclient)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_f382a851","line":40,"updated":"2015-06-08 11:56:49.000000000","message":"ditto","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"354c4f186a8c9f895e35030e5b8e923ef6da6d68","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_list_access_rule(self, role):"},{"line_number":38,"context_line":"        self.clients[role].list_access(self.share[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":41,"context_line":"    def test_create_delete_access_rule(self, role):"},{"line_number":42,"context_line":"        client \u003d self.clients[role]"},{"line_number":43,"context_line":"        share \u003d self.create_share(client\u003dclient)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_5156e3ce","line":40,"in_reply_to":"3afb71cf_f382a851","updated":"2015-06-09 11:56:53.000000000","message":"Done","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"501567a5e35dcbbe19dff3fa03040cc36ed96b2c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        share \u003d self.create_share(client\u003dclient)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        for access_type in CONF.access_types:"},{"line_number":46,"context_line":"            for access_level in CONF.access_levels:"},{"line_number":47,"context_line":"                raw_access \u003d client.manila("},{"line_number":48,"context_line":"                    \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":49,"context_line":"                    \u002710.0.0.1\u0027 % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_135e6412","line":46,"updated":"2015-06-08 11:56:49.000000000","message":"Tests should not have such cycles.\n\nThey should test such things separately.","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"354c4f186a8c9f895e35030e5b8e923ef6da6d68","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        share \u003d self.create_share(client\u003dclient)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        for access_type in CONF.access_types:"},{"line_number":46,"context_line":"            for access_level in CONF.access_levels:"},{"line_number":47,"context_line":"                raw_access \u003d client.manila("},{"line_number":48,"context_line":"                    \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":49,"context_line":"                    \u002710.0.0.1\u0027 % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_315b67f8","line":46,"in_reply_to":"3afb71cf_135e6412","updated":"2015-06-09 11:56:53.000000000","message":"Done","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"501567a5e35dcbbe19dff3fa03040cc36ed96b2c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            for access_level in CONF.access_levels:"},{"line_number":47,"context_line":"                raw_access \u003d client.manila("},{"line_number":48,"context_line":"                    \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":49,"context_line":"                    \u002710.0.0.1\u0027 % {"},{"line_number":50,"context_line":"                        \u0027level\u0027: access_level,"},{"line_number":51,"context_line":"                        \u0027id\u0027: share[\u0027id\u0027],"},{"line_number":52,"context_line":"                        \u0027type\u0027: access_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_d3ec4c2b","line":49,"updated":"2015-06-08 11:56:49.000000000","message":"Why do you use IP-like value? Proper value for each access type should be used.\n\nHow usernames are used in manila tempest tests:\n\nhttps://github.com/openstack/manila/blob/61d006f2/contrib/tempest/tempest/config_share.py#L65","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"354c4f186a8c9f895e35030e5b8e923ef6da6d68","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            for access_level in CONF.access_levels:"},{"line_number":47,"context_line":"                raw_access \u003d client.manila("},{"line_number":48,"context_line":"                    \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":49,"context_line":"                    \u002710.0.0.1\u0027 % {"},{"line_number":50,"context_line":"                        \u0027level\u0027: access_level,"},{"line_number":51,"context_line":"                        \u0027id\u0027: share[\u0027id\u0027],"},{"line_number":52,"context_line":"                        \u0027type\u0027: access_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_b16757b6","line":49,"in_reply_to":"3afb71cf_d3ec4c2b","updated":"2015-06-09 11:56:53.000000000","message":"Done","commit_id":"544dd02c5675142d696a793f23aa2087d78b53de"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"b92927c02233ca3f482afd784c98c7234c1f8010","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                cleanup_in_class\u003dTrue)"},{"line_number":36,"context_line":"        if \u0027cifs\u0027 in CONF.enable_protocols:"},{"line_number":37,"context_line":"            cls.cifs_share \u003d cls.create_share("},{"line_number":38,"context_line":"                share_protocol\u003d\u0027nfs\u0027,"},{"line_number":39,"context_line":"                public\u003dTrue,"},{"line_number":40,"context_line":"                cleanup_in_class\u003dTrue)"},{"line_number":41,"context_line":"        cls.access_to \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_7f150c3e","line":38,"updated":"2015-06-09 21:30:32.000000000","message":"\u0027cifs\u0027","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"2f8d0e8e276e426892b3e30ea149a98ae4f1de47","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                cleanup_in_class\u003dTrue)"},{"line_number":36,"context_line":"        if \u0027cifs\u0027 in CONF.enable_protocols:"},{"line_number":37,"context_line":"            cls.cifs_share \u003d cls.create_share("},{"line_number":38,"context_line":"                share_protocol\u003d\u0027nfs\u0027,"},{"line_number":39,"context_line":"                public\u003dTrue,"},{"line_number":40,"context_line":"                cleanup_in_class\u003dTrue)"},{"line_number":41,"context_line":"        cls.access_to \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_0558f054","line":38,"in_reply_to":"3afb71cf_7f150c3e","updated":"2015-06-10 10:58:47.000000000","message":"Done","commit_id":"b7d49a7ab220c4bc80545eac7232d5b1a328e494"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    @classmethod"},{"line_number":29,"context_line":"    def setUpClass(cls):"},{"line_number":30,"context_line":"        super(ShareAccessReadWriteTest, cls).setUpClass()"},{"line_number":31,"context_line":"        if \u0027nfs\u0027 in CONF.enable_protocols:"},{"line_number":32,"context_line":"            cls.nfs_share \u003d cls.create_share("},{"line_number":33,"context_line":"                share_protocol\u003d\u0027nfs\u0027,"},{"line_number":34,"context_line":"                public\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_75561d07","line":31,"updated":"2015-06-10 17:50:17.000000000","message":"Should be separate class for each protocol.","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    @testtools.skipUnless(\u0027nfs\u0027 in CONF.enable_protocols,"},{"line_number":52,"context_line":"                          \u0027Usage of NFS protocol is disabled\u0027)"},{"line_number":53,"context_line":"    def test_list_access_rule_for_nfs_share(self):"},{"line_number":54,"context_line":"            self.clients[\u0027user\u0027].list_access(self.nfs_share[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @testtools.skipUnless(\u0027cifs\u0027 in CONF.enable_protocols,"},{"line_number":57,"context_line":"                          \u0027Usage of CIFS protocol is disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_b5025508","line":54,"updated":"2015-06-10 17:50:17.000000000","message":"wrong indentation","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    @testtools.skipUnless(\u0027cifs\u0027 in CONF.enable_protocols,"},{"line_number":57,"context_line":"                          \u0027Usage of CIFS protocol is disabled\u0027)"},{"line_number":58,"context_line":"    def test_list_access_rule_for_cifs_share(self):"},{"line_number":59,"context_line":"            self.client.list_access(self.cifs_share[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _create_delete_access_rule(self, access_level, access_type, share_id):"},{"line_number":62,"context_line":"        raw_access \u003d self.client.manila("}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_95051912","line":59,"updated":"2015-06-10 17:50:17.000000000","message":"wrong indentation","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def _create_delete_access_rule(self, access_level, access_type, share_id):"},{"line_number":62,"context_line":"        raw_access \u003d self.client.manila("},{"line_number":63,"context_line":"            \u0027access-allow  --access-level %(level)s %(id)s %(type)s \u0027"},{"line_number":64,"context_line":"            \u0027%(access_to)s\u0027 % {"},{"line_number":65,"context_line":"                \u0027level\u0027: access_level,"},{"line_number":66,"context_line":"                \u0027id\u0027: share_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_b577f59e","line":63,"updated":"2015-06-10 17:50:17.000000000","message":"This should be used from client as you do it for \"list\" and \"get\" operations.","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self.client.wait_for_access_rule_status(access[\u0027id\u0027], share_id)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self.client.manila(\u0027access-deny %(share_id)s %(access_id)s\u0027 % {"},{"line_number":79,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":80,"context_line":"            \u0027access_id\u0027: access[\u0027id\u0027],"},{"line_number":81,"context_line":"        })"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_957ab986","line":78,"updated":"2015-06-10 17:50:17.000000000","message":"Same here.","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"52ad2d2d94cc43c334457572e5384bc086dd973a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                                                state\u003d\u0027deleted\u0027)"},{"line_number":85,"context_line":"        self.assertIsNone(self.client.get_access(access[\u0027id\u0027], share_id))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @testtools.skipUnless(\u0027nfs\u0027 in CONF.enable_protocols,"},{"line_number":88,"context_line":"                          \u0027Usage of NFS protocol is disabled\u0027)"},{"line_number":89,"context_line":"    @testtools.skipUnless(\u0027ro\u0027 in CONF.access_levels,"},{"line_number":90,"context_line":"                          \u0027Usage of RO access level is disabled\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afb71cf_95887972","line":87,"updated":"2015-06-10 17:50:17.000000000","message":"Tests on lines 87-121 can be defined using one method.","commit_id":"ed531cd8e62bfdbbf24b7099cdb0ee4b714378b4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def get_config_value_from_mapping(mapping_list, share_protocol):"},{"line_number":25,"context_line":"    for item in mapping_list:"},{"line_number":26,"context_line":"        protocol, values_list \u003d item.split(\u0027:\u0027)"},{"line_number":27,"context_line":"        if protocol.strip() \u003d\u003d share_protocol:"},{"line_number":28,"context_line":"            return[val for val in values_list.split(\u0027 \u0027) if val]"},{"line_number":29,"context_line":"    return []"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_1dd62b4f","line":26,"updated":"2015-06-24 05:12:04.000000000","message":"Oslo config is able to handle dicts. And in this case it should have been dict.","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    return []"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class ShareAccessReadWriteBase(base.BaseTestCase):"},{"line_number":34,"context_line":"    protocol \u003d None"},{"line_number":35,"context_line":"    access_level \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_3d00cfaa","line":32,"updated":"2015-06-24 05:12:04.000000000","message":"ddt is not used","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    return []"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class ShareAccessReadWriteBase(base.BaseTestCase):"},{"line_number":34,"context_line":"    protocol \u003d None"},{"line_number":35,"context_line":"    access_level \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_0ec8fa53","line":32,"in_reply_to":"fa32b979_3d00cfaa","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class ShareAccessReadWriteBase(base.BaseTestCase):"},{"line_number":34,"context_line":"    protocol \u003d None"},{"line_number":35,"context_line":"    access_level \u003d None"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_5dfd93af","line":33,"updated":"2015-06-24 05:12:04.000000000","message":"I guess this class is attempted to run as test suite and just skipped. Please, look at test run results.","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class ShareAccessReadWriteBase(base.BaseTestCase):"},{"line_number":34,"context_line":"    protocol \u003d None"},{"line_number":35,"context_line":"    access_level \u003d None"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_aef0ee91","line":33,"in_reply_to":"fa32b979_5dfd93af","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027cert\u0027: \u0027tenant.example.com\u0027,"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"        cls.access_types \u003d get_config_value_from_mapping("},{"line_number":60,"context_line":"            CONF.access_types_mapping, cls.protocol)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def setUp(self):"},{"line_number":63,"context_line":"        super(ShareAccessReadWriteBase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_fd5ee7e7","line":60,"updated":"2015-06-24 05:12:04.000000000","message":"If dict type of option were used then we could just use following:\n\ncls.access_types \u003d option_with_mapping[cls.protocol]","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def setUp(self):"},{"line_number":63,"context_line":"        super(ShareAccessReadWriteBase, self).setUp()"},{"line_number":64,"context_line":"        self.client \u003d self.clients[\u0027user\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_list_access_rule_for_share(self):"},{"line_number":67,"context_line":"        self.clients[\u0027user\u0027].list_access(self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_1dd94b57","line":64,"updated":"2015-06-24 05:12:04.000000000","message":"Redundant","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def setUp(self):"},{"line_number":63,"context_line":"        super(ShareAccessReadWriteBase, self).setUp()"},{"line_number":64,"context_line":"        self.client \u003d self.clients[\u0027user\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_list_access_rule_for_share(self):"},{"line_number":67,"context_line":"        self.clients[\u0027user\u0027].list_access(self.share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_2e585e89","line":64,"in_reply_to":"fa32b979_1dd94b57","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"04149eaacb54bde90487318de63cdc449aa7eb5c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.client \u003d self.clients[\u0027user\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_list_access_rule_for_share(self):"},{"line_number":67,"context_line":"        self.clients[\u0027user\u0027].list_access(self.share[\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _create_delete_access_rule(self, access_type, access_to, share_id):"},{"line_number":70,"context_line":"        access \u003d self.client.access_allow(share_id, access_type,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_5d14b3e7","line":67,"updated":"2015-06-24 05:12:04.000000000","message":"self.user_client.foo","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.client \u003d self.clients[\u0027user\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def test_list_access_rule_for_share(self):"},{"line_number":67,"context_line":"        self.clients[\u0027user\u0027].list_access(self.share[\u0027id\u0027])"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _create_delete_access_rule(self, access_type, access_to, share_id):"},{"line_number":70,"context_line":"        access \u003d self.client.access_allow(share_id, access_type,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_8e65ea45","line":67,"in_reply_to":"fa32b979_5d14b3e7","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7608aa830a60562a1bdc8dd309d123ea7d90d10b","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_delete_ip_access_rule(self):"},{"line_number":87,"context_line":"        if \u0027ip\u0027 not in self.access_types:"},{"line_number":88,"context_line":"            raise self.skipException(\"IP access rule is disebled\")"},{"line_number":89,"context_line":"        self._create_delete_access_rule(\u0027ip\u0027, \u002710.0.0.1\u0027,"},{"line_number":90,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_defd32b2","line":88,"updated":"2015-06-23 17:20:41.000000000","message":"s/disebled/disabled/","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_create_delete_ip_access_rule(self):"},{"line_number":87,"context_line":"        if \u0027ip\u0027 not in self.access_types:"},{"line_number":88,"context_line":"            raise self.skipException(\"IP access rule is disebled\")"},{"line_number":89,"context_line":"        self._create_delete_access_rule(\u0027ip\u0027, \u002710.0.0.1\u0027,"},{"line_number":90,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_ce4772a1","line":88,"in_reply_to":"fa32b979_defd32b2","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7608aa830a60562a1bdc8dd309d123ea7d90d10b","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_create_delete_user_access_rule(self):"},{"line_number":93,"context_line":"        if \u0027user\u0027 not in self.access_types:"},{"line_number":94,"context_line":"            raise self.skipException(\"User access rule is disebled\")"},{"line_number":95,"context_line":"        self._create_delete_access_rule(\u0027user\u0027, CONF.username_for_user_rules,"},{"line_number":96,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_dec21253","line":94,"updated":"2015-06-23 17:20:41.000000000","message":"s/disebled/disabled/","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_create_delete_user_access_rule(self):"},{"line_number":93,"context_line":"        if \u0027user\u0027 not in self.access_types:"},{"line_number":94,"context_line":"            raise self.skipException(\"User access rule is disebled\")"},{"line_number":95,"context_line":"        self._create_delete_access_rule(\u0027user\u0027, CONF.username_for_user_rules,"},{"line_number":96,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_8ecc0a36","line":94,"in_reply_to":"fa32b979_dec21253","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7608aa830a60562a1bdc8dd309d123ea7d90d10b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_create_delete_cert_access_rule(self):"},{"line_number":99,"context_line":"        if \u0027cert\u0027 not in self.access_types:"},{"line_number":100,"context_line":"            raise self.skipException(\"Cert access rule is disebled\")"},{"line_number":101,"context_line":"        self._create_delete_access_rule(\u0027cert\u0027, \u0027tenant.example.com\u0027,"},{"line_number":102,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_9ea7aabc","line":100,"updated":"2015-06-23 17:20:41.000000000","message":"s/disebled/disabled/","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"21a99ad8fff00732d87656de6393c90a8c6c395b","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_create_delete_cert_access_rule(self):"},{"line_number":99,"context_line":"        if \u0027cert\u0027 not in self.access_types:"},{"line_number":100,"context_line":"            raise self.skipException(\"Cert access rule is disebled\")"},{"line_number":101,"context_line":"        self._create_delete_access_rule(\u0027cert\u0027, \u0027tenant.example.com\u0027,"},{"line_number":102,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_2ecffe29","line":100,"in_reply_to":"fa32b979_9ea7aabc","updated":"2015-06-25 08:18:10.000000000","message":"Done","commit_id":"c0ec7504375aaa18ffd4a0d8574a3d11357e4142"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_list_from_string(values_list):"},{"line_number":23,"context_line":"    return[val for val in values_list.split(\u0027 \u0027) if val]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareAccessReadWriteBase(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_75a49907","line":23,"updated":"2015-07-06 17:35:42.000000000","message":"No need to use this func","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"def get_list_from_string(values_list):"},{"line_number":23,"context_line":"    return[val for val in values_list.split(\u0027 \u0027) if val]"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class ShareAccessReadWriteBase(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_31bfe561","line":23,"in_reply_to":"ba3cc151_75a49907","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        if cls.protocol not in CONF.enable_protocols:"},{"line_number":34,"context_line":"            message \u003d \"%s tests are disabled\" % cls.protocol"},{"line_number":35,"context_line":"            raise cls.skipException(message)"},{"line_number":36,"context_line":"        if cls.access_level not in get_list_from_string("},{"line_number":37,"context_line":"                CONF.access_levels_mapping.get(cls.protocol, [])):"},{"line_number":38,"context_line":"            raise cls.skipException(\"%(level)s tests for %(protocol)s share \""},{"line_number":39,"context_line":"                                    \"access are disabled\" % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_282c7daa","line":36,"updated":"2015-07-06 17:35:42.000000000","message":"if cls.access_level not in  CONF.access_levels_mapping.get(cls.protocol, \"\").split(\",\"):","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        if cls.protocol not in CONF.enable_protocols:"},{"line_number":34,"context_line":"            message \u003d \"%s tests are disabled\" % cls.protocol"},{"line_number":35,"context_line":"            raise cls.skipException(message)"},{"line_number":36,"context_line":"        if cls.access_level not in get_list_from_string("},{"line_number":37,"context_line":"                CONF.access_levels_mapping.get(cls.protocol, [])):"},{"line_number":38,"context_line":"            raise cls.skipException(\"%(level)s tests for %(protocol)s share \""},{"line_number":39,"context_line":"                                    \"access are disabled\" % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_718ecdd1","line":36,"in_reply_to":"ba3cc151_282c7daa","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            CONF.access_types_mapping.get(cls.protocol, []))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_list_access_rule_for_share(self):"},{"line_number":51,"context_line":"        self.user_client.list_access(self.share[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _create_delete_access_rule(self, access_type, access_to, share_id):"},{"line_number":54,"context_line":"        access \u003d self.user_client.access_allow(share_id, access_type,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_95103daa","line":51,"updated":"2015-07-06 17:35:42.000000000","message":"This test does not verify nothing.\n\nNeed to create access rules first then verify them.","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            CONF.access_types_mapping.get(cls.protocol, []))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_list_access_rule_for_share(self):"},{"line_number":51,"context_line":"        self.user_client.list_access(self.share[\u0027id\u0027])"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _create_delete_access_rule(self, access_type, access_to, share_id):"},{"line_number":54,"context_line":"        access \u003d self.user_client.access_allow(share_id, access_type,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_fc26fecc","line":51,"in_reply_to":"ba3cc151_95103daa","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertEqual(share_id, access.get(\u0027share_id\u0027))"},{"line_number":58,"context_line":"        self.assertEqual(access_type, access.get(\u0027access_type\u0027))"},{"line_number":59,"context_line":"        self.assertEqual(access_to.replace(\u0027\\\\\\\\\u0027, \u0027\\\\\u0027),"},{"line_number":60,"context_line":"                         access.get(\u0027access_to\u0027))"},{"line_number":61,"context_line":"        self.assertEqual(self.access_level, access.get(\u0027access_level\u0027))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_f59e6962","line":59,"updated":"2015-07-06 17:35:42.000000000","message":"Why do you need replacement here?","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertEqual(share_id, access.get(\u0027share_id\u0027))"},{"line_number":58,"context_line":"        self.assertEqual(access_type, access.get(\u0027access_type\u0027))"},{"line_number":59,"context_line":"        self.assertEqual(access_to.replace(\u0027\\\\\\\\\u0027, \u0027\\\\\u0027),"},{"line_number":60,"context_line":"                         access.get(\u0027access_to\u0027))"},{"line_number":61,"context_line":"        self.assertEqual(self.access_level, access.get(\u0027access_level\u0027))"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_e21ad86e","line":59,"in_reply_to":"ba3cc151_f59e6962","updated":"2015-07-08 10:23:04.000000000","message":"For case with user access rules, when access_to is in \"DOMAIN\\\\User\" format.","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.user_client.wait_for_access_rule_status(access[\u0027id\u0027], share_id)"},{"line_number":64,"context_line":"        self.user_client.access_deny(share_id, access[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.user_client.wait_for_access_rule_status(access[\u0027id\u0027], share_id,"},{"line_number":66,"context_line":"                                                     state\u003d\u0027deleted\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertIsNone(self.user_client.get_access(access[\u0027id\u0027], share_id))"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_c3cff2b1","line":66,"updated":"2015-07-06 17:35:42.000000000","message":"Resources with \"deleted\" state are invisible for API. So, here we should use \"self.assertRaises(NotFound, ...)\"","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.user_client.wait_for_access_rule_status(access[\u0027id\u0027], share_id)"},{"line_number":64,"context_line":"        self.user_client.access_deny(share_id, access[\u0027id\u0027])"},{"line_number":65,"context_line":"        self.user_client.wait_for_access_rule_status(access[\u0027id\u0027], share_id,"},{"line_number":66,"context_line":"                                                     state\u003d\u0027deleted\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self.assertIsNone(self.user_client.get_access(access[\u0027id\u0027], share_id))"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_ab190b8a","line":66,"in_reply_to":"ba3cc151_c3cff2b1","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_delete_ip_access_rule(self):"},{"line_number":71,"context_line":"        if \u0027ip\u0027 not in self.access_types:"},{"line_number":72,"context_line":"            raise self.skipException(\"IP access rule is disabled\")"},{"line_number":73,"context_line":"        self._create_delete_access_rule(\u0027ip\u0027, \u002710.0.0.1\u0027,"},{"line_number":74,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_635b8655","line":72,"updated":"2015-07-06 17:35:42.000000000","message":"... for protocol \u003cfoo\u003e","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_delete_ip_access_rule(self):"},{"line_number":71,"context_line":"        if \u0027ip\u0027 not in self.access_types:"},{"line_number":72,"context_line":"            raise self.skipException(\"IP access rule is disabled\")"},{"line_number":73,"context_line":"        self._create_delete_access_rule(\u0027ip\u0027, \u002710.0.0.1\u0027,"},{"line_number":74,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_cb1ecf6f","line":72,"in_reply_to":"ba3cc151_635b8655","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_create_delete_user_access_rule(self):"},{"line_number":77,"context_line":"        if \u0027user\u0027 not in self.access_types:"},{"line_number":78,"context_line":"            raise self.skipException(\"User access rule is disabled\")"},{"line_number":79,"context_line":"        self._create_delete_access_rule(\u0027user\u0027, CONF.username_for_user_rules,"},{"line_number":80,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_a33f4ed5","line":78,"updated":"2015-07-06 17:35:42.000000000","message":"... for protocol \u003cfoo\u003e","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_create_delete_user_access_rule(self):"},{"line_number":77,"context_line":"        if \u0027user\u0027 not in self.access_types:"},{"line_number":78,"context_line":"            raise self.skipException(\"User access rule is disabled\")"},{"line_number":79,"context_line":"        self._create_delete_access_rule(\u0027user\u0027, CONF.username_for_user_rules,"},{"line_number":80,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_8b14474d","line":78,"in_reply_to":"ba3cc151_a33f4ed5","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7bc2832eb075b4934cb0a760fe56efa79225ec98","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_create_delete_cert_access_rule(self):"},{"line_number":83,"context_line":"        if \u0027cert\u0027 not in self.access_types:"},{"line_number":84,"context_line":"            raise self.skipException(\"Cert access rule is disabled\")"},{"line_number":85,"context_line":"        self._create_delete_access_rule(\u0027cert\u0027, \u0027tenant.example.com\u0027,"},{"line_number":86,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_c330520a","line":84,"updated":"2015-07-06 17:35:42.000000000","message":"... for protocol \u003cfoo\u003e","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"56f72694b305e738da91b32e76c3040a29052071","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def test_create_delete_cert_access_rule(self):"},{"line_number":83,"context_line":"        if \u0027cert\u0027 not in self.access_types:"},{"line_number":84,"context_line":"            raise self.skipException(\"Cert access rule is disabled\")"},{"line_number":85,"context_line":"        self._create_delete_access_rule(\u0027cert\u0027, \u0027tenant.example.com\u0027,"},{"line_number":86,"context_line":"                                        self.share[\u0027id\u0027])"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_2b0e5b3b","line":84,"in_reply_to":"ba3cc151_c330520a","updated":"2015-07-08 10:23:04.000000000","message":"Done","commit_id":"fdf4d0f3e1b0ed3f66a03da4513648d353c7a332"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":21,"context_line":"CONF \u003d config.CONF"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def get_list_from_string(values_list):"},{"line_number":25,"context_line":"    return[val for val in values_list.split(\u0027 \u0027) if val]"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_2ce80ce2","line":24,"updated":"2015-07-13 10:47:06.000000000","message":"Left-over.","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ab26df8f92a3a8387ca9630321b9a90370103a03","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.assertTrue(any("},{"line_number":73,"context_line":"            [item for item in access_list if access[\u0027id\u0027] \u003d\u003d item[\u0027id\u0027]]))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _create_delete_access_rule(self, access_type, access_to, share_id):"},{"line_number":76,"context_line":"        access \u003d self.user_client.access_allow(share_id, access_type,"},{"line_number":77,"context_line":"                                               access_to, self.access_level)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a41bdd9_4cc23087","line":75,"updated":"2015-07-13 10:47:06.000000000","message":"For compatibility reasons I suggest to set param \"share_id\" as first.","commit_id":"89ff73ce4a79f994131d663e3bdcc2dfa6460cee"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"907eda4269ad4cba140e7fbe892c691cbe6a5e43","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        cls.access_types \u003d [val for val in CONF.access_types_mapping.get("},{"line_number":47,"context_line":"            cls.protocol, \u0027\u0027).split(\u0027 \u0027) if val]"},{"line_number":48,"context_line":"        if not cls.access_types:"},{"line_number":49,"context_line":"            raise cls.skipException(\"No access levels were provided for %s \""},{"line_number":50,"context_line":"                                    \"share access tests.\" % cls.protoco)"},{"line_number":51,"context_line":"        cls.access_to \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_05020d0a","line":48,"updated":"2015-07-16 08:06:52.000000000","message":"This check should be performed after share creation to avoid redundant actions.","commit_id":"bea0dbe750a600461fbb78fe235ed2800add07e3"},{"author":{"_account_id":7331,"name":"Julia Varlamova","email":"jvarlamova@mirantis.com","username":"jvarlamova"},"change_message_id":"08bb34a3121083b04c264d8a65c3ac1a181bbf3d","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        cls.access_types \u003d [val for val in CONF.access_types_mapping.get("},{"line_number":47,"context_line":"            cls.protocol, \u0027\u0027).split(\u0027 \u0027) if val]"},{"line_number":48,"context_line":"        if not cls.access_types:"},{"line_number":49,"context_line":"            raise cls.skipException(\"No access levels were provided for %s \""},{"line_number":50,"context_line":"                                    \"share access tests.\" % cls.protoco)"},{"line_number":51,"context_line":"        cls.access_to \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_1b6905f9","line":48,"in_reply_to":"9a41bdd9_05020d0a","updated":"2015-07-16 11:35:15.000000000","message":"Seems that it would be even better to perform this check before share creation.","commit_id":"bea0dbe750a600461fbb78fe235ed2800add07e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9092f93313faea72d394b4c0f2ca95cf07e8ae","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        cls.access_types \u003d [val for val in CONF.access_types_mapping.get("},{"line_number":47,"context_line":"            cls.protocol, \u0027\u0027).split(\u0027 \u0027) if val]"},{"line_number":48,"context_line":"        if not cls.access_types:"},{"line_number":49,"context_line":"            raise cls.skipException(\"No access levels were provided for %s \""},{"line_number":50,"context_line":"                                    \"share access tests.\" % cls.protoco)"},{"line_number":51,"context_line":"        cls.access_to \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a41bdd9_6ac71996","line":48,"in_reply_to":"9a41bdd9_1b6905f9","updated":"2015-07-16 11:37:35.000000000","message":"Right \u003d) I wanted to say exactly this. And wonder how come my comment has word \"after\" \u003d)","commit_id":"bea0dbe750a600461fbb78fe235ed2800add07e3"}]}
