)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"5051b299f98f49f3c063205fb13163b93209e1eb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"create, update, read, and delete for consistency groups and consistency"},{"line_number":12,"context_line":"group snapshots."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements bp: manila-client-consistency-groups"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia2760156ab289f127fd7411a7b9a13a371f5129c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_d7d6b6c2","line":14,"updated":"2015-08-24 14:22:11.000000000","message":"Your blueprint was on the wrong project so I have moved it and changed its name. Please update the commit message.\n\nhttps://blueprints.launchpad.net/python-manilaclient/+spec/manila-consistency-groups","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"dde16f50c654dc42baad0e91b555c194e249d4f3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"create, update, read, and delete for consistency groups and consistency"},{"line_number":12,"context_line":"group snapshots."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implements bp: manila-client-consistency-groups"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia2760156ab289f127fd7411a7b9a13a371f5129c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_a28bbb67","line":14,"in_reply_to":"fa1b9901_d7d6b6c2","updated":"2015-08-24 15:16:44.000000000","message":"Nm I renamed the BP to match.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"61bbf03e93642661b5816e0e221e3fcb16c604e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add consistency group support to manila client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can add support to the python-manilaclient for the Consistency Group"},{"line_number":10,"context_line":"feature in Manila Core. The client will support calls to the API to"},{"line_number":11,"context_line":"create, update, read, and delete for consistency groups and consistency"},{"line_number":12,"context_line":"group snapshots."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_c34c9e78","line":9,"updated":"2015-09-10 09:03:46.000000000","message":"\"we can add...\" is not good way to describe changes in commit message.\n\nShould be something similar:\n\n\"\"\"\n\nAdd support for recently implemented Manila features:\n\n- consistency groups\n\n- consistency groups snapshots\n\n\"\"\"\n\nAlso could be added small notes, that, you think, can be useful for reader.","commit_id":"6202669d56bd10014d4cb14b4174aece3303005d"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"0c05972b4f398c371cda0820b7c142e492366d96","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add consistency group support to manila client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can add support to the python-manilaclient for the Consistency Group"},{"line_number":10,"context_line":"feature in Manila Core. The client will support calls to the API to"},{"line_number":11,"context_line":"create, update, read, and delete for consistency groups and consistency"},{"line_number":12,"context_line":"group snapshots."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_743d3cdc","line":9,"in_reply_to":"da20952f_c34c9e78","updated":"2015-09-10 15:50:07.000000000","message":"Done","commit_id":"6202669d56bd10014d4cb14b4174aece3303005d"}],"manilaclient/openstack/common/apiclient/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        except exceptions.NotFound:"},{"line_number":73,"context_line":"            msg \u003d _(\"No %(name)s with a name or \""},{"line_number":74,"context_line":"                    \"ID of \u0027%(name_or_id)s\u0027 exists.\") % \\"},{"line_number":75,"context_line":"                {\"name\": manager.resource_class.__name__.lower(),"},{"line_number":76,"context_line":"                 \"name_or_id\": name_or_id}"},{"line_number":77,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":78,"context_line":"    except exceptions.NoUniqueMatch:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c06c809e","line":75,"updated":"2015-08-25 10:02:52.000000000","message":"It is common code from oslo incubator. It can be only sync\u0027ed, not changed manually.\n\nAlso, this change is unrelated to goal of commit.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        except exceptions.NotFound:"},{"line_number":73,"context_line":"            msg \u003d _(\"No %(name)s with a name or \""},{"line_number":74,"context_line":"                    \"ID of \u0027%(name_or_id)s\u0027 exists.\") % \\"},{"line_number":75,"context_line":"                {\"name\": manager.resource_class.__name__.lower(),"},{"line_number":76,"context_line":"                 \"name_or_id\": name_or_id}"},{"line_number":77,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":78,"context_line":"    except exceptions.NoUniqueMatch:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_91324ba6","line":75,"in_reply_to":"fa1b9901_c06c809e","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        msg \u003d _(\"Multiple %(name)s matches found for \""},{"line_number":82,"context_line":"                \"\u0027%(name_or_id)s\u0027, use an ID to be more specific.\") % \\"},{"line_number":83,"context_line":"            {\"name\": manager.resource_class.__name__.lower(),"},{"line_number":84,"context_line":"             \"name_or_id\": name_or_id}"},{"line_number":85,"context_line":"        raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0b7a52f1","line":84,"updated":"2015-09-05 06:13:45.000000000","message":"I don\u0027t think this belongs in this patch.","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        msg \u003d _(\"Multiple %(name)s matches found for \""},{"line_number":82,"context_line":"                \"\u0027%(name_or_id)s\u0027, use an ID to be more specific.\") % \\"},{"line_number":83,"context_line":"            {\"name\": manager.resource_class.__name__.lower(),"},{"line_number":84,"context_line":"             \"name_or_id\": name_or_id}"},{"line_number":85,"context_line":"        raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_97068484","line":84,"in_reply_to":"da20952f_0b7a52f1","updated":"2015-09-08 19:07:37.000000000","message":"Was fixing this as it doesn\u0027t pass pep8 check of ./run_tests.sh. It does pass tox -epep8 though.","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"}],"manilaclient/tests/unit/v1/test_consistency_group_snapshots.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                             cg_snapshots.RESOURCES_PATH)"},{"line_number":47,"context_line":"            self.assertEqual(result[\u0027resp_key\u0027],"},{"line_number":48,"context_line":"                             cg_snapshots.RESOURCE_NAME)"},{"line_number":49,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_snapshot_get(self):"},{"line_number":52,"context_line":"        with mock.patch.object(self.manager, \u0027_get\u0027, mock.Mock()):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ab000635","line":49,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock called/called-with","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                             cg_snapshots.RESOURCES_PATH)"},{"line_number":47,"context_line":"            self.assertEqual(result[\u0027resp_key\u0027],"},{"line_number":48,"context_line":"                             cg_snapshots.RESOURCE_NAME)"},{"line_number":49,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_snapshot_get(self):"},{"line_number":52,"context_line":"        with mock.patch.object(self.manager, \u0027_get\u0027, mock.Mock()):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_69ca9a1c","line":49,"in_reply_to":"da20952f_ab000635","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.assertEqual("},{"line_number":67,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":68,"context_line":"                cg_snapshots.RESOURCE_NAME)"},{"line_number":69,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_snapshot_update_obj(self):"},{"line_number":72,"context_line":"        cg_snapshot \u003d self._FakeConsistencyGroupSnapshot()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2bf4f658","line":69,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock _update call","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            self.assertEqual("},{"line_number":67,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":68,"context_line":"                cg_snapshots.RESOURCE_NAME)"},{"line_number":69,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_snapshot_update_obj(self):"},{"line_number":72,"context_line":"        cg_snapshot \u003d self._FakeConsistencyGroupSnapshot()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_09cf5e2a","line":69,"in_reply_to":"da20952f_2bf4f658","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.assertEqual("},{"line_number":81,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":82,"context_line":"                cg_snapshots.RESOURCE_NAME)"},{"line_number":83,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_snapshot_list_not_detailed(self):"},{"line_number":86,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0befb287","line":83,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock _update call","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            self.assertEqual("},{"line_number":81,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":82,"context_line":"                cg_snapshots.RESOURCE_NAME)"},{"line_number":83,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_snapshot_list_not_detailed(self):"},{"line_number":86,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_29d4a2bb","line":83,"in_reply_to":"da20952f_0befb287","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"}],"manilaclient/tests/unit/v1/test_consistency_groups.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            self.assertEqual(result[\u0027url\u0027], consistency_groups.RESOURCES_PATH)"},{"line_number":41,"context_line":"            self.assertEqual(result[\u0027resp_key\u0027],"},{"line_number":42,"context_line":"                             consistency_groups.RESOURCE_NAME)"},{"line_number":43,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_create_with_share_network_id(self):"},{"line_number":46,"context_line":"        resource_name \u003d consistency_groups.RESOURCE_NAME"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_eba03e44","line":43,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock called/called-with","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            self.assertEqual(result[\u0027url\u0027], consistency_groups.RESOURCES_PATH)"},{"line_number":41,"context_line":"            self.assertEqual(result[\u0027resp_key\u0027],"},{"line_number":42,"context_line":"                             consistency_groups.RESOURCE_NAME)"},{"line_number":43,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_create_with_share_network_id(self):"},{"line_number":46,"context_line":"        resource_name \u003d consistency_groups.RESOURCE_NAME"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_89e36ea4","line":43,"in_reply_to":"da20952f_eba03e44","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            self.assertEqual(result[\u0027url\u0027], consistency_groups.RESOURCES_PATH)"},{"line_number":55,"context_line":"            self.assertEqual(result[\u0027resp_key\u0027], resource_name)"},{"line_number":56,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_list_not_detailed(self):"},{"line_number":59,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4b904aed","line":56,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock called/called-with","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            self.assertEqual(result[\u0027url\u0027], consistency_groups.RESOURCES_PATH)"},{"line_number":55,"context_line":"            self.assertEqual(result[\u0027resp_key\u0027], resource_name)"},{"line_number":56,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_list_not_detailed(self):"},{"line_number":59,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_a9e0b297","line":56,"in_reply_to":"da20952f_4b904aed","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            self.assertEqual("},{"line_number":109,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":110,"context_line":"                consistency_groups.RESOURCE_NAME)"},{"line_number":111,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_snapshot_update_obj(self):"},{"line_number":114,"context_line":"        cg_snapshot \u003d self._FakeConsistencyGroupSnapshot()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0bbd7267","line":111,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock called/called-with","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            self.assertEqual("},{"line_number":109,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":110,"context_line":"                consistency_groups.RESOURCE_NAME)"},{"line_number":111,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_snapshot_update_obj(self):"},{"line_number":114,"context_line":"        cg_snapshot \u003d self._FakeConsistencyGroupSnapshot()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_09e67eb0","line":111,"in_reply_to":"da20952f_0bbd7267","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.assertEqual("},{"line_number":123,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":124,"context_line":"                consistency_groups.RESOURCE_NAME)"},{"line_number":125,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_2bc2b6e9","line":125,"updated":"2015-09-05 06:13:45.000000000","message":"test the mock called/called-with","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.assertEqual("},{"line_number":123,"context_line":"                result[\u0027resp_key\u0027],"},{"line_number":124,"context_line":"                consistency_groups.RESOURCE_NAME)"},{"line_number":125,"context_line":"            self.assertEqual(result[\u0027body\u0027], body_expected)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_29eb427a","line":125,"in_reply_to":"da20952f_2bc2b6e9","updated":"2015-09-08 19:07:37.000000000","message":"Done","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"}],"manilaclient/tests/unit/v1/test_shell.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        \u0027--description my_fake_description --name fake_name\u0027,"},{"line_number":1176,"context_line":"    )"},{"line_number":1177,"context_line":"    def test_cg_create(self, data):"},{"line_number":1178,"context_line":"        cmd \u003d \u0027cg-create\u0027 + \u0027 \u0027 + data"},{"line_number":1179,"context_line":"        self.run_command(cmd)"},{"line_number":1180,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/consistency-groups\u0027)"},{"line_number":1181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_8b78a2c5","line":1178,"updated":"2015-09-05 06:13:45.000000000","message":"\u0027 \u0027.join((\u0027cg-create\u0027, data))","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"        \u0027--description my_fake_description --name fake_name\u0027,"},{"line_number":1176,"context_line":"    )"},{"line_number":1177,"context_line":"    def test_cg_create(self, data):"},{"line_number":1178,"context_line":"        cmd \u003d \u0027cg-create\u0027 + \u0027 \u0027 + data"},{"line_number":1179,"context_line":"        self.run_command(cmd)"},{"line_number":1180,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/consistency-groups\u0027)"},{"line_number":1181,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_29a2624c","line":1178,"in_reply_to":"da20952f_8b78a2c5","updated":"2015-09-08 19:07:37.000000000","message":"Stayed with \u0027+\u0027 based on string concatenation used in rest of this file.","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        shell_v1._find_consistency_group.return_value \u003d fcg"},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"        cmd \u003d \u0027cg-snapshot-create\u0027"},{"line_number":1273,"context_line":"        cmd +\u003d \u0027 \u0027 + data"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"        self.run_command(cmd)"},{"line_number":1276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_26050d10","line":1273,"updated":"2015-09-05 06:13:45.000000000","message":"join","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"        shell_v1._find_consistency_group.return_value \u003d fcg"},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"        cmd \u003d \u0027cg-snapshot-create\u0027"},{"line_number":1273,"context_line":"        cmd +\u003d \u0027 \u0027 + data"},{"line_number":1274,"context_line":""},{"line_number":1275,"context_line":"        self.run_command(cmd)"},{"line_number":1276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_e9846ab2","line":1273,"in_reply_to":"da20952f_26050d10","updated":"2015-09-08 19:07:37.000000000","message":"Stayed with \u0027+\u0027 based on string concatenation used in rest of this file.","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"}],"manilaclient/v1/consistency_group_snapshots.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from urllib import urlencode  # noqa"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    from urllib.parse import urlencode  # noqa"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manilaclient import base"},{"line_number":23,"context_line":"from manilaclient.openstack.common.apiclient import base as common_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_4099506d","line":20,"updated":"2015-08-25 10:02:52.000000000","message":"Lines 17-20 can be replaced with following:\n\n\"\"\"\n\nfrom six.moves.urllib.parse import urlencode\n\n\"\"\"","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from urllib import urlencode  # noqa"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    from urllib.parse import urlencode  # noqa"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manilaclient import base"},{"line_number":23,"context_line":"from manilaclient.openstack.common.apiclient import base as common_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_d171a30d","line":20,"in_reply_to":"fa1b9901_4099506d","updated":"2015-08-25 22:11:32.000000000","message":"Using the line from your comment caused the following in \"tox -epep8\":\n  import only modules.\u0027from six.moves.urllib.parse import urlencode\u0027 does not import a module\n\nUsed \"from six.moves.urllib import parse\" as seen in base.py instead.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"61c769f23964c9ff09982dec20a1b9ce5bde22af","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    resource_class \u003d ConsistencyGroupSnapshot"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create(self, consistency_group_id, name\u003dNone, description\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group Snapshot."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param name: text - name of the new cg snapshot"},{"line_number":56,"context_line":"        :param description: text - description of the cg snapshot"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d56c749f","line":53,"updated":"2015-09-09 15:31:30.000000000","message":"Here","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    resource_class \u003d ConsistencyGroupSnapshot"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def create(self, consistency_group_id, name\u003dNone, description\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group Snapshot."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param name: text - name of the new cg snapshot"},{"line_number":56,"context_line":"        :param description: text - description of the cg snapshot"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_352a90e8","line":53,"in_reply_to":"da20952f_d56c749f","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"61c769f23964c9ff09982dec20a1b9ce5bde22af","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                            RESOURCE_NAME)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get(self, cg_snapshot):"},{"line_number":69,"context_line":"        \"\"\"Get a consistency group snapshot."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        :param cg_snapshot: either cg snapshot object or text with"},{"line_number":72,"context_line":"            its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_9566fcb9","line":69,"updated":"2015-09-09 15:31:30.000000000","message":"and here case is not consistent","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                            RESOURCE_NAME)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def get(self, cg_snapshot):"},{"line_number":69,"context_line":"        \"\"\"Get a consistency group snapshot."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        :param cg_snapshot: either cg snapshot object or text with"},{"line_number":72,"context_line":"            its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_15374c4e","line":69,"in_reply_to":"da20952f_9566fcb9","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"61c769f23964c9ff09982dec20a1b9ce5bde22af","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                         RESOURCE_NAME)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update(self, cg_snapshot, **kwargs):"},{"line_number":80,"context_line":"        \"\"\"Updates a consistency group snapshot."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        :param cg_snapshot: either consistency group snapshot object or text"},{"line_number":83,"context_line":"            with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_550704c9","line":80,"updated":"2015-09-09 15:31:30.000000000","message":"ditto","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                         RESOURCE_NAME)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def update(self, cg_snapshot, **kwargs):"},{"line_number":80,"context_line":"        \"\"\"Updates a consistency group snapshot."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        :param cg_snapshot: either consistency group snapshot object or text"},{"line_number":83,"context_line":"            with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b53ea027","line":80,"in_reply_to":"da20952f_550704c9","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"4d569f0470775543c0363924f2296e4b35cac0c2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"A group of snapshots taken of multiple shares.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __repr__(self):"},{"line_number":34,"context_line":"        return \"\u003ccg_snapshots: %s\u003e\" % self.id"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def update(self, **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Update this consistency group snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_14f2e506","line":34,"updated":"2015-09-09 19:22:48.000000000","message":"not consistent with Consistency Group","commit_id":"20e9c719f763b3343737b9fc248a2d523625b2cf"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"20ee53826990bb8079cd446c62820f82ee090e8c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"A group of snapshots taken of multiple shares.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def __repr__(self):"},{"line_number":34,"context_line":"        return \"\u003ccg_snapshots: %s\u003e\" % self.id"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def update(self, **kwargs):"},{"line_number":37,"context_line":"        \"\"\"Update this consistency group snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_78946f43","line":34,"in_reply_to":"da20952f_14f2e506","updated":"2015-09-09 21:49:04.000000000","message":"Changed to make this consistent with Consistency Group. New string will be \"\u003cConsistency Group Snapshot: %s\u003e\" which also matches the class name.","commit_id":"20e9c719f763b3343737b9fc248a2d523625b2cf"}],"manilaclient/v1/consistency_groups.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"Interface for consistency groups extension.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from urllib import urlencode  # noqa"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    from urllib.parse import urlencode  # noqa"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a02e2cf8","line":18,"updated":"2015-08-25 10:02:52.000000000","message":"same here as in https://review.openstack.org/#/c/215351/1/manilaclient/v1/consistency_group_snapshots.py","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\"\"\"Interface for consistency groups extension.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"try:"},{"line_number":18,"context_line":"    from urllib import urlencode  # noqa"},{"line_number":19,"context_line":"except ImportError:"},{"line_number":20,"context_line":"    from urllib.parse import urlencode  # noqa"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_11539b6c","line":18,"in_reply_to":"fa1b9901_a02e2cf8","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"16a2c43cfbaf2b3a38af018d419f43efe2e13954","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param share_network: text - The uuid of the share_network to use"},{"line_number":56,"context_line":"        when creating a consistency group with multi-svm capabilities."},{"line_number":57,"context_line":"        :param name: text - name of the new consistency group"},{"line_number":58,"context_line":"        :param description: text - description of the consistency group"},{"line_number":59,"context_line":"        :param source_cgsnapshot_id: text - The uuid of the cgsnapshot from"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_0627a9b6","line":56,"updated":"2015-09-05 06:13:45.000000000","message":"the indent looks wrong here (unless that\u0027s just a diff thing?)","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db60689fe5b405f99dc9fc536bc5d046a06b3055","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param share_network: text - The uuid of the share_network to use"},{"line_number":56,"context_line":"        when creating a consistency group with multi-svm capabilities."},{"line_number":57,"context_line":"        :param name: text - name of the new consistency group"},{"line_number":58,"context_line":"        :param description: text - description of the consistency group"},{"line_number":59,"context_line":"        :param source_cgsnapshot_id: text - The uuid of the cgsnapshot from"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_c9ae462f","line":56,"in_reply_to":"da20952f_0627a9b6","updated":"2015-09-08 19:07:37.000000000","message":"Maybe a diff thing. The indent matches multi line comments in other files from what I can see.","commit_id":"a6aaf487e7f91d8031d5cff9a88a5ab9ef5b955f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cddb976e4d1c102620803e4419010046c5034f0b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def create(self, share_network\u003dNone, name\u003dNone, description\u003dNone,"},{"line_number":52,"context_line":"               source_cgsnapshot_id\u003dNone, share_types\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param share_network: text - The uuid of the share_network to use"},{"line_number":56,"context_line":"        when creating a consistency group with multi-svm capabilities."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_55eb8412","line":53,"updated":"2015-09-09 15:30:30.000000000","message":"Consistency Group - starts from upper case","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def create(self, share_network\u003dNone, name\u003dNone, description\u003dNone,"},{"line_number":52,"context_line":"               source_cgsnapshot_id\u003dNone, share_types\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param share_network: text - The uuid of the share_network to use"},{"line_number":56,"context_line":"        when creating a consistency group with multi-svm capabilities."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_355ff076","line":53,"in_reply_to":"da20952f_55eb8412","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cddb976e4d1c102620803e4419010046c5034f0b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                            {RESOURCE_NAME: body}, RESOURCE_NAME)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get(self, consistency_group):"},{"line_number":86,"context_line":"        \"\"\"Get a consistency group."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        :param consistency_group: either consistency group object or text with"},{"line_number":89,"context_line":"            its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_75e6c845","line":86,"updated":"2015-09-09 15:30:30.000000000","message":"consistency group - starts from lower case. It is not consistent with previous.","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                            {RESOURCE_NAME: body}, RESOURCE_NAME)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def get(self, consistency_group):"},{"line_number":86,"context_line":"        \"\"\"Get a consistency group."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        :param consistency_group: either consistency group object or text with"},{"line_number":89,"context_line":"            its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_5562a43e","line":86,"in_reply_to":"da20952f_75e6c845","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"cddb976e4d1c102620803e4419010046c5034f0b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                         RESOURCE_NAME)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update(self, consistency_group, **kwargs):"},{"line_number":97,"context_line":"        \"\"\"Updates a consistency group."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param consistency_group: either consistency group object or text"},{"line_number":100,"context_line":"            with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_35cff0b4","line":97,"updated":"2015-09-09 15:30:30.000000000","message":"ditto","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                         RESOURCE_NAME)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def update(self, consistency_group, **kwargs):"},{"line_number":97,"context_line":"        \"\"\"Updates a consistency group."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        :param consistency_group: either consistency group object or text"},{"line_number":100,"context_line":"            with its ID."}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_155c2c7c","line":97,"in_reply_to":"da20952f_35cff0b4","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"4d569f0470775543c0363924f2296e4b35cac0c2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class ConsistencyGroup(common_base.Resource):"},{"line_number":30,"context_line":"    \"\"\"A consistency group is a logical grouping of shares.\"\"\""},{"line_number":31,"context_line":"    def __repr__(self):"},{"line_number":32,"context_line":"        return \"\u003cConsistency Group: %s\u003e\" % self.id"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def update(self, **kwargs):"},{"line_number":35,"context_line":"        \"\"\"Update this consistency group.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b48a1963","line":32,"updated":"2015-09-09 19:22:48.000000000","message":"not consistent with cg_snapshots","commit_id":"20e9c719f763b3343737b9fc248a2d523625b2cf"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"20ee53826990bb8079cd446c62820f82ee090e8c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"class ConsistencyGroup(common_base.Resource):"},{"line_number":30,"context_line":"    \"\"\"A consistency group is a logical grouping of shares.\"\"\""},{"line_number":31,"context_line":"    def __repr__(self):"},{"line_number":32,"context_line":"        return \"\u003cConsistency Group: %s\u003e\" % self.id"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def update(self, **kwargs):"},{"line_number":35,"context_line":"        \"\"\"Update this consistency group.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_58ebabdc","line":32,"in_reply_to":"da20952f_b48a1963","updated":"2015-09-09 21:49:04.000000000","message":"Done","commit_id":"20e9c719f763b3343737b9fc248a2d523625b2cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"61bbf03e93642661b5816e0e221e3fcb16c604e7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               source_cgsnapshot_id\u003dNone, share_types\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param share_network: text - The uuid of the share_network to use"},{"line_number":56,"context_line":"        when creating a consistency group with multi-svm capabilities."},{"line_number":57,"context_line":"        :param name: text - name of the new consistency group"},{"line_number":58,"context_line":"        :param description: text - description of the consistency group"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_60f348a0","line":55,"updated":"2015-09-10 09:03:46.000000000","message":"Here you say that it is only \"UUID\".","commit_id":"6202669d56bd10014d4cb14b4174aece3303005d"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"0c05972b4f398c371cda0820b7c142e492366d96","unresolved":false,"context_lines":[{"line_number":52,"context_line":"               source_cgsnapshot_id\u003dNone, share_types\u003dNone):"},{"line_number":53,"context_line":"        \"\"\"Create a Consistency Group."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param share_network: text - The uuid of the share_network to use"},{"line_number":56,"context_line":"        when creating a consistency group with multi-svm capabilities."},{"line_number":57,"context_line":"        :param name: text - name of the new consistency group"},{"line_number":58,"context_line":"        :param description: text - description of the consistency group"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_74845c0a","line":55,"in_reply_to":"da20952f_60f348a0","updated":"2015-09-10 15:50:07.000000000","message":"Done","commit_id":"6202669d56bd10014d4cb14b4174aece3303005d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"61bbf03e93642661b5816e0e221e3fcb16c604e7","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        share_network_id \u003d None"},{"line_number":74,"context_line":"        if share_network:"},{"line_number":75,"context_line":"            share_network_id \u003d common_base.getid(share_network)"},{"line_number":76,"context_line":"        if share_network_id:"},{"line_number":77,"context_line":"            body[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":78,"context_line":"        if source_cgsnapshot_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_00492cd0","line":75,"updated":"2015-09-10 09:03:46.000000000","message":"But here expect both - object with ID and UUID string. So, one of these should be changed to be consistent. In other places in this module you provide correct info.","commit_id":"6202669d56bd10014d4cb14b4174aece3303005d"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"0c05972b4f398c371cda0820b7c142e492366d96","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        share_network_id \u003d None"},{"line_number":74,"context_line":"        if share_network:"},{"line_number":75,"context_line":"            share_network_id \u003d common_base.getid(share_network)"},{"line_number":76,"context_line":"        if share_network_id:"},{"line_number":77,"context_line":"            body[\u0027share_network_id\u0027] \u003d share_network_id"},{"line_number":78,"context_line":"        if source_cgsnapshot_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_d4752832","line":75,"in_reply_to":"da20952f_00492cd0","updated":"2015-09-10 15:50:07.000000000","message":"Done","commit_id":"6202669d56bd10014d4cb14b4174aece3303005d"}],"manilaclient/v1/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    type\u003dstr,"},{"line_number":428,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":429,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":430,"context_line":"    help\u003d\u0027Metadata key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":431,"context_line":"    default\u003dNone)"},{"line_number":432,"context_line":"@cliutils.arg("},{"line_number":433,"context_line":"    \u0027--share-network\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e072e410","line":430,"updated":"2015-08-25 10:02:52.000000000","message":"This change is unrelated to the goal of commit.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    type\u003dstr,"},{"line_number":428,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":429,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":430,"context_line":"    help\u003d\u0027Metadata key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":431,"context_line":"    default\u003dNone)"},{"line_number":432,"context_line":"@cliutils.arg("},{"line_number":433,"context_line":"    \u0027--share-network\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_60379b4d","line":430,"in_reply_to":"fa1b9901_e072e410","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":583,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":584,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":585,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":586,"context_line":"    default\u003dNone)"},{"line_number":587,"context_line":"def do_manage(cs, args):"},{"line_number":588,"context_line":"    \"\"\"Manage share not handled by Manila.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_80c76811","line":585,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":582,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":583,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":584,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":585,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":586,"context_line":"    default\u003dNone)"},{"line_number":587,"context_line":"def do_manage(cs, args):"},{"line_number":588,"context_line":"    \"\"\"Manage share not handled by Manila.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_40093783","line":585,"in_reply_to":"fa1b9901_80c76811","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":677,"context_line":"@cliutils.arg("},{"line_number":678,"context_line":"    \u0027--access-level\u0027,"},{"line_number":679,"context_line":"    \u0027--access_level\u0027,"},{"line_number":680,"context_line":"    metavar\u003d\u0027\u003caccess_level\u003e\u0027,"},{"line_number":681,"context_line":"    type\u003dstr,"},{"line_number":682,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_40d150cc","line":679,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":676,"context_line":"    help\u003d\u0027Value that defines access.\u0027)"},{"line_number":677,"context_line":"@cliutils.arg("},{"line_number":678,"context_line":"    \u0027--access-level\u0027,"},{"line_number":679,"context_line":"    \u0027--access_level\u0027,"},{"line_number":680,"context_line":"    metavar\u003d\u0027\u003caccess_level\u003e\u0027,"},{"line_number":681,"context_line":"    type\u003dstr,"},{"line_number":682,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e0716b0d","line":679,"in_reply_to":"fa1b9901_40d150cc","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    type\u003dstr,"},{"line_number":755,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":756,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":757,"context_line":"    help\u003d\u0027Filters results by a metadata key and value. (Default\u003dNone)\u0027,"},{"line_number":758,"context_line":"    default\u003dNone)"},{"line_number":759,"context_line":"@cliutils.arg("},{"line_number":760,"context_line":"    \u0027--extra-specs\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_60d494bc","line":757,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    type\u003dstr,"},{"line_number":755,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":756,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":757,"context_line":"    help\u003d\u0027Filters results by a metadata key and value. (Default\u003dNone)\u0027,"},{"line_number":758,"context_line":"    default\u003dNone)"},{"line_number":759,"context_line":"@cliutils.arg("},{"line_number":760,"context_line":"    \u0027--extra-specs\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_40ce172e","line":757,"in_reply_to":"fa1b9901_60d494bc","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":765,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":766,"context_line":"    help\u003d\u0027Filters results by a extra specs key and value of share type that \u0027"},{"line_number":767,"context_line":"         \u0027was used for share creation. (Default\u003dNone)\u0027,"},{"line_number":768,"context_line":"    default\u003dNone)"},{"line_number":769,"context_line":"@cliutils.arg("},{"line_number":770,"context_line":"    \u0027--share-type\u0027, \u0027--volume-type\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_00dcb8e2","line":767,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":764,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":765,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":766,"context_line":"    help\u003d\u0027Filters results by a extra specs key and value of share type that \u0027"},{"line_number":767,"context_line":"         \u0027was used for share creation. (Default\u003dNone)\u0027,"},{"line_number":768,"context_line":"    default\u003dNone)"},{"line_number":769,"context_line":"@cliutils.arg("},{"line_number":770,"context_line":"    \u0027--share-type\u0027, \u0027--volume-type\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a09b7317","line":767,"in_reply_to":"fa1b9901_00dcb8e2","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":782,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"},{"line_number":783,"context_line":"    type\u003dint,"},{"line_number":784,"context_line":"    default\u003dNone,"},{"line_number":785,"context_line":"    help\u003d\u0027Maximum number of shares to return. (Default\u003dNone)\u0027)"},{"line_number":786,"context_line":"@cliutils.arg("},{"line_number":787,"context_line":"    \u0027--offset\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003coffset\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_20d77cc0","line":785,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":782,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"},{"line_number":783,"context_line":"    type\u003dint,"},{"line_number":784,"context_line":"    default\u003dNone,"},{"line_number":785,"context_line":"    help\u003d\u0027Maximum number of shares to return. (Default\u003dNone)\u0027)"},{"line_number":786,"context_line":"@cliutils.arg("},{"line_number":787,"context_line":"    \u0027--offset\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003coffset\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_40b3779a","line":785,"in_reply_to":"fa1b9901_20d77cc0","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":788,"context_line":"    metavar\u003d\u0027\u003coffset\u003e\u0027,"},{"line_number":789,"context_line":"    type\u003dint,"},{"line_number":790,"context_line":"    default\u003dNone,"},{"line_number":791,"context_line":"    help\u003d\u0027Set offset to define start point of share listing. (Default\u003dNone)\u0027)"},{"line_number":792,"context_line":"@cliutils.arg("},{"line_number":793,"context_line":"    \u0027--sort-key\u0027,"},{"line_number":794,"context_line":"    \u0027--sort_key\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a0f14c6c","line":791,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":788,"context_line":"    metavar\u003d\u0027\u003coffset\u003e\u0027,"},{"line_number":789,"context_line":"    type\u003dint,"},{"line_number":790,"context_line":"    default\u003dNone,"},{"line_number":791,"context_line":"    help\u003d\u0027Set offset to define start point of share listing. (Default\u003dNone)\u0027)"},{"line_number":792,"context_line":"@cliutils.arg("},{"line_number":793,"context_line":"    \u0027--sort-key\u0027,"},{"line_number":794,"context_line":"    \u0027--sort_key\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e0a40b4c","line":791,"in_reply_to":"fa1b9901_a0f14c6c","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":797,"context_line":"    default\u003dNone,"},{"line_number":798,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":799,"context_line":"    help\u003d\u0027Key to be sorted, available keys are %(keys)s. \u0027"},{"line_number":800,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027keys\u0027: constants.SHARE_SORT_KEY_VALUES})"},{"line_number":801,"context_line":"@cliutils.arg("},{"line_number":802,"context_line":"    \u0027--sort-dir\u0027,"},{"line_number":803,"context_line":"    \u0027--sort_dir\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_20fe9c38","line":800,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":797,"context_line":"    default\u003dNone,"},{"line_number":798,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":799,"context_line":"    help\u003d\u0027Key to be sorted, available keys are %(keys)s. \u0027"},{"line_number":800,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027keys\u0027: constants.SHARE_SORT_KEY_VALUES})"},{"line_number":801,"context_line":"@cliutils.arg("},{"line_number":802,"context_line":"    \u0027--sort-dir\u0027,"},{"line_number":803,"context_line":"    \u0027--sort_dir\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_205d2347","line":800,"in_reply_to":"fa1b9901_20fe9c38","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    default\u003dNone,"},{"line_number":807,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":808,"context_line":"    help\u003d\u0027Sort direction, available values are %(values)s. \u0027"},{"line_number":809,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027values\u0027: constants.SORT_DIR_VALUES})"},{"line_number":810,"context_line":"@cliutils.arg("},{"line_number":811,"context_line":"    \u0027--snapshot\u0027,"},{"line_number":812,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e0f74457","line":809,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":806,"context_line":"    default\u003dNone,"},{"line_number":807,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":808,"context_line":"    help\u003d\u0027Sort direction, available values are %(values)s. \u0027"},{"line_number":809,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027values\u0027: constants.SORT_DIR_VALUES})"},{"line_number":810,"context_line":"@cliutils.arg("},{"line_number":811,"context_line":"    \u0027--snapshot\u0027,"},{"line_number":812,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_8032ef0e","line":809,"in_reply_to":"fa1b9901_e0f74457","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":820,"context_line":"    help\u003d\u0027Filter results by host.\u0027)"},{"line_number":821,"context_line":"@cliutils.arg("},{"line_number":822,"context_line":"    \u0027--share-network\u0027,"},{"line_number":823,"context_line":"    \u0027--share_network\u0027,"},{"line_number":824,"context_line":"    metavar\u003d\u0027\u003cshare_network\u003e\u0027,"},{"line_number":825,"context_line":"    type\u003dstr,"},{"line_number":826,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_809528e5","line":823,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":820,"context_line":"    help\u003d\u0027Filter results by host.\u0027)"},{"line_number":821,"context_line":"@cliutils.arg("},{"line_number":822,"context_line":"    \u0027--share-network\u0027,"},{"line_number":823,"context_line":"    \u0027--share_network\u0027,"},{"line_number":824,"context_line":"    metavar\u003d\u0027\u003cshare_network\u003e\u0027,"},{"line_number":825,"context_line":"    type\u003dstr,"},{"line_number":826,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_603d5bdc","line":823,"in_reply_to":"fa1b9901_809528e5","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    help\u003d\u0027Filter results by share-network name or id.\u0027)"},{"line_number":829,"context_line":"@cliutils.arg("},{"line_number":830,"context_line":"    \u0027--project-id\u0027,"},{"line_number":831,"context_line":"    \u0027--project_id\u0027,"},{"line_number":832,"context_line":"    metavar\u003d\u0027\u003cproject_id\u003e\u0027,"},{"line_number":833,"context_line":"    type\u003dstr,"},{"line_number":834,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_409f1003","line":831,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":828,"context_line":"    help\u003d\u0027Filter results by share-network name or id.\u0027)"},{"line_number":829,"context_line":"@cliutils.arg("},{"line_number":830,"context_line":"    \u0027--project-id\u0027,"},{"line_number":831,"context_line":"    \u0027--project_id\u0027,"},{"line_number":832,"context_line":"    metavar\u003d\u0027\u003cproject_id\u003e\u0027,"},{"line_number":833,"context_line":"    type\u003dstr,"},{"line_number":834,"context_line":"    default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a01e136e","line":831,"in_reply_to":"fa1b9901_409f1003","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":935,"context_line":"    const\u003d\u0027any\u0027,"},{"line_number":936,"context_line":"    default\u003dNone,"},{"line_number":937,"context_line":"    choices\u003d[\u0027any\u0027, \u0027used\u0027, \u0027unused\u0027, ],"},{"line_number":938,"context_line":"    help\u003d\u0027Either filter or not snapshots by its usage. (Default\u003dAny)\u0027)"},{"line_number":939,"context_line":"@cliutils.arg("},{"line_number":940,"context_line":"    \u0027--limit\u0027,"},{"line_number":941,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_a0662c27","line":938,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":935,"context_line":"    const\u003d\u0027any\u0027,"},{"line_number":936,"context_line":"    default\u003dNone,"},{"line_number":937,"context_line":"    choices\u003d[\u0027any\u0027, \u0027used\u0027, \u0027unused\u0027, ],"},{"line_number":938,"context_line":"    help\u003d\u0027Either filter or not snapshots by its usage. (Default\u003dAny)\u0027)"},{"line_number":939,"context_line":"@cliutils.arg("},{"line_number":940,"context_line":"    \u0027--limit\u0027,"},{"line_number":941,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_bb1ac86d","line":938,"in_reply_to":"fa1b9901_a0662c27","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":941,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"},{"line_number":942,"context_line":"    type\u003dint,"},{"line_number":943,"context_line":"    default\u003dNone,"},{"line_number":944,"context_line":"    help\u003d\u0027Maximum number of share snapshots to return. (Default\u003dNone)\u0027)"},{"line_number":945,"context_line":"@cliutils.arg("},{"line_number":946,"context_line":"    \u0027--offset\u0027,"},{"line_number":947,"context_line":"    metavar\u003d\u0027\u003coffset\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e0a50447","line":944,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":941,"context_line":"    metavar\u003d\u0027\u003climit\u003e\u0027,"},{"line_number":942,"context_line":"    type\u003dint,"},{"line_number":943,"context_line":"    default\u003dNone,"},{"line_number":944,"context_line":"    help\u003d\u0027Maximum number of share snapshots to return. (Default\u003dNone)\u0027)"},{"line_number":945,"context_line":"@cliutils.arg("},{"line_number":946,"context_line":"    \u0027--offset\u0027,"},{"line_number":947,"context_line":"    metavar\u003d\u0027\u003coffset\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_fb42803d","line":944,"in_reply_to":"fa1b9901_e0a50447","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":948,"context_line":"    type\u003dint,"},{"line_number":949,"context_line":"    default\u003dNone,"},{"line_number":950,"context_line":"    help\u003d\u0027Set offset to define start point of share snapshots listing. \u0027"},{"line_number":951,"context_line":"         \u0027(Default\u003dNone)\u0027)"},{"line_number":952,"context_line":"@cliutils.arg("},{"line_number":953,"context_line":"    \u0027--sort-key\u0027,"},{"line_number":954,"context_line":"    \u0027--sort_key\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c0aa4019","line":951,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":948,"context_line":"    type\u003dint,"},{"line_number":949,"context_line":"    default\u003dNone,"},{"line_number":950,"context_line":"    help\u003d\u0027Set offset to define start point of share snapshots listing. \u0027"},{"line_number":951,"context_line":"         \u0027(Default\u003dNone)\u0027)"},{"line_number":952,"context_line":"@cliutils.arg("},{"line_number":953,"context_line":"    \u0027--sort-key\u0027,"},{"line_number":954,"context_line":"    \u0027--sort_key\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_db5c5c1b","line":951,"in_reply_to":"fa1b9901_c0aa4019","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":957,"context_line":"    default\u003dNone,"},{"line_number":958,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":959,"context_line":"    help\u003d\u0027Key to be sorted, available keys are %(keys)s. \u0027"},{"line_number":960,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027keys\u0027: constants.SNAPSHOT_SORT_KEY_VALUES})"},{"line_number":961,"context_line":"@cliutils.arg("},{"line_number":962,"context_line":"    \u0027--sort-dir\u0027,"},{"line_number":963,"context_line":"    \u0027--sort_dir\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_20ac5c34","line":960,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":957,"context_line":"    default\u003dNone,"},{"line_number":958,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":959,"context_line":"    help\u003d\u0027Key to be sorted, available keys are %(keys)s. \u0027"},{"line_number":960,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027keys\u0027: constants.SNAPSHOT_SORT_KEY_VALUES})"},{"line_number":961,"context_line":"@cliutils.arg("},{"line_number":962,"context_line":"    \u0027--sort-dir\u0027,"},{"line_number":963,"context_line":"    \u0027--sort_dir\u0027,  # alias"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_7b83d056","line":960,"in_reply_to":"fa1b9901_20ac5c34","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    default\u003dNone,"},{"line_number":967,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":968,"context_line":"    help\u003d\u0027Sort direction, available values are %(values)s. \u0027"},{"line_number":969,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027values\u0027: constants.SORT_DIR_VALUES})"},{"line_number":970,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":971,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":972,"context_line":"    \"\"\"List all the snapshots.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_60b9f478","line":969,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    default\u003dNone,"},{"line_number":967,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":968,"context_line":"    help\u003d\u0027Sort direction, available values are %(values)s. \u0027"},{"line_number":969,"context_line":"         \u0027(Default\u003dNone)\u0027 % {\u0027values\u0027: constants.SORT_DIR_VALUES})"},{"line_number":970,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":971,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":972,"context_line":"    \"\"\"List all the snapshots.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5b7e0c6b","line":969,"in_reply_to":"fa1b9901_60b9f478","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"    \u0027--is-public\u0027,"},{"line_number":1904,"context_line":"    metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":1905,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1906,"context_line":"    help\u003d\"Make type accessible to the public (Default\u003dTrue).\")"},{"line_number":1907,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":1908,"context_line":"def do_type_create(cs, args):"},{"line_number":1909,"context_line":"    \"\"\"Create a new share type.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_40b6308b","line":1906,"updated":"2015-08-25 10:02:52.000000000","message":"Unrelated change too.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":1903,"context_line":"    \u0027--is-public\u0027,"},{"line_number":1904,"context_line":"    metavar\u003d\u0027\u003cis_public\u003e\u0027,"},{"line_number":1905,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1906,"context_line":"    help\u003d\"Make type accessible to the public (Default\u003dTrue).\")"},{"line_number":1907,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":1908,"context_line":"def do_type_create(cs, args):"},{"line_number":1909,"context_line":"    \"\"\"Create a new share type.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_7beaf010","line":1906,"in_reply_to":"fa1b9901_40b6308b","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"    default\u003dNone,"},{"line_number":2094,"context_line":"    help\u003d\u0027Specify share-network name or id.\u0027)"},{"line_number":2095,"context_line":"@cliutils.arg("},{"line_number":2096,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"},{"line_number":2097,"context_line":"    metavar\u003d\u0027\u003csource_cgsnapshot_id\u003e\u0027,"},{"line_number":2098,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":2099,"context_line":"    default\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_005fd841","line":2096,"updated":"2015-08-25 10:02:52.000000000","message":"Please, add aliases here as you did above.","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":2093,"context_line":"    default\u003dNone,"},{"line_number":2094,"context_line":"    help\u003d\u0027Specify share-network name or id.\u0027)"},{"line_number":2095,"context_line":"@cliutils.arg("},{"line_number":2096,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"},{"line_number":2097,"context_line":"    metavar\u003d\u0027\u003csource_cgsnapshot_id\u003e\u0027,"},{"line_number":2098,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":2099,"context_line":"    default\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_3bc79899","line":2096,"in_reply_to":"fa1b9901_005fd841","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"    help\u003d\u0027Specify share-network name or id.\u0027)"},{"line_number":2095,"context_line":"@cliutils.arg("},{"line_number":2096,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"},{"line_number":2097,"context_line":"    metavar\u003d\u0027\u003csource_cgsnapshot_id\u003e\u0027,"},{"line_number":2098,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":2099,"context_line":"    default\u003dNone)"},{"line_number":2100,"context_line":"@cliutils.service_type(\u0027share\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_e0018407","line":2097,"updated":"2015-08-25 10:02:52.000000000","message":"add \"type\u003dstr\"?","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"    help\u003d\u0027Specify share-network name or id.\u0027)"},{"line_number":2095,"context_line":"@cliutils.arg("},{"line_number":2096,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"},{"line_number":2097,"context_line":"    metavar\u003d\u0027\u003csource_cgsnapshot_id\u003e\u0027,"},{"line_number":2098,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":2099,"context_line":"    default\u003dNone)"},{"line_number":2100,"context_line":"@cliutils.service_type(\u0027share\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_5bccccba","line":2097,"in_reply_to":"fa1b9901_e0018407","updated":"2015-08-25 22:11:32.000000000","message":"Done","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ffd2e4f33c696e5af440019fec8cd897f40c5915","unresolved":false,"context_lines":[{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"    share_types \u003d []"},{"line_number":2105,"context_line":"    if args.share_types:"},{"line_number":2106,"context_line":"        s_types \u003d args.share_types.split(\u0027,\u0027)"},{"line_number":2107,"context_line":"        for s_type in s_types:"},{"line_number":2108,"context_line":"            share_type \u003d _find_share_type(cs, s_type)"},{"line_number":2109,"context_line":"            share_types.append(share_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_0026f8cd","line":2106,"updated":"2015-08-25 10:02:52.000000000","message":"Maybe would good to add \"strip(...)\"?","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d0fb61e4a2c858316ca9c208509c67f4f6cd0630","unresolved":false,"context_lines":[{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"    share_types \u003d []"},{"line_number":2105,"context_line":"    if args.share_types:"},{"line_number":2106,"context_line":"        s_types \u003d args.share_types.split(\u0027,\u0027)"},{"line_number":2107,"context_line":"        for s_type in s_types:"},{"line_number":2108,"context_line":"            share_type \u003d _find_share_type(cs, s_type)"},{"line_number":2109,"context_line":"            share_types.append(share_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_dbef79af","line":2106,"in_reply_to":"fa1b9901_0026f8cd","updated":"2015-08-25 22:11:32.000000000","message":"There is another split() called on arguments in the _extract_key_value_options function. This function does not use strip(). It seems inconsistent to support whitespace for an argument at this code point but not support it elsewhere. Should I fix both code points to support whitespace for arguments or fix neither of them in this patch?","commit_id":"fc846386f406a363000c15a17e7095110ad3815a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1c2c935ff24807b714458e46d051f08484a8da4f","unresolved":false,"context_lines":[{"line_number":472,"context_line":"@cliutils.arg("},{"line_number":473,"context_line":"    \u0027--consistency-group\u0027,"},{"line_number":474,"context_line":"    \u0027--consistency_group\u0027,"},{"line_number":475,"context_line":"    \u0027--cg\u0027,"},{"line_number":476,"context_line":"    metavar\u003d\u0027\u003cconsistency-group\u003e\u0027,"},{"line_number":477,"context_line":"    help\u003d\u0027Optional consistency group name or ID in which to create the share. \u0027"},{"line_number":478,"context_line":"         \u0027(Default\u003dNone)\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_aa24fbc5","line":475,"updated":"2015-09-09 15:26:36.000000000","message":"lost \n\n\"\"\"\n\naction\u003d\u0027single_alias\u0027,\n\n\"\"\"","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":472,"context_line":"@cliutils.arg("},{"line_number":473,"context_line":"    \u0027--consistency-group\u0027,"},{"line_number":474,"context_line":"    \u0027--consistency_group\u0027,"},{"line_number":475,"context_line":"    \u0027--cg\u0027,"},{"line_number":476,"context_line":"    metavar\u003d\u0027\u003cconsistency-group\u003e\u0027,"},{"line_number":477,"context_line":"    help\u003d\u0027Optional consistency group name or ID in which to create the share. \u0027"},{"line_number":478,"context_line":"         \u0027(Default\u003dNone)\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_90b36a4d","line":475,"in_reply_to":"da20952f_aa24fbc5","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a5c6d71f0e25f40d075beb7f6890b4640d69de27","unresolved":false,"context_lines":[{"line_number":2127,"context_line":"    \u0027--share_network\u0027,"},{"line_number":2128,"context_line":"    metavar\u003d\u0027\u003cshare_network\u003e\u0027,"},{"line_number":2129,"context_line":"    type\u003dstr,"},{"line_number":2130,"context_line":"    default\u003dNone,"},{"line_number":2131,"context_line":"    help\u003d\u0027Specify share-network name or id.\u0027)"},{"line_number":2132,"context_line":"@cliutils.arg("},{"line_number":2133,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_1522eca3","line":2130,"updated":"2015-09-09 15:28:34.000000000","message":"same here","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":2127,"context_line":"    \u0027--share_network\u0027,"},{"line_number":2128,"context_line":"    metavar\u003d\u0027\u003cshare_network\u003e\u0027,"},{"line_number":2129,"context_line":"    type\u003dstr,"},{"line_number":2130,"context_line":"    default\u003dNone,"},{"line_number":2131,"context_line":"    help\u003d\u0027Specify share-network name or id.\u0027)"},{"line_number":2132,"context_line":"@cliutils.arg("},{"line_number":2133,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b0dc6e75","line":2130,"in_reply_to":"da20952f_1522eca3","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a5c6d71f0e25f40d075beb7f6890b4640d69de27","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"},{"line_number":2134,"context_line":"    \u0027--source_cgsnapshot_id\u0027,"},{"line_number":2135,"context_line":"    metavar\u003d\u0027\u003csource_cgsnapshot_id\u003e\u0027,"},{"line_number":2136,"context_line":"    type\u003dstr,"},{"line_number":2137,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":2138,"context_line":"    default\u003dNone)"},{"line_number":2139,"context_line":"@cliutils.service_type(\u0027share\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_d53474e0","line":2136,"updated":"2015-09-09 15:28:34.000000000","message":"and here","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":2133,"context_line":"    \u0027--source-cgsnapshot-id\u0027,"},{"line_number":2134,"context_line":"    \u0027--source_cgsnapshot_id\u0027,"},{"line_number":2135,"context_line":"    metavar\u003d\u0027\u003csource_cgsnapshot_id\u003e\u0027,"},{"line_number":2136,"context_line":"    type\u003dstr,"},{"line_number":2137,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":2138,"context_line":"    default\u003dNone)"},{"line_number":2139,"context_line":"@cliutils.service_type(\u0027share\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_90e12a2d","line":2136,"in_reply_to":"da20952f_d53474e0","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a5c6d71f0e25f40d075beb7f6890b4640d69de27","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"    help\u003d\u0027Name or ID of the consistency group(s).\u0027)"},{"line_number":2257,"context_line":"@cliutils.arg("},{"line_number":2258,"context_line":"    \u0027--force\u0027,"},{"line_number":2259,"context_line":"    \u0027--force\u0027,"},{"line_number":2260,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2261,"context_line":"    default\u003dFalse,"},{"line_number":2262,"context_line":"    help\u003d\u0027Attempt to force delete the consistency group (Default\u003dFalse).\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_b540e036","line":2259,"updated":"2015-09-09 15:28:34.000000000","message":"redundant line","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":2256,"context_line":"    help\u003d\u0027Name or ID of the consistency group(s).\u0027)"},{"line_number":2257,"context_line":"@cliutils.arg("},{"line_number":2258,"context_line":"    \u0027--force\u0027,"},{"line_number":2259,"context_line":"    \u0027--force\u0027,"},{"line_number":2260,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2261,"context_line":"    default\u003dFalse,"},{"line_number":2262,"context_line":"    help\u003d\u0027Attempt to force delete the consistency group (Default\u003dFalse).\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_70bd7601","line":2259,"in_reply_to":"da20952f_b540e036","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a5c6d71f0e25f40d075beb7f6890b4640d69de27","unresolved":false,"context_lines":[{"line_number":2490,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":2491,"context_line":"    help\u003d\u0027Name or ID of the consistency group snapshot.\u0027)"},{"line_number":2492,"context_line":"@cliutils.arg("},{"line_number":2493,"context_line":"    \u0027--force\u0027,"},{"line_number":2494,"context_line":"    \u0027--force\u0027,"},{"line_number":2495,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2496,"context_line":"    default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_f56c18d2","line":2493,"updated":"2015-09-09 15:28:34.000000000","message":"redundant line too.","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"da1a3a23a29be433968802cd812ca10458b5d786","unresolved":false,"context_lines":[{"line_number":2490,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":2491,"context_line":"    help\u003d\u0027Name or ID of the consistency group snapshot.\u0027)"},{"line_number":2492,"context_line":"@cliutils.arg("},{"line_number":2493,"context_line":"    \u0027--force\u0027,"},{"line_number":2494,"context_line":"    \u0027--force\u0027,"},{"line_number":2495,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2496,"context_line":"    default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_1043da14","line":2493,"in_reply_to":"da20952f_f56c18d2","updated":"2015-09-09 16:29:14.000000000","message":"Done","commit_id":"cab5fa44b087e61b8be58402368ccde3670bbe45"},{"author":{"_account_id":16433,"name":"izadorozhna","email":"izadorozhna@mirantis.com","username":"izadorozhna"},"change_message_id":"775e197b859b594e689e6bbf5eba3477dfaac749","unresolved":false,"context_lines":[{"line_number":2613,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2614,"context_line":"    default\u003dFalse,"},{"line_number":2615,"context_line":"    help\u003d\u0027Attempt to force delete the cg snapshot(s) (Default\u003dFalse).\u0027)"},{"line_number":2616,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":2617,"context_line":"@api_versions.experimental_api"},{"line_number":2618,"context_line":"def do_cg_snapshot_delete(cs, args):"},{"line_number":2619,"context_line":"    \"\"\"Remove one or more consistency group snapshots.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_8c5a654f","line":2616,"updated":"2015-09-15 14:08:03.000000000","message":"Maybe it is a typo, but we need to use \u0027sharev2\u0027 service type.\nWith a current service type, manila uses v1 API instead of v2.\nThe same typo with other v2 utils.","commit_id":"60505463853f3b2338670f41f0a05222c6aff7df"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"499cfc03a052e04a527486a4239bad91aa014e91","unresolved":false,"context_lines":[{"line_number":2613,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2614,"context_line":"    default\u003dFalse,"},{"line_number":2615,"context_line":"    help\u003d\u0027Attempt to force delete the cg snapshot(s) (Default\u003dFalse).\u0027)"},{"line_number":2616,"context_line":"@cliutils.service_type(\u0027share\u0027)"},{"line_number":2617,"context_line":"@api_versions.experimental_api"},{"line_number":2618,"context_line":"def do_cg_snapshot_delete(cs, args):"},{"line_number":2619,"context_line":"    \"\"\"Remove one or more consistency group snapshots.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_471666f2","line":2616,"in_reply_to":"ba15a1d1_8c5a654f","updated":"2015-09-15 14:13:03.000000000","message":"This was missed and should be consistent with the other @cliutils.service_type statements.","commit_id":"60505463853f3b2338670f41f0a05222c6aff7df"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bcc6bf54fdb5229b479daa5d0108d927876dc9de","unresolved":false,"context_lines":[{"line_number":2417,"context_line":"          \u0027available will be used.\u0027))"},{"line_number":2418,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2419,"context_line":"@api_versions.experimental_api"},{"line_number":2420,"context_line":"def do_cg_reset_state(cs, args):"},{"line_number":2421,"context_line":"    \"\"\"Explicitly update the state of a consistency group.\"\"\""},{"line_number":2422,"context_line":"    cg \u003d _find_consistency_group(cs, args.consistency_group)"},{"line_number":2423,"context_line":"    cs.consistency_groups.reset_state(cg, args.state)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_7fac47a0","line":2420,"updated":"2015-09-15 16:57:19.000000000","message":"This","commit_id":"556b5a65e9b4d59e909351f156e91de00114ed6d"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"f753216fac801db3a63ef30cf1cda65ec09d3835","unresolved":false,"context_lines":[{"line_number":2417,"context_line":"          \u0027available will be used.\u0027))"},{"line_number":2418,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2419,"context_line":"@api_versions.experimental_api"},{"line_number":2420,"context_line":"def do_cg_reset_state(cs, args):"},{"line_number":2421,"context_line":"    \"\"\"Explicitly update the state of a consistency group.\"\"\""},{"line_number":2422,"context_line":"    cg \u003d _find_consistency_group(cs, args.consistency_group)"},{"line_number":2423,"context_line":"    cs.consistency_groups.reset_state(cg, args.state)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_9f5efb74","line":2420,"in_reply_to":"ba15a1d1_7fac47a0","updated":"2015-09-15 17:02:34.000000000","message":"See below comment response","commit_id":"556b5a65e9b4d59e909351f156e91de00114ed6d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bcc6bf54fdb5229b479daa5d0108d927876dc9de","unresolved":false,"context_lines":[{"line_number":2547,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2548,"context_line":"@api_versions.experimental_api"},{"line_number":2549,"context_line":"def do_cg_snapshot_members(cs, args):"},{"line_number":2550,"context_line":"    \"\"\"Get member details for a consistency group snapshot.\"\"\""},{"line_number":2551,"context_line":"    cg_snapshot \u003d _find_cg_snapshot(cs, args.cg_snapshot)"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"    search_opts \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_dfbeb3d3","line":2550,"updated":"2015-09-15 16:57:19.000000000","message":"and this do not have \"description\" in manila help command.","commit_id":"556b5a65e9b4d59e909351f156e91de00114ed6d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f97e08984c53dcf10811c51fc52ce2ea21f1e3d3","unresolved":false,"context_lines":[{"line_number":2547,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2548,"context_line":"@api_versions.experimental_api"},{"line_number":2549,"context_line":"def do_cg_snapshot_members(cs, args):"},{"line_number":2550,"context_line":"    \"\"\"Get member details for a consistency group snapshot.\"\"\""},{"line_number":2551,"context_line":"    cg_snapshot \u003d _find_cg_snapshot(cs, args.cg_snapshot)"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"    search_opts \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_3f0ecf3b","line":2550,"in_reply_to":"ba15a1d1_7fb76786","updated":"2015-09-15 17:05:17.000000000","message":"Oh, sorry. It is ok.","commit_id":"556b5a65e9b4d59e909351f156e91de00114ed6d"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"f753216fac801db3a63ef30cf1cda65ec09d3835","unresolved":false,"context_lines":[{"line_number":2547,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":2548,"context_line":"@api_versions.experimental_api"},{"line_number":2549,"context_line":"def do_cg_snapshot_members(cs, args):"},{"line_number":2550,"context_line":"    \"\"\"Get member details for a consistency group snapshot.\"\"\""},{"line_number":2551,"context_line":"    cg_snapshot \u003d _find_cg_snapshot(cs, args.cg_snapshot)"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"    search_opts \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_7fb76786","line":2550,"in_reply_to":"ba15a1d1_dfbeb3d3","updated":"2015-09-15 17:02:34.000000000","message":"When I run \u0027manila help\u0027 I see the help for these commands. \n\n(.venv)stack@ubuntu:/opt/stack/python-manilaclient$ manila help\nusage: manila [--version] [-d] [--os-cache] [--os-reset-cache]\n              [--os-username \u003cauth-user-name\u003e] [--os-password \u003cauth-password\u003e]\n              [--os-tenant-name \u003cauth-tenant-name\u003e]\n              [--os-tenant-id \u003cauth-tenant-id\u003e] [--os-auth-url \u003cauth-url\u003e]\n              [--os-region-name \u003cregion-name\u003e] [--service-type \u003cservice-type\u003e]\n              [--service-name \u003cservice-name\u003e]\n              [--share-service-name \u003cshare-service-name\u003e]\n              [--endpoint-type \u003cendpoint-type\u003e]\n              [--os-share-api-version \u003cshare-api-ver\u003e]\n              [--os-cacert \u003cca-certificate\u003e] [--retries \u003cretries\u003e]\n              \u003csubcommand\u003e ...\n\nCommand-line interface to the OpenStack Manila API.\n\nPositional arguments:\n  \u003csubcommand\u003e\n    absolute-limits     Print a list of absolute limits for a user.\n    access-allow        Allow access to the share.\n    access-deny         Deny access to a share.\n    access-list         Show access list for share.\n    api-version         Display the API version information.\n    cg-create           Creates a new consistency group.\n    cg-delete           Remove one or more consistency groups.\n    cg-list             List consistency groups with filters.\n    cg-reset-state      Explicitly update the state of a consistency group.\n    cg-show             Show details about a consistency group.\n    cg-snapshot-create  Creates a new consistency group.\n    cg-snapshot-delete  Remove one or more consistency group snapshots.\n    cg-snapshot-list    List consistency group snapshots with filters.\n    cg-snapshot-members\n                        Get member details for a consistency group snapshot.\n    cg-snapshot-reset-state\n                        Explicitly update the state of a consistency group.","commit_id":"556b5a65e9b4d59e909351f156e91de00114ed6d"}]}