)]}'
{"manilaclient/v1/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"1b0e63f7f9ece94099f0d46f247a92d3f7ba7b57","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":107,"context_line":"    cliutils.print_dict(info)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def _find_consistency_group(cs, consistency_group):"},{"line_number":111,"context_line":"    \"\"\"Get a consistency group ID.\"\"\""},{"line_number":112,"context_line":"    return apiclient_utils.find_resource(cs.consistency_groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_cb520735","line":109,"updated":"2015-09-17 20:12:35.000000000","message":"This one should have decorator \"@api_versions.experimental_api\" instead of all its usages.","commit_id":"99bc21bfef8ddf6d86d21d90010df31c0b166db2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"f4424a7cb6211eb4c8f7cc486b1a2025f74ca159","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":107,"context_line":"    cliutils.print_dict(info)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def _find_consistency_group(cs, consistency_group):"},{"line_number":111,"context_line":"    \"\"\"Get a consistency group ID.\"\"\""},{"line_number":112,"context_line":"    return apiclient_utils.find_resource(cs.consistency_groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_56153a99","line":109,"in_reply_to":"ba15a1d1_36b686f9","updated":"2015-09-17 20:45:43.000000000","message":"Ben, my proposal is straight and easy, set decorator only here instead of added two below. That\u0027s it. Also, could be removed more redundant, but I do not insist on it.","commit_id":"99bc21bfef8ddf6d86d21d90010df31c0b166db2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a9611d6680e330e1013d6900a8f769511ac3545b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":107,"context_line":"    cliutils.print_dict(info)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def _find_consistency_group(cs, consistency_group):"},{"line_number":111,"context_line":"    \"\"\"Get a consistency group ID.\"\"\""},{"line_number":112,"context_line":"    return apiclient_utils.find_resource(cs.consistency_groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_567c5aeb","line":109,"in_reply_to":"ba15a1d1_56153a99","updated":"2015-09-17 20:46:55.000000000","message":"Also, if we do so, you should know, that this decorator will add experimental header to all requests, not only to consistency group one.","commit_id":"99bc21bfef8ddf6d86d21d90010df31c0b166db2"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"b0d1af44bcf1e4be5832105b12ad32c74bbe527c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":107,"context_line":"    cliutils.print_dict(info)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def _find_consistency_group(cs, consistency_group):"},{"line_number":111,"context_line":"    \"\"\"Get a consistency group ID.\"\"\""},{"line_number":112,"context_line":"    return apiclient_utils.find_resource(cs.consistency_groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_5108e4d9","line":109,"in_reply_to":"ba15a1d1_567c5aeb","updated":"2015-09-17 21:01:41.000000000","message":"If we add the @api_versions.experimental_api here it will add the experimental header multiple times the the HTTP header in some cases. I thought about doing it here but it seemed inconsistent with how the other annotations are used. Since do_create and do_list are making use of consistency groups it doesn\u0027t seem wrong that they are marked as experimental.","commit_id":"99bc21bfef8ddf6d86d21d90010df31c0b166db2"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"bfc9167bdc35abdc83a7487173c3c130c6e595dd","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":107,"context_line":"    cliutils.print_dict(info)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def _find_consistency_group(cs, consistency_group):"},{"line_number":111,"context_line":"    \"\"\"Get a consistency group ID.\"\"\""},{"line_number":112,"context_line":"    return apiclient_utils.find_resource(cs.consistency_groups,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_36b686f9","line":109,"in_reply_to":"ba15a1d1_cb520735","updated":"2015-09-17 20:38:32.000000000","message":"Valeriy, we have to merge this to get our release out. If you\u0027re sure this change is wrong then let\u0027s fix it, otherwise let\u0027s file a bug a move on. If you have an alternative proposal I think Chuck would be okay if you just uploaded your own patch.","commit_id":"99bc21bfef8ddf6d86d21d90010df31c0b166db2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"88a90c4ffef6d69ee1bca0fd9738815ad84139b7","unresolved":false,"context_lines":[{"line_number":505,"context_line":""},{"line_number":506,"context_line":"    share_network \u003d None"},{"line_number":507,"context_line":"    if args.share_network:"},{"line_number":508,"context_line":"        share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":509,"context_line":"    share \u003d cs.shares.create(args.share_protocol, args.size, args.snapshot_id,"},{"line_number":510,"context_line":"                             args.name, args.description,"},{"line_number":511,"context_line":"                             metadata\u003dshare_metadata,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_76f4fe59","line":508,"updated":"2015-09-17 20:49:56.000000000","message":"Share create request here will have \"experimental\" header too.","commit_id":"99bc21bfef8ddf6d86d21d90010df31c0b166db2"}]}