)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"5663f954e693144a5f4ab1d17c2c82559210baa2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    supported versions overlap. If not the client will display an error"},{"line_number":20,"context_line":"    and quit. See diagram 1 below."},{"line_number":21,"context_line":"*   The client supports the @wraps annotation. The annotation is used"},{"line_number":22,"context_line":"    with v2/shell.py commands to indicate the version supported by the"},{"line_number":23,"context_line":"    command."},{"line_number":24,"context_line":"*   If an appropriate command version isn\u0027t found for commands using"},{"line_number":25,"context_line":"    @wraps then the client will display an error and quit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_0cc8af21","line":22,"updated":"2015-11-09 17:11:41.000000000","message":"Only shell? Is there a way to use \"api class methods\" located in \"v2/shares.py\" and similar?","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    supported versions overlap. If not the client will display an error"},{"line_number":20,"context_line":"    and quit. See diagram 1 below."},{"line_number":21,"context_line":"*   The client supports the @wraps annotation. The annotation is used"},{"line_number":22,"context_line":"    with v2/shell.py commands to indicate the version supported by the"},{"line_number":23,"context_line":"    command."},{"line_number":24,"context_line":"*   If an appropriate command version isn\u0027t found for commands using"},{"line_number":25,"context_line":"    @wraps then the client will display an error and quit."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_dd6d7305","line":22,"in_reply_to":"da85f559_0cc8af21","updated":"2015-11-10 14:30:30.000000000","message":"Updated this to be accurate with current version.","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @wraps then the client will display an error and quit."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The files in the v2 directory include the latest available client code."},{"line_number":28,"context_line":"The files in the v1 directory represent the client code available in the"},{"line_number":29,"context_line":"following commit: ab49d645befd04c84272f0d24e1b604012d191dd."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Diagram 1:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_c5d86cf2","line":28,"updated":"2015-11-08 07:32:34.000000000","message":"It is not so anymore.","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    @wraps then the client will display an error and quit."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"The files in the v2 directory include the latest available client code."},{"line_number":28,"context_line":"The files in the v1 directory represent the client code available in the"},{"line_number":29,"context_line":"following commit: ab49d645befd04c84272f0d24e1b604012d191dd."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Diagram 1:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_cbaf16e2","line":28,"in_reply_to":"da85f559_c5d86cf2","updated":"2015-11-10 14:30:30.000000000","message":"Done","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                  Client displays error and quits"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  Server4:"},{"line_number":52,"context_line":"     1.0 (Kilo Server)"},{"line_number":53,"context_line":"      |-|"},{"line_number":54,"context_line":"     Client detects pre-microversion server and loads v1 client"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_65fc203f","line":52,"updated":"2015-11-08 07:32:34.000000000","message":"And Juno?","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                  Client displays error and quits"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  Server4:"},{"line_number":52,"context_line":"     1.0 (Kilo Server)"},{"line_number":53,"context_line":"      |-|"},{"line_number":54,"context_line":"     Client detects pre-microversion server and loads v1 client"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_abb6523b","line":52,"in_reply_to":"da85f559_65fc203f","updated":"2015-11-10 14:30:30.000000000","message":"Kilo is the last major release before microversions were introduced. If we can claim that the pre-microversion client fully supports Juno and Kilo then we should state that. I don\u0027t know if that is a true statement though.","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"76724849dc8cd4dc9287471d35b9db99df049aa4","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Example usage of wraps annotation:"},{"line_number":57,"context_line":"*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")"},{"line_number":58,"context_line":"*   Support 2.5 - latest: @api_version.wraps(\"2.5\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Implements: blueprint manila-client-advanced-microversion-support"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_8997b18f","line":58,"updated":"2015-11-09 16:52:55.000000000","message":"s/api_version/api_versions/","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Example usage of wraps annotation:"},{"line_number":57,"context_line":"*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")"},{"line_number":58,"context_line":"*   Support 2.5 - latest: @api_version.wraps(\"2.5\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Implements: blueprint manila-client-advanced-microversion-support"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_5d82e395","line":58,"in_reply_to":"da85f559_8997b18f","updated":"2015-11-10 14:30:30.000000000","message":"Done","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}],"contrib/ci/pre_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Set big quota for share networks to avoid limit exceedances"},{"line_number":23,"context_line":"echo \"MANILA_OPTGROUP_DEFAULT_quota_share_networks\u003d50\" \u003e\u003e $localrc_path"},{"line_number":24,"context_line":"echo \"VOLUME_BACKING_FILE_SIZE\u003d30250M\" \u003e\u003e $localrc_path "}],"source_content_type":"text/x-sh","patch_set":2,"id":"da85f559_25ddb814","line":24,"updated":"2015-11-08 07:32:34.000000000","message":"This is not related to the goal of commit.","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Set big quota for share networks to avoid limit exceedances"},{"line_number":23,"context_line":"echo \"MANILA_OPTGROUP_DEFAULT_quota_share_networks\u003d50\" \u003e\u003e $localrc_path"},{"line_number":24,"context_line":"echo \"VOLUME_BACKING_FILE_SIZE\u003d30250M\" \u003e\u003e $localrc_path "}],"source_content_type":"text/x-sh","patch_set":2,"id":"da85f559_4b824654","line":24,"in_reply_to":"da85f559_25ddb814","updated":"2015-11-10 14:30:30.000000000","message":"Done","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}],"manilaclient/api_versions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7884c7177e3d25025a0f5ab67002bbacb4cf7ad9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"MAX_VERSION \u003d \u00272.7\u0027"},{"line_number":34,"context_line":"MIN_VERSION \u003d \u00272.1\u0027"},{"line_number":35,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":36,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e74c3444","line":33,"updated":"2015-11-10 14:58:36.000000000","message":"There is no microversion 2.7 in master. Only proposed in gerrit. Latest available is v2.6","commit_id":"342f3cd45851e330a865c93910378120d39ec8a4"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d6814a5149536b8d18bc15df42282f5e0ea25335","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"MAX_VERSION \u003d \u00272.7\u0027"},{"line_number":34,"context_line":"MIN_VERSION \u003d \u00272.1\u0027"},{"line_number":35,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":36,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_acf1ac02","line":33,"in_reply_to":"da85f559_e74c3444","updated":"2015-11-13 01:38:44.000000000","message":"Done","commit_id":"342f3cd45851e330a865c93910378120d39ec8a4"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"210cd095327ebd505b9e786bf313ed6ae2bf8313","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Chuck Fouts"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_c1eda08f","side":"PARENT","line":2,"updated":"2015-11-13 16:36:16.000000000","message":"Why this is removed?","commit_id":"84d4d57fcefcffcc32503df8d8720de1bc10bf03"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"ffba1a46d020c771d66769fb09bfbc2115fb935d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Chuck Fouts"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_5c58d356","side":"PARENT","line":2,"in_reply_to":"da85f559_c1eda08f","updated":"2015-11-16 19:04:39.000000000","message":"Done","commit_id":"84d4d57fcefcffcc32503df8d8720de1bc10bf03"}],"manilaclient/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":471,"context_line":"            auth_url\u003dargs.os_auth_url,"},{"line_number":472,"context_line":"            insecure\u003dargs.insecure,"},{"line_number":473,"context_line":"            region_name\u003dargs.os_region_name,"},{"line_number":474,"context_line":"            tenant_id\u003dargs.os_project_id or args.os_tenant_id,"},{"line_number":475,"context_line":"            endpoint_type\u003dDEFAULT_MANILA_ENDPOINT_TYPE,"},{"line_number":476,"context_line":"            extensions\u003dself.extensions,"},{"line_number":477,"context_line":"            service_type\u003dconstants.V1_SERVICE_TYPE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_65dbc01c","line":474,"updated":"2015-11-08 07:32:34.000000000","message":"I guess better to set here \"project_id\" in addition to \"project_name\".","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":471,"context_line":"            auth_url\u003dargs.os_auth_url,"},{"line_number":472,"context_line":"            insecure\u003dargs.insecure,"},{"line_number":473,"context_line":"            region_name\u003dargs.os_region_name,"},{"line_number":474,"context_line":"            tenant_id\u003dargs.os_project_id or args.os_tenant_id,"},{"line_number":475,"context_line":"            endpoint_type\u003dDEFAULT_MANILA_ENDPOINT_TYPE,"},{"line_number":476,"context_line":"            extensions\u003dself.extensions,"},{"line_number":477,"context_line":"            service_type\u003dconstants.V1_SERVICE_TYPE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_d8b6e189","line":474,"in_reply_to":"da85f559_65dbc01c","updated":"2015-11-10 14:30:30.000000000","message":"Having as much client setup as we can in one place helps me figure out the intent. Hopefully it helps others as well.","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}],"manilaclient/tests/unit/test_api_versions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        v \u003d api_versions.APIVersion()"},{"line_number":40,"context_line":"        self.assertTrue(v.is_null())"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_invalid_version_strings(self):"},{"line_number":43,"context_line":"        self.assertRaises(exceptions.UnsupportedVersion,"},{"line_number":44,"context_line":"                          api_versions.APIVersion, \"2\")"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_a5544854","line":42,"updated":"2015-11-08 07:32:34.000000000","message":"@ddt.data(\"2\", \"200\", \"2.1.4\", ...)\n\ndef test_invalid_version_strings(self, version):\n\n    self.assertRaises(exceptions.UnsupportedVersion, api_versions.APIVersion, version)","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        v \u003d api_versions.APIVersion()"},{"line_number":40,"context_line":"        self.assertTrue(v.is_null())"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_invalid_version_strings(self):"},{"line_number":43,"context_line":"        self.assertRaises(exceptions.UnsupportedVersion,"},{"line_number":44,"context_line":"                          api_versions.APIVersion, \"2\")"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_8b479c4a","line":42,"in_reply_to":"da85f559_a5544854","updated":"2015-11-10 14:30:30.000000000","message":"Done","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}],"manilaclient/v1/limits.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"255fa17ab7c3c4dab77a9c98197131db8ba8182c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_a1109ca9","line":1,"updated":"2015-11-13 16:35:08.000000000","message":"Whose rights? Need either add copyright owner or remove \"rights reserved\" thing. Same in other files.","commit_id":"b5940d88d53a1eb1f1fbd8632a12bbebfe106ebb"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"ffba1a46d020c771d66769fb09bfbc2115fb935d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_b73eb8b6","line":1,"in_reply_to":"da85f559_a1109ca9","updated":"2015-11-16 19:04:39.000000000","message":"Done","commit_id":"b5940d88d53a1eb1f1fbd8632a12bbebfe106ebb"}],"manilaclient/v2/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                 service_catalog_url\u003dNone, user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":75,"context_line":"                 use_keyring\u003dFalse, force_new_token\u003dFalse,"},{"line_number":76,"context_line":"                 cached_token_lifetime\u003d300,"},{"line_number":77,"context_line":"                 version\u003dmanilaclient.API_MIN_VERSION,"},{"line_number":78,"context_line":"                 user_id\u003dNone,"},{"line_number":79,"context_line":"                 user_domain_id\u003dNone,"},{"line_number":80,"context_line":"                 user_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e5fd706f","line":77,"updated":"2015-11-08 07:32:34.000000000","message":"\"api_version\" should not be renamed. It is interface part. Rename breaks compatibility of existing apps that use python manila client. For same reason \"api_key\" is kept being the same as \"password\" field.","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                 service_catalog_url\u003dNone, user_agent\u003d\u0027python-manilaclient\u0027,"},{"line_number":75,"context_line":"                 use_keyring\u003dFalse, force_new_token\u003dFalse,"},{"line_number":76,"context_line":"                 cached_token_lifetime\u003d300,"},{"line_number":77,"context_line":"                 version\u003dmanilaclient.API_MIN_VERSION,"},{"line_number":78,"context_line":"                 user_id\u003dNone,"},{"line_number":79,"context_line":"                 user_domain_id\u003dNone,"},{"line_number":80,"context_line":"                 user_domain_name\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_12020570","line":77,"in_reply_to":"da85f559_e5fd706f","updated":"2015-11-10 14:30:30.000000000","message":"Done","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7884c7177e3d25025a0f5ab67002bbacb4cf7ad9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from manilaclient.v2 import shares"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class Client(object):"},{"line_number":43,"context_line":"    \"\"\"Top-level object to access the OpenStack Manila API."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Create an instance with your creds::"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e7551450","line":42,"updated":"2015-11-10 14:58:36.000000000","message":"This class could inherit lots of things from v1 and then just update ones that differ like redefine \"v1\" stuff to \"v2\".\n\nExample: https://review.openstack.org/#/c/242515/3/manilaclient/v2/client.py","commit_id":"342f3cd45851e330a865c93910378120d39ec8a4"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d6814a5149536b8d18bc15df42282f5e0ea25335","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from manilaclient.v2 import shares"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class Client(object):"},{"line_number":43,"context_line":"    \"\"\"Top-level object to access the OpenStack Manila API."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Create an instance with your creds::"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_292fd8f7","line":42,"in_reply_to":"da85f559_e7551450","updated":"2015-11-13 01:38:44.000000000","message":"I tried this but in the test had to change vars from \"client.ks_client\" to \"client.client.ks_client\". I\u0027d like to refactor the keystone code out of the client into a common class. Then there would not be as much code duplication. I think this refactor should be done in another patch though.","commit_id":"342f3cd45851e330a865c93910378120d39ec8a4"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2048,"context_line":"    default\u003dFalse,"},{"line_number":2049,"context_line":"    help\u003d\u0027Display all share types (Admin only).\u0027)"},{"line_number":2050,"context_line":"def do_type_list(cs, args):"},{"line_number":2051,"context_line":"    \"\"\"Print a list of available \u0027share types\u0027.\"\"\""},{"line_number":2052,"context_line":"    try:"},{"line_number":2053,"context_line":"        default \u003d cs.share_types.get()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_e534904b","line":2050,"updated":"2015-11-08 07:32:34.000000000","message":"\"Type list\" has diff on microversion 2.6","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","unresolved":false,"context_lines":[{"line_number":2047,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":2048,"context_line":"    default\u003dFalse,"},{"line_number":2049,"context_line":"    help\u003d\u0027Display all share types (Admin only).\u0027)"},{"line_number":2050,"context_line":"def do_type_list(cs, args):"},{"line_number":2051,"context_line":"    \"\"\"Print a list of available \u0027share types\u0027.\"\"\""},{"line_number":2052,"context_line":"    try:"},{"line_number":2053,"context_line":"        default \u003d cs.share_types.get()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_08865213","line":2050,"in_reply_to":"da85f559_e534904b","updated":"2015-11-10 14:30:30.000000000","message":"I see that uglide made a change on March 15th (https://github.com/openstack/python-manilaclient/commit/13b0ce4c6e495ba2df545a349ee5d4d243d20e03). Support for microversion 2.6 didn\u0027t get committed until September. Is this the command you meant?","commit_id":"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}]}
