)]}'
{"id":"openstack%2Fpython-manilaclient~229142","triplet_id":"openstack%2Fpython-manilaclient~master~I3733fe85424e39566addc070d42609e508259f19","project":"openstack/python-manilaclient","branch":"master","topic":"bp/manila-client-advanced-microversion-support","hashtags":[],"change_id":"I3733fe85424e39566addc070d42609e508259f19","subject":"Nova Style API Version Support for Client","status":"MERGED","created":"2015-09-29 20:37:00.000000000","updated":"2015-11-17 20:58:41.000000000","submitted":"2015-11-17 20:58:40.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":26,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f8e5542778808c64ec0bcdc36eaf77bd4e8ff740","_number":229142,"virtual_id_number":229142,"owner":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":2,"date":"2015-11-17 20:58:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},{"value":0,"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},{"value":0,"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":2,"date":"2015-11-17 11:56:24.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},{"value":0,"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},{"value":2,"date":"2015-11-17 20:17:28.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},{"value":0,"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},{"value":0,"date":"2015-11-17 11:56:44.000000000","_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"date":"2015-11-17 11:56:33.000000000","_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},{"value":1,"date":"2015-11-17 20:17:28.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"date":"2015-11-17 11:56:39.000000000","_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-10 14:36:07.000000000","updated_by":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"reviewer":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"state":"REVIEWER"},{"updated":"2015-11-10 14:39:45.000000000","updated_by":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"reviewer":{"_account_id":9366,"name":"Andrew Kerr","email":"andrew.kerr@netapp.com","username":"andrew-kerr"},"state":"REVIEWER"},{"updated":"2015-11-17 11:56:24.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2015-11-17 11:56:33.000000000","updated_by":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"reviewer":{"_account_id":14232,"name":"Igor Malinovskiy","email":"u.glide@gmail.com","username":"imalinovskiy"},"state":"REVIEWER"},{"updated":"2015-11-17 11:56:39.000000000","updated_by":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"reviewer":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"state":"REVIEWER"},{"updated":"2015-11-17 11:56:44.000000000","updated_by":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"reviewer":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"state":"REVIEWER"},{"updated":"2015-11-17 20:17:28.000000000","updated_by":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"reviewer":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"state":"REVIEWER"},{"updated":"2015-11-17 20:58:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"051ca2eb492b0246c0e3cac30edfce21b17a71a6","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-09-29 20:37:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8638c4bb4f2edf9859f5c5a7b8159de0c5b95603","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-29 21:17:40.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/1/check/gate-python-manilaclient-python26/3bdef00/ : FAILURE in 1m 06s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/1/check/gate-python-manilaclient-pep8/446263f/ : SUCCESS in 49s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/1/check/gate-python-manilaclient-docs/35cabfa//doc/build/html/ : SUCCESS in 1m 04s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/1/check/gate-python-manilaclient-python27/9ee41ab/ : SUCCESS in 1m 22s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/1/check/gate-python-manilaclient-python34/b7bdd97/ : SUCCESS in 1m 46s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/1/check/gate-manilaclient-dsvm-neutron-functional/f478fc7/ : FAILURE in 40m 23s","accounts_in_message":[],"_revision_number":1},{"id":"1d44895880dc386c98617a7bcc5168337e0ee6c1","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-04 14:18:32.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0a318f6efac462be603927426c49bcf361aee2a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-04 14:18:40.000000000","message":"Patch Set 1:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"0ba13414c563316f6f40fba80e531ededb1596f1","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-08 03:59:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"aeff6490cb3d24d7ecdec554bdd142e586f4fe05","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-08 04:30:27.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/2/check/gate-python-manilaclient-python26/05e8bef/ : FAILURE in 2m 09s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/2/check/gate-python-manilaclient-pep8/1db2d27/ : SUCCESS in 1m 05s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/2/check/gate-python-manilaclient-docs/41de291//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/2/check/gate-python-manilaclient-python27/1becd74/ : SUCCESS in 2m 34s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/2/check/gate-python-manilaclient-python34/f7db134/ : SUCCESS in 3m 31s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/2/check/gate-manilaclient-dsvm-neutron-functional/52e2e09/ : SUCCESS in 30m 42s","accounts_in_message":[],"_revision_number":2},{"id":"df05da74b1bd8fc053b350ab80a541b32e13aaaf","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-08 07:32:34.000000000","message":"Patch Set 2: Code-Review-1\n\n(7 comments)\n\nPlease, see inline comments.","accounts_in_message":[],"_revision_number":2},{"id":"3c5a9e93e067c6b4d30107f8e97246077b84df23","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-08 07:49:41.000000000","message":"Patch Set 2:\n\nOne more thing:\n\n\"manilaclient.v1.client\" module should stay for compatibility reasons. Same for all other. And if you set just redirect then need to call \"warnings\" with deprecation.","accounts_in_message":[],"_revision_number":2},{"id":"76724849dc8cd4dc9287471d35b9db99df049aa4","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-09 16:52:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"5663f954e693144a5f4ab1d17c2c82559210baa2","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-09 17:11:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e456523fb0f3549d3c278f7159961aa2fc06bcf5","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-09 17:19:54.000000000","message":"Patch Set 2:\n\n+:\n\nconsistency groups and its snapshots modules should have \"wraps\" decorator with minimum microversion set to 2.4. Same situation with migration API.","accounts_in_message":[],"_revision_number":2},{"id":"592ce04fce227907979ea01bbb585f490cecde9c","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-10 14:26:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"fb5c918711f3655aa0b2e2d7cf3d6bd9da6ebc5e","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-10 14:30:30.000000000","message":"Patch Set 2:\n\n(9 comments)","accounts_in_message":[],"_revision_number":2},{"id":"60e935b5d7bb1d1dab6060fcc102c80d648beb40","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-10 14:42:23.000000000","message":"Patch Set 3:\n\nValeriy, \n\nI added the wraps decorator to consistency_groups.py and consistency_group_snapshots.py. I kept the other wraps decorators in v2/shell.py. You think it is better to use the wraps decorator in the classes that v2/shell.py calls?","accounts_in_message":[],"_revision_number":3},{"id":"7884c7177e3d25025a0f5ab67002bbacb4cf7ad9","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-10 14:58:36.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ca889e47f74e2ec4fd210aa13a6df8f846e6ac01","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 15:07:14.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/3/check/gate-python-manilaclient-python26/8e76d33/ : SUCCESS in 2m 18s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/3/check/gate-python-manilaclient-pep8/02fdc13/ : SUCCESS in 58s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/3/check/gate-python-manilaclient-docs/80da469//doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/3/check/gate-python-manilaclient-python27/6ab9de8/ : SUCCESS in 2m 57s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/3/check/gate-python-manilaclient-python34/72ff301/ : SUCCESS in 2m 23s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/3/check/gate-manilaclient-dsvm-neutron-functional/72c3b3c/ : FAILURE in 28m 53s","accounts_in_message":[],"_revision_number":3},{"id":"bcf4637f0078c09fabe6ac0166bb546662699197","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-10 15:33:52.000000000","message":"Patch Set 3:\n\nChuck,\n\nwe can use both. And there is cases when we need both. And one of such cases - rename of API URLs. Example:\n\nshell func for share migration will have decorator only with minimum version \"2.5\", but lower level will have two - \"2.5-2.6\" and \"2.7+\".","accounts_in_message":[],"_revision_number":3},{"id":"36c050b0ee291d366ae3569b7973f18b8d0621bb","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-10 17:10:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1a681dbaf7fd27d980cedc5a9a024a5c56c2e6cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-10 18:27:51.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/4/check/gate-python-manilaclient-python26/f352603/ : SUCCESS in 2m 06s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/4/check/gate-python-manilaclient-pep8/d0df150/ : SUCCESS in 1m 13s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/4/check/gate-python-manilaclient-docs/9e9e236//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/4/check/gate-python-manilaclient-python27/9bb177f/ : SUCCESS in 2m 34s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/4/check/gate-python-manilaclient-python34/f3fe4dd/ : SUCCESS in 2m 56s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/4/check/gate-manilaclient-dsvm-neutron-functional/c589b26/ : SUCCESS in 43m 00s","accounts_in_message":[],"_revision_number":4},{"id":"f659e691732878146c8caece60b109c48d210a73","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-11 13:05:20.000000000","message":"Patch Set 4: Code-Review-1\n\nCouple of things to be addressed:\n\n1) [mandatory] Old API managers in dir \"v1\" should exist for compatibility reasons. It is OK to just import there v2-stuff.\n\n2) [desired] in unit tests with consistency groups, consistency group snapshots, share instances and migration should be tested all cases. Now - only last microversion. Expected - all. With too old - NotFound, etc...","accounts_in_message":[],"_revision_number":4},{"id":"d6814a5149536b8d18bc15df42282f5e0ea25335","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-13 01:38:44.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"ffb72a889e50c02f9e89b296123d3c4dfd94b89b","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-13 01:44:33.000000000","message":"Patch Set 4:\n\nValeriy,\n\nAdded back v1 Manager classes as requested. I also added negative tests to check for version in consisteny_groups and consistency_group_snapshots. This feels like it should be a functional test since it is testing api_versions in addition to the the class under test. I\u0027ll look at adding functional test support this weekend. \n\nAs mentioned in an above comment I\u0027d like to refactor the keystone code in the v1 and v2 client.py files into a new common file in a separate change. A lot of the code in the client is common code to deal with keystone. It will make keystone changes easier to implement in the future.\n\nThanks for the reviews so far.","accounts_in_message":[],"_revision_number":4},{"id":"1178c4e60d4adc0100faaf2d23d3d85699fca4a6","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-13 03:04:43.000000000","message":"Patch Set 4:\n\nForgot to mention that patch set 5 is waiting on NetApp code review before it is released upstream.","accounts_in_message":[],"_revision_number":4},{"id":"da2fc07b7fb3956b1f3a90377440bb94d43e10dd","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-13 15:12:03.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ec2b0800ce512d761abad4cae0b6535d31f22c64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-13 16:27:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/5/check/gate-python-manilaclient-python26/eab5256/ : SUCCESS in 2m 06s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/5/check/gate-python-manilaclient-pep8/a7f5747/ : SUCCESS in 1m 08s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/5/check/gate-python-manilaclient-docs/ec12013//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/5/check/gate-python-manilaclient-python27/030b54b/ : SUCCESS in 2m 41s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/5/check/gate-python-manilaclient-python34/310185d/ : SUCCESS in 3m 09s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/5/check/gate-manilaclient-dsvm-neutron-functional/ee09ef6/ : SUCCESS in 47m 13s","accounts_in_message":[],"_revision_number":5},{"id":"255fa17ab7c3c4dab77a9c98197131db8ba8182c","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-13 16:35:08.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"210cd095327ebd505b9e786bf313ed6ae2bf8313","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-13 16:36:16.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"dbe7c7e07375a1e5ce826ded34e946c375fc4095","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-14 04:15:16.000000000","message":"Patch Set 5: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":5},{"id":"78bb6add53ca33b3f97d9cd7279de9471b5450e1","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2015-11-16 07:17:22.000000000","message":"Patch Set 5: Code-Review-1\n\nneeds rebase","accounts_in_message":[],"_revision_number":5},{"id":"1d85c645a5f93e75a08e4584f05d911f4fccab70","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-16 19:03:56.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ffba1a46d020c771d66769fb09bfbc2115fb935d","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2015-11-16 19:04:39.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"ef13c2793a738584c2117dbbe5a3a37ead5b3c83","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-16 21:31:09.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/6/check/gate-python-manilaclient-python26/3f0f5ab/ : SUCCESS in 2m 26s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/6/check/gate-python-manilaclient-pep8/6c946b9/ : SUCCESS in 1m 38s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/6/check/gate-python-manilaclient-docs/a6d3dfe//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/6/check/gate-python-manilaclient-python27/218d8c7/ : SUCCESS in 2m 49s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/6/check/gate-python-manilaclient-python34/1679df8/ : SUCCESS in 2m 49s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/6/check/gate-manilaclient-dsvm-neutron-functional/03ecc8e/ : SUCCESS in 33m 51s","accounts_in_message":[],"_revision_number":6},{"id":"f49610be612ec35fe4401760b85ce52b55e51bc3","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-11-17 11:56:24.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"e27f89a4ff5d35d3d9c6869e0e429307da6c0d61","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2015-11-17 20:17:28.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"e372dd0bd16fe217c1fe8076c553f2897696643c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-17 20:17:35.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"a59ccd01b0896dcf39e825b9cd551e8654dab8e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-17 20:58:40.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-python26 http://logs.openstack.org/42/229142/6/gate/gate-python-manilaclient-python26/2868f53/ : SUCCESS in 2m 16s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/42/229142/6/gate/gate-python-manilaclient-docs/fa17d73//doc/build/html/ : SUCCESS in 1m 10s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/42/229142/6/gate/gate-python-manilaclient-pep8/5103b6c/ : SUCCESS in 1m 16s\n- gate-python-manilaclient-python27 http://logs.openstack.org/42/229142/6/gate/gate-python-manilaclient-python27/60109fb/ : SUCCESS in 2m 41s\n- gate-python-manilaclient-python34 http://logs.openstack.org/42/229142/6/gate/gate-python-manilaclient-python34/51f5812/ : SUCCESS in 2m 52s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/42/229142/6/gate/gate-manilaclient-dsvm-neutron-functional/611206d/ : SUCCESS in 40m 47s","accounts_in_message":[],"_revision_number":6},{"id":"4ac23b3cf3910110af9ae0db96c55b70e6832477","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-17 20:58:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"c34e3b7d2cb04a2fd047e69ea75878ab70624716","revisions":{"aabaef9478421a92ff152b690551de08affb5739":{"kind":"REWORK","_number":1,"created":"2015-09-29 20:37:00.000000000","uploader":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"ref":"refs/changes/42/229142/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/42/229142/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/1"}}},"commit":{"parents":[{"commit":"9d25b0353bf3be176de43055dfcf1dc799b66f73","subject":"Merge \"Change Manilaclient to use --os-region-name param\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9d25b0353bf3be176de43055dfcf1dc799b66f73"}]}],"author":{"name":"cFouts","email":"fchuck@netapp.com","date":"2015-09-01 23:12:01.000000000","tz":-240},"committer":{"name":"Chuck Fouts","email":"fchuck@netapp.com","date":"2015-09-29 20:36:59.000000000","tz":0},"subject":"[WIP] Nova Style API Version Support for Client","message":"[WIP] Nova Style API Version Support for Client\n\nThe Manila client needs the following changes to support microversions:\n\n*   Maintain backwards compatibility with Kilo. When the client detects\n    that the server doesn\u0027t support microversions it will fall back to\n    using the v1 API.\n*   The --os-share-api-version option supports overriding the version.\n*   If 1.0 is specified as the version the client will load the v1\n    client and use the server\u0027s v1 API.\n*   The client will send a request for the server\u0027s API version and\n    determine if the client\u0027s supported versions and the server\u0027s\n    supported versions overlap. If not the client will display an error\n    and quit. See diagram 1 below.\n*   The client supports the @wraps annotation. The annotation is used\n    with v2/shell.py commands to indicate the version supported by the\n    command.\n*   If an appropriate command version isn\u0027t found for commands using\n    @wraps then the client will display an error and quit.\n\nThe files in the v2 directory include the latest available client code.\nThe files in the v1 directory represent the client code available in the\nfollowing commit: ab49d645befd04c84272f0d24e1b604012d191dd.\n\nDiagram 1:\n  Client:\n         2.5           2.8\n          |-------------|\n\n  Server1:\n     2.0           2.5\n      |-------------|\n     Client uses version 2.5\n\n  Server2:\n               2.7           2.10\n                |-------------|\n               Client uses version 2.8\n\n  Server3:\n                  2.9           2.12\n                   |-------------|\n                  Client displays error and quits\n\n  Server4:\n     1.0 (Kilo Server)\n      |-|\n     Client detects pre-microversion server and loads v1 client\n\nImplements: blueprint manila-client-advanced-microversion-support\n\nChange-Id: I3733fe85424e39566addc070d42609e508259f19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/aabaef9478421a92ff152b690551de08affb5739"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/aabaef9478421a92ff152b690551de08affb5739"}]},"branch":"refs/heads/master"},"f61eb3f5ad81eac6ca7ade982c4feb3f4810933e":{"kind":"REWORK","_number":2,"created":"2015-11-08 03:59:39.000000000","uploader":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"ref":"refs/changes/42/229142/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/42/229142/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/2"}}},"commit":{"parents":[{"commit":"84d4d57fcefcffcc32503df8d8720de1bc10bf03","subject":"Wrong help for \u0027manila cg-snapshot-create\u0027 command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/84d4d57fcefcffcc32503df8d8720de1bc10bf03"}]}],"author":{"name":"cFouts","email":"fchuck@netapp.com","date":"2015-09-01 23:12:01.000000000","tz":-240},"committer":{"name":"Chuck Fouts","email":"fchuck@netapp.com","date":"2015-11-08 03:59:38.000000000","tz":0},"subject":"[WIP] Nova Style API Version Support for Client","message":"[WIP] Nova Style API Version Support for Client\n\nThe Manila client needs the following changes to support microversions:\n\n*   Maintain backwards compatibility with Kilo. When the client detects\n    that the server doesn\u0027t support microversions it will fall back to\n    using the v1 API.\n*   The --os-share-api-version option supports overriding the version.\n*   If 1.0 is specified as the version the client will load the v1\n    client and use the server\u0027s v1 API.\n*   The client will send a request for the server\u0027s API version and\n    determine if the client\u0027s supported versions and the server\u0027s\n    supported versions overlap. If not the client will display an error\n    and quit. See diagram 1 below.\n*   The client supports the @wraps annotation. The annotation is used\n    with v2/shell.py commands to indicate the version supported by the\n    command.\n*   If an appropriate command version isn\u0027t found for commands using\n    @wraps then the client will display an error and quit.\n\nThe files in the v2 directory include the latest available client code.\nThe files in the v1 directory represent the client code available in the\nfollowing commit: ab49d645befd04c84272f0d24e1b604012d191dd.\n\nDiagram 1:\n  Client:\n         2.5           2.8\n          |-------------|\n\n  Server1:\n     2.0           2.5\n      |-------------|\n     Client uses version 2.5\n\n  Server2:\n               2.7           2.10\n                |-------------|\n               Client uses version 2.8\n\n  Server3:\n                  2.9           2.12\n                   |-------------|\n                  Client displays error and quits\n\n  Server4:\n     1.0 (Kilo Server)\n      |-|\n     Client detects pre-microversion server and loads v1 client\n\nExample usage of wraps annotation:\n*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")\n*   Support 2.5 - latest: @api_version.wraps(\"2.5\")\n\nImplements: blueprint manila-client-advanced-microversion-support\n\nChange-Id: I3733fe85424e39566addc070d42609e508259f19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f61eb3f5ad81eac6ca7ade982c4feb3f4810933e"}]},"branch":"refs/heads/master"},"342f3cd45851e330a865c93910378120d39ec8a4":{"kind":"REWORK","_number":3,"created":"2015-11-10 14:26:27.000000000","uploader":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"ref":"refs/changes/42/229142/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/42/229142/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/3"}}},"commit":{"parents":[{"commit":"84d4d57fcefcffcc32503df8d8720de1bc10bf03","subject":"Wrong help for \u0027manila cg-snapshot-create\u0027 command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/84d4d57fcefcffcc32503df8d8720de1bc10bf03"}]}],"author":{"name":"cFouts","email":"fchuck@netapp.com","date":"2015-09-01 23:12:01.000000000","tz":-240},"committer":{"name":"Chuck Fouts","email":"fchuck@netapp.com","date":"2015-11-10 14:26:26.000000000","tz":0},"subject":"Nova Style API Version Support for Client","message":"Nova Style API Version Support for Client\n\nThe Manila client needs the following changes to support microversions:\n\n*   Maintain backwards compatibility with Kilo. When the client detects\n    that the server doesn\u0027t support microversions it will fall back to\n    using the v1 API.\n*   The --os-share-api-version option supports overriding the version.\n*   If 1.0 is specified as the version the client will load the v1\n    client and use the server\u0027s v1 API.\n*   The client will send a request for the server\u0027s API version and\n    determine if the client\u0027s supported versions and the server\u0027s\n    supported versions overlap. If not the client will display an error\n    and quit. See diagram 1 below.\n*   The client supports the @wraps annotation. The annotation is used\n    with the v2/shell.py commands and any class that inherits from\n    the Manager class in manilaclient/base.py.\n*   If an appropriate command version isn\u0027t found for commands using\n    @wraps then the client will display an error and quit.\n\nfollowing commit: ab49d645befd04c84272f0d24e1b604012d191dd.\n\nDiagram 1:\n  Client:\n         2.5           2.8\n          |-------------|\n\n  Server1:\n     2.0           2.5\n      |-------------|\n     Client uses version 2.5\n\n  Server2:\n               2.7           2.10\n                |-------------|\n               Client uses version 2.8\n\n  Server3:\n                  2.9           2.12\n                   |-------------|\n                  Client displays error and quits\n\n  Server4:\n     1.0 (Kilo Server)\n      |-|\n     Client detects pre-microversion server and loads v1 client\n\nExample usage of wraps annotation:\n*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")\n*   Support 2.5 - latest: @api_versions.wraps(\"2.5\")\n\nImplements: blueprint manila-client-advanced-microversion-support\n\nChange-Id: I3733fe85424e39566addc070d42609e508259f19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/342f3cd45851e330a865c93910378120d39ec8a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/342f3cd45851e330a865c93910378120d39ec8a4"}]},"branch":"refs/heads/master"},"329ce2891ae5a719517def6da132267375a9d02c":{"kind":"REWORK","_number":4,"created":"2015-11-10 17:10:56.000000000","uploader":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"ref":"refs/changes/42/229142/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/42/229142/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/4"}}},"commit":{"parents":[{"commit":"84d4d57fcefcffcc32503df8d8720de1bc10bf03","subject":"Wrong help for \u0027manila cg-snapshot-create\u0027 command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/84d4d57fcefcffcc32503df8d8720de1bc10bf03"}]}],"author":{"name":"cFouts","email":"fchuck@netapp.com","date":"2015-09-01 23:12:01.000000000","tz":-240},"committer":{"name":"Chuck Fouts","email":"fchuck@netapp.com","date":"2015-11-10 17:10:55.000000000","tz":0},"subject":"Nova Style API Version Support for Client","message":"Nova Style API Version Support for Client\n\nThe Manila client needs the following changes to support microversions:\n\n*   Maintain backwards compatibility with Kilo. When the client detects\n    that the server doesn\u0027t support microversions it will fall back to\n    using the v1 API.\n*   The --os-share-api-version option supports overriding the version.\n*   If 1.0 is specified as the version the client will load the v1\n    client and use the server\u0027s v1 API.\n*   The client will send a request for the server\u0027s API version and\n    determine if the client\u0027s supported versions and the server\u0027s\n    supported versions overlap. If not the client will display an error\n    and quit. See diagram 1 below.\n*   The client supports the @wraps annotation. The annotation is used\n    with the v2/shell.py commands and any class that inherits from\n    the Manager class in manilaclient/base.py.\n*   If an appropriate command version isn\u0027t found for commands using\n    @wraps then the client will display an error and quit.\n\nfollowing commit: ab49d645befd04c84272f0d24e1b604012d191dd.\n\nDiagram 1:\n  Client:\n         2.5           2.8\n          |-------------|\n\n  Server1:\n     2.0           2.5\n      |-------------|\n     Client uses version 2.5\n\n  Server2:\n               2.7           2.10\n                |-------------|\n               Client uses version 2.8\n\n  Server3:\n                  2.9           2.12\n                   |-------------|\n                  Client displays error and quits\n\n  Server4:\n     1.0 (Kilo Server)\n      |-|\n     Client detects pre-microversion server and loads v1 client\n\nExample usage of wraps annotation:\n*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")\n*   Support 2.5 - latest: @api_versions.wraps(\"2.5\")\n\nImplements: blueprint manila-client-advanced-microversion-support\n\nChange-Id: I3733fe85424e39566addc070d42609e508259f19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/329ce2891ae5a719517def6da132267375a9d02c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/329ce2891ae5a719517def6da132267375a9d02c"}]},"branch":"refs/heads/master"},"b5940d88d53a1eb1f1fbd8632a12bbebfe106ebb":{"kind":"REWORK","_number":5,"created":"2015-11-13 15:12:03.000000000","uploader":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"ref":"refs/changes/42/229142/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/42/229142/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/5"}}},"commit":{"parents":[{"commit":"84d4d57fcefcffcc32503df8d8720de1bc10bf03","subject":"Wrong help for \u0027manila cg-snapshot-create\u0027 command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/84d4d57fcefcffcc32503df8d8720de1bc10bf03"}]}],"author":{"name":"cFouts","email":"fchuck@netapp.com","date":"2015-09-01 23:12:01.000000000","tz":-240},"committer":{"name":"Chuck Fouts","email":"fchuck@netapp.com","date":"2015-11-13 15:12:02.000000000","tz":0},"subject":"Nova Style API Version Support for Client","message":"Nova Style API Version Support for Client\n\nThe Manila client needs the following changes to support microversions:\n\n*   Maintain backwards compatibility with Kilo. When the client detects\n    that the server doesn\u0027t support microversions it will fall back to\n    using the v1 API.\n*   The --os-share-api-version option supports overriding the version.\n*   If 1.0 is specified as the version the client will load the v1\n    client and use the server\u0027s v1 API.\n*   The client will send a request for the server\u0027s API version and\n    determine if the client\u0027s supported versions and the server\u0027s\n    supported versions overlap. If not the client will display an error\n    and quit. See diagram 1 below.\n*   The client supports the @wraps annotation. The annotation is used\n    with the v2/shell.py commands and any class that inherits from\n    the Manager class in manilaclient/base.py.\n*   If an appropriate command version isn\u0027t found for commands using\n    @wraps then the client will display an error and quit.\n\nfollowing commit: ab49d645befd04c84272f0d24e1b604012d191dd.\n\nDiagram 1:\n  Client:\n         2.5           2.8\n          |-------------|\n\n  Server1:\n     2.0           2.5\n      |-------------|\n     Client uses version 2.5\n\n  Server2:\n               2.7           2.10\n                |-------------|\n               Client uses version 2.8\n\n  Server3:\n                  2.9           2.12\n                   |-------------|\n                  Client displays error and quits\n\n  Server4:\n     1.0 (Kilo Server)\n      |-|\n     Client detects pre-microversion server and loads v1 client\n\nExample usage of wraps annotation:\n*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")\n*   Support 2.5 - latest: @api_versions.wraps(\"2.5\")\n\nImplements: blueprint manila-client-advanced-microversion-support\n\nChange-Id: I3733fe85424e39566addc070d42609e508259f19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b5940d88d53a1eb1f1fbd8632a12bbebfe106ebb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b5940d88d53a1eb1f1fbd8632a12bbebfe106ebb"}]},"branch":"refs/heads/master"},"c34e3b7d2cb04a2fd047e69ea75878ab70624716":{"kind":"REWORK","_number":6,"created":"2015-11-16 19:03:56.000000000","uploader":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"ref":"refs/changes/42/229142/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/42/229142/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/42/229142/6"}}},"commit":{"parents":[{"commit":"47b519106a6a420474b33332415929e17a5e554e","subject":"Manila list shows one export location not multiple","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/47b519106a6a420474b33332415929e17a5e554e"}]}],"author":{"name":"cFouts","email":"fchuck@netapp.com","date":"2015-09-01 23:12:01.000000000","tz":-240},"committer":{"name":"Chuck Fouts","email":"fchuck@netapp.com","date":"2015-11-16 19:03:55.000000000","tz":0},"subject":"Nova Style API Version Support for Client","message":"Nova Style API Version Support for Client\n\nThe Manila client needs the following changes to support microversions:\n\n*   Maintain backwards compatibility with Kilo. When the client detects\n    that the server doesn\u0027t support microversions it will fall back to\n    using the v1 API.\n*   The --os-share-api-version option supports overriding the version.\n*   If 1.0 is specified as the version the client will load the v1\n    client and use the server\u0027s v1 API.\n*   The client will send a request for the server\u0027s API version and\n    determine if the client\u0027s supported versions and the server\u0027s\n    supported versions overlap. If not the client will display an error\n    and quit. See diagram 1 below.\n*   The client supports the @wraps annotation. The annotation is used\n    with the v2/shell.py commands and any class that inherits from\n    the Manager class in manilaclient/base.py.\n*   If an appropriate command version isn\u0027t found for commands using\n    @wraps then the client will display an error and quit.\n\nfollowing commit: ab49d645befd04c84272f0d24e1b604012d191dd.\n\nDiagram 1:\n  Client:\n         2.5           2.8\n          |-------------|\n\n  Server1:\n     2.0           2.5\n      |-------------|\n     Client uses version 2.5\n\n  Server2:\n               2.7           2.10\n                |-------------|\n               Client uses version 2.8\n\n  Server3:\n                  2.9           2.12\n                   |-------------|\n                  Client displays error and quits\n\n  Server4:\n     1.0 (Kilo Server)\n      |-|\n     Client detects pre-microversion server and loads v1 client\n\nExample usage of wraps annotation:\n*   Support 2.0 - 2.4: @api_versions.wraps(\"2.0\", \"2.4\")\n*   Support 2.5 - latest: @api_versions.wraps(\"2.5\")\n\nImplements: blueprint manila-client-advanced-microversion-support\n\nChange-Id: I3733fe85424e39566addc070d42609e508259f19\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/c34e3b7d2cb04a2fd047e69ea75878ab70624716"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/c34e3b7d2cb04a2fd047e69ea75878ab70624716"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}