)]}'
{"manilaclient/api_versions.py":[{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"f61c3573f3cfbdb2b8abbce90b30b04fd6e0ba2d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"def get_versioned_methods(func_name, api_version\u003dNone):"},{"line_number":329,"context_line":"    versioned_methods \u003d _VERSIONED_METHOD_MAP.get(func_name, [])"},{"line_number":330,"context_line":"    print versioned_methods"},{"line_number":331,"context_line":"    print api_version"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    if api_version and not api_version.is_null():"},{"line_number":334,"context_line":"        return [m for m in versioned_methods"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_8b5a3f82","line":331,"range":{"start_line":331,"start_character":10,"end_line":331,"end_character":21},"updated":"2016-01-28 16:50:51.000000000","message":"remove the print statements","commit_id":"4a0c14b913a0193a429420c70fa395e53f69950b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0bd85337c163d7f6a37c19bedc10b1f045c91b71","unresolved":false,"context_lines":[{"line_number":328,"context_line":"def get_versioned_methods(func_name, api_version\u003dNone):"},{"line_number":329,"context_line":"    versioned_methods \u003d _VERSIONED_METHOD_MAP.get(func_name, [])"},{"line_number":330,"context_line":"    print versioned_methods"},{"line_number":331,"context_line":"    print api_version"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    if api_version and not api_version.is_null():"},{"line_number":334,"context_line":"        return [m for m in versioned_methods"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f6507a0c","line":331,"range":{"start_line":331,"start_character":10,"end_line":331,"end_character":21},"in_reply_to":"7a5de9d1_8b5a3f82","updated":"2016-01-28 16:53:59.000000000","message":"Done","commit_id":"4a0c14b913a0193a429420c70fa395e53f69950b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MAX_VERSION \u003d \u00272.11\u0027"},{"line_number":35,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":36,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_c70ddb3f","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":19},"updated":"2016-02-28 17:37:27.000000000","message":"The current server microversion is 2.12.","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MAX_VERSION \u003d \u00272.11\u0027"},{"line_number":35,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":36,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_e24a8dab","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":19},"in_reply_to":"9aed3d3a_c70ddb3f","updated":"2016-02-28 19:43:37.000000000","message":"I believe this changeset will make it 2.12:\n\nhttps://review.openstack.org/#/c/249544/","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"}],"manilaclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        return (200, {}, replicas)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def get_share_replicas_5678(self, **kw):"},{"line_number":607,"context_line":"        replicas \u003d {"},{"line_number":608,"context_line":"            \u0027share_replica\u0027: self.fake_share_replica,"},{"line_number":609,"context_line":"        }"},{"line_number":610,"context_line":"        return (200, {}, replicas)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def post_share_replicas(self, **kw):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_620ddd36","line":609,"range":{"start_line":607,"start_character":8,"end_line":609,"end_character":9},"updated":"2016-02-28 17:37:27.000000000","message":"No need to wrap dicts that fit on one line.\n\nhttp://docs.openstack.org/developer/hacking/#dictionaries-lists\n\nSame below.","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        return (200, {}, replicas)"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"    def get_share_replicas_5678(self, **kw):"},{"line_number":607,"context_line":"        replicas \u003d {"},{"line_number":608,"context_line":"            \u0027share_replica\u0027: self.fake_share_replica,"},{"line_number":609,"context_line":"        }"},{"line_number":610,"context_line":"        return (200, {}, replicas)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def post_share_replicas(self, **kw):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_22cbd51f","line":609,"range":{"start_line":607,"start_character":8,"end_line":609,"end_character":9},"in_reply_to":"9aed3d3a_620ddd36","updated":"2016-02-28 19:43:37.000000000","message":"Done","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"}],"manilaclient/v1/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99637cec23fafc0d3e14cd7291a99a226d0a5a5b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        self.quotas \u003d quotas.QuotaSetManager(self)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self.shares \u003d shares.ShareManager(self)"},{"line_number":210,"context_line":"        self.share_snapshots \u003d share_snapshots.ShareSnapshotManager(self)"},{"line_number":211,"context_line":"        self.share_types \u003d share_types.ShareTypeManager(self)"},{"line_number":212,"context_line":"        self.share_type_access \u003d share_type_access.ShareTypeAccessManager(self)"},{"line_number":213,"context_line":"        self.share_servers \u003d share_servers.ShareServerManager(self)"},{"line_number":214,"context_line":"        self.pools \u003d scheduler_stats.PoolManager(self)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_55ab1d75","line":211,"range":{"start_line":210,"start_character":8,"end_line":211,"end_character":61},"updated":"2016-02-06 16:47:03.000000000","message":"Redundant update of file.","commit_id":"09da923663f9f1c7710f31d72fa324e1c3a7c322"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d01fcd04b525c4c4f33f93102a4c0d2ebf8c5065","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self.shares \u003d shares.ShareManager(self)"},{"line_number":210,"context_line":"        self.share_snapshots \u003d share_snapshots.ShareSnapshotManager(self)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.share_types \u003d share_types.ShareTypeManager(self)"},{"line_number":213,"context_line":"        self.share_type_access \u003d share_type_access.ShareTypeAccessManager(self)"},{"line_number":214,"context_line":"        self.share_servers \u003d share_servers.ShareServerManager(self)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_a3d42020","side":"PARENT","line":211,"updated":"2016-02-22 10:19:00.000000000","message":"Redundant change.","commit_id":"835482e4e499097941467bc3e41fac3501bf25d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        self.shares \u003d shares.ShareManager(self)"},{"line_number":210,"context_line":"        self.share_snapshots \u003d share_snapshots.ShareSnapshotManager(self)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.share_types \u003d share_types.ShareTypeManager(self)"},{"line_number":213,"context_line":"        self.share_type_access \u003d share_type_access.ShareTypeAccessManager(self)"},{"line_number":214,"context_line":"        self.share_servers \u003d share_servers.ShareServerManager(self)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_21cbd31f","side":"PARENT","line":211,"in_reply_to":"bae84128_a3d42020","updated":"2016-02-22 21:08:31.000000000","message":"Done","commit_id":"835482e4e499097941467bc3e41fac3501bf25d8"}],"manilaclient/v1/share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"398b69199c1a1ef51589fb019bcfa9b60d5413ef","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        if share:"},{"line_number":61,"context_line":"            share_id \u003d \u0027?share-id\u003d\u0027 + str(common_base.getid(share))"},{"line_number":62,"context_line":"            url \u003d RESOURCES_PATH + share_id"},{"line_number":63,"context_line":"            return self._list(url, RESOURCES_NAME)"},{"line_number":64,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a68dd71_0e5a782a","line":61,"range":{"start_line":61,"start_character":25,"end_line":61,"end_character":33},"updated":"2016-01-24 05:58:21.000000000","message":"share_id","commit_id":"f9f3cd405fe8343d817dc66c103091f84147e7f4"}],"manilaclient/v2/share_replicas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d01fcd04b525c4c4f33f93102a4c0d2ebf8c5065","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright Chuck Fouts"},{"line_number":2,"context_line":"# Copyright (c) 2016 Goutham Pacha Ravi"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_23d0101f","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":39},"updated":"2016-02-22 10:19:00.000000000","message":"Please, make copyrights look similar. Also, copyright should contain year.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright Chuck Fouts"},{"line_number":2,"context_line":"# Copyright (c) 2016 Goutham Pacha Ravi"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_ba0f132d","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":39},"in_reply_to":"bae84128_23d0101f","updated":"2016-02-22 21:08:31.000000000","message":"Done","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d01fcd04b525c4c4f33f93102a4c0d2ebf8c5065","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if share:"},{"line_number":77,"context_line":"            share_id \u003d \u0027?share_id\u003d\u0027 + str(common_base.getid(share))"},{"line_number":78,"context_line":"            url \u003d RESOURCES_PATH + \u0027/detail\u0027 + share_id"},{"line_number":79,"context_line":"            return self._list(url, RESOURCES_NAME)"},{"line_number":80,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_6378582b","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":41},"updated":"2016-02-22 10:19:00.000000000","message":"Why do you need \"str\" conversion here? Looks redundant.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if share:"},{"line_number":77,"context_line":"            share_id \u003d \u0027?share_id\u003d\u0027 + str(common_base.getid(share))"},{"line_number":78,"context_line":"            url \u003d RESOURCES_PATH + \u0027/detail\u0027 + share_id"},{"line_number":79,"context_line":"            return self._list(url, RESOURCES_NAME)"},{"line_number":80,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_9a216fa2","line":77,"range":{"start_line":77,"start_character":38,"end_line":77,"end_character":41},"in_reply_to":"bae84128_6378582b","updated":"2016-02-22 21:08:31.000000000","message":"Done","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"16f230cc2b16e05e847c657a7ffa43723d49e82a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def create(self, share, availability_zone\u003dNone, share_network\u003dNone):"},{"line_number":93,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param share: The share to create the replica for"},{"line_number":96,"context_line":"        :param availability_zone: The \u0027availability_zone\u0027 of the replica."},{"line_number":97,"context_line":"        :param share_network: either share network object or its UUID."},{"line_number":98,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_6c903d44","line":95,"range":{"start_line":95,"start_character":22,"end_line":95,"end_character":57},"updated":"2016-02-22 15:09:01.000000000","message":"Indicate if \"share object or text with its ID\". Also better if comment doesn\u0027t end in a preposition.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def create(self, share, availability_zone\u003dNone, share_network\u003dNone):"},{"line_number":93,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param share: The share to create the replica for"},{"line_number":96,"context_line":"        :param availability_zone: The \u0027availability_zone\u0027 of the replica."},{"line_number":97,"context_line":"        :param share_network: either share network object or its UUID."},{"line_number":98,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_1a36ffe5","line":95,"range":{"start_line":95,"start_character":22,"end_line":95,"end_character":57},"in_reply_to":"bae84128_6c903d44","updated":"2016-02-22 21:08:31.000000000","message":"Done","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"16f230cc2b16e05e847c657a7ffa43723d49e82a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param share: The share to create the replica for"},{"line_number":96,"context_line":"        :param availability_zone: The \u0027availability_zone\u0027 of the replica."},{"line_number":97,"context_line":"        :param share_network: either share network object or its UUID."},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_ccf4e988","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":72},"updated":"2016-02-22 15:09:01.000000000","message":"Same as above comment.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        :param share: The share to create the replica for"},{"line_number":96,"context_line":"        :param availability_zone: The \u0027availability_zone\u0027 of the replica."},{"line_number":97,"context_line":"        :param share_network: either share network object or its UUID."},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_26f2c96f","line":96,"range":{"start_line":96,"start_character":34,"end_line":96,"end_character":72},"in_reply_to":"bae84128_ccf4e988","updated":"2016-02-22 21:08:31.000000000","message":"Done","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"16f230cc2b16e05e847c657a7ffa43723d49e82a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            RESOURCE_NAME)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @api_versions.wraps(\"2.11\")"},{"line_number":116,"context_line":"    def delete(self, replica, force\u003dFalse):"},{"line_number":117,"context_line":"        \"\"\"Delete a replica."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        :param replica: either replica object or its UUID."}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_0c7411fb","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":43},"updated":"2016-02-22 15:09:01.000000000","message":"Why do we have a delete method that takes a force flag if we also have a force_delete method?","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            RESOURCE_NAME)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @api_versions.wraps(\"2.11\")"},{"line_number":116,"context_line":"    def delete(self, replica, force\u003dFalse):"},{"line_number":117,"context_line":"        \"\"\"Delete a replica."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        :param replica: either replica object or its UUID."}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_46326d11","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":43},"in_reply_to":"bae84128_0c7411fb","updated":"2016-02-22 21:08:31.000000000","message":"the client should have --force flag as an option in the existing delete command. As an administrator i would use just that. However, to be consistent with the share-instance-force-delete command, i added the other way as well. I honestly think it shouldn\u0027t matter.. why shouldn\u0027t we have two ways to do the same thing?","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"054ce23c5bc17ffeb218fe5a350018d1127ac6be","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                            RESOURCE_NAME)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    @api_versions.wraps(\"2.11\")"},{"line_number":116,"context_line":"    def delete(self, replica, force\u003dFalse):"},{"line_number":117,"context_line":"        \"\"\"Delete a replica."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        :param replica: either replica object or its UUID."}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_1719a322","line":116,"range":{"start_line":116,"start_character":30,"end_line":116,"end_character":43},"in_reply_to":"bae84128_46326d11","updated":"2016-02-23 15:14:04.000000000","message":"Having two implementations of an operation means there are two code points to maintain instead of one. This means that you have to remember to update both code points which goes against the DRY principle (https://en.wikipedia.org/wiki/Don%27t_repeat_yourself). You also have to maintain additional test code.\n\nWhy is it better to have two ways to execute the same command? Also, the de facto standard between Manila and Cinder clients appears to be the use of the \"--force\" flag. The share-replica-force-delete method is not fully consistent with the rest of the API in the same way that the \"--force\" flag is. It seems to add more confusion than it does functionality at the cost of maintaining more code. Also, unless an end user has actually asked for this feature it is YAGNI (https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it).","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"16f230cc2b16e05e847c657a7ffa43723d49e82a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return self._do_force_delete(replica, \"force_delete\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @api_versions.wraps(\"2.11\")"},{"line_number":128,"context_line":"    def reset_state(self, replica, state):"},{"line_number":129,"context_line":"        return self._do_reset_state(replica, state, \"reset_status\")"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @api_versions.wraps(\"2.11\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_ec78cdc6","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":19},"updated":"2016-02-22 15:09:01.000000000","message":"Definitely need comments on what \"reset_state\" and \"reset_replica_state\" do and how they differ. Not knowing the details myself the naming of the methods leads me to believe that they are redundant methods.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return self._do_force_delete(replica, \"force_delete\")"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @api_versions.wraps(\"2.11\")"},{"line_number":128,"context_line":"    def reset_state(self, replica, state):"},{"line_number":129,"context_line":"        return self._do_reset_state(replica, state, \"reset_status\")"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @api_versions.wraps(\"2.11\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_863c75e3","line":128,"range":{"start_line":128,"start_character":8,"end_line":128,"end_character":19},"in_reply_to":"bae84128_ec78cdc6","updated":"2016-02-22 21:08:31.000000000","message":"thanks, added docstring for consistency.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"db3391d86cb185ea7021704032679b925379640c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self._do_delete(replica, force\u003dforce)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @api_versions.wraps(\"2.11\")"},{"line_number":125,"context_line":"    def force_delete(self, replica):"},{"line_number":126,"context_line":"        \"\"\"Force delete a replica."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        :param replica: either replica object or its UUID."}],"source_content_type":"text/x-python","patch_set":8,"id":"9aed3d3a_2be2a09f","line":125,"updated":"2016-02-27 15:36:27.000000000","message":"This function appears to be unused now. Please remove the function.","commit_id":"3b162ff58268c90fa5a93a9d4a7ee3a60e53f6f4"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        share_id \u003d common_base.getid(share)"},{"line_number":97,"context_line":"        body \u003d {"},{"line_number":98,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":99,"context_line":"        }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if availability_zone:"},{"line_number":102,"context_line":"            body[\u0027availability_zone\u0027] \u003d common_base.getid(availability_zone)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_021fb15f","line":99,"range":{"start_line":97,"start_character":8,"end_line":99,"end_character":9},"updated":"2016-02-28 17:37:27.000000000","message":"No wrap.","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        \"\"\""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        share_id \u003d common_base.getid(share)"},{"line_number":97,"context_line":"        body \u003d {"},{"line_number":98,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":99,"context_line":"        }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if availability_zone:"},{"line_number":102,"context_line":"            body[\u0027availability_zone\u0027] \u003d common_base.getid(availability_zone)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_4296d9f0","line":99,"range":{"start_line":97,"start_character":8,"end_line":99,"end_character":9},"in_reply_to":"9aed3d3a_021fb15f","updated":"2016-02-28 19:43:37.000000000","message":"Done","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":13167,"name":"Yogesh","email":"ykshirsa@netapp.com","username":"yogi1"},"change_message_id":"b898e19329fac9386a8dfb94cb5e78abf846d8ba","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    return apiclient_utils.find_resource(cs.share_snapshots, snapshot)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def _print_share_snapshot(cs, snapshot):"},{"line_number":156,"context_line":"    info \u003d snapshot._info.copy()"},{"line_number":157,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":158,"context_line":"    cliutils.print_dict(info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_111be01c","line":155,"range":{"start_line":155,"start_character":4,"end_line":155,"end_character":25},"updated":"2016-01-28 17:16:37.000000000","message":"There is similar method above for replica. Why don\u0027t we merge then and avoid the duplication?","commit_id":"344cc41c785962ba8f4e4b655c31b541a2b51f5c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99637cec23fafc0d3e14cd7291a99a226d0a5a5b","unresolved":false,"context_lines":[{"line_number":2895,"context_line":"    share \u003d _find_share(cs, args.share_id) if args.share_id else None"},{"line_number":2896,"context_line":""},{"line_number":2897,"context_line":"    list_of_keys \u003d ["},{"line_number":2898,"context_line":"        \u0027ID\u0027, \u0027Status\u0027, \u0027Replica State\u0027,"},{"line_number":2899,"context_line":"        \u0027Share ID\u0027, \u0027Host\u0027, \u0027Availability Zone\u0027"},{"line_number":2900,"context_line":"    ]"},{"line_number":2901,"context_line":"    if share:"},{"line_number":2902,"context_line":"        replicas \u003d cs.share_replicas.list(share)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_f584890b","line":2899,"range":{"start_line":2898,"start_character":8,"end_line":2899,"end_character":47},"updated":"2016-02-06 16:47:03.000000000","message":"Need to add \"updated_at\" for display, it is very valuable to get to know when replica was updated.","commit_id":"09da923663f9f1c7710f31d72fa324e1c3a7c322"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99637cec23fafc0d3e14cd7291a99a226d0a5a5b","unresolved":false,"context_lines":[{"line_number":2965,"context_line":""},{"line_number":2966,"context_line":"    for replica in args.replica:"},{"line_number":2967,"context_line":"        try:"},{"line_number":2968,"context_line":"            replica_ref \u003d _find_share_replica(cs, replica)"},{"line_number":2969,"context_line":"            cs.share_replicas.delete(replica_ref)"},{"line_number":2970,"context_line":"        except Exception as e:"},{"line_number":2971,"context_line":"            failure_count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_f5b249e4","line":2968,"range":{"start_line":2968,"start_character":26,"end_line":2968,"end_character":45},"updated":"2016-02-06 16:47:03.000000000","message":"\"_find_share_replica\" returns replica object.\n\n\"replica\" can be only ID.\n\nIn \"cs.share_replicas.delete\" \"replica\" used only for taking ID.\n\nSo, this step is completely redundant and function \"_find_share_replica\" should be deleted as useless.","commit_id":"09da923663f9f1c7710f31d72fa324e1c3a7c322"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"99637cec23fafc0d3e14cd7291a99a226d0a5a5b","unresolved":false,"context_lines":[{"line_number":2985,"context_line":"@api_versions.experimental_api"},{"line_number":2986,"context_line":"def do_share_replica_promote(cs, args):"},{"line_number":2987,"context_line":"    \"\"\"Set the specified replica to active state.\"\"\""},{"line_number":2988,"context_line":"    replica \u003d _find_share_replica(cs, args.replica)"},{"line_number":2989,"context_line":"    cs.share_replicas.promote(replica)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_b5c9315b","line":2988,"range":{"start_line":2988,"start_character":14,"end_line":2988,"end_character":33},"updated":"2016-02-06 16:47:03.000000000","message":"Same here.","commit_id":"09da923663f9f1c7710f31d72fa324e1c3a7c322"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d01fcd04b525c4c4f33f93102a4c0d2ebf8c5065","unresolved":false,"context_lines":[{"line_number":3082,"context_line":"    default\u003dNone,"},{"line_number":3083,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3084,"context_line":"    help\u003d\u0027List replicas belonging to share.\u0027)"},{"line_number":3085,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":3086,"context_line":"@api_versions.experimental_api"},{"line_number":3087,"context_line":"def do_share_replica_list(cs, args):"},{"line_number":3088,"context_line":"    \"\"\"List share replicas.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_e3274862","line":3085,"range":{"start_line":3085,"start_character":0,"end_line":3085,"end_character":33},"updated":"2016-02-22 10:19:00.000000000","message":"Should be replaced with following:\n\n\"\"\"\n\n@api_versions.wraps(\"2.11\")\n\n\"\"\"\n\nSame for all other new methods.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":3082,"context_line":"    default\u003dNone,"},{"line_number":3083,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3084,"context_line":"    help\u003d\u0027List replicas belonging to share.\u0027)"},{"line_number":3085,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":3086,"context_line":"@api_versions.experimental_api"},{"line_number":3087,"context_line":"def do_share_replica_list(cs, args):"},{"line_number":3088,"context_line":"    \"\"\"List share replicas.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_612afb2d","line":3085,"range":{"start_line":3085,"start_character":0,"end_line":3085,"end_character":33},"in_reply_to":"bae84128_e3274862","updated":"2016-02-22 21:08:31.000000000","message":"Done","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"dd2c831aaafcf68aadd7d0cbb32927c91d9b8255","unresolved":false,"context_lines":[{"line_number":3210,"context_line":"    failure_count \u003d 0"},{"line_number":3211,"context_line":"    for replica in args.replica:"},{"line_number":3212,"context_line":"        try:"},{"line_number":3213,"context_line":"            replica \u003d _find_share_replica(replica)"},{"line_number":3214,"context_line":"            cs.share_replicas.force_delete(replica)"},{"line_number":3215,"context_line":"        except Exception as e:"},{"line_number":3216,"context_line":"            failure_count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_456ef195","line":3213,"range":{"start_line":3213,"start_character":12,"end_line":3213,"end_character":50},"updated":"2016-02-22 13:39:29.000000000","message":"It will fail. Should have two args, where first one is \"cs\". See line 3177.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b8d06fc401543c818b0878edc8ae01f4d0baf4c7","unresolved":false,"context_lines":[{"line_number":3210,"context_line":"    failure_count \u003d 0"},{"line_number":3211,"context_line":"    for replica in args.replica:"},{"line_number":3212,"context_line":"        try:"},{"line_number":3213,"context_line":"            replica \u003d _find_share_replica(replica)"},{"line_number":3214,"context_line":"            cs.share_replicas.force_delete(replica)"},{"line_number":3215,"context_line":"        except Exception as e:"},{"line_number":3216,"context_line":"            failure_count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_8561193c","line":3213,"range":{"start_line":3213,"start_character":12,"end_line":3213,"end_character":50},"in_reply_to":"bae84128_456ef195","updated":"2016-02-22 13:47:11.000000000","message":"Also it means test coverage is weak and should be improved.","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8c0f57927b1cd1089b210bce83e0ee4dfb89959a","unresolved":false,"context_lines":[{"line_number":3210,"context_line":"    failure_count \u003d 0"},{"line_number":3211,"context_line":"    for replica in args.replica:"},{"line_number":3212,"context_line":"        try:"},{"line_number":3213,"context_line":"            replica \u003d _find_share_replica(replica)"},{"line_number":3214,"context_line":"            cs.share_replicas.force_delete(replica)"},{"line_number":3215,"context_line":"        except Exception as e:"},{"line_number":3216,"context_line":"            failure_count +\u003d 1"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_25900dec","line":3213,"range":{"start_line":3213,"start_character":12,"end_line":3213,"end_character":50},"in_reply_to":"bae84128_8561193c","updated":"2016-02-22 13:49:14.000000000","message":"eek. see, that\u0027s why i need unit tests :) Thanks!","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d01fcd04b525c4c4f33f93102a4c0d2ebf8c5065","unresolved":false,"context_lines":[{"line_number":3235,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":3236,"context_line":"@api_versions.experimental_api"},{"line_number":3237,"context_line":"def do_share_replica_reset_state(cs, args):"},{"line_number":3238,"context_line":"    \"\"\"Explicitly update the \u0027status\u0027 of a share replica.\"\"\""},{"line_number":3239,"context_line":"    replica \u003d _find_share_replica(cs, args.replica)"},{"line_number":3240,"context_line":"    cs.share_replicas.reset_state(replica, args.state)"},{"line_number":3241,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_036fcc92","line":3238,"range":{"start_line":3238,"start_character":30,"end_line":3238,"end_character":36},"updated":"2016-02-22 10:19:00.000000000","message":"Here \"status\" but CMD contains \"state\"?","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":3235,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":3236,"context_line":"@api_versions.experimental_api"},{"line_number":3237,"context_line":"def do_share_replica_reset_state(cs, args):"},{"line_number":3238,"context_line":"    \"\"\"Explicitly update the \u0027status\u0027 of a share replica.\"\"\""},{"line_number":3239,"context_line":"    replica \u003d _find_share_replica(cs, args.replica)"},{"line_number":3240,"context_line":"    cs.share_replicas.reset_state(replica, args.state)"},{"line_number":3241,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_c196674b","line":3238,"range":{"start_line":3238,"start_character":30,"end_line":3238,"end_character":36},"in_reply_to":"bae84128_036fcc92","updated":"2016-02-22 21:08:31.000000000","message":"yeah.. that\u0027s a known discrepancy, isn\u0027t it... we\u0027ve \u0027status\u0027 and \u0027replica_state\u0027 attributes in the resource, ShareInstance.\n\nHowever, we would like for this CLI to be consistent with what was there for shares, share_instances, cgs, snapshots, etc.\n\n    do_share_instance_reset_state on line 1248\n    do_snapshot_reset_state on line 1545\n    do_reset_state on line 1562\n    do_cg_reset_state on line 2837\n    do_cg_snapshot_reset_state on line 2962","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d01fcd04b525c4c4f33f93102a4c0d2ebf8c5065","unresolved":false,"context_lines":[{"line_number":3268,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":3269,"context_line":"@api_versions.experimental_api"},{"line_number":3270,"context_line":"def do_share_replica_resync(cs, args):"},{"line_number":3271,"context_line":"    \"\"\"Explicitly update the \u0027replica_state\u0027 of a share replica.\"\"\""},{"line_number":3272,"context_line":"    replica \u003d _find_share_replica(cs, args.replica)"},{"line_number":3273,"context_line":"    cs.share_replicas.resync(replica)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_e3590800","line":3271,"range":{"start_line":3271,"start_character":7,"end_line":3271,"end_character":64},"updated":"2016-02-22 10:19:00.000000000","message":"Copy-paste from \"share-replica-reset-replica-state\".","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5a4cc6652b83470359337ec778465949e94bb6e1","unresolved":false,"context_lines":[{"line_number":3268,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":3269,"context_line":"@api_versions.experimental_api"},{"line_number":3270,"context_line":"def do_share_replica_resync(cs, args):"},{"line_number":3271,"context_line":"    \"\"\"Explicitly update the \u0027replica_state\u0027 of a share replica.\"\"\""},{"line_number":3272,"context_line":"    replica \u003d _find_share_replica(cs, args.replica)"},{"line_number":3273,"context_line":"    cs.share_replicas.resync(replica)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_c1d2e7ff","line":3271,"range":{"start_line":3271,"start_character":7,"end_line":3271,"end_character":64},"in_reply_to":"bae84128_e3590800","updated":"2016-02-22 21:08:31.000000000","message":"Done. Though it still makes sense :P","commit_id":"b1886e4f7fa936b52868eed5b2d70ddcd850852f"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":3078,"context_line":"    \u0027--share-id\u0027,"},{"line_number":3079,"context_line":"    \u0027--share_id\u0027,"},{"line_number":3080,"context_line":"    \u0027--si\u0027,  # alias"},{"line_number":3081,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":3082,"context_line":"    default\u003dNone,"},{"line_number":3083,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3084,"context_line":"    help\u003d\u0027List replicas belonging to share.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_822101a2","line":3081,"range":{"start_line":3081,"start_character":12,"end_line":3081,"end_character":24},"updated":"2016-02-28 17:37:27.000000000","message":"Can this accept the share name or ID, same as do_share_replica_create() below?","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":3078,"context_line":"    \u0027--share-id\u0027,"},{"line_number":3079,"context_line":"    \u0027--share_id\u0027,"},{"line_number":3080,"context_line":"    \u0027--si\u0027,  # alias"},{"line_number":3081,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":3082,"context_line":"    default\u003dNone,"},{"line_number":3083,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3084,"context_line":"    help\u003d\u0027List replicas belonging to share.\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_62715de0","line":3081,"range":{"start_line":3081,"start_character":12,"end_line":3081,"end_character":24},"in_reply_to":"9aed3d3a_822101a2","updated":"2016-02-28 19:43:37.000000000","message":"It does, right now. Could add --share or --share-name as option aliases... but none of the other commands here have either of those option aliases..","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":3156,"context_line":"    \u0027replica\u0027,"},{"line_number":3157,"context_line":"    metavar\u003d\u0027\u003creplica\u003e\u0027,"},{"line_number":3158,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":3159,"context_line":"    help\u003d\u0027ID of the replica.\u0027)"},{"line_number":3160,"context_line":"@cliutils.arg("},{"line_number":3161,"context_line":"    \u0027--force\u0027,"},{"line_number":3162,"context_line":"    action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_424ed96f","line":3159,"range":{"start_line":3159,"start_character":9,"end_line":3159,"end_character":29},"updated":"2016-02-28 17:37:27.000000000","message":"Nit: Above you say \u0027ID of the replica instance\u0027, while this says \u0027ID of the replica\u0027.  Can you improve the consistency in the help strings?","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":3156,"context_line":"    \u0027replica\u0027,"},{"line_number":3157,"context_line":"    metavar\u003d\u0027\u003creplica\u003e\u0027,"},{"line_number":3158,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":3159,"context_line":"    help\u003d\u0027ID of the replica.\u0027)"},{"line_number":3160,"context_line":"@cliutils.arg("},{"line_number":3161,"context_line":"    \u0027--force\u0027,"},{"line_number":3162,"context_line":"    action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_424b7987","line":3159,"range":{"start_line":3159,"start_character":9,"end_line":3159,"end_character":29},"in_reply_to":"9aed3d3a_424ed96f","updated":"2016-02-28 19:43:37.000000000","message":"yessir","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":3158,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":3159,"context_line":"    help\u003d\u0027ID of the replica.\u0027)"},{"line_number":3160,"context_line":"@cliutils.arg("},{"line_number":3161,"context_line":"    \u0027--force\u0027,"},{"line_number":3162,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3163,"context_line":"    default\u003dFalse,"},{"line_number":3164,"context_line":"    help\u003d\u0027Administrators can force delete the replica (Default\u003dFalse).\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_625b1d2f","line":3161,"range":{"start_line":3161,"start_character":5,"end_line":3161,"end_character":12},"updated":"2016-02-28 17:37:27.000000000","message":"What does this actually mean?  Delete from DB and don\u0027t contact backends?  Delete from DB while ignoring all backend errors?","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":3158,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":3159,"context_line":"    help\u003d\u0027ID of the replica.\u0027)"},{"line_number":3160,"context_line":"@cliutils.arg("},{"line_number":3161,"context_line":"    \u0027--force\u0027,"},{"line_number":3162,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3163,"context_line":"    default\u003dFalse,"},{"line_number":3164,"context_line":"    help\u003d\u0027Administrators can force delete the replica (Default\u003dFalse).\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_e2544d22","line":3161,"range":{"start_line":3161,"start_character":5,"end_line":3161,"end_character":12},"in_reply_to":"9aed3d3a_625b1d2f","updated":"2016-02-28 19:43:37.000000000","message":"Attempt to cleanup from the backend .. Enhanced help string.","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"5b42b7f5b3a14a72127cc7d864731308f5206b5c","unresolved":false,"context_lines":[{"line_number":3201,"context_line":"@cliutils.arg("},{"line_number":3202,"context_line":"    \u0027replica\u0027,"},{"line_number":3203,"context_line":"    metavar\u003d\u0027\u003creplica\u003e\u0027,"},{"line_number":3204,"context_line":"    help\u003d\u0027Name or ID of the share replica to modify.\u0027)"},{"line_number":3205,"context_line":"@cliutils.arg("},{"line_number":3206,"context_line":"    \u0027--state\u0027,"},{"line_number":3207,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_024df16b","line":3204,"range":{"start_line":3204,"start_character":10,"end_line":3204,"end_character":52},"updated":"2016-02-28 17:37:27.000000000","message":"In do_share_replica_create(), one cannot specify a replica name.  So how can this command identify a replica by name?  Same below.","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"51a01c71d95720af0f805a32af28cda8d741e89c","unresolved":false,"context_lines":[{"line_number":3201,"context_line":"@cliutils.arg("},{"line_number":3202,"context_line":"    \u0027replica\u0027,"},{"line_number":3203,"context_line":"    metavar\u003d\u0027\u003creplica\u003e\u0027,"},{"line_number":3204,"context_line":"    help\u003d\u0027Name or ID of the share replica to modify.\u0027)"},{"line_number":3205,"context_line":"@cliutils.arg("},{"line_number":3206,"context_line":"    \u0027--state\u0027,"},{"line_number":3207,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aed3d3a_dd19287b","line":3204,"range":{"start_line":3204,"start_character":10,"end_line":3204,"end_character":52},"in_reply_to":"9aed3d3a_024df16b","updated":"2016-02-28 19:43:37.000000000","message":"Thanks. Removed.","commit_id":"3ec11bd73c727a6903f7f9b4b168fd45ea2ad0b4"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"073a267ecbf0fa7a3f066f33722f17bcb3707e73","unresolved":false,"context_lines":[{"line_number":3161,"context_line":"    \u0027--force\u0027,"},{"line_number":3162,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3163,"context_line":"    default\u003dFalse,"},{"line_number":3164,"context_line":"    help\u003d\u0027Attempt to force deletion of a replica on its backend. Setting \u0027"},{"line_number":3165,"context_line":"         \u0027this option to True will purge the replica from Manila even if it \u0027"},{"line_number":3166,"context_line":"         \u0027is not cleaned up on the backend. Defaults to False.\u0027)"},{"line_number":3167,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":3168,"context_line":"@api_versions.experimental_api"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_af4d0940","line":3165,"range":{"start_line":3164,"start_character":65,"end_line":3165,"end_character":29},"updated":"2016-02-29 00:22:26.000000000","message":"Do you really have to set the option to True?  I thought action\u003d\u0027store_true\u0027 meant you only had to specify --force without being required to include its value.\n\nAnd how did you get Alex to go along with a --force switch anyway?","commit_id":"a1eaf192341b4feee53433c39461f2358a9a1abe"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"37185fb291fce23c996a7a6fcd9bab241b8ab2f8","unresolved":false,"context_lines":[{"line_number":3161,"context_line":"    \u0027--force\u0027,"},{"line_number":3162,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":3163,"context_line":"    default\u003dFalse,"},{"line_number":3164,"context_line":"    help\u003d\u0027Attempt to force deletion of a replica on its backend. Setting \u0027"},{"line_number":3165,"context_line":"         \u0027this option to True will purge the replica from Manila even if it \u0027"},{"line_number":3166,"context_line":"         \u0027is not cleaned up on the backend. Defaults to False.\u0027)"},{"line_number":3167,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":3168,"context_line":"@api_versions.experimental_api"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aed3d3a_6f42e169","line":3165,"range":{"start_line":3164,"start_character":65,"end_line":3165,"end_character":29},"in_reply_to":"9aed3d3a_af4d0940","updated":"2016-02-29 01:01:10.000000000","message":"Thanks, fixed. Learned that argparse behavior new today! Alex and I hate force_delete. However, following the idiom here, if administrators think that this destructive action is the only way to eliminate something, they can use this flag.. Its almost like having bare DB access at this point.","commit_id":"a1eaf192341b4feee53433c39461f2358a9a1abe"}]}
