)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds CLI commands to manage/unmanage snapshot."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Server side change:"},{"line_number":12,"context_line":"https://review.openstack.org/#/c/249542/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3a74dcca46396a7161be69d181b1566652ea5b32"},{"line_number":15,"context_line":"Implements: blueprint manage-unmanage-snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bae84128_d1cad919","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":40},"updated":"2016-02-22 03:24:00.000000000","message":"This needs to be:\n\nDepends-On: I87a066173c85d969607d132accd9f0e9bd49c235\n\nSince this message does not make sense after the patch has merged, i would suggest not including this here. manila-client functional tests should not pass until the server micro version is \u003e\u003d the micro version configured here.. so this will not merge until the server side change merges.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds CLI commands to manage/unmanage snapshot."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Server side change:"},{"line_number":12,"context_line":"https://review.openstack.org/#/c/249542/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I3a74dcca46396a7161be69d181b1566652ea5b32"},{"line_number":15,"context_line":"Implements: blueprint manage-unmanage-snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bae84128_c319ab7b","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":40},"in_reply_to":"bae84128_d1cad919","updated":"2016-02-25 04:16:55.000000000","message":"Removed.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"}],"manilaclient/api_versions.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8837660a4d54ac03c947fccebd3e7c5fe078b30","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MAX_VERSION \u003d \u00272.9\u0027"},{"line_number":35,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":36,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_6bc3c889","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":18},"updated":"2016-02-08 04:49:40.000000000","message":"2.11 is currently the next available microversion.","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f77a2b27ea1ceba9ea745e76f121a0c5044cc508","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    LOG.addHandler(logging.StreamHandler())"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"MAX_VERSION \u003d \u00272.9\u0027"},{"line_number":35,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":36,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":37,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_87f14697","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":18},"in_reply_to":"5a5ae5dd_6bc3c889","updated":"2016-02-08 13:48:57.000000000","message":"Done","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"}],"manilaclient/tests/unit/test_api_versions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50076b2c4c3abe2984e43fad682eb65f54a6e15f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            self.assertEqual(v.ver_minor, exp_minor)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        _test_string(\"1.1\", 1, 1)"},{"line_number":34,"context_line":"        _test_string(\"2.11\", 2, 11)"},{"line_number":35,"context_line":"        _test_string(\"5.234\", 5, 234)"},{"line_number":36,"context_line":"        _test_string(\"12.5\", 12, 5)"},{"line_number":37,"context_line":"        _test_string(\"2.0\", 2, 0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_3efeb76b","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":35},"updated":"2016-02-15 07:12:27.000000000","message":"unrelated changes?","commit_id":"5bc207624c8a0806a81eb61ba1de1b4a1e19338b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2f3948e2d1e8333ec040a763178a87c0c2c5c86d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            self.assertEqual(v.ver_minor, exp_minor)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        _test_string(\"1.1\", 1, 1)"},{"line_number":34,"context_line":"        _test_string(\"2.11\", 2, 11)"},{"line_number":35,"context_line":"        _test_string(\"5.234\", 5, 234)"},{"line_number":36,"context_line":"        _test_string(\"12.5\", 12, 5)"},{"line_number":37,"context_line":"        _test_string(\"2.0\", 2, 0)"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7dae1299","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":35},"in_reply_to":"dae33548_3efeb76b","updated":"2016-02-17 07:33:03.000000000","message":"Removed.","commit_id":"5bc207624c8a0806a81eb61ba1de1b4a1e19338b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"50076b2c4c3abe2984e43fad682eb65f54a6e15f","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_server_is_too_old(self):"},{"line_number":264,"context_line":"        self._mock_returned_server_version(\u00272.2\u0027, \u00272.0\u0027)"},{"line_number":265,"context_line":"        manilaclient.API_MAX_VERSION \u003d api_versions.APIVersion(\"2.11\")"},{"line_number":266,"context_line":"        manilaclient.API_MIN_VERSION \u003d api_versions.APIVersion(\"2.9\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        self.assertRaises(exceptions.UnsupportedVersion,"},{"line_number":269,"context_line":"                          api_versions.discover_version,"},{"line_number":270,"context_line":"                          self.fake_client,"},{"line_number":271,"context_line":"                          api_versions.APIVersion(\"2.11\"))"},{"line_number":272,"context_line":"        self.assertTrue(self.fake_client.services.server_api_version.called)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_server_and_client_max_are_same(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_fe2a8fe6","line":271,"range":{"start_line":265,"start_character":59,"end_line":271,"end_character":56},"updated":"2016-02-15 07:12:27.000000000","message":"same..","commit_id":"5bc207624c8a0806a81eb61ba1de1b4a1e19338b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2f3948e2d1e8333ec040a763178a87c0c2c5c86d","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_server_is_too_old(self):"},{"line_number":264,"context_line":"        self._mock_returned_server_version(\u00272.2\u0027, \u00272.0\u0027)"},{"line_number":265,"context_line":"        manilaclient.API_MAX_VERSION \u003d api_versions.APIVersion(\"2.11\")"},{"line_number":266,"context_line":"        manilaclient.API_MIN_VERSION \u003d api_versions.APIVersion(\"2.9\")"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        self.assertRaises(exceptions.UnsupportedVersion,"},{"line_number":269,"context_line":"                          api_versions.discover_version,"},{"line_number":270,"context_line":"                          self.fake_client,"},{"line_number":271,"context_line":"                          api_versions.APIVersion(\"2.11\"))"},{"line_number":272,"context_line":"        self.assertTrue(self.fake_client.services.server_api_version.called)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_server_and_client_max_are_same(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dae33548_7d857205","line":271,"range":{"start_line":265,"start_character":59,"end_line":271,"end_character":56},"in_reply_to":"dae33548_fe2a8fe6","updated":"2016-02-17 07:33:03.000000000","message":"Done","commit_id":"5bc207624c8a0806a81eb61ba1de1b4a1e19338b"}],"manilaclient/tests/unit/v2/test_share_snapshots.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            \"name\": name,"},{"line_number":151,"context_line":"            \"description\": description,"},{"line_number":152,"context_line":"        }"},{"line_number":153,"context_line":"        version \u003d api_versions.APIVersion(\"2.9\")"},{"line_number":154,"context_line":"        mock_microversion \u003d mock.Mock(api_version\u003dversion)"},{"line_number":155,"context_line":"        manager \u003d share_snapshots.ShareSnapshotManager(api\u003dmock_microversion)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_d02f9b9f","line":153,"range":{"start_line":153,"start_character":43,"end_line":153,"end_character":46},"updated":"2016-02-10 17:03:53.000000000","message":"2.11","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            \"name\": name,"},{"line_number":151,"context_line":"            \"description\": description,"},{"line_number":152,"context_line":"        }"},{"line_number":153,"context_line":"        version \u003d api_versions.APIVersion(\"2.9\")"},{"line_number":154,"context_line":"        mock_microversion \u003d mock.Mock(api_version\u003dversion)"},{"line_number":155,"context_line":"        manager \u003d share_snapshots.ShareSnapshotManager(api\u003dmock_microversion)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_f5af6092","line":153,"range":{"start_line":153,"start_character":43,"end_line":153,"end_character":46},"in_reply_to":"3a57f1b5_d02f9b9f","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_unmanage_snapshot(self):"},{"line_number":168,"context_line":"        snapshot \u003d \"fake_snapshot\""},{"line_number":169,"context_line":"        version \u003d api_versions.APIVersion(\"2.9\")"},{"line_number":170,"context_line":"        mock_microversion \u003d mock.Mock(api_version\u003dversion)"},{"line_number":171,"context_line":"        manager \u003d share_snapshots.ShareSnapshotManager(api\u003dmock_microversion)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_f02c17ad","line":169,"range":{"start_line":169,"start_character":43,"end_line":169,"end_character":46},"updated":"2016-02-10 17:03:53.000000000","message":"2.11","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_unmanage_snapshot(self):"},{"line_number":168,"context_line":"        snapshot \u003d \"fake_snapshot\""},{"line_number":169,"context_line":"        version \u003d api_versions.APIVersion(\"2.9\")"},{"line_number":170,"context_line":"        mock_microversion \u003d mock.Mock(api_version\u003dversion)"},{"line_number":171,"context_line":"        manager \u003d share_snapshots.ShareSnapshotManager(api\u003dmock_microversion)"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_55956c3e","line":169,"range":{"start_line":169,"start_character":43,"end_line":169,"end_character":46},"in_reply_to":"3a57f1b5_f02c17ad","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3e776555159d0e16a49a04e4e5385fafb971ff3e","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def test_snapshot_unmanage(self):"},{"line_number":572,"context_line":"        self.run_command(\u0027snapshot-unmanage 1234\u0027)"},{"line_number":573,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/snapshots/1234/action\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def test_delete(self):"},{"line_number":576,"context_line":"        self.run_command(\u0027delete 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_4d1885d3","line":573,"range":{"start_line":573,"start_character":58,"end_line":573,"end_character":60},"updated":"2016-03-01 01:21:14.000000000","message":"body \u003d {\u0027unmanage\u0027: None}\n\nif you make another patch.","commit_id":"fdcaadaec43e9b80fb5b3e23e4c755435e7fcf2b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"25419148deaa7cd7526d63c7d07b6c5e58f2a6ba","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    def test_snapshot_unmanage(self):"},{"line_number":572,"context_line":"        self.run_command(\u0027snapshot-unmanage 1234\u0027)"},{"line_number":573,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/snapshots/1234/action\u0027)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"    def test_delete(self):"},{"line_number":576,"context_line":"        self.run_command(\u0027delete 1234\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aed3d3a_566932f8","line":573,"range":{"start_line":573,"start_character":58,"end_line":573,"end_character":60},"in_reply_to":"9aed3d3a_4d1885d3","updated":"2016-03-01 03:01:15.000000000","message":"Done","commit_id":"fdcaadaec43e9b80fb5b3e23e4c755435e7fcf2b"}],"manilaclient/v2/share_snapshots.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                             \u0027description\u0027: description}}"},{"line_number":77,"context_line":"        return self._create(\u0027/snapshots\u0027, body, \u0027snapshot\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @api_versions.wraps(\"2.9\")  # noqa"},{"line_number":80,"context_line":"    def manage(self, share_id, driver_options\u003dNone,"},{"line_number":81,"context_line":"               name\u003dNone, description\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Manage some existing share snapshot."}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_300aaf27","line":79,"range":{"start_line":79,"start_character":25,"end_line":79,"end_character":28},"updated":"2016-02-10 17:03:53.000000000","message":"2.11","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                             \u0027description\u0027: description}}"},{"line_number":77,"context_line":"        return self._create(\u0027/snapshots\u0027, body, \u0027snapshot\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @api_versions.wraps(\"2.9\")  # noqa"},{"line_number":80,"context_line":"    def manage(self, share_id, driver_options\u003dNone,"},{"line_number":81,"context_line":"               name\u003dNone, description\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Manage some existing share snapshot."}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_f5b480d2","line":79,"range":{"start_line":79,"start_character":25,"end_line":79,"end_character":28},"in_reply_to":"3a57f1b5_300aaf27","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param share_id: UUID of the share."},{"line_number":85,"context_line":"        :param driver_options: dict - custom set of key-values."},{"line_number":86,"context_line":"        :param name: text - name of new share"},{"line_number":87,"context_line":"        :param description: - description for new share"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        driver_options \u003d driver_options if driver_options else dict()"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_0b21884d","line":86,"range":{"start_line":86,"start_character":40,"end_line":86,"end_character":45},"updated":"2016-02-10 17:03:53.000000000","message":"s/share/snapshot","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param share_id: UUID of the share."},{"line_number":85,"context_line":"        :param driver_options: dict - custom set of key-values."},{"line_number":86,"context_line":"        :param name: text - name of new share"},{"line_number":87,"context_line":"        :param description: - description for new share"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        driver_options \u003d driver_options if driver_options else dict()"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_55ca8c50","line":86,"range":{"start_line":86,"start_character":40,"end_line":86,"end_character":45},"in_reply_to":"3a57f1b5_0b21884d","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        :param share_id: UUID of the share."},{"line_number":85,"context_line":"        :param driver_options: dict - custom set of key-values."},{"line_number":86,"context_line":"        :param name: text - name of new share"},{"line_number":87,"context_line":"        :param description: - description for new share"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        driver_options \u003d driver_options if driver_options else dict()"},{"line_number":90,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_eb174ceb","line":87,"range":{"start_line":87,"start_character":50,"end_line":87,"end_character":55},"updated":"2016-02-10 17:03:53.000000000","message":"s/share/snapshot","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        :param share_id: UUID of the share."},{"line_number":85,"context_line":"        :param driver_options: dict - custom set of key-values."},{"line_number":86,"context_line":"        :param name: text - name of new share"},{"line_number":87,"context_line":"        :param description: - description for new share"},{"line_number":88,"context_line":"        \"\"\""},{"line_number":89,"context_line":"        driver_options \u003d driver_options if driver_options else dict()"},{"line_number":90,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_35c70847","line":87,"range":{"start_line":87,"start_character":50,"end_line":87,"end_character":55},"in_reply_to":"3a57f1b5_eb174ceb","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        return self._create(\u0027/snapshots/manage\u0027, {\u0027snapshot\u0027: body},"},{"line_number":97,"context_line":"                            \u0027snapshot\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @api_versions.wraps(\"2.9\")  # noqa"},{"line_number":100,"context_line":"    def unmanage(self, snapshot):"},{"line_number":101,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_7017c751","line":99,"range":{"start_line":99,"start_character":25,"end_line":99,"end_character":28},"updated":"2016-02-10 17:03:53.000000000","message":"2.11","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        return self._create(\u0027/snapshots/manage\u0027, {\u0027snapshot\u0027: body},"},{"line_number":97,"context_line":"                            \u0027snapshot\u0027)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @api_versions.wraps(\"2.9\")  # noqa"},{"line_number":100,"context_line":"    def unmanage(self, snapshot):"},{"line_number":101,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_95c41441","line":99,"range":{"start_line":99,"start_character":25,"end_line":99,"end_character":28},"in_reply_to":"3a57f1b5_7017c751","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def unmanage(self, snapshot):"},{"line_number":101,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        :param share: either share object or text with its ID."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        return self._action(\"unmanage\", snapshot)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_0be8a8e1","line":103,"range":{"start_line":103,"start_character":15,"end_line":103,"end_character":20},"updated":"2016-02-10 17:03:53.000000000","message":"s/share/snapshot","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"79b1e4127b3014a59e50ef43fee632b44fc78e30","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def unmanage(self, snapshot):"},{"line_number":101,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        :param share: either share object or text with its ID."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        return self._action(\"unmanage\", snapshot)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_2bcc8488","line":103,"range":{"start_line":103,"start_character":29,"end_line":103,"end_character":34},"updated":"2016-02-10 17:03:53.000000000","message":"s/share/snapshot","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4d48d81b89ef6a0a6d83a6e0ad4479e08d21bc2b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def unmanage(self, snapshot):"},{"line_number":101,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        :param share: either share object or text with its ID."},{"line_number":104,"context_line":"        \"\"\""},{"line_number":105,"context_line":"        return self._action(\"unmanage\", snapshot)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_75c1902e","line":103,"range":{"start_line":103,"start_character":29,"end_line":103,"end_character":34},"in_reply_to":"3a57f1b5_2bcc8488","updated":"2016-02-14 06:19:59.000000000","message":"Done","commit_id":"9ce478b6eaa994fb5b9c972d63e3469634b8c696"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"Unmanage this snapshot.\"\"\""},{"line_number":52,"context_line":"        self.manager.unmanage(self)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def manage_snapshot(self):"},{"line_number":55,"context_line":"        \"\"\"Manage this snapshot.\"\"\""},{"line_number":56,"context_line":"        self.manager.manage(self)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ShareSnapshotManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_11a3a150","line":56,"range":{"start_line":54,"start_character":4,"end_line":56,"end_character":33},"updated":"2016-02-22 03:24:00.000000000","message":"I guess you don\u0027t need this here.. because manage takes params from the shell besides the snapshot ref itself.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"Unmanage this snapshot.\"\"\""},{"line_number":52,"context_line":"        self.manager.unmanage(self)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def manage_snapshot(self):"},{"line_number":55,"context_line":"        \"\"\"Manage this snapshot.\"\"\""},{"line_number":56,"context_line":"        self.manager.manage(self)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class ShareSnapshotManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_e805ae14","line":56,"range":{"start_line":54,"start_character":4,"end_line":56,"end_character":33},"in_reply_to":"bae84128_11a3a150","updated":"2016-02-25 04:16:55.000000000","message":"You are right.  Removed.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                             \u0027description\u0027: description}}"},{"line_number":77,"context_line":"        return self._create(\u0027/snapshots\u0027, body, \u0027snapshot\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @api_versions.wraps(\"2.12\")  # noqa"},{"line_number":80,"context_line":"    def manage(self, share_id, provider_location,"},{"line_number":81,"context_line":"               driver_options\u003dNone,"},{"line_number":82,"context_line":"               name\u003dNone, description\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_31b7c587","line":79,"range":{"start_line":79,"start_character":33,"end_line":79,"end_character":39},"updated":"2016-02-22 03:24:00.000000000","message":"why noqa?","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                             \u0027description\u0027: description}}"},{"line_number":77,"context_line":"        return self._create(\u0027/snapshots\u0027, body, \u0027snapshot\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    @api_versions.wraps(\"2.12\")  # noqa"},{"line_number":80,"context_line":"    def manage(self, share_id, provider_location,"},{"line_number":81,"context_line":"               driver_options\u003dNone,"},{"line_number":82,"context_line":"               name\u003dNone, description\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_63089f29","line":79,"range":{"start_line":79,"start_character":33,"end_line":79,"end_character":39},"in_reply_to":"bae84128_31b7c587","updated":"2016-02-25 04:16:55.000000000","message":"I saw this in shares.py.  I thought it is needed to avoid a pep8 error.  It looks like we don\u0027t need it.  Removed.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return self._create(\u0027/snapshots/manage\u0027, {\u0027snapshot\u0027: body},"},{"line_number":99,"context_line":"                            \u0027snapshot\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @api_versions.wraps(\"2.12\")  # noqa"},{"line_number":102,"context_line":"    def unmanage(self, snapshot):"},{"line_number":103,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_71b14d8f","line":101,"range":{"start_line":101,"start_character":32,"end_line":101,"end_character":39},"updated":"2016-02-22 03:24:00.000000000","message":"?","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        return self._create(\u0027/snapshots/manage\u0027, {\u0027snapshot\u0027: body},"},{"line_number":99,"context_line":"                            \u0027snapshot\u0027)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @api_versions.wraps(\"2.12\")  # noqa"},{"line_number":102,"context_line":"    def unmanage(self, snapshot):"},{"line_number":103,"context_line":"        \"\"\"Unmanage a share snapshot."},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_430d9b36","line":101,"range":{"start_line":101,"start_character":32,"end_line":101,"end_character":39},"in_reply_to":"bae84128_71b14d8f","updated":"2016-02-25 04:16:55.000000000","message":"Removed.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e6984b053708db07c65ed069b576965c7beb0437","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def manage(self, share, provider_location,"},{"line_number":77,"context_line":"               driver_options\u003dNone,"},{"line_number":78,"context_line":"               name\u003dNone, description\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Manage some existing share snapshot."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param share: The share."},{"line_number":82,"context_line":"        :param provider_location: The provider location of"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_076fda92","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":22},"updated":"2016-02-27 03:50:46.000000000","message":"s/some/an","commit_id":"aa8e7fbeb7036e5cfb342394a97f99fc63cd3b35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6859442742f23bd93971925f08bae950af285836","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def manage(self, share, provider_location,"},{"line_number":77,"context_line":"               driver_options\u003dNone,"},{"line_number":78,"context_line":"               name\u003dNone, description\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Manage some existing share snapshot."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param share: The share."},{"line_number":82,"context_line":"        :param provider_location: The provider location of"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_7d3c5ce2","line":79,"range":{"start_line":79,"start_character":18,"end_line":79,"end_character":22},"in_reply_to":"9aed3d3a_076fda92","updated":"2016-02-28 20:55:57.000000000","message":"Done","commit_id":"aa8e7fbeb7036e5cfb342394a97f99fc63cd3b35"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"8c2bd728696ada7386eac56a850d0cc25c036b31","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \u0027provider_location\u0027: provider_location,"},{"line_number":92,"context_line":"            \u0027driver_options\u0027: driver_options,"},{"line_number":93,"context_line":"            \u0027name\u0027: name,"},{"line_number":94,"context_line":"            \u0027description\u0027: description"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"        return self._create(\u0027/snapshots/manage\u0027, {\u0027snapshot\u0027: body},"},{"line_number":97,"context_line":"                            \u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_2ec62948","line":94,"range":{"start_line":94,"start_character":37,"end_line":94,"end_character":38},"updated":"2016-02-28 01:39:41.000000000","message":"If you do another patch set, add a trailing comma...","commit_id":"aa8e7fbeb7036e5cfb342394a97f99fc63cd3b35"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"6859442742f23bd93971925f08bae950af285836","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            \u0027provider_location\u0027: provider_location,"},{"line_number":92,"context_line":"            \u0027driver_options\u0027: driver_options,"},{"line_number":93,"context_line":"            \u0027name\u0027: name,"},{"line_number":94,"context_line":"            \u0027description\u0027: description"},{"line_number":95,"context_line":"        }"},{"line_number":96,"context_line":"        return self._create(\u0027/snapshots/manage\u0027, {\u0027snapshot\u0027: body},"},{"line_number":97,"context_line":"                            \u0027snapshot\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"9aed3d3a_5d3fd8d5","line":94,"range":{"start_line":94,"start_character":37,"end_line":94,"end_character":38},"in_reply_to":"9aed3d3a_2ec62948","updated":"2016-02-28 20:55:57.000000000","message":"Done","commit_id":"aa8e7fbeb7036e5cfb342394a97f99fc63cd3b35"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"069e1bced7f74ec6325ad7d986a2917d730ea951","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               name\u003dNone, description\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Manage an existing share snapshot."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param share: The share."},{"line_number":82,"context_line":"        :param provider_location: The provider location of"},{"line_number":83,"context_line":"                                  the snapshot on the backend."},{"line_number":84,"context_line":"        :param driver_options: dict - custom set of key-values."}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_9212ea55","line":81,"range":{"start_line":81,"start_character":22,"end_line":81,"end_character":31},"updated":"2016-02-29 01:19:35.000000000","message":"either share object or text with its ID","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5065e6fb286707871eafe6f7fa546d871f2c3867","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               name\u003dNone, description\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Manage an existing share snapshot."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param share: The share."},{"line_number":82,"context_line":"        :param provider_location: The provider location of"},{"line_number":83,"context_line":"                                  the snapshot on the backend."},{"line_number":84,"context_line":"        :param driver_options: dict - custom set of key-values."}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_17406333","line":81,"range":{"start_line":81,"start_character":22,"end_line":81,"end_character":31},"in_reply_to":"9aed3d3a_9212ea55","updated":"2016-03-01 01:16:42.000000000","message":"Done","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"25aeda5e8ad83e1fc5dc177fa51059b45702dcd0","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        :param name: text - name of new snapshot"},{"line_number":86,"context_line":"        :param description: - description for new snapshot"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        driver_options \u003d driver_options if driver_options else dict()"},{"line_number":89,"context_line":"        body \u003d {"},{"line_number":90,"context_line":"            \u0027share_id\u0027: common_base.getid(share),"},{"line_number":91,"context_line":"            \u0027provider_location\u0027: provider_location,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_1835b6d9","line":88,"range":{"start_line":88,"start_character":63,"end_line":88,"end_character":69},"updated":"2016-03-01 21:19:04.000000000","message":"please use {}","commit_id":"32c0215c2440eba78d828ee728caa54286339ad1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"94d33fda2e4fd06b20ad9a7417b6f8c110c99df6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        :param name: text - name of new snapshot"},{"line_number":86,"context_line":"        :param description: - description for new snapshot"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        driver_options \u003d driver_options if driver_options else dict()"},{"line_number":89,"context_line":"        body \u003d {"},{"line_number":90,"context_line":"            \u0027share_id\u0027: common_base.getid(share),"},{"line_number":91,"context_line":"            \u0027provider_location\u0027: provider_location,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_cb41a80d","line":88,"range":{"start_line":88,"start_character":63,"end_line":88,"end_character":69},"in_reply_to":"7af24918_1835b6d9","updated":"2016-03-02 03:19:50.000000000","message":"Done","commit_id":"32c0215c2440eba78d828ee728caa54286339ad1"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8837660a4d54ac03c947fccebd3e7c5fe078b30","unresolved":false,"context_lines":[{"line_number":678,"context_line":"@cliutils.arg("},{"line_number":679,"context_line":"    \u0027--name\u0027,"},{"line_number":680,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":681,"context_line":"    help\u003d\u0027Optional share name. (Default\u003dNone)\u0027,"},{"line_number":682,"context_line":"    default\u003dNone)"},{"line_number":683,"context_line":"@cliutils.arg("},{"line_number":684,"context_line":"    \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_ab70e0a4","line":681,"range":{"start_line":681,"start_character":19,"end_line":681,"end_character":24},"updated":"2016-02-08 04:49:40.000000000","message":"s/share/snapshot","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f77a2b27ea1ceba9ea745e76f121a0c5044cc508","unresolved":false,"context_lines":[{"line_number":678,"context_line":"@cliutils.arg("},{"line_number":679,"context_line":"    \u0027--name\u0027,"},{"line_number":680,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":681,"context_line":"    help\u003d\u0027Optional share name. (Default\u003dNone)\u0027,"},{"line_number":682,"context_line":"    default\u003dNone)"},{"line_number":683,"context_line":"@cliutils.arg("},{"line_number":684,"context_line":"    \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_c7289e9c","line":681,"range":{"start_line":681,"start_character":19,"end_line":681,"end_character":24},"in_reply_to":"5a5ae5dd_ab70e0a4","updated":"2016-02-08 13:48:57.000000000","message":"Done","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8837660a4d54ac03c947fccebd3e7c5fe078b30","unresolved":false,"context_lines":[{"line_number":683,"context_line":"@cliutils.arg("},{"line_number":684,"context_line":"    \u0027--description\u0027,"},{"line_number":685,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":686,"context_line":"    help\u003d\u0027Optional share description. (Default\u003dNone)\u0027,"},{"line_number":687,"context_line":"    default\u003dNone)"},{"line_number":688,"context_line":"@cliutils.arg("},{"line_number":689,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_4b6ccccd","line":686,"range":{"start_line":686,"start_character":19,"end_line":686,"end_character":24},"updated":"2016-02-08 04:49:40.000000000","message":"s/share/snapshot/","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f77a2b27ea1ceba9ea745e76f121a0c5044cc508","unresolved":false,"context_lines":[{"line_number":683,"context_line":"@cliutils.arg("},{"line_number":684,"context_line":"    \u0027--description\u0027,"},{"line_number":685,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":686,"context_line":"    help\u003d\u0027Optional share description. (Default\u003dNone)\u0027,"},{"line_number":687,"context_line":"    default\u003dNone)"},{"line_number":688,"context_line":"@cliutils.arg("},{"line_number":689,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_e7235abb","line":686,"range":{"start_line":686,"start_character":19,"end_line":686,"end_character":24},"in_reply_to":"5a5ae5dd_4b6ccccd","updated":"2016-02-08 13:48:57.000000000","message":"Done","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8837660a4d54ac03c947fccebd3e7c5fe078b30","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":694,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":695,"context_line":"    default\u003dNone)"},{"line_number":696,"context_line":"def do_manage_snapshot(cs, args):"},{"line_number":697,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""},{"line_number":698,"context_line":"    driver_options \u003d _extract_key_value_options(args, \u0027driver_options\u0027)"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_8b6de4cd","line":696,"range":{"start_line":696,"start_character":4,"end_line":696,"end_character":22},"updated":"2016-02-08 04:49:40.000000000","message":"I\u0027m not sure this name is correct.  Like Cinder, Manila uses a noun-verb CLI command naming pattern, unless the noun is \u0027share\u0027 in which case only the verb is used.  So I think this should be \u0027snapshot-manage\u0027 instead of \u0027manage-snapshot\u0027.","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f77a2b27ea1ceba9ea745e76f121a0c5044cc508","unresolved":false,"context_lines":[{"line_number":693,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":694,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":695,"context_line":"    default\u003dNone)"},{"line_number":696,"context_line":"def do_manage_snapshot(cs, args):"},{"line_number":697,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""},{"line_number":698,"context_line":"    driver_options \u003d _extract_key_value_options(args, \u0027driver_options\u0027)"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_a729e29c","line":696,"range":{"start_line":696,"start_character":4,"end_line":696,"end_character":22},"in_reply_to":"5a5ae5dd_8b6de4cd","updated":"2016-02-08 13:48:57.000000000","message":"You are right.","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"e8837660a4d54ac03c947fccebd3e7c5fe078b30","unresolved":false,"context_lines":[{"line_number":719,"context_line":"    \u0027snapshot\u0027,"},{"line_number":720,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":721,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":722,"context_line":"def do_unmanage_snapshot(cs, args):"},{"line_number":723,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":724,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":725,"context_line":"    snapshot_ref.unmanage_snapshot()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_aba78009","line":722,"range":{"start_line":722,"start_character":4,"end_line":722,"end_character":24},"updated":"2016-02-08 04:49:40.000000000","message":"As above, this should be \u0027snapshot-unmanage\u0027.","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f77a2b27ea1ceba9ea745e76f121a0c5044cc508","unresolved":false,"context_lines":[{"line_number":719,"context_line":"    \u0027snapshot\u0027,"},{"line_number":720,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":721,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":722,"context_line":"def do_unmanage_snapshot(cs, args):"},{"line_number":723,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":724,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":725,"context_line":"    snapshot_ref.unmanage_snapshot()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_0711d65c","line":722,"range":{"start_line":722,"start_character":4,"end_line":722,"end_character":24},"in_reply_to":"5a5ae5dd_aba78009","updated":"2016-02-08 13:48:57.000000000","message":"Done","commit_id":"6bda7bc197e24d46f7404c035e3f4154e934c007"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a58e09e0caba673cb65378570a47b8eda154cc27","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"@cliutils.arg("},{"line_number":782,"context_line":"    \u0027share_id\u0027,"},{"line_number":783,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":784,"context_line":"    type\u003dstr,"},{"line_number":785,"context_line":"    help\u003d\u0027snapshot-manage share id.\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_992268b8","line":782,"range":{"start_line":782,"start_character":4,"end_line":782,"end_character":14},"updated":"2016-02-19 21:44:11.000000000","message":"Can you make this accept either the ID or name of the share, exactly how you did with do_snapshot_unmanage?  do_unmanage is an example of the same thing with a share.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3870136651c65d111df112afd6dd4c33efbb1630","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"@cliutils.arg("},{"line_number":782,"context_line":"    \u0027share_id\u0027,"},{"line_number":783,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":784,"context_line":"    type\u003dstr,"},{"line_number":785,"context_line":"    help\u003d\u0027snapshot-manage share id.\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_491c4b77","line":782,"range":{"start_line":782,"start_character":4,"end_line":782,"end_character":14},"in_reply_to":"bae84128_71782dc5","updated":"2016-02-22 14:48:38.000000000","message":"Sorry, probably doesn\u0027t need it. It\u0027s a required parameter.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"@cliutils.arg("},{"line_number":782,"context_line":"    \u0027share_id\u0027,"},{"line_number":783,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":784,"context_line":"    type\u003dstr,"},{"line_number":785,"context_line":"    help\u003d\u0027snapshot-manage share id.\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_6857deca","line":782,"range":{"start_line":782,"start_character":4,"end_line":782,"end_character":14},"in_reply_to":"bae84128_992268b8","updated":"2016-02-25 04:16:55.000000000","message":"Done","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"@cliutils.arg("},{"line_number":782,"context_line":"    \u0027share_id\u0027,"},{"line_number":783,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":784,"context_line":"    type\u003dstr,"},{"line_number":785,"context_line":"    help\u003d\u0027snapshot-manage share id.\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_71782dc5","line":782,"range":{"start_line":782,"start_character":4,"end_line":782,"end_character":14},"in_reply_to":"bae84128_992268b8","updated":"2016-02-22 03:24:00.000000000","message":"also, alias it please, --si, --share_id, --share-id","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":782,"context_line":"    \u0027share_id\u0027,"},{"line_number":783,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":784,"context_line":"    type\u003dstr,"},{"line_number":785,"context_line":"    help\u003d\u0027snapshot-manage share id.\u0027)"},{"line_number":786,"context_line":"@cliutils.arg("},{"line_number":787,"context_line":"    \u0027provider_location\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_f14a7d82","line":785,"range":{"start_line":785,"start_character":10,"end_line":785,"end_character":34},"updated":"2016-02-22 03:24:00.000000000","message":"Share ID/Name(if you include support for name) of the Snapshot to be managed.","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":782,"context_line":"    \u0027share_id\u0027,"},{"line_number":783,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":784,"context_line":"    type\u003dstr,"},{"line_number":785,"context_line":"    help\u003d\u0027snapshot-manage share id.\u0027)"},{"line_number":786,"context_line":"@cliutils.arg("},{"line_number":787,"context_line":"    \u0027provider_location\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_680ebee6","line":785,"range":{"start_line":785,"start_character":10,"end_line":785,"end_character":34},"in_reply_to":"bae84128_f14a7d82","updated":"2016-02-25 04:16:55.000000000","message":"Done","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"a58e09e0caba673cb65378570a47b8eda154cc27","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    \u0027provider_location\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"},{"line_number":789,"context_line":"    type\u003dstr,"},{"line_number":790,"context_line":"    help\u003d\u0027provider location.\u0027)"},{"line_number":791,"context_line":"@cliutils.arg("},{"line_number":792,"context_line":"    \u0027--name\u0027,"},{"line_number":793,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_9c109650","line":790,"range":{"start_line":790,"start_character":10,"end_line":790,"end_character":18},"updated":"2016-02-19 21:44:11.000000000","message":"Caps","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    \u0027provider_location\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"},{"line_number":789,"context_line":"    type\u003dstr,"},{"line_number":790,"context_line":"    help\u003d\u0027provider location.\u0027)"},{"line_number":791,"context_line":"@cliutils.arg("},{"line_number":792,"context_line":"    \u0027--name\u0027,"},{"line_number":793,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_68251e5b","line":790,"range":{"start_line":790,"start_character":10,"end_line":790,"end_character":18},"in_reply_to":"bae84128_715f8d41","updated":"2016-02-25 04:16:55.000000000","message":"Done","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":787,"context_line":"    \u0027provider_location\u0027,"},{"line_number":788,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"},{"line_number":789,"context_line":"    type\u003dstr,"},{"line_number":790,"context_line":"    help\u003d\u0027provider location.\u0027)"},{"line_number":791,"context_line":"@cliutils.arg("},{"line_number":792,"context_line":"    \u0027--name\u0027,"},{"line_number":793,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_715f8d41","line":790,"range":{"start_line":790,"start_character":10,"end_line":790,"end_character":18},"in_reply_to":"bae84128_9c109650","updated":"2016-02-22 03:24:00.000000000","message":"Should this be better qualified? \"Provider Location of the snapshot on the backend.\"","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ba8d3960ffea150d88d22b8aa5d71862ee37fd73","unresolved":false,"context_lines":[{"line_number":804,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":805,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":806,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":807,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":808,"context_line":"    default\u003dNone)"},{"line_number":809,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":810,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_71266dcf","line":807,"range":{"start_line":807,"start_character":10,"end_line":807,"end_character":64},"updated":"2016-02-22 03:24:00.000000000","message":"Optional driver options as key\u003dvalue pairs (Default\u003dNone)","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b2960738e323a30a46762343040f1f5d83648c12","unresolved":false,"context_lines":[{"line_number":804,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":805,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":806,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":807,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":808,"context_line":"    default\u003dNone)"},{"line_number":809,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":810,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"bae84128_28d2f634","line":807,"range":{"start_line":807,"start_character":10,"end_line":807,"end_character":64},"in_reply_to":"bae84128_71266dcf","updated":"2016-02-25 04:16:55.000000000","message":"Done","commit_id":"dee3f353033ab4a79e1d3a06483690a2d3fd848b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"069e1bced7f74ec6325ad7d986a2917d730ea951","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":818,"context_line":"    help\u003d\u0027Optional driver options as key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":819,"context_line":"    default\u003dNone)"},{"line_number":820,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":821,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""},{"line_number":822,"context_line":"    share_ref \u003d _find_share(cs, args.share)"},{"line_number":823,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_727ac678","line":820,"range":{"start_line":820,"start_character":4,"end_line":820,"end_character":22},"updated":"2016-02-29 01:19:35.000000000","message":"Please add unit tests for this and the method below in manilaclient/tests/unit/v2/test_shell.py","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aff9de6d6be2bf3b7949898ada42d7e0ddb6f583","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":818,"context_line":"    help\u003d\u0027Optional driver options as key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":819,"context_line":"    default\u003dNone)"},{"line_number":820,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":821,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""},{"line_number":822,"context_line":"    share_ref \u003d _find_share(cs, args.share)"},{"line_number":823,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_d2b91217","line":820,"range":{"start_line":820,"start_character":4,"end_line":820,"end_character":22},"updated":"2016-02-29 01:22:03.000000000","message":"Please use the api versions wrapper to prevent CLI users from using this method\n\n@api_versions.wraps(\"2.12\")","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5065e6fb286707871eafe6f7fa546d871f2c3867","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":818,"context_line":"    help\u003d\u0027Optional driver options as key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":819,"context_line":"    default\u003dNone)"},{"line_number":820,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":821,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""},{"line_number":822,"context_line":"    share_ref \u003d _find_share(cs, args.share)"},{"line_number":823,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_b706d7cb","line":820,"range":{"start_line":820,"start_character":4,"end_line":820,"end_character":22},"in_reply_to":"9aed3d3a_727ac678","updated":"2016-03-01 01:16:42.000000000","message":"Done","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5065e6fb286707871eafe6f7fa546d871f2c3867","unresolved":false,"context_lines":[{"line_number":817,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":818,"context_line":"    help\u003d\u0027Optional driver options as key\u003dvalue pairs (Default\u003dNone).\u0027,"},{"line_number":819,"context_line":"    default\u003dNone)"},{"line_number":820,"context_line":"def do_snapshot_manage(cs, args):"},{"line_number":821,"context_line":"    \"\"\"Manage share snapshot not handled by Manila.\"\"\""},{"line_number":822,"context_line":"    share_ref \u003d _find_share(cs, args.share)"},{"line_number":823,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_57678bb6","line":820,"range":{"start_line":820,"start_character":4,"end_line":820,"end_character":22},"in_reply_to":"9aed3d3a_d2b91217","updated":"2016-03-01 01:16:42.000000000","message":"Done","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"069e1bced7f74ec6325ad7d986a2917d730ea951","unresolved":false,"context_lines":[{"line_number":845,"context_line":"@cliutils.arg("},{"line_number":846,"context_line":"    \u0027snapshot\u0027,"},{"line_number":847,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":849,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":850,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":851,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_b2b1ee49","line":848,"range":{"start_line":848,"start_character":36,"end_line":848,"end_character":39},"updated":"2016-02-29 01:19:35.000000000","message":"Please see comment below","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5065e6fb286707871eafe6f7fa546d871f2c3867","unresolved":false,"context_lines":[{"line_number":845,"context_line":"@cliutils.arg("},{"line_number":846,"context_line":"    \u0027snapshot\u0027,"},{"line_number":847,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":849,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":850,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":851,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_aad14e59","line":848,"range":{"start_line":848,"start_character":36,"end_line":848,"end_character":39},"in_reply_to":"9aed3d3a_b2b1ee49","updated":"2016-03-01 01:16:42.000000000","message":"Done","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aff9de6d6be2bf3b7949898ada42d7e0ddb6f583","unresolved":false,"context_lines":[{"line_number":846,"context_line":"    \u0027snapshot\u0027,"},{"line_number":847,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":849,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":850,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":851,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":852,"context_line":"    snapshot_ref.unmanage_snapshot()"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_52cd02b6","line":849,"range":{"start_line":849,"start_character":4,"end_line":849,"end_character":24},"updated":"2016-02-29 01:22:03.000000000","message":"Please use the api versions wrapper to prevent CLI users from using this method\n\n@api_versions.wraps(\"2.12\")","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5065e6fb286707871eafe6f7fa546d871f2c3867","unresolved":false,"context_lines":[{"line_number":846,"context_line":"    \u0027snapshot\u0027,"},{"line_number":847,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":849,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":850,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":851,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":852,"context_line":"    snapshot_ref.unmanage_snapshot()"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_17f863c2","line":849,"range":{"start_line":849,"start_character":4,"end_line":849,"end_character":24},"in_reply_to":"9aed3d3a_52cd02b6","updated":"2016-03-01 01:16:42.000000000","message":"Done","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"069e1bced7f74ec6325ad7d986a2917d730ea951","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":849,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":850,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":851,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":852,"context_line":"    snapshot_ref.unmanage_snapshot()"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_12a25afd","line":852,"range":{"start_line":851,"start_character":4,"end_line":852,"end_character":36},"updated":"2016-02-29 01:19:35.000000000","message":"This currently only accepts one argument... \n\nIf you want to accept a list of snapshots to unmanage:\n\n\n    def do_snapshot_unmanage(cs, args):\n        failure_count \u003d 0\n        kwargs \u003d {}\n\n        for snapshot in args.snapshot:\n            try:\n                snapshot_ref \u003d _find_share_snapshot(cs, snapshot)\n                snapshot_ref.unmanage_snapshot()\n            except Exception as e:\n                failure_count +\u003d 1\n                print(\"Unmanage for share snapshot %s failed: %s\" % (snapshot, e),\n                      file\u003dsys.stderr)\n\n        if failure_count \u003d\u003d len(args.snapshot):\n            raise exceptions.CommandError(\"Unable to unmanage any of the\"\n                                        \" specified snapshots.\")","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5065e6fb286707871eafe6f7fa546d871f2c3867","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":849,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":850,"context_line":"    \"\"\"Unmanage share snapshot.\"\"\""},{"line_number":851,"context_line":"    snapshot_ref \u003d _find_share_snapshot(cs, args.snapshot)"},{"line_number":852,"context_line":"    snapshot_ref.unmanage_snapshot()"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_eac7d695","line":852,"range":{"start_line":851,"start_character":4,"end_line":852,"end_character":36},"in_reply_to":"9aed3d3a_12a25afd","updated":"2016-03-01 01:16:42.000000000","message":"Done","commit_id":"260738003e59b7c782e2b975b32393ee1c7558c8"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"25aeda5e8ad83e1fc5dc177fa51059b45702dcd0","unresolved":false,"context_lines":[{"line_number":803,"context_line":"@cliutils.arg("},{"line_number":804,"context_line":"    \u0027--name\u0027,"},{"line_number":805,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":806,"context_line":"    help\u003d\u0027Optional snapshot name. (Default\u003dNone)\u0027,"},{"line_number":807,"context_line":"    default\u003dNone)"},{"line_number":808,"context_line":"@cliutils.arg("},{"line_number":809,"context_line":"    \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_58e9fe19","line":806,"range":{"start_line":806,"start_character":47,"end_line":806,"end_character":49},"updated":"2016-03-01 21:19:04.000000000","message":"please add a period","commit_id":"32c0215c2440eba78d828ee728caa54286339ad1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"94d33fda2e4fd06b20ad9a7417b6f8c110c99df6","unresolved":false,"context_lines":[{"line_number":803,"context_line":"@cliutils.arg("},{"line_number":804,"context_line":"    \u0027--name\u0027,"},{"line_number":805,"context_line":"    metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":806,"context_line":"    help\u003d\u0027Optional snapshot name. (Default\u003dNone)\u0027,"},{"line_number":807,"context_line":"    default\u003dNone)"},{"line_number":808,"context_line":"@cliutils.arg("},{"line_number":809,"context_line":"    \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_cb26c867","line":806,"range":{"start_line":806,"start_character":47,"end_line":806,"end_character":49},"in_reply_to":"7af24918_58e9fe19","updated":"2016-03-02 03:19:50.000000000","message":"Done","commit_id":"32c0215c2440eba78d828ee728caa54286339ad1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"25aeda5e8ad83e1fc5dc177fa51059b45702dcd0","unresolved":false,"context_lines":[{"line_number":808,"context_line":"@cliutils.arg("},{"line_number":809,"context_line":"    \u0027--description\u0027,"},{"line_number":810,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":811,"context_line":"    help\u003d\u0027Optional snapshot description. (Default\u003dNone)\u0027,"},{"line_number":812,"context_line":"    default\u003dNone)"},{"line_number":813,"context_line":"@cliutils.arg("},{"line_number":814,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_b893e2a2","line":811,"range":{"start_line":811,"start_character":54,"end_line":811,"end_character":56},"updated":"2016-03-01 21:19:04.000000000","message":"please add a period.","commit_id":"32c0215c2440eba78d828ee728caa54286339ad1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"94d33fda2e4fd06b20ad9a7417b6f8c110c99df6","unresolved":false,"context_lines":[{"line_number":808,"context_line":"@cliutils.arg("},{"line_number":809,"context_line":"    \u0027--description\u0027,"},{"line_number":810,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":811,"context_line":"    help\u003d\u0027Optional snapshot description. (Default\u003dNone)\u0027,"},{"line_number":812,"context_line":"    default\u003dNone)"},{"line_number":813,"context_line":"@cliutils.arg("},{"line_number":814,"context_line":"    \u0027--driver_options\u0027, \u0027--driver-options\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7af24918_ab2b7c2f","line":811,"range":{"start_line":811,"start_character":54,"end_line":811,"end_character":56},"in_reply_to":"7af24918_b893e2a2","updated":"2016-03-02 03:19:50.000000000","message":"Done","commit_id":"32c0215c2440eba78d828ee728caa54286339ad1"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bdbf569cf27b61eeb14fcdd25aa77e9cda2c0109","unresolved":false,"context_lines":[{"line_number":796,"context_line":"    type\u003dstr,"},{"line_number":797,"context_line":"    help\u003d\u0027Name or ID of the share.\u0027)"},{"line_number":798,"context_line":"@cliutils.arg("},{"line_number":799,"context_line":"    \u0027provider_location\u0027,"},{"line_number":800,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"},{"line_number":801,"context_line":"    type\u003dstr,"},{"line_number":802,"context_line":"    help\u003d\u0027Provider location of the snapshot on the backend.\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_8ed792ec","line":799,"range":{"start_line":799,"start_character":4,"end_line":799,"end_character":24},"updated":"2016-03-02 13:22:11.000000000","message":"add alias \"provider-location\"? as you do for driver_options","commit_id":"1dd271e047afb395dd27f0f91c3cb7134dd40567"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f6a1815e11c0120fc1d97c75f20d4e5dfdab208e","unresolved":false,"context_lines":[{"line_number":796,"context_line":"    type\u003dstr,"},{"line_number":797,"context_line":"    help\u003d\u0027Name or ID of the share.\u0027)"},{"line_number":798,"context_line":"@cliutils.arg("},{"line_number":799,"context_line":"    \u0027provider_location\u0027,"},{"line_number":800,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"},{"line_number":801,"context_line":"    type\u003dstr,"},{"line_number":802,"context_line":"    help\u003d\u0027Provider location of the snapshot on the backend.\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_ee0d6b91","line":799,"range":{"start_line":799,"start_character":4,"end_line":799,"end_character":24},"in_reply_to":"7af24918_206ac2b3","updated":"2016-03-02 15:40:32.000000000","message":"Got the following error after adding \u0027provider-location\u0027 as an alias.  So I removed it now.  provider_location is positional.  Maybe alias is not allowed.\n\nERROR: invalid option string \u0027provider_location\u0027: must start with a character \u0027-\u0027","commit_id":"1dd271e047afb395dd27f0f91c3cb7134dd40567"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b5e01a79844aee13bdecf65d553f52418148252b","unresolved":false,"context_lines":[{"line_number":796,"context_line":"    type\u003dstr,"},{"line_number":797,"context_line":"    help\u003d\u0027Name or ID of the share.\u0027)"},{"line_number":798,"context_line":"@cliutils.arg("},{"line_number":799,"context_line":"    \u0027provider_location\u0027,"},{"line_number":800,"context_line":"    metavar\u003d\u0027\u003cprovider_location\u003e\u0027,"},{"line_number":801,"context_line":"    type\u003dstr,"},{"line_number":802,"context_line":"    help\u003d\u0027Provider location of the snapshot on the backend.\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_206ac2b3","line":799,"range":{"start_line":799,"start_character":4,"end_line":799,"end_character":24},"in_reply_to":"7af24918_8ed792ec","updated":"2016-03-02 15:08:15.000000000","message":"Done","commit_id":"1dd271e047afb395dd27f0f91c3cb7134dd40567"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28bbbd1b1eb0d02b27b24dc914d3d87962105cfd","unresolved":false,"context_lines":[{"line_number":850,"context_line":"    nargs\u003d\u0027+\u0027,"},{"line_number":851,"context_line":"    help\u003d\u0027Name or ID of the snapshot(s).\u0027)"},{"line_number":852,"context_line":"def do_snapshot_unmanage(cs, args):"},{"line_number":853,"context_line":"    \"\"\"Unmanage one or more share snapshots (Admin only).\"\"\""},{"line_number":854,"context_line":"    failure_count \u003d 0"},{"line_number":855,"context_line":"    for snapshot in args.snapshot:"},{"line_number":856,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7af24918_64933750","line":853,"range":{"start_line":853,"start_character":44,"end_line":853,"end_character":56},"updated":"2016-03-02 16:25:02.000000000","message":"We still need to finish that discussion around this. However, thanks for making it consistent with what\u0027s out there.","commit_id":"095a9d468f61fe90b9a91848f270c25c48bf9797"}]}
