)]}'
{"manilaclient/tests/unit/v2/test_shares.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7ea67c87c8d6721ccd2bdcc6e02adc941007742e","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    @ddt.data("},{"line_number":502,"context_line":"        (\"2.6\", \"os-migrate_share\"),"},{"line_number":503,"context_line":"        (\"2.7\", \"migrate_share\"),"},{"line_number":504,"context_line":"        (\"2.13\", \"migration_start\"),"},{"line_number":505,"context_line":"    )"},{"line_number":506,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_5f6cb034","line":503,"updated":"2016-02-29 22:56:02.000000000","message":"test 2.12?","commit_id":"d4fcb8ba2c7cad8aa24cacf277a8e81875357794"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c59b0b952149530234ac25854984bfbfcba46e69","unresolved":false,"context_lines":[{"line_number":500,"context_line":""},{"line_number":501,"context_line":"    @ddt.data("},{"line_number":502,"context_line":"        (\"2.6\", \"os-migrate_share\"),"},{"line_number":503,"context_line":"        (\"2.7\", \"migrate_share\"),"},{"line_number":504,"context_line":"        (\"2.13\", \"migration_start\"),"},{"line_number":505,"context_line":"    )"},{"line_number":506,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_4260eb35","line":503,"in_reply_to":"9aed3d3a_5f6cb034","updated":"2016-03-01 20:52:02.000000000","message":"Done","commit_id":"d4fcb8ba2c7cad8aa24cacf277a8e81875357794"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"0fcdcff2679e87358847831292309af88f42d472","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return self._do_migrate_share("},{"line_number":223,"context_line":"            share, host, force_host_copy, True, \"os-migrate_share\")"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @api_versions.wraps(\"2.7\", \"2.9\")  # noqa"},{"line_number":226,"context_line":"    def migrate_share(self, share, host, force_host_copy):"},{"line_number":227,"context_line":"        return self._do_migrate_share("},{"line_number":228,"context_line":"            share, host, force_host_copy, True, \"migrate_share\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_158a05c0","line":225,"range":{"start_line":225,"start_character":32,"end_line":225,"end_character":35},"updated":"2016-02-10 16:39:16.000000000","message":"2.10","commit_id":"81e9310875ababfc7c41a7aefb0a01f8b802d13b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"26d7f1de5f8e4ed37a7e9ff0c7a387e42a9168c7","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return self._do_migrate_share("},{"line_number":223,"context_line":"            share, host, force_host_copy, True, \"os-migrate_share\")"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @api_versions.wraps(\"2.7\", \"2.9\")  # noqa"},{"line_number":226,"context_line":"    def migrate_share(self, share, host, force_host_copy):"},{"line_number":227,"context_line":"        return self._do_migrate_share("},{"line_number":228,"context_line":"            share, host, force_host_copy, True, \"migrate_share\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_8c249daf","line":225,"range":{"start_line":225,"start_character":32,"end_line":225,"end_character":35},"in_reply_to":"3a57f1b5_158a05c0","updated":"2016-02-16 19:52:01.000000000","message":"Done","commit_id":"81e9310875ababfc7c41a7aefb0a01f8b802d13b"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7ea67c87c8d6721ccd2bdcc6e02adc941007742e","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        :param share: The :class:\u0027share\u0027 to migrate"},{"line_number":210,"context_line":"        :param host: The destination host and pool"},{"line_number":211,"context_line":"        :param force_host_copy: Skip driver optimizations"},{"line_number":212,"context_line":"        :param notify: whether migration completion should be notified"},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        return self._action("}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_5fae70e6","line":212,"updated":"2016-02-29 22:56:02.000000000","message":"please add line for action_name if you are updating this.","commit_id":"d4fcb8ba2c7cad8aa24cacf277a8e81875357794"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c59b0b952149530234ac25854984bfbfcba46e69","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        :param share: The :class:\u0027share\u0027 to migrate"},{"line_number":210,"context_line":"        :param host: The destination host and pool"},{"line_number":211,"context_line":"        :param force_host_copy: Skip driver optimizations"},{"line_number":212,"context_line":"        :param notify: whether migration completion should be notified"},{"line_number":213,"context_line":"        \"\"\""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        return self._action("}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_c254fb55","line":212,"in_reply_to":"9aed3d3a_5fae70e6","updated":"2016-03-01 20:52:02.000000000","message":"Done","commit_id":"d4fcb8ba2c7cad8aa24cacf277a8e81875357794"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"f32294fdfd21dff1bcb239a42be5d3bea362c5fc","unresolved":false,"context_lines":[{"line_number":564,"context_line":"                                     \u0027complete migration.\u0027)"},{"line_number":565,"context_line":"@api_versions.experimental_api"},{"line_number":566,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":567,"context_line":"def do_complete_migration(cs, args):"},{"line_number":568,"context_line":"    \"\"\"Completes migration for a given share.\"\"\""},{"line_number":569,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":570,"context_line":"    share.complete_migration()"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_a03ada34","line":567,"range":{"start_line":567,"start_character":4,"end_line":567,"end_character":25},"updated":"2016-02-03 19:19:51.000000000","message":"This subcommand should be \u0027migration-complete\u0027 instead of \u0027complete-migration\u0027.","commit_id":"06b832c0cfffa2f4f1134614ac0050512390376b"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"f32294fdfd21dff1bcb239a42be5d3bea362c5fc","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                                     \u0027cancel migration.\u0027)"},{"line_number":576,"context_line":"@api_versions.experimental_api"},{"line_number":577,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":578,"context_line":"def do_cancel_migration(cs, args):"},{"line_number":579,"context_line":"    \"\"\"Attempts to cancel migration for a given share.\"\"\""},{"line_number":580,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":581,"context_line":"    share.cancel_migration()"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_c01276b4","line":578,"range":{"start_line":578,"start_character":4,"end_line":578,"end_character":23},"updated":"2016-02-03 19:19:51.000000000","message":"This subcommand should be \u0027migration-cancel\u0027 instead of \u0027cancel-migration\u0027.","commit_id":"06b832c0cfffa2f4f1134614ac0050512390376b"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"f32294fdfd21dff1bcb239a42be5d3bea362c5fc","unresolved":false,"context_lines":[{"line_number":606,"context_line":"         \u0027 progress information.\u0027)"},{"line_number":607,"context_line":"@api_versions.experimental_api"},{"line_number":608,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":609,"context_line":"def do_get_migration_progress(cs, args):"},{"line_number":610,"context_line":"    \"\"\"Explicitly update the state of a share.\"\"\""},{"line_number":611,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":612,"context_line":"    result \u003d share.get_migration_progress()"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_201eeaba","line":609,"range":{"start_line":609,"start_character":4,"end_line":609,"end_character":29},"updated":"2016-02-03 19:19:51.000000000","message":"This subcommand should be \u0027migration-get-progress\u0027 instead of \u0027get-migration-progress\u0027.","commit_id":"06b832c0cfffa2f4f1134614ac0050512390376b"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"0fcdcff2679e87358847831292309af88f42d472","unresolved":false,"context_lines":[{"line_number":638,"context_line":"@api_versions.experimental_api"},{"line_number":639,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":640,"context_line":"def do_migration_cancel(cs, args):"},{"line_number":641,"context_line":"    \"\"\"Attempts to cancel migration for a given share.\"\"\""},{"line_number":642,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":643,"context_line":"    share.migration_cancel()"},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_9504b57e","line":641,"range":{"start_line":641,"start_character":4,"end_line":641,"end_character":57},"updated":"2016-02-10 16:39:16.000000000","message":"Maybe tell the user that this will only cancel the copy operation. Same for the \"migration-get-progress\" command, tell the user that it will only get the progress of the copy operation.","commit_id":"81e9310875ababfc7c41a7aefb0a01f8b802d13b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"26d7f1de5f8e4ed37a7e9ff0c7a387e42a9168c7","unresolved":false,"context_lines":[{"line_number":638,"context_line":"@api_versions.experimental_api"},{"line_number":639,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":640,"context_line":"def do_migration_cancel(cs, args):"},{"line_number":641,"context_line":"    \"\"\"Attempts to cancel migration for a given share.\"\"\""},{"line_number":642,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":643,"context_line":"    share.migration_cancel()"},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_cc36a5e6","line":641,"range":{"start_line":641,"start_character":4,"end_line":641,"end_character":57},"in_reply_to":"3a57f1b5_9504b57e","updated":"2016-02-16 19:52:01.000000000","message":"Done","commit_id":"81e9310875ababfc7c41a7aefb0a01f8b802d13b"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"0fcdcff2679e87358847831292309af88f42d472","unresolved":false,"context_lines":[{"line_number":669,"context_line":"@api_versions.experimental_api"},{"line_number":670,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":671,"context_line":"def do_migration_get_progress(cs, args):"},{"line_number":672,"context_line":"    \"\"\"Explicitly update the state of a share.\"\"\""},{"line_number":673,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":674,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":675,"context_line":"    cliutils.print_dict(result[1])"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a57f1b5_f59c096b","line":672,"range":{"start_line":672,"start_character":5,"end_line":672,"end_character":49},"updated":"2016-02-10 16:39:16.000000000","message":"Wrong docstring.","commit_id":"81e9310875ababfc7c41a7aefb0a01f8b802d13b"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"26d7f1de5f8e4ed37a7e9ff0c7a387e42a9168c7","unresolved":false,"context_lines":[{"line_number":669,"context_line":"@api_versions.experimental_api"},{"line_number":670,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":671,"context_line":"def do_migration_get_progress(cs, args):"},{"line_number":672,"context_line":"    \"\"\"Explicitly update the state of a share.\"\"\""},{"line_number":673,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":674,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":675,"context_line":"    cliutils.print_dict(result[1])"}],"source_content_type":"text/x-python","patch_set":11,"id":"dae33548_0c31adec","line":672,"range":{"start_line":672,"start_character":5,"end_line":672,"end_character":49},"in_reply_to":"3a57f1b5_f59c096b","updated":"2016-02-16 19:52:01.000000000","message":"Done","commit_id":"81e9310875ababfc7c41a7aefb0a01f8b802d13b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"173db8f0ee3e2f374a771254287b4e2d5f4a2f9a","unresolved":false,"context_lines":[{"line_number":624,"context_line":"@cliutils.arg("},{"line_number":625,"context_line":"    \u0027share\u0027, metavar\u003d\u0027\u003cshare\u003e\u0027, help\u003d\u0027Name or ID of share to \u0027"},{"line_number":626,"context_line":"                                     \u0027complete migration.\u0027)"},{"line_number":627,"context_line":"@api_versions.experimental_api"},{"line_number":628,"context_line":"@api_versions.wraps(\"2.12\")"},{"line_number":629,"context_line":"def do_migration_complete(cs, args):"},{"line_number":630,"context_line":"    \"\"\"Completes migration for a given share.\"\"\""},{"line_number":631,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":632,"context_line":"    share.migration_complete()"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"@cliutils.arg("},{"line_number":636,"context_line":"    \u0027share\u0027, metavar\u003d\u0027\u003cshare\u003e\u0027, help\u003d\u0027Name or ID of share to \u0027"},{"line_number":637,"context_line":"                                     \u0027cancel migration.\u0027)"},{"line_number":638,"context_line":"@api_versions.experimental_api"},{"line_number":639,"context_line":"@api_versions.wraps(\"2.12\")"},{"line_number":640,"context_line":"def do_migration_cancel(cs, args):"},{"line_number":641,"context_line":"    \"\"\"Attempts to cancel migration for a given share during copying.\"\"\""},{"line_number":642,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":643,"context_line":"    share.migration_cancel()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_54e35705","line":643,"range":{"start_line":627,"start_character":0,"end_line":643,"end_character":28},"updated":"2016-02-22 03:37:13.000000000","message":"For the sake of simplicity can all these be options of the migrate command?\n\n    do_migrate (i.e, on the command line, \u0027migrate\u0027) \n\ncan have options --complete, --cancel, --get_progress\n\ninstead of these being:\n\n - migration_complete\n - migration_get_progress\n - migration_cancel\n\n\nIf that\u0027s not acceptable, I would hope we can have:\n\n - migrate-start\n - migrate-complete\n - migrate-cancel\n - migrate-status","commit_id":"6fcedb9eb3c8a8986f1bbbfe7132748c3740d740"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5289477843126f6bb0df70ed52f2f415ac03286f","unresolved":false,"context_lines":[{"line_number":624,"context_line":"@cliutils.arg("},{"line_number":625,"context_line":"    \u0027share\u0027, metavar\u003d\u0027\u003cshare\u003e\u0027, help\u003d\u0027Name or ID of share to \u0027"},{"line_number":626,"context_line":"                                     \u0027complete migration.\u0027)"},{"line_number":627,"context_line":"@api_versions.experimental_api"},{"line_number":628,"context_line":"@api_versions.wraps(\"2.12\")"},{"line_number":629,"context_line":"def do_migration_complete(cs, args):"},{"line_number":630,"context_line":"    \"\"\"Completes migration for a given share.\"\"\""},{"line_number":631,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":632,"context_line":"    share.migration_complete()"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"@cliutils.arg("},{"line_number":636,"context_line":"    \u0027share\u0027, metavar\u003d\u0027\u003cshare\u003e\u0027, help\u003d\u0027Name or ID of share to \u0027"},{"line_number":637,"context_line":"                                     \u0027cancel migration.\u0027)"},{"line_number":638,"context_line":"@api_versions.experimental_api"},{"line_number":639,"context_line":"@api_versions.wraps(\"2.12\")"},{"line_number":640,"context_line":"def do_migration_cancel(cs, args):"},{"line_number":641,"context_line":"    \"\"\"Attempts to cancel migration for a given share during copying.\"\"\""},{"line_number":642,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":643,"context_line":"    share.migration_cancel()"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":14,"id":"bae84128_4c9e7508","line":643,"range":{"start_line":627,"start_character":0,"end_line":643,"end_character":28},"in_reply_to":"bae84128_54e35705","updated":"2016-02-25 00:42:01.000000000","message":"Done","commit_id":"6fcedb9eb3c8a8986f1bbbfe7132748c3740d740"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7ea67c87c8d6721ccd2bdcc6e02adc941007742e","unresolved":false,"context_lines":[{"line_number":609,"context_line":"              \u0027optimizations. Default\u003dFalse.\u0027,"},{"line_number":610,"context_line":"              default\u003dFalse)"},{"line_number":611,"context_line":"@api_versions.experimental_api"},{"line_number":612,"context_line":"@api_versions.wraps(\"2.5\", \"2.11\")"},{"line_number":613,"context_line":"def do_migrate(cs, args):"},{"line_number":614,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host.\"\"\""},{"line_number":615,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aed3d3a_dfc0c052","line":612,"range":{"start_line":612,"start_character":30,"end_line":612,"end_character":32},"updated":"2016-02-29 22:56:02.000000000","message":"what happened to 2.12?","commit_id":"d4fcb8ba2c7cad8aa24cacf277a8e81875357794"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c59b0b952149530234ac25854984bfbfcba46e69","unresolved":false,"context_lines":[{"line_number":609,"context_line":"              \u0027optimizations. Default\u003dFalse.\u0027,"},{"line_number":610,"context_line":"              default\u003dFalse)"},{"line_number":611,"context_line":"@api_versions.experimental_api"},{"line_number":612,"context_line":"@api_versions.wraps(\"2.5\", \"2.11\")"},{"line_number":613,"context_line":"def do_migrate(cs, args):"},{"line_number":614,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host.\"\"\""},{"line_number":615,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_a251ef64","line":612,"range":{"start_line":612,"start_character":30,"end_line":612,"end_character":32},"in_reply_to":"9aed3d3a_dfc0c052","updated":"2016-03-01 20:52:02.000000000","message":"Done","commit_id":"d4fcb8ba2c7cad8aa24cacf277a8e81875357794"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"6e97a35a61e7a539db12a19189a32c82c03d2d7a","unresolved":false,"context_lines":[{"line_number":628,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"@cliutils.arg("},{"line_number":632,"context_line":"    \u0027share\u0027, metavar\u003d\u0027\u003cshare\u003e\u0027, help\u003d\u0027Name or ID of share to migrate.\u0027)"},{"line_number":633,"context_line":"@cliutils.arg(\u0027host\u0027, metavar\u003d\u0027\u003chost#pool\u003e\u0027, help\u003d\u0027Destination host and pool.\u0027)"},{"line_number":634,"context_line":"@cliutils.arg(\u0027--force-host-copy\u0027, metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":635,"context_line":"              choices\u003d[\u0027True\u0027, \u0027False\u0027], required\u003dFalse,"},{"line_number":636,"context_line":"              help\u003d\u0027Enables or disables generic host-based \u0027"},{"line_number":637,"context_line":"              \u0027force-migration, which bypasses driver \u0027"},{"line_number":638,"context_line":"              \u0027optimizations. Default\u003dFalse.\u0027,"},{"line_number":639,"context_line":"              default\u003dFalse)"},{"line_number":640,"context_line":"@cliutils.arg(\u0027--notify\u0027, metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":641,"context_line":"              choices\u003d[\u0027True\u0027, \u0027False\u0027], required\u003dFalse,"},{"line_number":642,"context_line":"              help\u003d\u0027Enables or disables notification of data copying completed\u0027"},{"line_number":643,"context_line":"              \u0027. Default\u003dTrue.\u0027,"},{"line_number":644,"context_line":"              default\u003dTrue)"},{"line_number":645,"context_line":"@api_versions.experimental_api"},{"line_number":646,"context_line":"@api_versions.wraps(\"2.14\")"},{"line_number":647,"context_line":"def do_migration_start(cs, args):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_6e2686cf","line":644,"range":{"start_line":631,"start_character":0,"end_line":644,"end_character":27},"updated":"2016-03-02 13:26:23.000000000","message":"Please, make it consistent with all your new methods. Would be great to see same as on lines 675-684","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a1f0867c1db1a06f11a5c257bf05db7388a00aa1","unresolved":false,"context_lines":[{"line_number":628,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"@cliutils.arg("},{"line_number":632,"context_line":"    \u0027share\u0027, metavar\u003d\u0027\u003cshare\u003e\u0027, help\u003d\u0027Name or ID of share to migrate.\u0027)"},{"line_number":633,"context_line":"@cliutils.arg(\u0027host\u0027, metavar\u003d\u0027\u003chost#pool\u003e\u0027, help\u003d\u0027Destination host and pool.\u0027)"},{"line_number":634,"context_line":"@cliutils.arg(\u0027--force-host-copy\u0027, metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":635,"context_line":"              choices\u003d[\u0027True\u0027, \u0027False\u0027], required\u003dFalse,"},{"line_number":636,"context_line":"              help\u003d\u0027Enables or disables generic host-based \u0027"},{"line_number":637,"context_line":"              \u0027force-migration, which bypasses driver \u0027"},{"line_number":638,"context_line":"              \u0027optimizations. Default\u003dFalse.\u0027,"},{"line_number":639,"context_line":"              default\u003dFalse)"},{"line_number":640,"context_line":"@cliutils.arg(\u0027--notify\u0027, metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":641,"context_line":"              choices\u003d[\u0027True\u0027, \u0027False\u0027], required\u003dFalse,"},{"line_number":642,"context_line":"              help\u003d\u0027Enables or disables notification of data copying completed\u0027"},{"line_number":643,"context_line":"              \u0027. Default\u003dTrue.\u0027,"},{"line_number":644,"context_line":"              default\u003dTrue)"},{"line_number":645,"context_line":"@api_versions.experimental_api"},{"line_number":646,"context_line":"@api_versions.wraps(\"2.14\")"},{"line_number":647,"context_line":"def do_migration_start(cs, args):"}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_da95d4e4","line":644,"range":{"start_line":631,"start_character":0,"end_line":644,"end_character":27},"in_reply_to":"7af24918_6e2686cf","updated":"2016-03-02 14:11:21.000000000","message":"Done","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c9fbd031bcfbea13cd0de315d466a9d8d5ab8995","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"    \u0027binary\u0027,"},{"line_number":2342,"context_line":"    metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":2343,"context_line":"    help\u003d\"Service binary, could be \u0027manila-share\u0027 or \u0027manila-scheduler\u0027.\")"},{"line_number":2344,"context_line":"def do_service_enable(cs, args):"},{"line_number":2345,"context_line":"    \"\"\"Enables \u0027manila-share\u0027 or \u0027manila-scheduler\u0027 services (Admin only).\"\"\""},{"line_number":2346,"context_line":"    columns \u003d (\"Host\", \"Binary\", \"Enabled\")"},{"line_number":2347,"context_line":"    result \u003d cs.services.enable(args.host, args.binary)"},{"line_number":2348,"context_line":"    result.enabled \u003d not result.disabled"},{"line_number":2349,"context_line":"    cliutils.print_list([result], columns)"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_44f569c9","line":2349,"range":{"start_line":2344,"start_character":0,"end_line":2349,"end_character":42},"updated":"2016-03-02 13:40:00.000000000","message":"I am not suggesting a new feature if we don\u0027t have one.. i am thinking out loud :) \n\n\n\nCan we disable m-dat?","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e94623dbf42f9aa1a3d39c97be67c03b6d9470ad","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"    \u0027binary\u0027,"},{"line_number":2342,"context_line":"    metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":2343,"context_line":"    help\u003d\"Service binary, could be \u0027manila-share\u0027 or \u0027manila-scheduler\u0027.\")"},{"line_number":2344,"context_line":"def do_service_enable(cs, args):"},{"line_number":2345,"context_line":"    \"\"\"Enables \u0027manila-share\u0027 or \u0027manila-scheduler\u0027 services (Admin only).\"\"\""},{"line_number":2346,"context_line":"    columns \u003d (\"Host\", \"Binary\", \"Enabled\")"},{"line_number":2347,"context_line":"    result \u003d cs.services.enable(args.host, args.binary)"},{"line_number":2348,"context_line":"    result.enabled \u003d not result.disabled"},{"line_number":2349,"context_line":"    cliutils.print_list([result], columns)"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_ee2a648f","line":2349,"range":{"start_line":2344,"start_character":0,"end_line":2349,"end_character":42},"in_reply_to":"7af24918_171d47bd","updated":"2016-03-03 01:38:52.000000000","message":"Isn\u0027t that a bug at this point? or would it be a feature?","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a1f0867c1db1a06f11a5c257bf05db7388a00aa1","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"    \u0027binary\u0027,"},{"line_number":2342,"context_line":"    metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":2343,"context_line":"    help\u003d\"Service binary, could be \u0027manila-share\u0027 or \u0027manila-scheduler\u0027.\")"},{"line_number":2344,"context_line":"def do_service_enable(cs, args):"},{"line_number":2345,"context_line":"    \"\"\"Enables \u0027manila-share\u0027 or \u0027manila-scheduler\u0027 services (Admin only).\"\"\""},{"line_number":2346,"context_line":"    columns \u003d (\"Host\", \"Binary\", \"Enabled\")"},{"line_number":2347,"context_line":"    result \u003d cs.services.enable(args.host, args.binary)"},{"line_number":2348,"context_line":"    result.enabled \u003d not result.disabled"},{"line_number":2349,"context_line":"    cliutils.print_list([result], columns)"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_da631419","line":2349,"range":{"start_line":2344,"start_character":0,"end_line":2349,"end_character":42},"in_reply_to":"7af24918_44f569c9","updated":"2016-03-02 14:11:21.000000000","message":"I just tested disabling it through service-disable command and migrating, it still worked","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4aca739ab86afd8f55801fb5055a94c6a3a87f3c","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"    \u0027binary\u0027,"},{"line_number":2342,"context_line":"    metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":2343,"context_line":"    help\u003d\"Service binary, could be \u0027manila-share\u0027 or \u0027manila-scheduler\u0027.\")"},{"line_number":2344,"context_line":"def do_service_enable(cs, args):"},{"line_number":2345,"context_line":"    \"\"\"Enables \u0027manila-share\u0027 or \u0027manila-scheduler\u0027 services (Admin only).\"\"\""},{"line_number":2346,"context_line":"    columns \u003d (\"Host\", \"Binary\", \"Enabled\")"},{"line_number":2347,"context_line":"    result \u003d cs.services.enable(args.host, args.binary)"},{"line_number":2348,"context_line":"    result.enabled \u003d not result.disabled"},{"line_number":2349,"context_line":"    cliutils.print_list([result], columns)"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_171d47bd","line":2349,"range":{"start_line":2344,"start_character":0,"end_line":2349,"end_character":42},"in_reply_to":"7af24918_d52645b9","updated":"2016-03-02 16:35:39.000000000","message":"No no no, the opposite. I disabled it, and migration worked anyway, the data service received the request, migrated, sent response back... so it is in fact not being disabled by \"service-disable\" command.","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"81a581de92d28884c12386cb2ce52b41bfd84250","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"    \u0027binary\u0027,"},{"line_number":2342,"context_line":"    metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":2343,"context_line":"    help\u003d\"Service binary, could be \u0027manila-share\u0027 or \u0027manila-scheduler\u0027.\")"},{"line_number":2344,"context_line":"def do_service_enable(cs, args):"},{"line_number":2345,"context_line":"    \"\"\"Enables \u0027manila-share\u0027 or \u0027manila-scheduler\u0027 services (Admin only).\"\"\""},{"line_number":2346,"context_line":"    columns \u003d (\"Host\", \"Binary\", \"Enabled\")"},{"line_number":2347,"context_line":"    result \u003d cs.services.enable(args.host, args.binary)"},{"line_number":2348,"context_line":"    result.enabled \u003d not result.disabled"},{"line_number":2349,"context_line":"    cliutils.print_list([result], columns)"},{"line_number":2350,"context_line":""},{"line_number":2351,"context_line":""},{"line_number":2352,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":18,"id":"7af24918_d52645b9","line":2349,"range":{"start_line":2344,"start_character":0,"end_line":2349,"end_character":42},"in_reply_to":"7af24918_da631419","updated":"2016-03-02 14:13:41.000000000","message":"Do you mean the service was disabled and you couldn\u0027t migrate?\n\nThat\u0027s as expected then.. Could you please update the docstring here?\n\n\"\"\"Enables \u0027manila-share\u0027, \u0027manila-scheduler\u0027 or \"manila-data\" services (Admin only).\"\"\"\n\n\nsame below..","commit_id":"4ec5c7d3955c23256cdb1b0c369019eb503d91eb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    metavar\u003d\u0027\u003chost#pool\u003e\u0027,"},{"line_number":620,"context_line":"    help\u003d\u0027Destination host and pool.\u0027)"},{"line_number":621,"context_line":"@cliutils.arg("},{"line_number":622,"context_line":"    \u0027--force-host-copy\u0027,"},{"line_number":623,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":624,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":625,"context_line":"    required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_5f3861ef","line":622,"range":{"start_line":622,"start_character":5,"end_line":622,"end_character":23},"updated":"2016-03-03 04:37:45.000000000","message":"any aliases?\n\n\u0027--force_host_copy\u0027","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    metavar\u003d\u0027\u003chost#pool\u003e\u0027,"},{"line_number":620,"context_line":"    help\u003d\u0027Destination host and pool.\u0027)"},{"line_number":621,"context_line":"@cliutils.arg("},{"line_number":622,"context_line":"    \u0027--force-host-copy\u0027,"},{"line_number":623,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":624,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":625,"context_line":"    required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_adc04251","line":622,"range":{"start_line":622,"start_character":5,"end_line":622,"end_character":23},"in_reply_to":"7af24918_066849b8","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b3709b575570584c2faeea66def82a28ae097f56","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    metavar\u003d\u0027\u003chost#pool\u003e\u0027,"},{"line_number":620,"context_line":"    help\u003d\u0027Destination host and pool.\u0027)"},{"line_number":621,"context_line":"@cliutils.arg("},{"line_number":622,"context_line":"    \u0027--force-host-copy\u0027,"},{"line_number":623,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":624,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":625,"context_line":"    required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_066849b8","line":622,"range":{"start_line":622,"start_character":5,"end_line":622,"end_character":23},"in_reply_to":"7af24918_5f3861ef","updated":"2016-03-03 08:06:39.000000000","message":"+1 consistent with others","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":630,"context_line":"@api_versions.wraps(\"2.5\", \"2.14\")"},{"line_number":631,"context_line":"def do_migrate(cs, args):"},{"line_number":632,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":633,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host (Admin only).\"\"\""},{"line_number":634,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":635,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_845d7f7b","line":633,"range":{"start_line":633,"start_character":49,"end_line":633,"end_character":61},"updated":"2016-03-03 04:37:45.000000000","message":"Please remove this tag. I updated this file with this changeset: https://review.openstack.org/#/c/287436\n\n\nPlease add (Experimental) instead, in favor of https://review.openstack.org/#/c/286706/","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":630,"context_line":"@api_versions.wraps(\"2.5\", \"2.14\")"},{"line_number":631,"context_line":"def do_migrate(cs, args):"},{"line_number":632,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":633,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host (Admin only).\"\"\""},{"line_number":634,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":635,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_a4e6bbad","line":633,"range":{"start_line":633,"start_character":4,"end_line":633,"end_character":65},"updated":"2016-03-03 04:37:45.000000000","message":"Why double docstring?","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b3709b575570584c2faeea66def82a28ae097f56","unresolved":false,"context_lines":[{"line_number":630,"context_line":"@api_versions.wraps(\"2.5\", \"2.14\")"},{"line_number":631,"context_line":"def do_migrate(cs, args):"},{"line_number":632,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":633,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host (Admin only).\"\"\""},{"line_number":634,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":635,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_a6eb5512","line":633,"range":{"start_line":633,"start_character":49,"end_line":633,"end_character":61},"in_reply_to":"7af24918_845d7f7b","updated":"2016-03-03 08:06:39.000000000","message":"Well if this lands before that proposed revert, then it should use (Admin only) as-is -- which was discussed and approved.  If it lands after that revert then Goutham is right -- but that hasn\u0027t been approved. Timing is everything.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b3709b575570584c2faeea66def82a28ae097f56","unresolved":false,"context_lines":[{"line_number":630,"context_line":"@api_versions.wraps(\"2.5\", \"2.14\")"},{"line_number":631,"context_line":"def do_migrate(cs, args):"},{"line_number":632,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":633,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host (Admin only).\"\"\""},{"line_number":634,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":635,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_06dde96e","line":633,"range":{"start_line":633,"start_character":4,"end_line":633,"end_character":65},"in_reply_to":"7af24918_a4e6bbad","updated":"2016-03-03 08:06:39.000000000","message":"+1","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":630,"context_line":"@api_versions.wraps(\"2.5\", \"2.14\")"},{"line_number":631,"context_line":"def do_migrate(cs, args):"},{"line_number":632,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":633,"context_line":"    \"\"\"(Deprecated) Migrates share to a new host (Admin only).\"\"\""},{"line_number":634,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":635,"context_line":"    share.migration_start(args.host, args.force_host_copy, True)"},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_edb6caf7","line":633,"range":{"start_line":633,"start_character":49,"end_line":633,"end_character":61},"in_reply_to":"7af24918_a6eb5512","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":658,"context_line":"    required\u003dFalse,"},{"line_number":659,"context_line":"    help\u003d\u0027Enables or disables notification of data copying completed. \u0027"},{"line_number":660,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":661,"context_line":"    default\u003dTrue)"},{"line_number":662,"context_line":"@api_versions.experimental_api"},{"line_number":663,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":664,"context_line":"def do_migration_start(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_9fb789f4","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":16},"updated":"2016-03-03 04:37:45.000000000","message":"can you use store true as well, action\u003d\u0027store_true\u0027 like other commands in this file.. \n\nthat way, users can just specify the option \u0027--notify\u0027 and it will work as expected.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":658,"context_line":"    required\u003dFalse,"},{"line_number":659,"context_line":"    help\u003d\u0027Enables or disables notification of data copying completed. \u0027"},{"line_number":660,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":661,"context_line":"    default\u003dTrue)"},{"line_number":662,"context_line":"@api_versions.experimental_api"},{"line_number":663,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":664,"context_line":"def do_migration_start(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_68d628f2","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":16},"in_reply_to":"7af24918_4651b1d7","updated":"2016-03-03 13:30:16.000000000","message":"this would make sense only if default value was false","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b3709b575570584c2faeea66def82a28ae097f56","unresolved":false,"context_lines":[{"line_number":658,"context_line":"    required\u003dFalse,"},{"line_number":659,"context_line":"    help\u003d\u0027Enables or disables notification of data copying completed. \u0027"},{"line_number":660,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":661,"context_line":"    default\u003dTrue)"},{"line_number":662,"context_line":"@api_versions.experimental_api"},{"line_number":663,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":664,"context_line":"def do_migration_start(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_4651b1d7","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":16},"in_reply_to":"7af24918_9fb789f4","updated":"2016-03-03 08:06:39.000000000","message":"+1 and that would apply to froce-host-copy also","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":662,"context_line":"@api_versions.experimental_api"},{"line_number":663,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":664,"context_line":"def do_migration_start(cs, args):"},{"line_number":665,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":666,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":667,"context_line":"    share.migration_start(args.host, args.force_host_copy, args.notify)"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_5fa8618d","line":665,"range":{"start_line":665,"start_character":37,"end_line":665,"end_character":47},"updated":"2016-03-03 04:37:45.000000000","message":"same concern as above","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":662,"context_line":"@api_versions.experimental_api"},{"line_number":663,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":664,"context_line":"def do_migration_start(cs, args):"},{"line_number":665,"context_line":"    \"\"\"Migrates share to a new host (Admin only).\"\"\""},{"line_number":666,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":667,"context_line":"    share.migration_start(args.host, args.force_host_copy, args.notify)"},{"line_number":668,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_d2df2d38","line":665,"range":{"start_line":665,"start_character":37,"end_line":665,"end_character":47},"in_reply_to":"7af24918_5fa8618d","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":674,"context_line":"@api_versions.experimental_api"},{"line_number":675,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":676,"context_line":"def do_migration_complete(cs, args):"},{"line_number":677,"context_line":"    \"\"\"Completes migration for a given share (Admin only).\"\"\""},{"line_number":678,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":679,"context_line":"    share.migration_complete()"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_1fc4195d","line":677,"range":{"start_line":677,"start_character":45,"end_line":677,"end_character":57},"updated":"2016-03-03 04:37:45.000000000","message":"same concern as above.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":674,"context_line":"@api_versions.experimental_api"},{"line_number":675,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":676,"context_line":"def do_migration_complete(cs, args):"},{"line_number":677,"context_line":"    \"\"\"Completes migration for a given share (Admin only).\"\"\""},{"line_number":678,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":679,"context_line":"    share.migration_complete()"},{"line_number":680,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_32e931e7","line":677,"range":{"start_line":677,"start_character":45,"end_line":677,"end_character":57},"in_reply_to":"7af24918_1fc4195d","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":686,"context_line":"@api_versions.experimental_api"},{"line_number":687,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":688,"context_line":"def do_migration_cancel(cs, args):"},{"line_number":689,"context_line":"    \"\"\"Cancels migration for a given share when copying (Admin only).\"\"\""},{"line_number":690,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":691,"context_line":"    share.migration_cancel()"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_3f759531","line":689,"range":{"start_line":689,"start_character":56,"end_line":689,"end_character":68},"updated":"2016-03-03 04:37:45.000000000","message":"same concern as above","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":686,"context_line":"@api_versions.experimental_api"},{"line_number":687,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":688,"context_line":"def do_migration_cancel(cs, args):"},{"line_number":689,"context_line":"    \"\"\"Cancels migration for a given share when copying (Admin only).\"\"\""},{"line_number":690,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":691,"context_line":"    share.migration_cancel()"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_12e6b514","line":689,"range":{"start_line":689,"start_character":56,"end_line":689,"end_character":68},"in_reply_to":"7af24918_3f759531","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":697,"context_line":"    help\u003d\u0027Name or ID of the share to modify.\u0027)"},{"line_number":698,"context_line":"@cliutils.arg("},{"line_number":699,"context_line":"    \u0027state\u0027,"},{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_bfe525dd","line":699,"range":{"start_line":699,"start_character":5,"end_line":699,"end_character":10},"updated":"2016-03-03 04:37:45.000000000","message":"--state?\n\nalso add aliases, --task_state, --task-state","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":697,"context_line":"    help\u003d\u0027Name or ID of the share to modify.\u0027)"},{"line_number":698,"context_line":"@cliutils.arg("},{"line_number":699,"context_line":"    \u0027state\u0027,"},{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_68bf48aa","line":699,"range":{"start_line":699,"start_character":5,"end_line":699,"end_character":10},"in_reply_to":"7af24918_bfe525dd","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":697,"context_line":"    help\u003d\u0027Name or ID of the share to modify.\u0027)"},{"line_number":698,"context_line":"@cliutils.arg("},{"line_number":699,"context_line":"    \u0027state\u0027,"},{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"},{"line_number":703,"context_line":"          \u0027migration_error, migration_success, migration_cancelled.\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_1fc09929","line":700,"range":{"start_line":699,"start_character":5,"end_line":700,"end_character":21},"updated":"2016-03-03 04:37:45.000000000","message":"most reset task state methods make this optional.. they have a \"default\" behavior if the option is not specified. is it true for this case?","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":696,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":697,"context_line":"    help\u003d\u0027Name or ID of the share to modify.\u0027)"},{"line_number":698,"context_line":"@cliutils.arg("},{"line_number":699,"context_line":"    \u0027state\u0027,"},{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"},{"line_number":703,"context_line":"          \u0027migration_error, migration_success, migration_cancelled.\u0027))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_a8e310d8","line":700,"range":{"start_line":699,"start_character":5,"end_line":700,"end_character":21},"in_reply_to":"7af24918_1fc09929","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5676ee2efb94cd33ad1a0825e0de201330f69f15","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"},{"line_number":703,"context_line":"          \u0027migration_error, migration_success, migration_cancelled.\u0027))"},{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_62a2e0fe","line":703,"range":{"start_line":703,"start_character":11,"end_line":703,"end_character":66},"updated":"2016-03-03 04:47:30.000000000","message":"The server side change suggests that these statuses are valid:\n\nTASK_STATE_MIGRATION_STARTING,\n    TASK_STATE_MIGRATION_IN_PROGRESS,\n    TASK_STATE_MIGRATION_COMPLETING,\n    TASK_STATE_MIGRATION_SUCCESS,\n    TASK_STATE_MIGRATION_ERROR,\n    TASK_STATE_MIGRATION_CANCELLED,\n    TASK_STATE_MIGRATION_DRIVER_IN_PROGRESS,\n    TASK_STATE_MIGRATION_DRIVER_PHASE1_DONE,\n    TASK_STATE_DATA_COPYING_STARTING,\n    TASK_STATE_DATA_COPYING_IN_PROGRESS,\n    TASK_STATE_DATA_COPYING_COMPLETING,\n    TASK_STATE_DATA_COPYING_COMPLETED,\n    TASK_STATE_DATA_COPYING_CANCELLED,\n    TASK_STATE_DATA_COPYING_ERROR\n\n\nhttps://review.openstack.org/#/c/250515/45/manila/common/constants.py","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"},{"line_number":703,"context_line":"          \u0027migration_error, migration_success, migration_cancelled.\u0027))"},{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_0d105658","line":703,"range":{"start_line":703,"start_character":11,"end_line":703,"end_character":66},"in_reply_to":"7af24918_62a2e0fe","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b3709b575570584c2faeea66def82a28ae097f56","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"},{"line_number":703,"context_line":"          \u0027migration_error, migration_success, migration_cancelled.\u0027))"},{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_86da994a","line":703,"range":{"start_line":703,"start_character":11,"end_line":703,"end_character":66},"in_reply_to":"7af24918_62a2e0fe","updated":"2016-03-03 08:06:39.000000000","message":"Probably correct to only allow these 3 and not allow the in-progress ones.  Worth further consideration though.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    metavar\u003d\u0027\u003cstate\u003e\u0027,"},{"line_number":701,"context_line":"    default\u003dNone,"},{"line_number":702,"context_line":"    help\u003d(\u0027Indicate which task state to assign the share. Options include \u0027"},{"line_number":703,"context_line":"          \u0027migration_error, migration_success, migration_cancelled.\u0027))"},{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_a805d011","line":703,"range":{"start_line":703,"start_character":11,"end_line":703,"end_character":66},"in_reply_to":"7af24918_86da994a","updated":"2016-03-03 13:30:16.000000000","message":"Although server is allowing, at this moment it should be consistent.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"},{"line_number":707,"context_line":"    \"\"\"Explicitly update the state of a share (Admin only).\"\"\""},{"line_number":708,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":709,"context_line":"    share.reset_task_state(args.state)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_5f0b418e","line":707,"range":{"start_line":707,"start_character":46,"end_line":707,"end_character":58},"updated":"2016-03-03 04:37:45.000000000","message":"please remove \"Admin Only\", add Experimental instead..","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"},{"line_number":707,"context_line":"    \"\"\"Explicitly update the state of a share (Admin only).\"\"\""},{"line_number":708,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":709,"context_line":"    share.reset_task_state(args.state)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_1fd7f9ed","line":707,"range":{"start_line":707,"start_character":28,"end_line":707,"end_character":35},"updated":"2016-03-03 04:37:45.000000000","message":"task state?","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"b3709b575570584c2faeea66def82a28ae097f56","unresolved":false,"context_lines":[{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"},{"line_number":707,"context_line":"    \"\"\"Explicitly update the state of a share (Admin only).\"\"\""},{"line_number":708,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":709,"context_line":"    share.reset_task_state(args.state)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_66c78d64","line":707,"range":{"start_line":707,"start_character":46,"end_line":707,"end_character":58},"in_reply_to":"7af24918_5f0b418e","updated":"2016-03-03 08:06:39.000000000","message":"+1 for experimental. That patch landed so we should get those consistent or enter a bug.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":704,"context_line":"@api_versions.experimental_api"},{"line_number":705,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":706,"context_line":"def do_reset_task_state(cs, args):"},{"line_number":707,"context_line":"    \"\"\"Explicitly update the state of a share (Admin only).\"\"\""},{"line_number":708,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":709,"context_line":"    share.reset_task_state(args.state)"},{"line_number":710,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_ed37ea4a","line":707,"range":{"start_line":707,"start_character":46,"end_line":707,"end_character":58},"in_reply_to":"7af24918_66c78d64","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":717,"context_line":"@api_versions.experimental_api"},{"line_number":718,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":719,"context_line":"def do_migration_get_progress(cs, args):"},{"line_number":720,"context_line":"    \"\"\"Gets migration progress for a given share when copying (Admin only).\"\"\""},{"line_number":721,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":722,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":723,"context_line":"    cliutils.print_dict(result[1])"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_dff75189","line":720,"range":{"start_line":720,"start_character":62,"end_line":720,"end_character":74},"updated":"2016-03-03 04:37:45.000000000","message":"same concern here.. Add (Experimental) instead.","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"65169e6bb338b4ba1c1a5d156689305805565db3","unresolved":false,"context_lines":[{"line_number":717,"context_line":"@api_versions.experimental_api"},{"line_number":718,"context_line":"@api_versions.wraps(\"2.15\")"},{"line_number":719,"context_line":"def do_migration_get_progress(cs, args):"},{"line_number":720,"context_line":"    \"\"\"Gets migration progress for a given share when copying (Admin only).\"\"\""},{"line_number":721,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":722,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":723,"context_line":"    cliutils.print_dict(result[1])"}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_72c61969","line":720,"range":{"start_line":720,"start_character":62,"end_line":720,"end_character":74},"in_reply_to":"7af24918_dff75189","updated":"2016-03-03 13:30:16.000000000","message":"Done","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fb03050638e51ca5a6fec602a21a8093bb8ceeff","unresolved":false,"context_lines":[{"line_number":720,"context_line":"    \"\"\"Gets migration progress for a given share when copying (Admin only).\"\"\""},{"line_number":721,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":722,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":723,"context_line":"    cliutils.print_dict(result[1])"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":21,"id":"7af24918_1f54191f","line":723,"range":{"start_line":723,"start_character":24,"end_line":723,"end_character":33},"updated":"2016-03-03 04:37:45.000000000","message":"For sanity, in case the result is paginated, ever, \n\ndef _print_progress(cs, progress):\n    info \u003d progress._info.copy()\n    info.pop(\u0027links\u0027, None)\n    cliutils.print_dict(info)","commit_id":"dc7d8c8d53547e2ad8cffcb0b72f1abaf11d9bdf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5217b8acdd2c9e9b50e9a9e5407d910903b50e56","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    help\u003d\u0027Name or ID of the share to modify.\u0027)"},{"line_number":701,"context_line":"@cliutils.arg("},{"line_number":702,"context_line":"    \u0027--task-state\u0027,"},{"line_number":703,"context_line":"    \u0027--task_state\u0027,"},{"line_number":704,"context_line":"    metavar\u003d\u0027\u003ctask_state\u003e\u0027,"},{"line_number":705,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":706,"context_line":"    default\u003d\u0027migration_error\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_684908b7","line":703,"range":{"start_line":703,"start_character":7,"end_line":703,"end_character":17},"updated":"2016-03-03 13:34:15.000000000","message":"Please add --state as well, didn\u0027t mean we need to get rid of it..","commit_id":"5ffba5a8eff6f651bc1671c5855c950192542787"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cb715935362902dafa9f75c4c09831ff538af048","unresolved":false,"context_lines":[{"line_number":700,"context_line":"    help\u003d\u0027Name or ID of the share to modify.\u0027)"},{"line_number":701,"context_line":"@cliutils.arg("},{"line_number":702,"context_line":"    \u0027--task-state\u0027,"},{"line_number":703,"context_line":"    \u0027--task_state\u0027,"},{"line_number":704,"context_line":"    metavar\u003d\u0027\u003ctask_state\u003e\u0027,"},{"line_number":705,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":706,"context_line":"    default\u003d\u0027migration_error\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_fedaf249","line":703,"range":{"start_line":703,"start_character":7,"end_line":703,"end_character":17},"in_reply_to":"7af24918_684908b7","updated":"2016-03-03 13:58:12.000000000","message":"Done","commit_id":"5ffba5a8eff6f651bc1671c5855c950192542787"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5217b8acdd2c9e9b50e9a9e5407d910903b50e56","unresolved":false,"context_lines":[{"line_number":731,"context_line":"    \"\"\"Gets migration progress of a given share when copying (Experimental).\"\"\""},{"line_number":732,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":733,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":734,"context_line":"    cliutils.print_dict(result[1])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_8891f4f3","line":734,"range":{"start_line":734,"start_character":24,"end_line":734,"end_character":33},"updated":"2016-03-03 13:34:15.000000000","message":"For sanity, in case the result is paginated, ever, \n    \n    _print_progress(cs, result)\n\n\ndef _print_progress(cs, progress):\n    info \u003d progress._info.copy()\n    info.pop(\u0027links\u0027, None)\n    cliutils.print_dict(info)","commit_id":"5ffba5a8eff6f651bc1671c5855c950192542787"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"cb715935362902dafa9f75c4c09831ff538af048","unresolved":false,"context_lines":[{"line_number":731,"context_line":"    \"\"\"Gets migration progress of a given share when copying (Experimental).\"\"\""},{"line_number":732,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":733,"context_line":"    result \u003d share.migration_get_progress()"},{"line_number":734,"context_line":"    cliutils.print_dict(result[1])"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"@cliutils.arg("}],"source_content_type":"text/x-python","patch_set":23,"id":"7af24918_5efe86ae","line":734,"range":{"start_line":734,"start_character":24,"end_line":734,"end_character":33},"in_reply_to":"7af24918_8891f4f3","updated":"2016-03-03 13:58:12.000000000","message":"forgot about it! Done now.","commit_id":"5ffba5a8eff6f651bc1671c5855c950192542787"}]}
