)]}'
{"manilaclient/tests/functional/client.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"030e201ed992e0cf3a4ff0666aea60a5410fe31d","unresolved":false,"context_lines":[{"line_number":862,"context_line":"        \"\"\""},{"line_number":863,"context_line":"        cmd \u003d \"share-export-location-list %s\" % share"},{"line_number":864,"context_line":"        if columns is not None:"},{"line_number":865,"context_line":"            cmd +\u003d \" --columns \" + columns"},{"line_number":866,"context_line":"        export_locations_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":867,"context_line":"        export_locations \u003d utils.listing(export_locations_raw)"},{"line_number":868,"context_line":"        return export_locations"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_9d6001a7","line":865,"updated":"2016-01-22 17:28:48.000000000","message":"I\u0027d try using join for python, but I don\u0027t mind this for readability","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9b65d7682136deeb25b251122f7eb3447d09c00","unresolved":false,"context_lines":[{"line_number":862,"context_line":"        \"\"\""},{"line_number":863,"context_line":"        cmd \u003d \"share-export-location-list %s\" % share"},{"line_number":864,"context_line":"        if columns is not None:"},{"line_number":865,"context_line":"            cmd +\u003d \" --columns \" + columns"},{"line_number":866,"context_line":"        export_locations_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":867,"context_line":"        export_locations \u003d utils.listing(export_locations_raw)"},{"line_number":868,"context_line":"        return export_locations"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_c00ce23d","line":865,"in_reply_to":"9a68dd71_9d6001a7","updated":"2016-02-02 10:46:59.000000000","message":"It was intentional approach and expected thing is described in docstring. There is no real reason to expect here list and then apply \"join\" operation to it. It is used by limited set of tests that provide expected string explicitly.","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"030e201ed992e0cf3a4ff0666aea60a5410fe31d","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        share_raw \u003d self.manila("},{"line_number":880,"context_line":"            \u0027share-export-location-show %(share)s %(el_uuid)s\u0027 % {"},{"line_number":881,"context_line":"                \u0027share\u0027: share,"},{"line_number":882,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":883,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":884,"context_line":"        return share"},{"line_number":885,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_bda8658e","line":882,"updated":"2016-01-22 17:28:48.000000000","message":"microversion param should be separate line","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a34a9d8c0a1cd604e1da762a510a3bb055d9eac0","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        share_raw \u003d self.manila("},{"line_number":880,"context_line":"            \u0027share-export-location-show %(share)s %(el_uuid)s\u0027 % {"},{"line_number":881,"context_line":"                \u0027share\u0027: share,"},{"line_number":882,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":883,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":884,"context_line":"        return share"},{"line_number":885,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_a419737b","line":882,"in_reply_to":"7a5de9d1_55671325","updated":"2016-01-28 15:05:09.000000000","message":"Not a requirement, but a documented openstack guideline:\nhttp://docs.openstack.org/developer/hacking/#calling-methods","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9b65d7682136deeb25b251122f7eb3447d09c00","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        share_raw \u003d self.manila("},{"line_number":880,"context_line":"            \u0027share-export-location-show %(share)s %(el_uuid)s\u0027 % {"},{"line_number":881,"context_line":"                \u0027share\u0027: share,"},{"line_number":882,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":883,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":884,"context_line":"        return share"},{"line_number":885,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_1580fe8a","line":882,"in_reply_to":"7a5de9d1_a419737b","updated":"2016-02-02 10:46:59.000000000","message":"Done","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d4172f16cd54cf5d344e59a411be892026bc14f","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        share_raw \u003d self.manila("},{"line_number":880,"context_line":"            \u0027share-export-location-show %(share)s %(el_uuid)s\u0027 % {"},{"line_number":881,"context_line":"                \u0027share\u0027: share,"},{"line_number":882,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":883,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":884,"context_line":"        return share"},{"line_number":885,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_55671325","line":882,"in_reply_to":"9a68dd71_bda8658e","updated":"2016-01-28 14:00:46.000000000","message":"why?","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"030e201ed992e0cf3a4ff0666aea60a5410fe31d","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            \u0027share-instance-export-location-show \u0027"},{"line_number":917,"context_line":"            \u0027%(share_instance)s %(el_uuid)s\u0027 % {"},{"line_number":918,"context_line":"                \u0027share_instance\u0027: share_instance,"},{"line_number":919,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":920,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":921,"context_line":"        return share"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_7d0f4d88","line":919,"range":{"start_line":919,"start_character":50,"end_line":919,"end_character":62},"updated":"2016-01-22 17:28:48.000000000","message":"same","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9b65d7682136deeb25b251122f7eb3447d09c00","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            \u0027share-instance-export-location-show \u0027"},{"line_number":917,"context_line":"            \u0027%(share_instance)s %(el_uuid)s\u0027 % {"},{"line_number":918,"context_line":"                \u0027share_instance\u0027: share_instance,"},{"line_number":919,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":920,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":921,"context_line":"        return share"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_35541a20","line":919,"range":{"start_line":919,"start_character":50,"end_line":919,"end_character":62},"in_reply_to":"7a5de9d1_e4368be6","updated":"2016-02-02 10:46:59.000000000","message":"Done","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a34a9d8c0a1cd604e1da762a510a3bb055d9eac0","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            \u0027share-instance-export-location-show \u0027"},{"line_number":917,"context_line":"            \u0027%(share_instance)s %(el_uuid)s\u0027 % {"},{"line_number":918,"context_line":"                \u0027share_instance\u0027: share_instance,"},{"line_number":919,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":920,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":921,"context_line":"        return share"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_e4368be6","line":919,"range":{"start_line":919,"start_character":50,"end_line":919,"end_character":62},"in_reply_to":"7a5de9d1_f56ddf04","updated":"2016-01-28 15:05:09.000000000","message":"openstack calling methods guideline","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d4172f16cd54cf5d344e59a411be892026bc14f","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            \u0027share-instance-export-location-show \u0027"},{"line_number":917,"context_line":"            \u0027%(share_instance)s %(el_uuid)s\u0027 % {"},{"line_number":918,"context_line":"                \u0027share_instance\u0027: share_instance,"},{"line_number":919,"context_line":"                \u0027el_uuid\u0027: export_location_uuid}, microversion\u003dmicroversion)"},{"line_number":920,"context_line":"        share \u003d output_parser.details(share_raw)"},{"line_number":921,"context_line":"        return share"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_f56ddf04","line":919,"range":{"start_line":919,"start_character":50,"end_line":919,"end_character":62},"in_reply_to":"9a68dd71_7d0f4d88","updated":"2016-01-28 14:00:46.000000000","message":"why?","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"}],"manilaclient/tests/functional/test_export_locations.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"030e201ed992e0cf3a4ff0666aea60a5410fe31d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            self.share[\u0027id\u0027], columns\u003d\u0027uuid,path\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertTrue(len(export_locations) \u003e 0)"},{"line_number":54,"context_line":"        expected_keys \u003d (\u0027Uuid\u0027, \u0027Path\u0027)"},{"line_number":55,"context_line":"        unexpected_keys \u003d (\u0027Updated At\u0027, \u0027Created At\u0027)"},{"line_number":56,"context_line":"        for el in export_locations:"},{"line_number":57,"context_line":"            for key in expected_keys:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_98600fa7","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":21},"updated":"2016-01-22 17:28:48.000000000","message":"why do we have UUID,Uuid,uuid (above, here, below)?","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0003d5eaaa983b178d94d3b0ac5ad20581d39b05","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            self.share[\u0027id\u0027], columns\u003d\u0027uuid,path\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.assertTrue(len(export_locations) \u003e 0)"},{"line_number":54,"context_line":"        expected_keys \u003d (\u0027Uuid\u0027, \u0027Path\u0027)"},{"line_number":55,"context_line":"        unexpected_keys \u003d (\u0027Updated At\u0027, \u0027Created At\u0027)"},{"line_number":56,"context_line":"        for el in export_locations:"},{"line_number":57,"context_line":"            for key in expected_keys:"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_5270330b","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":21},"in_reply_to":"9a68dd71_98600fa7","updated":"2016-01-22 18:47:55.000000000","message":"\"Uuid\" and \"UUID\" are CLI\u0027ed names of columns, which are translated original key \"uuid\" returned by API.\n\nThere are 2 different capitalized versions because one of them is from \"list\" API and another from \"get/show\". So, it is expected proper behaviour.","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"}],"manilaclient/v2/share_instance_export_locations.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"030e201ed992e0cf3a4ff0666aea60a5410fe31d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            (\"/share_instances/%(share_instance_id)s/export_locations/\""},{"line_number":50,"context_line":"             \"%(export_location_id)s\") % {"},{"line_number":51,"context_line":"                 \"share_instance_id\": share_instance_id,"},{"line_number":52,"context_line":"                 \"export_location_id\": export_location_id}, \"export_location\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_984faf6a","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":76},"updated":"2016-01-22 17:28:48.000000000","message":"separate line for get parameter \u0027export_location\u0027","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d9b65d7682136deeb25b251122f7eb3447d09c00","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            (\"/share_instances/%(share_instance_id)s/export_locations/\""},{"line_number":50,"context_line":"             \"%(export_location_id)s\") % {"},{"line_number":51,"context_line":"                 \"share_instance_id\": share_instance_id,"},{"line_number":52,"context_line":"                 \"export_location_id\": export_location_id}, \"export_location\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_c02382a6","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":76},"in_reply_to":"7a5de9d1_84e8f711","updated":"2016-02-02 10:46:59.000000000","message":"Done","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"a34a9d8c0a1cd604e1da762a510a3bb055d9eac0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            (\"/share_instances/%(share_instance_id)s/export_locations/\""},{"line_number":50,"context_line":"             \"%(export_location_id)s\") % {"},{"line_number":51,"context_line":"                 \"share_instance_id\": share_instance_id,"},{"line_number":52,"context_line":"                 \"export_location_id\": export_location_id}, \"export_location\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_84e8f711","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":76},"in_reply_to":"7a5de9d1_95a6eb51","updated":"2016-01-28 15:05:09.000000000","message":"guideline to put args on separate lines when they don\u0027t fit on one.","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d4172f16cd54cf5d344e59a411be892026bc14f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            (\"/share_instances/%(share_instance_id)s/export_locations/\""},{"line_number":50,"context_line":"             \"%(export_location_id)s\") % {"},{"line_number":51,"context_line":"                 \"share_instance_id\": share_instance_id,"},{"line_number":52,"context_line":"                 \"export_location_id\": export_location_id}, \"export_location\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a5de9d1_95a6eb51","line":52,"range":{"start_line":52,"start_character":61,"end_line":52,"end_character":76},"in_reply_to":"9a68dd71_984faf6a","updated":"2016-01-28 14:00:46.000000000","message":"why?","commit_id":"0d358683c04b874f203d5c60616b4763a3a4483f"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"af057459370dd014341131e39e3dbfa611e94093","unresolved":false,"context_lines":[{"line_number":707,"context_line":"@cliutils.arg("},{"line_number":708,"context_line":"    \u0027export_location\u0027,"},{"line_number":709,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":710,"context_line":"    help\u003d\u0027Name or ID of the share export location.\u0027)"},{"line_number":711,"context_line":"def do_share_export_location_show(cs, args):"},{"line_number":712,"context_line":"    \"\"\"Show export location of the share.\"\"\""},{"line_number":713,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_756d6498","line":710,"range":{"start_line":710,"start_character":9,"end_line":710,"end_character":14},"updated":"2016-01-08 10:57:41.000000000","message":"Name of export location?","commit_id":"4de2806a4fb0364da92a3a590fc17cb16205143d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2eda57b1eba4669e5326e3c7c42abd70f615bafe","unresolved":false,"context_lines":[{"line_number":707,"context_line":"@cliutils.arg("},{"line_number":708,"context_line":"    \u0027export_location\u0027,"},{"line_number":709,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":710,"context_line":"    help\u003d\u0027Name or ID of the share export location.\u0027)"},{"line_number":711,"context_line":"def do_share_export_location_show(cs, args):"},{"line_number":712,"context_line":"    \"\"\"Show export location of the share.\"\"\""},{"line_number":713,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_ec2506ae","line":710,"range":{"start_line":710,"start_character":9,"end_line":710,"end_character":14},"in_reply_to":"fa69d971_756d6498","updated":"2016-01-08 13:13:37.000000000","message":"Done","commit_id":"4de2806a4fb0364da92a3a590fc17cb16205143d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"af057459370dd014341131e39e3dbfa611e94093","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"@cliutils.arg("},{"line_number":1278,"context_line":"    \u0027export_location\u0027,"},{"line_number":1279,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1280,"context_line":"    help\u003d\u0027Name or ID of the share instance export location.\u0027)"},{"line_number":1281,"context_line":"def do_share_instance_export_location_show(cs, args):"},{"line_number":1282,"context_line":"    \"\"\"Show export location for the share instance.\"\"\""},{"line_number":1283,"context_line":"    instance \u003d _find_share_instance(cs, args.instance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_b299247b","line":1280,"range":{"start_line":1280,"start_character":9,"end_line":1280,"end_character":15},"updated":"2016-01-08 10:57:41.000000000","message":"Name of export location?","commit_id":"4de2806a4fb0364da92a3a590fc17cb16205143d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2eda57b1eba4669e5326e3c7c42abd70f615bafe","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"@cliutils.arg("},{"line_number":1278,"context_line":"    \u0027export_location\u0027,"},{"line_number":1279,"context_line":"    metavar\u003d\u0027\u003cexport_location\u003e\u0027,"},{"line_number":1280,"context_line":"    help\u003d\u0027Name or ID of the share instance export location.\u0027)"},{"line_number":1281,"context_line":"def do_share_instance_export_location_show(cs, args):"},{"line_number":1282,"context_line":"    \"\"\"Show export location for the share instance.\"\"\""},{"line_number":1283,"context_line":"    instance \u003d _find_share_instance(cs, args.instance)"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_cc592237","line":1280,"range":{"start_line":1280,"start_character":9,"end_line":1280,"end_character":15},"in_reply_to":"fa69d971_b299247b","updated":"2016-01-08 13:13:37.000000000","message":"Done","commit_id":"4de2806a4fb0364da92a3a590fc17cb16205143d"}]}