)]}'
{"id":"openstack%2Fpython-manilaclient~259334","triplet_id":"openstack%2Fpython-manilaclient~master~Ibbd705fdceb2229b6af4df66b982784077f21330","project":"openstack/python-manilaclient","branch":"master","topic":"code-cleanup","hashtags":[],"change_id":"Ibbd705fdceb2229b6af4df66b982784077f21330","subject":"Remove unreachable code from unit tests","status":"MERGED","created":"2015-12-18 08:50:17.000000000","updated":"2016-01-08 05:01:14.000000000","submitted":"2016-01-08 05:01:14.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8086c42c3c34d887631d350b7c5eecb9ebf8d39f","_number":259334,"virtual_id_number":259334,"owner":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":2,"date":"2016-01-08 05:01:14.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"all":[{"value":2,"date":"2015-12-23 17:49:07.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-07 21:00:40.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"all":[{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-07 21:00:40.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-12-23 17:49:07.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2016-01-07 21:00:40.000000000","updated_by":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"reviewer":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"state":"REVIEWER"},{"updated":"2016-01-08 05:01:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0c8f6ac92d34f6d3f0579df965e237fcca03c165","author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"date":"2015-12-18 08:50:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d2bb5ab0d688d8378a3464c26de629e5e0c7364d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-12-18 09:27:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-pep8/969db38/ : SUCCESS in 1m 03s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/check/gate-python-manilaclient-docs/cd3b0ba//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python27/df89ecb/ : SUCCESS in 3m 20s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python34/30f0f9c/ : SUCCESS in 2m 54s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/check/gate-manilaclient-dsvm-neutron-functional/892144a/ : SUCCESS in 37m 08s","accounts_in_message":[],"_revision_number":1},{"id":"b62a8f68291ae1baa9ef874bdcf4468970bcb75d","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2015-12-23 17:49:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4ceebd87f920cb3275a7b7231f9cc82fa9c60b43","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2016-01-07 21:00:40.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7a16765d650678f33ac222313c13326ea033522c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 21:00:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"27ec81eff00cf41b7f56aeff15baafa1beea54fc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 22:31:45.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/gate/gate-python-manilaclient-docs/8b89995//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-pep8/4a58c52/ : SUCCESS in 1m 13s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-python27/6894c81/ : SUCCESS in 6m 12s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-python34/a2e6d5b/ : SUCCESS in 6m 12s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/gate/gate-manilaclient-dsvm-neutron-functional/c00bf9c/ : FAILURE in 46m 10s","accounts_in_message":[],"_revision_number":1},{"id":"557b0ccaba5415ccf99ab71ea11d4b47c4105992","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2016-01-07 22:34:14.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"b2353269b0c3539880c5b8ac7fc9f915a022f78e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 23:58:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-pep8/8dbbdbf/ : SUCCESS in 1m 12s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/check/gate-python-manilaclient-docs/2040763//doc/build/html/ : SUCCESS in 1m 15s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python27/ebe3ceb/ : SUCCESS in 3m 03s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python34/4578277/ : SUCCESS in 3m 03s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/check/gate-manilaclient-dsvm-neutron-functional/fb0aa83/ : SUCCESS in 1h 08m 08s","accounts_in_message":[],"_revision_number":1},{"id":"44ef5700e59efee49fb915dea91e5521873a9bb2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-07 23:58:45.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"643ed3b5a630d79d92d28798a50fa14df93d04e1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 00:32:14.000000000","message":"Patch Set 1:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c09f02ac6084c2c8189c1cdf9534d5ad69265452","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 01:13:50.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/gate/gate-python-manilaclient-docs/5454152//doc/build/html/ : SUCCESS in 1m 19s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-pep8/ad2fe02/ : SUCCESS in 1m 06s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-python27/a146b9d/ : SUCCESS in 3m 11s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-python34/ce9b854/ : SUCCESS in 3m 33s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/gate/gate-manilaclient-dsvm-neutron-functional/5255a05/ : FAILURE in 35m 02s","accounts_in_message":[],"_revision_number":1},{"id":"e7e07bd870d69a9bb7d94cd0af46901a90c169aa","author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"date":"2016-01-08 02:40:07.000000000","message":"Patch Set 1:\n\nrevirify","accounts_in_message":[],"_revision_number":1},{"id":"14fdb33393031d91ca61d05b6ce4c61b2443ff71","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2016-01-08 02:45:39.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"1e97e20b1ec6b49a1545acd93105c479fab4a9ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 03:27:20.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-pep8/ce61c17/ : SUCCESS in 57s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/check/gate-python-manilaclient-docs/4bb3495//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python27/e8742fd/ : SUCCESS in 3m 33s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python34/7eb6b3e/ : SUCCESS in 3m 12s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/check/gate-manilaclient-dsvm-neutron-functional/4a7a73e/ : FAILURE in 38m 02s","accounts_in_message":[],"_revision_number":1},{"id":"143b533f9f7efe7dbc7b26528c6cfa97446f66b1","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2016-01-08 03:28:25.000000000","message":"Patch Set 1:\n\nreverify","accounts_in_message":[],"_revision_number":1},{"id":"184ae8746b0ce2bf0ba23d8789308bb1e1a316a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 04:16:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-pep8/00497f3/ : SUCCESS in 1m 02s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/check/gate-python-manilaclient-docs/6301106//doc/build/html/ : SUCCESS in 1m 06s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python27/9cd90d9/ : SUCCESS in 2m 37s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/check/gate-python-manilaclient-python34/312346b/ : SUCCESS in 3m 00s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/check/gate-manilaclient-dsvm-neutron-functional/eb26e1d/ : SUCCESS in 48m 10s","accounts_in_message":[],"_revision_number":1},{"id":"a742a71e49ee172de95d9bb483569f9871bb17aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 04:21:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"74f8c668793d010aebc1d8114c05af1550c5f911","date":"2016-01-08 05:01:14.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"84a193501e7dc5c7d1998a56e491905d87223744","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 05:01:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/34/259334/1/gate/gate-python-manilaclient-docs/30774f0//doc/build/html/ : SUCCESS in 1m 11s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-pep8/f178876/ : SUCCESS in 1m 10s\n- gate-python-manilaclient-python27 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-python27/09f7d75/ : SUCCESS in 2m 38s\n- gate-python-manilaclient-python34 http://logs.openstack.org/34/259334/1/gate/gate-python-manilaclient-python34/8e8ffb2/ : SUCCESS in 3m 20s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/34/259334/1/gate/gate-manilaclient-dsvm-neutron-functional/ccee776/ : SUCCESS in 38m 05s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3e41af6f267dee3ce72bdd2da13bdde121a0b874","revisions":{"3e41af6f267dee3ce72bdd2da13bdde121a0b874":{"kind":"REWORK","_number":1,"created":"2015-12-18 08:50:17.000000000","uploader":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"ref":"refs/changes/34/259334/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/34/259334/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/34/259334/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/34/259334/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/34/259334/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/34/259334/1"}}},"commit":{"parents":[{"commit":"b3b7987271b3b83c62f420552ebda993527c52c7","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b3b7987271b3b83c62f420552ebda993527c52c7"}]}],"author":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2015-12-18 08:15:19.000000000","tz":-480},"committer":{"name":"Ankit Agrawal","email":"ankit11.agrawal@nttdata.com","date":"2015-12-18 08:19:35.000000000","tz":-480},"subject":"Remove unreachable code from unit tests","message":"Remove unreachable code from unit tests\n\nThis patch removes unreachable code that exists in method\n_cs_request_with_retries of fake_clients.py module.\n\nTrivialFix\n\nChange-Id: Ibbd705fdceb2229b6af4df66b982784077f21330\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3e41af6f267dee3ce72bdd2da13bdde121a0b874"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/3e41af6f267dee3ce72bdd2da13bdde121a0b874"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}