)]}'
{"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a533e59b50c4b8ef9e2448f0a92a0be448ec6bc8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"env | grep OS_"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Set options to config client."},{"line_number":35,"context_line":"source $BASE/new/devstack/openrc demo demo"},{"line_number":36,"context_line":"env | grep OS_"},{"line_number":37,"context_line":"export OS_TENANT_NAME\u003d${OS_PROJECT_NAME:-$OS_TENANT_NAME}"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"source $BASE/new/devstack/openrc admin demo"},{"line_number":40,"context_line":"env | grep OS_"},{"line_number":41,"context_line":"export OS_TENANT_NAME\u003d${OS_PROJECT_NAME:-$OS_TENANT_NAME}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Suppress errors in cleanup of resources"},{"line_number":44,"context_line":"SUPPRESS_ERRORS\u003d${SUPPRESS_ERRORS_IN_CLEANUP:-True}"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dab17558_db6a5f80","line":41,"range":{"start_line":35,"start_character":0,"end_line":41,"end_character":57},"updated":"2016-05-17 14:14:59.000000000","message":"These \"source\"s were made twice only for sake of config init.\nRemoving config init you should remove these too.","commit_id":"dd67d43a22ccaa4d38600ded2dc39f92d30f7f36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a533e59b50c4b8ef9e2448f0a92a0be448ec6bc8","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        DEFAULT_NEUTRON_SUBNET\u003d$(neutron subnet-show private-subnet -c id -f value)"},{"line_number":55,"context_line":"        NEUTRON_NET\u003d${NEUTRON_NET:-$DEFAULT_NEUTRON_NET}"},{"line_number":56,"context_line":"        NEUTRON_SUBNET\u003d${NEUTRON_SUBNET:-$DEFAULT_NEUTRON_SUBNET}"},{"line_number":57,"context_line":"        manila share-network-create \\"},{"line_number":58,"context_line":"            --name $SHARE_NETWORK_NAME \\"},{"line_number":59,"context_line":"            --neutron-net $NEUTRON_NET \\"},{"line_number":60,"context_line":"            --neutron-subnet $NEUTRON_SUBNET"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        DEFAULT_NOVA_NET\u003d$(nova net-list | grep private | awk \u0027{print $2}\u0027)"},{"line_number":63,"context_line":"        NOVA_NET\u003d${NOVA_NET:-$DEFAULT_NOVA_NET}"},{"line_number":64,"context_line":"        manila share-network-create \\"},{"line_number":65,"context_line":"            --name $SHARE_NETWORK_NAME \\"},{"line_number":66,"context_line":"            --nova-net $NOVA_NET"},{"line_number":67,"context_line":"    fi"},{"line_number":68,"context_line":"    iniset $MANILACLIENT_CONF DEFAULT share_network $SHARE_NETWORK_NAME"},{"line_number":69,"context_line":"    iniset $MANILACLIENT_CONF DEFAULT admin_share_network $SHARE_NETWORK_NAME"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dab17558_fb9f63b1","line":66,"range":{"start_line":57,"start_character":8,"end_line":66,"end_character":32},"updated":"2016-05-17 14:14:59.000000000","message":"This \"share-network\" has been created under \"demo\" project. But in code you hardcoded \"admin\" project, and, it fails as expected - resource of other project is not available.","commit_id":"dd67d43a22ccaa4d38600ded2dc39f92d30f7f36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a533e59b50c4b8ef9e2448f0a92a0be448ec6bc8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            --name $SHARE_NETWORK_NAME \\"},{"line_number":66,"context_line":"            --nova-net $NOVA_NET"},{"line_number":67,"context_line":"    fi"},{"line_number":68,"context_line":"    iniset $MANILACLIENT_CONF DEFAULT share_network $SHARE_NETWORK_NAME"},{"line_number":69,"context_line":"    iniset $MANILACLIENT_CONF DEFAULT admin_share_network $SHARE_NETWORK_NAME"},{"line_number":70,"context_line":"fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Set share type if required"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dab17558_5bdb0f4f","line":69,"range":{"start_line":68,"start_character":4,"end_line":69,"end_character":77},"updated":"2016-05-17 14:14:59.000000000","message":"These too are project-related too. Currently, we use single tenant for both roles, that\u0027s why now it works.","commit_id":"dd67d43a22ccaa4d38600ded2dc39f92d30f7f36"}],"manilaclient/tests/functional/base.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2c1ae69ffea8d9425f71e8f44c76b239f03b8f2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027microversion\u0027: microversion,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        share_network \u003d share_network or client.share_network"},{"line_number":230,"context_line":"        share_type \u003d share_type or CONF.share_type"},{"line_number":231,"context_line":"        if share_network:"},{"line_number":232,"context_line":"            data[\u0027share_network\u0027] \u003d share_network"},{"line_number":233,"context_line":"        if share_type:"}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_2e83e805","side":"PARENT","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":50},"updated":"2016-03-28 03:45:02.000000000","message":"Why need to remove this line?","commit_id":"b1274edefe55dd52280a42a23a2055053766f0ff"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"315861c54bb57e764720c8c67fcd552924ff7234","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            \u0027microversion\u0027: microversion,"},{"line_number":228,"context_line":"        }"},{"line_number":229,"context_line":"        share_network \u003d share_network or client.share_network"},{"line_number":230,"context_line":"        share_type \u003d share_type or CONF.share_type"},{"line_number":231,"context_line":"        if share_network:"},{"line_number":232,"context_line":"            data[\u0027share_network\u0027] \u003d share_network"},{"line_number":233,"context_line":"        if share_type:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_3f3e1dda","side":"PARENT","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":50},"in_reply_to":"da0c15f0_2e83e805","updated":"2016-03-31 13:15:54.000000000","message":"Done","commit_id":"b1274edefe55dd52280a42a23a2055053766f0ff"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2c1ae69ffea8d9425f71e8f44c76b239f03b8f2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                         \"environment or update your \""},{"line_number":141,"context_line":"                                         \" clouds.yaml and check again\")"},{"line_number":142,"context_line":"        auth_info \u003d cloud_config.config[\u0027auth\u0027]"},{"line_number":143,"context_line":"        user \u003d auth_info[\u0027username\u0027]"},{"line_number":144,"context_line":"        passwd \u003d auth_info[\u0027password\u0027]"},{"line_number":145,"context_line":"        tenant \u003d auth_info[\u0027project_name\u0027]"},{"line_number":146,"context_line":"        auth_url \u003d auth_info[\u0027auth_url\u0027]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":149,"context_line":"            insecure\u003dCONF.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_2e100801","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":40},"updated":"2016-03-28 03:45:02.000000000","message":"This parameter only used once, you could just remove it and   direct assignment，  \"username\u003dauth_info[\u0027username\u0027]\".","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"315861c54bb57e764720c8c67fcd552924ff7234","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                                         \"environment or update your \""},{"line_number":141,"context_line":"                                         \" clouds.yaml and check again\")"},{"line_number":142,"context_line":"        auth_info \u003d cloud_config.config[\u0027auth\u0027]"},{"line_number":143,"context_line":"        user \u003d auth_info[\u0027username\u0027]"},{"line_number":144,"context_line":"        passwd \u003d auth_info[\u0027password\u0027]"},{"line_number":145,"context_line":"        tenant \u003d auth_info[\u0027project_name\u0027]"},{"line_number":146,"context_line":"        auth_url \u003d auth_info[\u0027auth_url\u0027]"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":149,"context_line":"            insecure\u003dCONF.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_1f4cf99c","line":146,"range":{"start_line":143,"start_character":8,"end_line":146,"end_character":40},"in_reply_to":"da0c15f0_2e100801","updated":"2016-03-31 13:15:54.000000000","message":"Done","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2c1ae69ffea8d9425f71e8f44c76b239f03b8f2","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                         \"environment or update your \""},{"line_number":174,"context_line":"                                         \"clouds.yaml and check again\")"},{"line_number":175,"context_line":"        auth_info \u003d cloud_config.config[\u0027auth\u0027]"},{"line_number":176,"context_line":"        user \u003d auth_info[\u0027username\u0027]"},{"line_number":177,"context_line":"        passwd \u003d auth_info[\u0027password\u0027]"},{"line_number":178,"context_line":"        tenant \u003d auth_info[\u0027project_name\u0027]"},{"line_number":179,"context_line":"        auth_url \u003d auth_info[\u0027auth_url\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":182,"context_line":"            insecure\u003dCONF.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_8e9b1472","line":179,"range":{"start_line":176,"start_character":7,"end_line":179,"end_character":40},"updated":"2016-03-28 03:45:02.000000000","message":"above","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"315861c54bb57e764720c8c67fcd552924ff7234","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                         \"environment or update your \""},{"line_number":174,"context_line":"                                         \"clouds.yaml and check again\")"},{"line_number":175,"context_line":"        auth_info \u003d cloud_config.config[\u0027auth\u0027]"},{"line_number":176,"context_line":"        user \u003d auth_info[\u0027username\u0027]"},{"line_number":177,"context_line":"        passwd \u003d auth_info[\u0027password\u0027]"},{"line_number":178,"context_line":"        tenant \u003d auth_info[\u0027project_name\u0027]"},{"line_number":179,"context_line":"        auth_url \u003d auth_info[\u0027auth_url\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":182,"context_line":"            insecure\u003dCONF.insecure,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_7f5d3546","line":179,"range":{"start_line":176,"start_character":7,"end_line":179,"end_character":40},"in_reply_to":"da0c15f0_8e9b1472","updated":"2016-03-31 13:15:54.000000000","message":"Done","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2c1ae69ffea8d9425f71e8f44c76b239f03b8f2","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":182,"context_line":"            insecure\u003dCONF.insecure,"},{"line_number":183,"context_line":"            cli_dir\u003dCONF.manila_exec_dir)"},{"line_number":184,"context_line":"        # Set specific for user project share network"},{"line_number":185,"context_line":"            username\u003duser,"},{"line_number":186,"context_line":"            password\u003dpasswd,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_0e0d4437","line":183,"range":{"start_line":183,"start_character":40,"end_line":183,"end_character":41},"updated":"2016-03-28 03:45:02.000000000","message":"Redundant parentheses","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"315861c54bb57e764720c8c67fcd552924ff7234","unresolved":false,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":182,"context_line":"            insecure\u003dCONF.insecure,"},{"line_number":183,"context_line":"            cli_dir\u003dCONF.manila_exec_dir)"},{"line_number":184,"context_line":"        # Set specific for user project share network"},{"line_number":185,"context_line":"            username\u003duser,"},{"line_number":186,"context_line":"            password\u003dpasswd,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_df560129","line":183,"range":{"start_line":183,"start_character":40,"end_line":183,"end_character":41},"in_reply_to":"da0c15f0_0e0d4437","updated":"2016-03-31 13:15:54.000000000","message":"Done","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2c1ae69ffea8d9425f71e8f44c76b239f03b8f2","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":182,"context_line":"            insecure\u003dCONF.insecure,"},{"line_number":183,"context_line":"            cli_dir\u003dCONF.manila_exec_dir)"},{"line_number":184,"context_line":"        # Set specific for user project share network"},{"line_number":185,"context_line":"            username\u003duser,"},{"line_number":186,"context_line":"            password\u003dpasswd,"},{"line_number":187,"context_line":"            tenant_name\u003dtenant,"}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_4e78dc2b","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":53},"updated":"2016-03-28 03:45:02.000000000","message":"Move to code line 190.","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"315861c54bb57e764720c8c67fcd552924ff7234","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        manilaclient \u003d client.ManilaCLIClient("},{"line_number":182,"context_line":"            insecure\u003dCONF.insecure,"},{"line_number":183,"context_line":"            cli_dir\u003dCONF.manila_exec_dir)"},{"line_number":184,"context_line":"        # Set specific for user project share network"},{"line_number":185,"context_line":"            username\u003duser,"},{"line_number":186,"context_line":"            password\u003dpasswd,"},{"line_number":187,"context_line":"            tenant_name\u003dtenant,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_bf534d38","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":53},"in_reply_to":"da0c15f0_4e78dc2b","updated":"2016-03-31 13:15:54.000000000","message":"Done","commit_id":"a6d0a4d421c376425cb693e23199514e96c95dbd"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa8880c00c1732b28608897172d35b9d989bbdd0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manilaclient.tests.functional import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class handle_cleanup_exceptions(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_86054b12","line":29,"updated":"2016-03-31 20:35:51.000000000","message":"why change the order of these two lines?","commit_id":"323f0fe2a61d1ac06f641acd34de4970a1cb0dd5"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"e8fb9a2e03478a10e13e9ae92228f9ede76fa34c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manilaclient.tests.functional import utils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":29,"context_line":"CONF \u003d config.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class handle_cleanup_exceptions(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_ce8c6adc","line":29,"in_reply_to":"ba0121b8_86054b12","updated":"2016-04-12 10:01:20.000000000","message":"No Particular Reason. It got interchanged in the effort to completely eliminate use of manilaclient.conf file. Will fix it in the next patch. Thanks.","commit_id":"323f0fe2a61d1ac06f641acd34de4970a1cb0dd5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa8880c00c1732b28608897172d35b9d989bbdd0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            raise NoCloudConfigException(\"Cloud not find a suitable cloud for \""},{"line_number":139,"context_line":"                                         \"functional tests. Please check your \""},{"line_number":140,"context_line":"                                         \"environment or update your \""},{"line_number":141,"context_line":"                                         \" clouds.yaml and check again\")"},{"line_number":142,"context_line":"        auth_info \u003d cloud_config.config[\u0027auth\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        manilaclient \u003d client.ManilaCLIClient("}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_81bc15bc","line":141,"updated":"2016-03-31 20:35:51.000000000","message":"If I just run \u0027tox -efunctional\u0027 in python-novaclient without making any effort to get \u0027username\u0027, \u0027password\u0027, \u0027tenant_name\u0027 set, I hit this exception, which at least points me in the right direction.  If I do the same ini python-manilaclient with your patch, the exception is *not* hit.  Instead the code runs on to get a more mysterious KeyError when setting \u0027username\u0027 a few lines down.","commit_id":"323f0fe2a61d1ac06f641acd34de4970a1cb0dd5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a533e59b50c4b8ef9e2448f0a92a0be448ec6bc8","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            try:"},{"line_number":128,"context_line":"                cloud_config \u003d cls.openstack_config.get_one_cloud("},{"line_number":129,"context_line":"                    \u0027devstack\u0027,"},{"line_number":130,"context_line":"                    auth\u003ddict(username\u003d\u0027admin\u0027, project_name\u003d\u0027admin\u0027))"},{"line_number":131,"context_line":"            except os_client_config.exceptions.OpenStackConfigException:"},{"line_number":132,"context_line":"                try:"},{"line_number":133,"context_line":"                    cloud_config \u003d cls.openstack_config.get_one_cloud("}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_588155c2","line":130,"range":{"start_line":130,"start_character":25,"end_line":130,"end_character":69},"updated":"2016-05-17 14:14:59.000000000","message":"These were configurable before and not are not.","commit_id":"dd67d43a22ccaa4d38600ded2dc39f92d30f7f36"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a533e59b50c4b8ef9e2448f0a92a0be448ec6bc8","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        try:"},{"line_number":157,"context_line":"            cloud_config \u003d cls.openstack_config.get_one_cloud("},{"line_number":158,"context_line":"                \u0027devstack\u0027,"},{"line_number":159,"context_line":"                auth\u003ddict(admin_user\u003d\u0027manila\u0027,"},{"line_number":160,"context_line":"                          admin_tenant_name\u003d\u0027service\u0027))"},{"line_number":161,"context_line":"        except os_client_config.exceptions.OpenStackConfigException:"},{"line_number":162,"context_line":"            try:"},{"line_number":163,"context_line":"                cloud_config \u003d cls.openstack_config.get_one_cloud(\u0027envvars\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_58cf9528","line":160,"range":{"start_line":159,"start_character":26,"end_line":160,"end_character":55},"updated":"2016-05-17 14:14:59.000000000","message":"Same here. Operator should be able to change creds.","commit_id":"dd67d43a22ccaa4d38600ded2dc39f92d30f7f36"}],"tox.ini":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"aa8880c00c1732b28608897172d35b9d989bbdd0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  OS_TEST_TIMEOUT \u003d 500"},{"line_number":46,"context_line":"  OS_MANILA_EXEC_DIR \u003d {envdir}/bin"},{"line_number":47,"context_line":"  USE_SHARE_NETWORK\u003dTrue"},{"line_number":48,"context_line":"  JOB_NAME\u003dneutron"},{"line_number":49,"context_line":"commands \u003d"},{"line_number":50,"context_line":"  {envdir}/bin/python setup.py install"},{"line_number":51,"context_line":"  {envdir}/bin/python setup.py testr --testr-args\u003d\u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":11,"id":"ba0121b8_81d9b559","line":48,"updated":"2016-03-31 20:35:51.000000000","message":"Pardon what may be a dumb question, but I don\u0027t see what enabling neutron networking rather than nova, and using a share network, when the functional tests are run has to do with the changes you describe in your commit message.","commit_id":"323f0fe2a61d1ac06f641acd34de4970a1cb0dd5"},{"author":{"_account_id":9285,"name":"Madhu Mohan","email":"mmnelemane@suse.com","username":"snmohan83"},"change_message_id":"e8fb9a2e03478a10e13e9ae92228f9ede76fa34c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  OS_TEST_TIMEOUT \u003d 500"},{"line_number":46,"context_line":"  OS_MANILA_EXEC_DIR \u003d {envdir}/bin"},{"line_number":47,"context_line":"  USE_SHARE_NETWORK\u003dTrue"},{"line_number":48,"context_line":"  JOB_NAME\u003dneutron"},{"line_number":49,"context_line":"commands \u003d"},{"line_number":50,"context_line":"  {envdir}/bin/python setup.py install"},{"line_number":51,"context_line":"  {envdir}/bin/python setup.py testr --testr-args\u003d\u0027{posargs}\u0027"}],"source_content_type":"text/x-properties","patch_set":11,"id":"ba0121b8_4e34dafa","line":48,"in_reply_to":"ba0121b8_81d9b559","updated":"2016-04-12 10:01:20.000000000","message":"Thats right. This change came up in an effort to completely eliminate the need for manilaclient.conf so that the tests can be run without one. However, I realized that would be a much bigger change and probably even deserves a spec and therefore I restricted my changes to just the authentication part. I will remove this in the next patch. Hope that would pass the Jenkins test.","commit_id":"323f0fe2a61d1ac06f641acd34de4970a1cb0dd5"}]}