)]}'
{"id":"openstack%2Fpython-manilaclient~269015","triplet_id":"openstack%2Fpython-manilaclient~master~Ifd43c6d226487d2b1c4ec099096595373725e596","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1535284","hashtags":[],"change_id":"Ifd43c6d226487d2b1c4ec099096595373725e596","subject":"Add uppercase env var names for consistency","status":"MERGED","created":"2016-01-18 12:13:22.000000000","updated":"2016-01-21 14:34:03.000000000","submitted":"2016-01-21 14:34:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a24d1fa5a7690656a103c10258c5e8250e698ab8","_number":269015,"virtual_id_number":269015,"owner":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":2,"date":"2016-01-21 14:34:03.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"all":[{"value":2,"date":"2016-01-21 10:44:42.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-20 19:18:14.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":1,"date":"2016-01-18 20:14:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":1,"date":"2016-01-18 12:39:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"all":[{"value":0,"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"value":0,"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},{"value":0,"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"value":1,"date":"2016-01-21 13:44:56.000000000","_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-18 12:28:17.000000000","updated_by":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"reviewer":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"state":"REVIEWER"},{"updated":"2016-01-18 12:39:02.000000000","updated_by":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"reviewer":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"state":"REVIEWER"},{"updated":"2016-01-18 20:14:57.000000000","updated_by":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"reviewer":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"state":"REVIEWER"},{"updated":"2016-01-20 19:18:14.000000000","updated_by":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"reviewer":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"state":"REVIEWER"},{"updated":"2016-01-21 10:44:42.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2016-01-21 14:34:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"30366b60f259185093d9930859b5394f89f98500","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2016-01-18 12:13:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"12a90bc708e731ca116f09483f60e8b2387466d3","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2016-01-18 12:28:15.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"1f30b0739092d13c237d11051edf4e5923c6bcc6","author":{"_account_id":4460,"name":"Vincent Untz","email":"vuntz@opensuse.org","username":"vuntz"},"date":"2016-01-18 12:28:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4e3f86c92cfbac6598608e7ecfbd27a708dec2f0","author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"date":"2016-01-18 12:39:02.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d478ab35ac9a23415e14ba5db1edb441d4ba9a79","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-18 13:10:16.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/15/269015/2/check/gate-python-manilaclient-pep8/d9a8c70/ : SUCCESS in 1m 13s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/15/269015/2/check/gate-python-manilaclient-docs/b6cc6d9//doc/build/html/ : SUCCESS in 51s\n- gate-python-manilaclient-python27 http://logs.openstack.org/15/269015/2/check/gate-python-manilaclient-python27/d0bd128/ : SUCCESS in 2m 34s\n- gate-python-manilaclient-python34 http://logs.openstack.org/15/269015/2/check/gate-python-manilaclient-python34/fe701ee/ : SUCCESS in 3m 20s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/15/269015/2/check/gate-manilaclient-dsvm-neutron-functional/b465436/ : SUCCESS in 38m 01s","accounts_in_message":[],"_revision_number":2},{"id":"887362355b11b0657e8c71a525110d3a1265aade","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2016-01-18 20:14:57.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM.\n\nHave you given thought to whether the mixed case env var names should be deprecated?","accounts_in_message":[],"_revision_number":2},{"id":"a3943de11cf4f36f7f2409627915b4c7d0687086","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2016-01-20 19:18:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"7be8143a50fbbe816e21e8325f08c3a39891e3b9","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2016-01-21 08:08:51.000000000","message":"Patch Set 2:\n\n\u003e LGTM.\n \u003e \n \u003e Have you given thought to whether the mixed case env var names\n \u003e should be deprecated?\n\nHm. No. Should I mention it in the helptext? Or is there any more formal way to deprecate env vars?","accounts_in_message":[],"_revision_number":2},{"id":"dc6875b58dda85c5e09db9525139bc52cc698964","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-01-21 10:44:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"630e74d3b89c15bec7f3efc4fc6ccb5ce1856717","author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"date":"2016-01-21 11:38:13.000000000","message":"Patch Set 2:\n\nI know the more formal way to deprecate config options, but not env vars.  I suppose one could LOG that they are deprecated, mention in help text, and remove support in N.\n\nNothing to hold this one up for, but if someone knows the answer I\u0027d be interested.","accounts_in_message":[],"_revision_number":2},{"id":"5d20beb441425a4e58010be45d09a2483f1e8d2c","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2016-01-21 13:44:56.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9a5002c566c932112988cb3ca060937d3ac2362a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 13:45:02.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"81b51e7db92f2e1f06191d8385ae62f551b41900","date":"2016-01-21 14:34:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"cf7974d644cc33d10dc6bc8dd912d00796ca2e57","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 14:34:03.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/15/269015/2/gate/gate-python-manilaclient-docs/104393a//doc/build/html/ : SUCCESS in 1m 08s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/15/269015/2/gate/gate-python-manilaclient-pep8/aefc26b/ : SUCCESS in 1m 07s\n- gate-python-manilaclient-python27 http://logs.openstack.org/15/269015/2/gate/gate-python-manilaclient-python27/c32eaf7/ : SUCCESS in 2m 36s\n- gate-python-manilaclient-python34 http://logs.openstack.org/15/269015/2/gate/gate-python-manilaclient-python34/d494dfa/ : SUCCESS in 2m 34s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/15/269015/2/gate/gate-manilaclient-dsvm-neutron-functional/422ffcb/ : SUCCESS in 48m 40s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9a362ff188e8f4b116404ad0484be544a99f3272","revisions":{"62fec5346d1f2a742408702ad58f406b0a63d463":{"kind":"REWORK","_number":1,"created":"2016-01-18 12:13:22.000000000","uploader":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"ref":"refs/changes/15/269015/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/15/269015/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/1"}}},"commit":{"parents":[{"commit":"37dc7e8ebdbf90c55eabf630b73d7c2da6dc3644","subject":"Merge \"Fix the \"OpenStack CLI guide\" link\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/37dc7e8ebdbf90c55eabf630b73d7c2da6dc3644"}]}],"author":{"name":"Thomas Bechtold","email":"tbechtold@suse.com","date":"2016-01-18 12:10:11.000000000","tz":60},"committer":{"name":"Thomas Bechtold","email":"tbechtold@suse.com","date":"2016-01-18 12:10:11.000000000","tz":60},"subject":"Add uppercase env var names for consistency","message":"Add uppercase env var names for consistency\n\nSome env var names (the vars starting with manilaclient_) are mixing\nlower and uppercase. To be consistent with the other env vars (and\nalso with env vars from other openstack client projects), add also\nthe only-upper-case var names. Newly added env variables are:\n\n- MANILACLIENT_UUID_CACHE_DIR\n- MANILACLIENT_DEBUG\n- MANILACLIENT_INSECURE\n\nChange-Id: Ifd43c6d226487d2b1c4ec099096595373725e596\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/62fec5346d1f2a742408702ad58f406b0a63d463"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/62fec5346d1f2a742408702ad58f406b0a63d463"}]},"branch":"refs/heads/master"},"9a362ff188e8f4b116404ad0484be544a99f3272":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-01-18 12:28:15.000000000","uploader":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"ref":"refs/changes/15/269015/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/15/269015/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/15/269015/2"}}},"commit":{"parents":[{"commit":"37dc7e8ebdbf90c55eabf630b73d7c2da6dc3644","subject":"Merge \"Fix the \"OpenStack CLI guide\" link\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/37dc7e8ebdbf90c55eabf630b73d7c2da6dc3644"}]}],"author":{"name":"Thomas Bechtold","email":"tbechtold@suse.com","date":"2016-01-18 12:10:11.000000000","tz":60},"committer":{"name":"Thomas Bechtold","email":"tbechtold@suse.com","date":"2016-01-18 12:27:46.000000000","tz":60},"subject":"Add uppercase env var names for consistency","message":"Add uppercase env var names for consistency\n\nSome env var names (the vars starting with manilaclient_) are mixing\nlower and uppercase. To be consistent with the other env vars (and\nalso with env vars from other openstack client projects), add also\nthe only-upper-case var names. Newly added env variables are:\n\n- MANILACLIENT_UUID_CACHE_DIR\n- MANILACLIENT_DEBUG\n- MANILACLIENT_INSECURE\n\nCloses-bug: #1535284\nChange-Id: Ifd43c6d226487d2b1c4ec099096595373725e596\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9a362ff188e8f4b116404ad0484be544a99f3272"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9a362ff188e8f4b116404ad0484be544a99f3272"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}