)]}'
{"id":"openstack%2Fpython-manilaclient~269603","triplet_id":"openstack%2Fpython-manilaclient~master~I24835745d028fa50252207cb02304e73657696e5","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1535692","hashtags":[],"change_id":"I24835745d028fa50252207cb02304e73657696e5","subject":"Fix backwards compatibility for v1 API imports","status":"MERGED","created":"2016-01-19 12:41:41.000000000","updated":"2016-01-20 23:23:21.000000000","submitted":"2016-01-20 23:23:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fe8a19fa08c577ff34afe60268e9a1fbc522737e","_number":269603,"virtual_id_number":269603,"owner":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":2,"date":"2016-01-20 23:23:20.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},{"value":0,"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"all":[{"value":2,"date":"2016-01-20 18:49:42.000000000","_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-19 23:25:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},{"value":2,"date":"2016-01-20 22:30:27.000000000","_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":2,"date":"2016-01-20 17:45:18.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"all":[{"value":0,"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},{"value":1,"date":"2016-01-20 22:30:27.000000000","_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"date":"2016-01-19 13:51:42.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"value":0,"date":"2016-01-19 13:51:33.000000000","_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-19 13:51:33.000000000","updated_by":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"reviewer":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"state":"REVIEWER"},{"updated":"2016-01-19 13:51:42.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2016-01-19 23:25:54.000000000","updated_by":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"reviewer":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"state":"REVIEWER"},{"updated":"2016-01-20 17:45:18.000000000","updated_by":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"reviewer":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"state":"REVIEWER"},{"updated":"2016-01-20 18:49:42.000000000","updated_by":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"reviewer":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"state":"REVIEWER"},{"updated":"2016-01-20 22:30:27.000000000","updated_by":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"reviewer":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"state":"REVIEWER"},{"updated":"2016-01-20 23:23:20.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3fda5748c646640064236ac4a3b017a25de79755","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-01-19 12:41:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2927f0d392c06c70e39c5ddde89e9b159e8c395a","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-01-19 12:42:09.000000000","message":"Topic set to bug/1535692","accounts_in_message":[],"_revision_number":1},{"id":"c8daa47bad44ea5ad704d9925e8ad90b1e0e2c78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-19 13:41:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/03/269603/1/check/gate-python-manilaclient-pep8/ff0550a/ : SUCCESS in 1m 13s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/03/269603/1/check/gate-python-manilaclient-docs/f6604b0//doc/build/html/ : SUCCESS in 1m 12s\n- gate-python-manilaclient-python27 http://logs.openstack.org/03/269603/1/check/gate-python-manilaclient-python27/49ffd9b/ : SUCCESS in 2m 41s\n- gate-python-manilaclient-python34 http://logs.openstack.org/03/269603/1/check/gate-python-manilaclient-python34/f03cbd3/ : SUCCESS in 4m 43s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/03/269603/1/check/gate-manilaclient-dsvm-neutron-functional/b49c04e/ : SUCCESS in 38m 33s","accounts_in_message":[],"_revision_number":1},{"id":"2fab0b921fa77788c1307794c42a4690b1e86540","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-01-19 13:53:28.000000000","message":"Patch Set 1:\n\nWe should make new release 1.6.1 with this fix.","accounts_in_message":[],"_revision_number":1},{"id":"0750a26e748f3854f819e86bb15d890fa8c7bd50","author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"date":"2016-01-19 17:51:04.000000000","message":"Patch Set 1:\n\nWhy \"assert False\" instead of self.assertFalse(  ?","accounts_in_message":[],"_revision_number":1},{"id":"e872c0425653ab1cd7d1972cae0868aa99aaf6d2","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-01-19 17:55:58.000000000","message":"Patch Set 1:\n\nMark, why not common \"assert\"? We need just to fail test, not perform real assertion, so, using common one.","accounts_in_message":[],"_revision_number":1},{"id":"5d4808c580cce26027424f9963e827582ae06a10","author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"date":"2016-01-19 23:25:54.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nTested the change and it appears good to me. Sorry I didn\u0027t catch this when the original patch was made. Added a comment regarding reducing code duplication with this patch.","accounts_in_message":[],"_revision_number":1},{"id":"2c173c1a770affe077d7ffdeb73b6725b9df7087","author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"date":"2016-01-20 17:45:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"f7a691700ddf687c8092a0acd25b26929acd0b26","author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"date":"2016-01-20 18:49:42.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d8dadba88f20e9bb66c5f6232ee7d224673fcce3","author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"date":"2016-01-20 22:30:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bcd6c25983548bba4772a05658551a9c97db09c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-20 22:30:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ababb89f9a42a23cbf3f05707f7057f4ef8c9e27","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-20 23:23:20.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/03/269603/1/gate/gate-python-manilaclient-docs/af702a2//doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/03/269603/1/gate/gate-python-manilaclient-pep8/fea7e65/ : SUCCESS in 1m 11s\n- gate-python-manilaclient-python27 http://logs.openstack.org/03/269603/1/gate/gate-python-manilaclient-python27/10cba22/ : SUCCESS in 2m 33s\n- gate-python-manilaclient-python34 http://logs.openstack.org/03/269603/1/gate/gate-python-manilaclient-python34/b192136/ : SUCCESS in 3m 07s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/03/269603/1/gate/gate-manilaclient-dsvm-neutron-functional/19cfd94/ : SUCCESS in 52m 24s","accounts_in_message":[],"_revision_number":1},{"id":"fe8a19fa08c577ff34afe60268e9a1fbc522737e","date":"2016-01-20 23:23:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e2b825cc69e3fe364387604a51938c6f6dd3186c","revisions":{"e2b825cc69e3fe364387604a51938c6f6dd3186c":{"kind":"REWORK","_number":1,"created":"2016-01-19 12:41:41.000000000","uploader":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"ref":"refs/changes/03/269603/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/03/269603/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/03/269603/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/03/269603/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/03/269603/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/03/269603/1"}}},"commit":{"parents":[{"commit":"37dc7e8ebdbf90c55eabf630b73d7c2da6dc3644","subject":"Merge \"Fix the \"OpenStack CLI guide\" link\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/37dc7e8ebdbf90c55eabf630b73d7c2da6dc3644"}]}],"author":{"name":"vponomaryov","email":"vponomaryov@mirantis.com","date":"2016-01-19 12:21:23.000000000","tz":120},"committer":{"name":"vponomaryov","email":"vponomaryov@mirantis.com","date":"2016-01-19 12:41:08.000000000","tz":120},"subject":"Fix backwards compatibility for v1 API imports","message":"Fix backwards compatibility for v1 API imports\n\nAll python modules in \"manilaclient/v1\" override v2 modules with v2 modules\nand v1 modules do not provide APIs at all. So, fix those imports and add\ntest coverage.\n\nChange-Id: I24835745d028fa50252207cb02304e73657696e5\nCloses-Bug: #1535692\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e2b825cc69e3fe364387604a51938c6f6dd3186c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/e2b825cc69e3fe364387604a51938c6f6dd3186c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}