)]}'
{"manilaclient/config.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dbad9dc79c32a3f63166516a32f8a81fb031db8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":113,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":114,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\""},{"line_number":115,"context_line":"                     \"Allowed share protocols: nfs, cifs, cephfs, glusterfs,  \""},{"line_number":116,"context_line":"                     \"hdfs.\"),"},{"line_number":117,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":118,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_af402108","line":115,"range":{"start_line":115,"start_character":77,"end_line":115,"end_character":78},"updated":"2016-03-03 18:18:38.000000000","message":"extra space","commit_id":"387a18ac02c6b616f58c16acf3198bb1a5787c64"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"a9662fe348aeaa973ecb05b2bc30908fdaad9853","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                help\u003d\"Dict contains access types mapping to share \""},{"line_number":113,"context_line":"                     \"protocol. It will be used to create access rules \""},{"line_number":114,"context_line":"                     \"for shares. Format: \u0027\u003cprotocol\u003e: \u003ctype1\u003e \u003ctype2\u003e\u0027,...\""},{"line_number":115,"context_line":"                     \"Allowed share protocols: nfs, cifs, cephfs, glusterfs,  \""},{"line_number":116,"context_line":"                     \"hdfs.\"),"},{"line_number":117,"context_line":"    cfg.DictOpt(\u0027access_levels_mapping\u0027,"},{"line_number":118,"context_line":"                default\u003d{\u0027nfs\u0027: \u0027rw ro\u0027, \u0027cifs\u0027: \u0027rw\u0027},"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_3ae73141","line":115,"range":{"start_line":115,"start_character":77,"end_line":115,"end_character":78},"in_reply_to":"7af24918_af402108","updated":"2016-03-03 18:31:33.000000000","message":"Done","commit_id":"387a18ac02c6b616f58c16acf3198bb1a5787c64"}],"manilaclient/tests/unit/test_shell.py":[{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"5667813a0363f90310f6de11eb9f4a379b1a778e","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_help_unknown_command(self):"},{"line_number":133,"context_line":"        self.assertRaises(exceptions.CommandError, self.shell, \u0027help foofoo\u0027)"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def test_help_on_subcommand(self):"},{"line_number":136,"context_line":"        required \u003d ["},{"line_number":137,"context_line":"            \u0027.*?^usage: manila list\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7af24918_2d4416b5","line":134,"updated":"2016-03-03 19:58:41.000000000","message":"I think the idea with test_help is not to match a lot of text, but still to verify that \u0027help\u0027 seems to work. I\u0027d suggest leaving some easy matches in and taking the the details that are more likely to change.","commit_id":"6bad71c9e6990b555a1b629e87b9b0afdf997e0f"}],"manilaclient/tests/unit/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a81e9e8a04a30629084872b489e5d1daedba7b47","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @ddt.data(\"alice\", \"alice_bob\", \"alice bob\")"},{"line_number":44,"context_line":"    def test_share_allow_access_cephx_valid(self, cephx_id):"},{"line_number":45,"context_line":"        self.share.allow(\u0027cephx\u0027, cephx_id, None)"},{"line_number":46,"context_line":"        self.assertTrue(self.share.manager.allow.called)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @ddt.data(\u0027\u0027, \u0027client.manila\u0027)"},{"line_number":49,"context_line":"    def test_share_allow_access_cephx_invalid(self, cephx_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_5e5eb876","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":56},"updated":"2016-03-02 21:02:42.000000000","message":"could you assert called with rather, because you have a new body..","commit_id":"2b3e2497c9aa5d41c7e7f6a6d4290adec98e97c2"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"f215e60056c993391fbe611f354a2f8407393d3b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @ddt.data(\"alice\", \"alice_bob\", \"alice bob\")"},{"line_number":44,"context_line":"    def test_share_allow_access_cephx_valid(self, cephx_id):"},{"line_number":45,"context_line":"        self.share.allow(\u0027cephx\u0027, cephx_id, None)"},{"line_number":46,"context_line":"        self.assertTrue(self.share.manager.allow.called)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @ddt.data(\u0027\u0027, \u0027client.manila\u0027)"},{"line_number":49,"context_line":"    def test_share_allow_access_cephx_invalid(self, cephx_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_2ce7ff40","line":46,"range":{"start_line":46,"start_character":19,"end_line":46,"end_character":56},"in_reply_to":"7af24918_5e5eb876","updated":"2016-03-03 17:59:31.000000000","message":"Done","commit_id":"2b3e2497c9aa5d41c7e7f6a6d4290adec98e97c2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @ddt.data(\"alice\", \"alice_bob\", \"alice bob\")"},{"line_number":44,"context_line":"    def test_share_allow_access_cephx_valid(self, cephx_id):"},{"line_number":45,"context_line":"        self.share.allow(\u0027cephx\u0027, cephx_id, None)"},{"line_number":46,"context_line":"        self.assertTrue(self.share.manager.allow.called)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @ddt.data(\u0027\u0027, \u0027client.manila\u0027)"},{"line_number":49,"context_line":"    def test_share_allow_access_cephx_invalid(self, cephx_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_43606d01","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":56},"updated":"2016-03-03 13:51:32.000000000","message":"It would be great to address Goutham\u0027s comment from PS 4.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"25302bbccb5e195e18e29894a4402572bb2c836f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertFalse(self.share.manager.allow.called)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # TODO(rraja): With py34, unable to run a unit test with a non-ascii test"},{"line_number":57,"context_line":"    # data using ddt. Seperate this test for now, and find a better solution"},{"line_number":58,"context_line":"    # later."},{"line_number":59,"context_line":"    def test_share_allow_access_cephx_invalid_with_non_ascii(self):"},{"line_number":60,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_0f9af56d","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":26},"updated":"2016-03-03 18:21:16.000000000","message":"s/Seperate/Separate/","commit_id":"387a18ac02c6b616f58c16acf3198bb1a5787c64"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"a9662fe348aeaa973ecb05b2bc30908fdaad9853","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertFalse(self.share.manager.allow.called)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # TODO(rraja): With py34, unable to run a unit test with a non-ascii test"},{"line_number":57,"context_line":"    # data using ddt. Seperate this test for now, and find a better solution"},{"line_number":58,"context_line":"    # later."},{"line_number":59,"context_line":"    def test_share_allow_access_cephx_invalid_with_non_ascii(self):"},{"line_number":60,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_5ad67d4f","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":26},"in_reply_to":"7af24918_0f9af56d","updated":"2016-03-03 18:31:33.000000000","message":"Done","commit_id":"387a18ac02c6b616f58c16acf3198bb1a5787c64"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"798fcad928b196640939c14a552d16a3a5743262","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self._validate_cephx_id(access.strip())"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            raise exceptions.CommandError("},{"line_number":86,"context_line":"                \u0027Only ip, user, and cert types are supported\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def update_all_metadata(self, metadata):"},{"line_number":89,"context_line":"        \"\"\"Update all metadata of this share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_c1e04bcf","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":40},"updated":"2016-03-02 13:32:05.000000000","message":"update this too?","commit_id":"67b74335320f5f990f4135f0ffe954a822d330c5"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fbe3d710cb903e58c96db08a0280f9559ab7ccc7","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            self._validate_cephx_id(access.strip())"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            raise exceptions.CommandError("},{"line_number":86,"context_line":"                \u0027Only ip, user, and cert types are supported\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def update_all_metadata(self, metadata):"},{"line_number":89,"context_line":"        \"\"\"Update all metadata of this share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_0b435e43","line":86,"range":{"start_line":86,"start_character":17,"end_line":86,"end_character":40},"in_reply_to":"7af24918_c1e04bcf","updated":"2016-03-02 17:05:53.000000000","message":"Done","commit_id":"67b74335320f5f990f4135f0ffe954a822d330c5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91bf4d0315e318b37feaeb1ea231d2b0e3a03818","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @staticmethod"},{"line_number":135,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":136,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":137,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":138,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def reset_state(self, state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_8636a450","line":137,"range":{"start_line":137,"start_character":18,"end_line":137,"end_character":41},"updated":"2016-02-04 15:38:29.000000000","message":"I don\u0027t see webob imported in this file.. This should be:\n     \n    raise exceptions.CommandError(\"my_message\")\n \nfor consistency...","commit_id":"67b74335320f5f990f4135f0ffe954a822d330c5"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d1edb221795cb84443117842c2ce17462b866b1c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @staticmethod"},{"line_number":135,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":136,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":137,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":138,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def reset_state(self, state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_ad510911","line":137,"range":{"start_line":137,"start_character":18,"end_line":137,"end_character":41},"in_reply_to":"5a5ae5dd_8636a450","updated":"2016-03-01 11:57:32.000000000","message":"And absence of unit tests coverage is not a big deal? ))","commit_id":"67b74335320f5f990f4135f0ffe954a822d330c5"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fbe3d710cb903e58c96db08a0280f9559ab7ccc7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @staticmethod"},{"line_number":135,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":136,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":137,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":138,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def reset_state(self, state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4b4d666b","line":137,"range":{"start_line":137,"start_character":18,"end_line":137,"end_character":41},"in_reply_to":"5a5ae5dd_8636a450","updated":"2016-03-02 17:05:53.000000000","message":"Done","commit_id":"67b74335320f5f990f4135f0ffe954a822d330c5"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fbe3d710cb903e58c96db08a0280f9559ab7ccc7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    @staticmethod"},{"line_number":135,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":136,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":137,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003d_("},{"line_number":138,"context_line":"                \u0027Ceph IDs may not contain periods\u0027))"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def reset_state(self, state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_6b9f82b4","line":137,"range":{"start_line":137,"start_character":18,"end_line":137,"end_character":41},"in_reply_to":"7af24918_ad510911","updated":"2016-03-02 17:05:53.000000000","message":"Will update the unit tests in patchset 3.","commit_id":"67b74335320f5f990f4135f0ffe954a822d330c5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"91e63698b6156f2cac227082862a4ec9187946ad","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def allow(self, access_type, access, access_level):"},{"line_number":59,"context_line":"        \"\"\"Allow access to a share.\"\"\""},{"line_number":60,"context_line":"        self._validate_access(access_type, access)"},{"line_number":61,"context_line":"        return self.manager.allow(self, access_type, access, access_level)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def deny(self, id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_39d14658","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":50},"updated":"2016-03-02 21:02:05.000000000","message":"Redefine \"allow\" and call a variation of self_validate_access which checks cephx. Maybe have the default validate [\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027] and the one modified supplying [\u0027ip\u0027,\u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027]","commit_id":"2b3e2497c9aa5d41c7e7f6a6d4290adec98e97c2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"91e63698b6156f2cac227082862a4ec9187946ad","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            # common name. The meaning of a string depends on its"},{"line_number":81,"context_line":"            # interpretation and is limited to 64 characters."},{"line_number":82,"context_line":"            self._validate_common_name(access.strip())"},{"line_number":83,"context_line":"        elif access_type \u003d\u003d \u0027cephx\u0027:"},{"line_number":84,"context_line":"            self._validate_cephx_id(access.strip())"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            raise exceptions.CommandError("},{"line_number":87,"context_line":"                \u0027Only ip, user, cert or cephx types are supported\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_f9919e9a","line":84,"range":{"start_line":83,"start_character":8,"end_line":84,"end_character":51},"updated":"2016-03-02 21:02:05.000000000","message":"My suggestion is to call this only if a certain parameter is passed and ceph is included, you could even have a list of types to be validated, and validate only if in the list (change this if, elif).","commit_id":"2b3e2497c9aa5d41c7e7f6a6d4290adec98e97c2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"91e63698b6156f2cac227082862a4ec9187946ad","unresolved":false,"context_lines":[{"line_number":446,"context_line":"            share, access_type, access, access_level, \"os-allow_access\")"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    @api_versions.wraps(\"2.7\")  # noqa"},{"line_number":449,"context_line":"    def allow(self, share, access_type, access, access_level):"},{"line_number":450,"context_line":"        return self._do_allow("},{"line_number":451,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_d9edc2f0","line":449,"range":{"start_line":449,"start_character":4,"end_line":449,"end_character":62},"updated":"2016-03-02 21:02:05.000000000","message":"duplicate this one with other microversion, calling the redefined method. Set this one to 2.7 to 2.12.","commit_id":"2b3e2497c9aa5d41c7e7f6a6d4290adec98e97c2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36cd22b1f326c2957f1d171ca0acb1b73c1616c5","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        return access"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _validate_access(self, access_type, access, valid_access_types\u003d()):"},{"line_number":363,"context_line":"        if access_type in valid_access_types:"},{"line_number":364,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":365,"context_line":"                self._validate_ip_range(access)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_234a8126","line":362,"range":{"start_line":362,"start_character":52,"end_line":362,"end_character":73},"updated":"2016-03-03 13:42:24.000000000","message":"def _validate_access(self, access_type, access, valid_access_types\u003dNone):\n\n\n        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027) if valid_access_types is None\n        # Rest of the method","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"901c800f25dcda8b15915c18d80f9ed11eebeb0e","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        return access"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _validate_access(self, access_type, access, valid_access_types\u003d()):"},{"line_number":363,"context_line":"        if access_type in valid_access_types:"},{"line_number":364,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":365,"context_line":"                self._validate_ip_range(access)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_698107c3","line":362,"range":{"start_line":362,"start_character":52,"end_line":362,"end_character":73},"in_reply_to":"7af24918_03102558","updated":"2016-03-03 14:55:22.000000000","message":"Here you would set version\u003dapi_version.MAX_VERSION as a parameter so that you don\u0027t need to override it if you want.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"        return access"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _validate_access(self, access_type, access, valid_access_types\u003d()):"},{"line_number":363,"context_line":"        if access_type in valid_access_types:"},{"line_number":364,"context_line":"            if access_type \u003d\u003d \u0027ip\u0027:"},{"line_number":365,"context_line":"                self._validate_ip_range(access)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_03102558","line":362,"range":{"start_line":362,"start_character":52,"end_line":362,"end_character":73},"in_reply_to":"7af24918_234a8126","updated":"2016-03-03 13:51:32.000000000","message":"+1","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                if prefix \u003c 0 or prefix \u003e 32:"},{"line_number":409,"context_line":"                    raise ValueError()"},{"line_number":410,"context_line":"            except ValueError:"},{"line_number":411,"context_line":"                msg \u003d \u0027IP prefix should be in range from 0 to 32\u0027"},{"line_number":412,"context_line":"                raise exceptions.CommandError(msg)"},{"line_number":413,"context_line":"        ip_range \u003d ip_range[0].split(\u0027.\u0027)"},{"line_number":414,"context_line":"        if len(ip_range) !\u003d 4:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_a364d1b8","line":411,"range":{"start_line":411,"start_character":63,"end_line":411,"end_character":65},"updated":"2016-03-03 13:51:32.000000000","message":"Please add a period if you upload another patch.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    def _validate_cephx_id(cephx_id):"},{"line_number":426,"context_line":"        if not cephx_id:"},{"line_number":427,"context_line":"            raise exceptions.CommandError("},{"line_number":428,"context_line":"                \u0027Ceph IDs may not be empty\u0027)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        # This restriction may be lifted in Ceph in the future:"},{"line_number":431,"context_line":"        # http://tracker.ceph.com/issues/14626"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_838ef576","line":428,"range":{"start_line":428,"start_character":41,"end_line":428,"end_character":43},"updated":"2016-03-03 13:51:32.000000000","message":"Please add a period if you upload another patch.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        # http://tracker.ceph.com/issues/14626"},{"line_number":432,"context_line":"        if not set(cephx_id) \u003c\u003d set(string.printable):"},{"line_number":433,"context_line":"            raise exceptions.CommandError("},{"line_number":434,"context_line":"                \u0027Ceph IDs must consist of ASCII printable characters\u0027)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"        # Periods are technically permitted, but we restrict them here"},{"line_number":437,"context_line":"        # to avoid confusion where users are unsure whether they should"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c3eabd0e","line":434,"range":{"start_line":434,"start_character":67,"end_line":434,"end_character":69},"updated":"2016-03-03 13:51:32.000000000","message":"Please add a period if you upload another patch.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        # create \"client.client.foobar\"."},{"line_number":440,"context_line":"        if \u0027.\u0027 in cephx_id:"},{"line_number":441,"context_line":"            raise exceptions.CommandError("},{"line_number":442,"context_line":"                \u0027Ceph IDs may not contain periods\u0027)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"},{"line_number":445,"context_line":"    def allow(self, share, access_type, access, access_level):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_e3f539ed","line":442,"range":{"start_line":442,"start_character":48,"end_line":442,"end_character":50},"updated":"2016-03-03 13:51:32.000000000","message":"Please add a period if you upload another patch.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36cd22b1f326c2957f1d171ca0acb1b73c1616c5","unresolved":false,"context_lines":[{"line_number":450,"context_line":""},{"line_number":451,"context_line":"    @api_versions.wraps(\"2.7\", \"2.12\")  # noqa"},{"line_number":452,"context_line":"    def allow(self, share, access_type, access, access_level):"},{"line_number":453,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027)"},{"line_number":454,"context_line":"        self._validate_access(access_type, access, valid_access_types)"},{"line_number":455,"context_line":"        return self._do_allow("},{"line_number":456,"context_line":"            share, access_type, access, access_level, \"allow_access\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_030dc5e7","line":453,"range":{"start_line":453,"start_character":29,"end_line":453,"end_character":51},"updated":"2016-03-03 13:42:24.000000000","message":"Can you please make these the default in the method so we don\u0027t need to pass these here?","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"36cd22b1f326c2957f1d171ca0acb1b73c1616c5","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        return self._do_allow("},{"line_number":456,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    @api_versions.wraps(\"2.13\")  # noqa"},{"line_number":459,"context_line":"    def allow(self, share, access_type, access, access_level):"},{"line_number":460,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027)"},{"line_number":461,"context_line":"        self._validate_access(access_type, access, valid_access_types)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c3891d28","line":458,"range":{"start_line":458,"start_character":4,"end_line":458,"end_character":31},"updated":"2016-03-03 13:42:24.000000000","message":"I honestly think this overloading is not necessary for a new access type.. if we modify allow\u0027s action in any way, all further methods will have to respecify the valid_access_types.. i think it would be cleaner to do the micro version check inline... \n\n\nif micro version \u003e\u003d 2.13, then the valid access types include \u0027cephx\u0027","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5f8d7b63daa44442045e24ca1b4f1aa0f3cde24","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        return self._do_allow("},{"line_number":456,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    @api_versions.wraps(\"2.13\")  # noqa"},{"line_number":459,"context_line":"    def allow(self, share, access_type, access, access_level):"},{"line_number":460,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027)"},{"line_number":461,"context_line":"        self._validate_access(access_type, access, valid_access_types)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_8fdd73e2","line":458,"range":{"start_line":458,"start_character":4,"end_line":458,"end_character":31},"in_reply_to":"7af24918_89a29397","updated":"2016-03-03 15:16:15.000000000","message":"Ignore my comments. Looks like this is cleaner than the way i was suggesting.. please add the default value in the method though..so that you can avoid sending (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027) for the older requests.. they were always allowed.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        return self._do_allow("},{"line_number":456,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    @api_versions.wraps(\"2.13\")  # noqa"},{"line_number":459,"context_line":"    def allow(self, share, access_type, access, access_level):"},{"line_number":460,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027)"},{"line_number":461,"context_line":"        self._validate_access(access_type, access, valid_access_types)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_fe795283","line":458,"range":{"start_line":458,"start_character":4,"end_line":458,"end_character":31},"in_reply_to":"7af24918_c3891d28","updated":"2016-03-03 13:51:32.000000000","message":"that could also work, but I think this approach is cleaner. If rraja prefers to implement \"if micro ersion \u003e\u003d 2.13\" it is fine.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"901c800f25dcda8b15915c18d80f9ed11eebeb0e","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        return self._do_allow("},{"line_number":456,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"    @api_versions.wraps(\"2.13\")  # noqa"},{"line_number":459,"context_line":"    def allow(self, share, access_type, access, access_level):"},{"line_number":460,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027)"},{"line_number":461,"context_line":"        self._validate_access(access_type, access, valid_access_types)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_89a29397","line":458,"range":{"start_line":458,"start_character":4,"end_line":458,"end_character":31},"in_reply_to":"7af24918_fe795283","updated":"2016-03-03 14:55:22.000000000","message":"The way you can perform this check:\n\n\n   from manilaclient import api_versions\n\n\n\n   api_versions.APIVersion(version) \u003e\u003d api_versions.APIVersion(\u00272.13\u0027)","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4d89a33869630f51e7ee90c231b137f16903d0cc","unresolved":false,"context_lines":[{"line_number":954,"context_line":"@cliutils.arg("},{"line_number":955,"context_line":"    \u0027access_type\u0027,"},{"line_number":956,"context_line":"    metavar\u003d\u0027\u003caccess_type\u003e\u0027,"},{"line_number":957,"context_line":"    help\u003d\u0027Access rule type (only \"ip\", \"user\"(user or group), \"cert\" or  \u0027"},{"line_number":958,"context_line":"         \u0027\"cephx\" are supported).\u0027)"},{"line_number":959,"context_line":"@cliutils.arg("},{"line_number":960,"context_line":"    \u0027access_to\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_8318b51f","line":957,"range":{"start_line":957,"start_character":69,"end_line":957,"end_character":71},"updated":"2016-03-03 13:51:32.000000000","message":"I preferred \"and\". I guess this is debatable.","commit_id":"d774b057a1ee0e52eb51e3696e7d2fbd707287aa"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7dbad9dc79c32a3f63166516a32f8a81fb031db8","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    \u0027share_protocol\u0027,"},{"line_number":522,"context_line":"    metavar\u003d\u0027\u003cshare_protocol\u003e\u0027,"},{"line_number":523,"context_line":"    type\u003dstr,"},{"line_number":524,"context_line":"    help\u003d\u0027Share type (NFS, CIFS, CephFS, GlusterFS, or HDFS).\u0027)"},{"line_number":525,"context_line":"@cliutils.arg("},{"line_number":526,"context_line":"    \u0027size\u0027,"},{"line_number":527,"context_line":"    metavar\u003d\u0027\u003csize\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_cf1e4d0b","line":524,"range":{"start_line":524,"start_character":50,"end_line":524,"end_character":51},"updated":"2016-03-03 18:18:38.000000000","message":"I forget if this comma is preferred or not, but it would be nice if this and below message were consistent on that.","commit_id":"387a18ac02c6b616f58c16acf3198bb1a5787c64"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"a9662fe348aeaa973ecb05b2bc30908fdaad9853","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    \u0027share_protocol\u0027,"},{"line_number":522,"context_line":"    metavar\u003d\u0027\u003cshare_protocol\u003e\u0027,"},{"line_number":523,"context_line":"    type\u003dstr,"},{"line_number":524,"context_line":"    help\u003d\u0027Share type (NFS, CIFS, CephFS, GlusterFS, or HDFS).\u0027)"},{"line_number":525,"context_line":"@cliutils.arg("},{"line_number":526,"context_line":"    \u0027size\u0027,"},{"line_number":527,"context_line":"    metavar\u003d\u0027\u003csize\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7af24918_fac78993","line":524,"range":{"start_line":524,"start_character":50,"end_line":524,"end_character":51},"in_reply_to":"7af24918_cf1e4d0b","updated":"2016-03-03 18:31:33.000000000","message":"Done","commit_id":"387a18ac02c6b616f58c16acf3198bb1a5787c64"}]}
