)]}'
{"manilaclient/tests/functional/test_export_locations.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"7921723fb25ab60435026332c90dd19306606729","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":29,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":30,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":33,"context_line":"    def test_list_share_export_locations(self, role):"},{"line_number":34,"context_line":"        client \u003d self.admin_client if role \u003d\u003d \u0027admin\u0027 else self.user_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_53a6d853","line":31,"updated":"2016-03-02 12:28:04.000000000","message":"These tests should be microversion-based.\n\nExamples could be found here: https://github.com/openstack/python-manilaclient/blob/835482e4/manilaclient/tests/functional/test_share_types.py","commit_id":"965f36706523da5804e49abb0f1e013571ffaf48"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"40dbeaf430fae9fe2f2743863b3c8f7bba1d2a68","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":29,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":30,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":33,"context_line":"    def test_list_share_export_locations(self, role):"},{"line_number":34,"context_line":"        client \u003d self.admin_client if role \u003d\u003d \u0027admin\u0027 else self.user_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_af6eac93","line":31,"in_reply_to":"7af24918_3d081991","updated":"2016-03-02 19:14:04.000000000","message":"+1","commit_id":"965f36706523da5804e49abb0f1e013571ffaf48"},{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"bc4480b064db0d9bfc6fdf06573dbc6febcaaa7f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        cls.share \u003d cls.create_share("},{"line_number":29,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":30,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    @ddt.data(\u0027admin\u0027, \u0027user\u0027)"},{"line_number":33,"context_line":"    def test_list_share_export_locations(self, role):"},{"line_number":34,"context_line":"        client \u003d self.admin_client if role \u003d\u003d \u0027admin\u0027 else self.user_client"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_3d081991","line":31,"in_reply_to":"7af24918_53a6d853","updated":"2016-03-02 19:07:30.000000000","message":"OK, I added microversion checks.  Granted, I did this in a fairly coarse way.  I don\u0027t see much value in testing minor differences between microversions within the same Manila release from the client side.  (Different releases, or server-side testing would be a different story.)  So I\u0027m just ensuring that each test is run only if the microversion range supports the test parameters.  Some are fine with 2.9, while others require the newer 2.14.","commit_id":"965f36706523da5804e49abb0f1e013571ffaf48"}]}
