)]}'
{"id":"openstack%2Fpython-manilaclient~287436","triplet_id":"openstack%2Fpython-manilaclient~master~I28043b4d8e89909caf76a8e2e4306f0cb952c1d3","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1457155","hashtags":[],"change_id":"I28043b4d8e89909caf76a8e2e4306f0cb952c1d3","subject":"Revert usage of help text marking \"admin only\" CLIs","status":"ABANDONED","created":"2016-03-02 20:58:03.000000000","updated":"2016-03-03 15:41:55.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e1ac4cc476742b49461f042a827d0152bf93d6bf","_number":287436,"virtual_id_number":287436,"owner":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":1,"date":"2016-03-03 15:27:50.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-03-03 14:48:04.000000000","_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2016-03-03 14:38:09.000000000","_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"date":"2016-03-03 14:38:09.000000000","_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"date":"2016-03-03 14:38:09.000000000","_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"date":"2016-03-03 14:38:09.000000000","_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"date":"2016-03-03 14:38:09.000000000","_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"date":"2016-03-03 14:38:09.000000000","_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-03 04:13:48.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"},{"updated":"2016-03-03 04:13:54.000000000","updated_by":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"reviewer":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"state":"REVIEWER"},{"updated":"2016-03-03 04:14:04.000000000","updated_by":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"reviewer":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"state":"REVIEWER"},{"updated":"2016-03-03 04:14:08.000000000","updated_by":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"reviewer":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"state":"REVIEWER"},{"updated":"2016-03-03 04:14:21.000000000","updated_by":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"reviewer":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"state":"REVIEWER"},{"updated":"2016-03-03 08:14:16.000000000","updated_by":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"reviewer":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"state":"REVIEWER"},{"updated":"2016-03-03 15:27:50.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4590e24f62ea9df6ac7aee411dd63e00f2c52122","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-02 20:58:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b881305cb919da1993650cdb2798af79f590206","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-02 22:31:29.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/36/287436/1/check/gate-python-manilaclient-pep8/56e430d/ : SUCCESS in 42s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/36/287436/1/check/gate-python-manilaclient-docs/c8c0556//doc/build/html/ : SUCCESS in 51s\n- gate-python-manilaclient-python27 http://logs.openstack.org/36/287436/1/check/gate-python-manilaclient-python27/14904b7/ : SUCCESS in 2m 03s\n- gate-python-manilaclient-python34 http://logs.openstack.org/36/287436/1/check/gate-python-manilaclient-python34/564eb6b/ : SUCCESS in 2m 52s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/36/287436/1/check/gate-manilaclient-dsvm-neutron-functional/2b546fa/ : FAILURE in 41m 24s","accounts_in_message":[],"_revision_number":1},{"id":"6dbda2bb3a83222271fd67c47cedd9685aa448cd","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 02:27:10.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"e27a9474a54d52452a9066e183d9bdcf58e70c5b","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 02:31:22.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"cbfc283e8e191517c92f5918e80400cf4c94be6c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 03:40:47.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/36/287436/3/check/gate-python-manilaclient-pep8/7f9abf2/ : SUCCESS in 54s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/36/287436/3/check/gate-python-manilaclient-docs/6acd50d//doc/build/html/ : SUCCESS in 2m 38s\n- gate-python-manilaclient-python27 http://logs.openstack.org/36/287436/3/check/gate-python-manilaclient-python27/093659f/ : SUCCESS in 1m 50s\n- gate-python-manilaclient-python34 http://logs.openstack.org/36/287436/3/check/gate-python-manilaclient-python34/c7eb893/ : SUCCESS in 3m 06s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/36/287436/3/check/gate-manilaclient-dsvm-neutron-functional/2d850c8/ : SUCCESS in 49m 09s","accounts_in_message":[],"_revision_number":3},{"id":"3dc9ae4c914155f9dac93d98ed10ceda17804b29","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 05:40:02.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"50e54ddea59a792bd012a61b8637ed6337080234","author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"date":"2016-03-03 08:14:16.000000000","message":"Patch Set 3:\n\nThis was discussed with the initial patch and although we agree with your statement, the decision was that the tagging was probably better than nothing -- until we have a better solution.","accounts_in_message":[],"_revision_number":3},{"id":"77b3b982397f2d1f46ba3c57bd113d899ccc585e","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 12:51:54.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"afd066f7198762fa04b5783d79dab1b65e9019e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 13:47:28.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/36/287436/4/check/gate-python-manilaclient-pep8/ee1092f/ : SUCCESS in 39s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/36/287436/4/check/gate-python-manilaclient-docs/20a7790//doc/build/html/ : SUCCESS in 34s\n- gate-python-manilaclient-python27 http://logs.openstack.org/36/287436/4/check/gate-python-manilaclient-python27/b5a4b88/ : SUCCESS in 1m 59s\n- gate-python-manilaclient-python34 http://logs.openstack.org/36/287436/4/check/gate-python-manilaclient-python34/5e6a87b/ : SUCCESS in 2m 38s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/36/287436/4/check/gate-manilaclient-dsvm-neutron-functional/8421049/ : FAILURE in 52m 30s","accounts_in_message":[],"_revision_number":4},{"id":"49d5bf46173c262f80c239fc6e7d5c5c359b730c","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 13:52:10.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"4b07d99e2433fc51fefbb989e4f35d192fd72957","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 14:38:09.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"5d579dff14f55714958badc8059222731c5aae5a","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 14:48:04.000000000","message":"Patch Set 5:\n\nHi Mark, \nWe should be helping the user, True.. but i think this bug is invalid when we\u0027ve already solved this with the server! Clients make a request and the server will respond with a 403. That\u0027s a great feedback. That\u0027s when an unprivileged requester will know to contact support/the administrator. That\u0027s why we have HTTP 403 with a clear message \"Administrator privileges are required to make this request\".. It would be a different question when the CLI starts checking policies.. We made a conscious decision not to do that; that\u0027s duplicated effort; and effort in the wrong direction. I do not believe users need anything more than \n\n     \"HTTP 403. Administrator privileges are required to make this request\"\n\nas a response. We decided to tag Experimental features because the client is hiding the implementation... We could have gone another direction and said the user needs an --experimental option to be specified for sure. We didn\u0027t do that; so we decided to provide help text instead suggesting that they need to know in some way that the feature is experimental. When we ourselves don\u0027t know what could be determined to be \"admin\" level APIs, i think this could be left to the traditional \"client-server\" response.. Thoughts?","accounts_in_message":[],"_revision_number":5},{"id":"7537eab89eb49314d82bdd8f3a34e24d4d64cf3a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 15:27:50.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-pep8 http://logs.openstack.org/36/287436/5/check/gate-python-manilaclient-pep8/2f4521b/ : SUCCESS in 2m 46s\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/36/287436/5/check/gate-python-manilaclient-docs/4ee9054//doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-manilaclient-python27 http://logs.openstack.org/36/287436/5/check/gate-python-manilaclient-python27/74cbd71/ : SUCCESS in 3m 56s\n- gate-python-manilaclient-python34 http://logs.openstack.org/36/287436/5/check/gate-python-manilaclient-python34/998afa6/ : SUCCESS in 4m 45s\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/36/287436/5/check/gate-manilaclient-dsvm-neutron-functional/078f996/ : SUCCESS in 40m 24s","accounts_in_message":[],"_revision_number":5},{"id":"e9c6125cf23f6081b8ef7aad507e68ed7debbb93","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2016-03-03 15:41:55.000000000","message":"Abandoned\n\nWe\u0027re abandoning this patch so we can replace the help text with a better solution in the future..","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"63d1bf47bcaaaca9be384e028e2931554121d4ec","revisions":{"23b32b5d77fb96979f080ebc38e568e8090b416e":{"kind":"REWORK","_number":1,"created":"2016-03-02 20:58:03.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/36/287436/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/36/287436/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/1"}}},"commit":{"parents":[{"commit":"412b392cb2148d3dea7dbd89350004ec5cec2543","subject":"Annotate CLI commands for experimental features","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/412b392cb2148d3dea7dbd89350004ec5cec2543"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-02 18:31:10.000000000","tz":-300},"committer":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-02 18:31:52.000000000","tz":0},"subject":"Revert usage of help text marking \"admin only\" CLIs","message":"Revert usage of help text marking \"admin only\" CLIs\n\nCommit 37f2e50bd433149b893d30a478947f3e17f928e9 appended\nhelp text for a number of CLI commands in v2/shell.py to tag CLI\ncommands that work with \"Admin\" APIs. While it may be helpful for a\nuser to see \"admin\" features tagged appropriately, this is not the way\nto go since \u0027policy.json\u0027 associated with the manila-api service can\nbe altered by deployers and would be the source of truth for Manila\u0027s\nbehavior in the cloud wrt APIs.\n\nFor example, It would be extremely confusing for a user to see a CLI\ncommand, for example, \u0027share-replica-resync\u0027 tagged \"Admin Only\" when\nin fact, the deployer could allow users access to that API.\n\nSince the manila-api service already responds with an appropriate 403\nerror when contexts don\u0027t match with policy, we may consider this problem\nsolved more efficiently.\n\nRemove all \u0027admin-only\u0027 tags.\n\nChange-Id: I28043b4d8e89909caf76a8e2e4306f0cb952c1d3\nCloses-Bug: #1457155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/23b32b5d77fb96979f080ebc38e568e8090b416e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/23b32b5d77fb96979f080ebc38e568e8090b416e"}]},"branch":"refs/heads/master"},"7faddf59c3091c09578b055a0aa8d7ff9e4c2044":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-03-03 02:27:10.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/36/287436/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/36/287436/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/2"}}},"commit":{"parents":[{"commit":"98a59fb5c2696a2f2adf2bb998667c22fc6dd8cd","subject":"Annotate CLI commands for experimental features","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/98a59fb5c2696a2f2adf2bb998667c22fc6dd8cd"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-02 18:31:10.000000000","tz":-300},"committer":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-03 02:27:10.000000000","tz":0},"subject":"Revert usage of help text marking \"admin only\" CLIs","message":"Revert usage of help text marking \"admin only\" CLIs\n\nCommit 37f2e50bd433149b893d30a478947f3e17f928e9 appended\nhelp text for a number of CLI commands in v2/shell.py to tag CLI\ncommands that work with \"Admin\" APIs. While it may be helpful for a\nuser to see \"admin\" features tagged appropriately, this is not the way\nto go since \u0027policy.json\u0027 associated with the manila-api service can\nbe altered by deployers and would be the source of truth for Manila\u0027s\nbehavior in the cloud wrt APIs.\n\nFor example, It would be extremely confusing for a user to see a CLI\ncommand, for example, \u0027share-replica-resync\u0027 tagged \"Admin Only\" when\nin fact, the deployer could allow users access to that API.\n\nSince the manila-api service already responds with an appropriate 403\nerror when contexts don\u0027t match with policy, we may consider this problem\nsolved more efficiently.\n\nRemove all \u0027admin-only\u0027 tags.\n\nChange-Id: I28043b4d8e89909caf76a8e2e4306f0cb952c1d3\nCloses-Bug: #1457155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7faddf59c3091c09578b055a0aa8d7ff9e4c2044"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7faddf59c3091c09578b055a0aa8d7ff9e4c2044"}]},"branch":"refs/heads/master"},"95b8837dbd7435c78fc9c2c6231d5f9bfa00989e":{"kind":"REWORK","_number":3,"created":"2016-03-03 02:31:22.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/36/287436/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/36/287436/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/3"}}},"commit":{"parents":[{"commit":"98a59fb5c2696a2f2adf2bb998667c22fc6dd8cd","subject":"Annotate CLI commands for experimental features","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/98a59fb5c2696a2f2adf2bb998667c22fc6dd8cd"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-02 18:31:10.000000000","tz":-300},"committer":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-03 02:30:57.000000000","tz":0},"subject":"Revert usage of help text marking \"admin only\" CLIs","message":"Revert usage of help text marking \"admin only\" CLIs\n\nCommit 37f2e50bd433149b893d30a478947f3e17f928e9 appended\nhelp text for a number of CLI commands in v2/shell.py to tag CLI\ncommands that work with \"Admin\" APIs. While it may be helpful for a\nuser to see \"admin\" features tagged appropriately, this is not the way\nto go since \u0027policy.json\u0027 associated with the manila-api service can\nbe altered by deployers and would be the source of truth for Manila\u0027s\nbehavior in the cloud wrt APIs.\n\nFor example, It would be extremely confusing for a user to see a CLI\ncommand, for example, \u0027share-replica-resync\u0027 tagged \"Admin Only\" when\nin fact, the deployer could allow users access to that API.\n\nSince the manila-api service already responds with an appropriate 403\nerror when contexts don\u0027t match with policy, we may consider this problem\nsolved more efficiently.\n\nRemove all \u0027admin-only\u0027 tags.\n\nChange-Id: I28043b4d8e89909caf76a8e2e4306f0cb952c1d3\nCloses-Bug: #1457155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/95b8837dbd7435c78fc9c2c6231d5f9bfa00989e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/95b8837dbd7435c78fc9c2c6231d5f9bfa00989e"}]},"branch":"refs/heads/master"},"d0220781f1cafe2f0802ca2ce12b6bf578158347":{"kind":"REWORK","_number":4,"created":"2016-03-03 12:51:54.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/36/287436/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/36/287436/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/4"}}},"commit":{"parents":[{"commit":"1b35a002f95491dde68544afdfa510c06f46a890","subject":"Merge \"CLI for manage/unmanage snapshot\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/1b35a002f95491dde68544afdfa510c06f46a890"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-02 18:31:10.000000000","tz":-300},"committer":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-03 12:51:53.000000000","tz":0},"subject":"Revert usage of help text marking \"admin only\" CLIs","message":"Revert usage of help text marking \"admin only\" CLIs\n\nCommit 37f2e50bd433149b893d30a478947f3e17f928e9 appended\nhelp text for a number of CLI commands in v2/shell.py to tag CLI\ncommands that work with \"Admin\" APIs. While it may be helpful for a\nuser to see \"admin\" features tagged appropriately, this is not the way\nto go since \u0027policy.json\u0027 associated with the manila-api service can\nbe altered by deployers and would be the source of truth for Manila\u0027s\nbehavior in the cloud wrt APIs.\n\nFor example, It would be extremely confusing for a user to see a CLI\ncommand, for example, \u0027share-replica-resync\u0027 tagged \"Admin Only\" when\nin fact, the deployer could allow users access to that API.\n\nSince the manila-api service already responds with an appropriate 403\nerror when contexts don\u0027t match with policy, we may consider this problem\nsolved more efficiently.\n\nRemove all \u0027admin-only\u0027 tags.\n\nChange-Id: I28043b4d8e89909caf76a8e2e4306f0cb952c1d3\nCloses-Bug: #1457155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d0220781f1cafe2f0802ca2ce12b6bf578158347"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d0220781f1cafe2f0802ca2ce12b6bf578158347"}]},"branch":"refs/heads/master"},"63d1bf47bcaaaca9be384e028e2931554121d4ec":{"kind":"REWORK","_number":5,"created":"2016-03-03 14:38:09.000000000","uploader":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"ref":"refs/changes/36/287436/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/36/287436/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/36/287436/5"}}},"commit":{"parents":[{"commit":"127d0d8f9ee78f0880c1a04bbff8a45a9175bcda","subject":"Annotate CLI commands for experimental features","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/127d0d8f9ee78f0880c1a04bbff8a45a9175bcda"}]}],"author":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-02 18:31:10.000000000","tz":-300},"committer":{"name":"Goutham Pacha Ravi","email":"gouthamr@netapp.com","date":"2016-03-03 14:38:08.000000000","tz":0},"subject":"Revert usage of help text marking \"admin only\" CLIs","message":"Revert usage of help text marking \"admin only\" CLIs\n\nCommit 37f2e50bd433149b893d30a478947f3e17f928e9 appended\nhelp text for a number of CLI commands in v2/shell.py to tag CLI\ncommands that work with \"Admin\" APIs. While it may be helpful for a\nuser to see \"admin\" features tagged appropriately, this is not the way\nto go since \u0027policy.json\u0027 associated with the manila-api service can\nbe altered by deployers and would be the source of truth for Manila\u0027s\nbehavior in the cloud wrt APIs.\n\nFor example, It would be extremely confusing for a user to see a CLI\ncommand, for example, \u0027share-replica-resync\u0027 tagged \"Admin Only\" when\nin fact, the deployer could allow users access to that API.\n\nSince the manila-api service already responds with an appropriate 403\nerror when contexts don\u0027t match with policy, we may consider this problem\nsolved more efficiently.\n\nRemove all \u0027admin-only\u0027 tags.\n\nChange-Id: I28043b4d8e89909caf76a8e2e4306f0cb952c1d3\nCloses-Bug: #1457155\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/63d1bf47bcaaaca9be384e028e2931554121d4ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/63d1bf47bcaaaca9be384e028e2931554121d4ec"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
