)]}'
{"manilaclient/api_versions.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"28fd854b47de4748d84f5820937cbbea28ac1db7","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    valid_version \u003d requested_version"},{"line_number":285,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":286,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":287,"context_line":"            if (manilaclient.API_MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_37c5193c","line":288,"range":{"start_line":287,"start_character":12,"end_line":288,"end_character":72},"updated":"2016-03-29 16:16:50.000000000","message":"If this conditions returns False then client does not have support of server microversions at all. So, this condition should have \"else\" clause and raise exception, that client is not suitable for server at all.","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"eb8f8b3997d60be188723954be6bdb7ca38e6277","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    valid_version \u003d requested_version"},{"line_number":285,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":286,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":287,"context_line":"            if (manilaclient.API_MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_4e2397a7","line":288,"range":{"start_line":287,"start_character":12,"end_line":288,"end_character":72},"in_reply_to":"ba0121b8_37c5193c","updated":"2016-03-30 15:27:44.000000000","message":"Good point.","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d42709676b9f9b5ed28474ae560f1474656e074a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    valid_version \u003d requested_version"},{"line_number":285,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":286,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":287,"context_line":"            if (manilaclient.API_MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_657031dd","line":288,"range":{"start_line":287,"start_character":12,"end_line":288,"end_character":72},"in_reply_to":"ba0121b8_37c5193c","updated":"2016-03-30 18:05:38.000000000","message":"This method validates the requested version. This particular logic is only validating if the requested version should be changed to the maximum server version. The following method _validate_server_version validates what you are talking about and raises the appropriate exception. The logic was split out into separate methods in order to reduce the complexity of the code. Let me know if this isn\u0027t acceptable.","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3ee2bf932f0a6f10865b0dfa092d369732ba67e9","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    valid_version \u003d requested_version"},{"line_number":285,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":286,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":287,"context_line":"            if (manilaclient.API_MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_77bcb16c","line":288,"range":{"start_line":287,"start_character":12,"end_line":288,"end_character":72},"in_reply_to":"ba0121b8_37c5193c","updated":"2016-03-29 16:20:34.000000000","message":"s/conditions/condition/\n\nAnd yes, need to cover such case with unit tests.","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d42709676b9f9b5ed28474ae560f1474656e074a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    valid_version \u003d requested_version"},{"line_number":285,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":286,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":287,"context_line":"            if (manilaclient.API_MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_c5601d04","line":288,"range":{"start_line":287,"start_character":12,"end_line":288,"end_character":72},"in_reply_to":"ba0121b8_77bcb16c","updated":"2016-03-30 18:05:38.000000000","message":"This was already covered in test_api_versions.py. I reviewed the unit tests and added one that was missing but unrelated to this change. Let me know if I should remove that test since it is unrelated.","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"92793c24c7a8a9b9a970d31538d7ead58875a21f","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    valid_version \u003d requested_version"},{"line_number":285,"context_line":"    if not requested_version.matches(server_start_version, server_end_version):"},{"line_number":286,"context_line":"        if server_end_version \u003c\u003d requested_version:"},{"line_number":287,"context_line":"            if (manilaclient.API_MIN_VERSION \u003c\u003d server_end_version and"},{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_5eeb3a13","line":288,"range":{"start_line":287,"start_character":12,"end_line":288,"end_character":72},"in_reply_to":"ba0121b8_c5601d04","updated":"2016-03-30 19:00:32.000000000","message":"Now I see. But function names \"_validate_requested_version\" and \"_validate_server_version\" do not really explain \"what do they do?\".\n\nIn \"_validate_server_version\" you compare client and server ranges, it is different than \"validate server version\".","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"77db111b8dc029fd50a6134789c2f17c30486fe7","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"},{"line_number":292,"context_line":"                logger.debug(msg, {"},{"line_number":293,"context_line":"                    \"requested_version\": requested_version,"},{"line_number":294,"context_line":"                    \"server_end_version\": server_end_version})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_dc484430","line":291,"range":{"start_line":291,"start_character":51,"end_line":291,"end_character":52},"updated":"2016-03-29 16:01:58.000000000","message":"extra space at end","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"d42709676b9f9b5ed28474ae560f1474656e074a","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                    server_end_version \u003c\u003d manilaclient.API_MAX_VERSION):"},{"line_number":289,"context_line":"                msg \u003d _(\"Requested version %(requested_version)s is \""},{"line_number":290,"context_line":"                        \"not supported. Downgrading requested version \""},{"line_number":291,"context_line":"                        \"to %(server_end_version)s. \")"},{"line_number":292,"context_line":"                logger.debug(msg, {"},{"line_number":293,"context_line":"                    \"requested_version\": requested_version,"},{"line_number":294,"context_line":"                    \"server_end_version\": server_end_version})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_09f360d7","line":291,"range":{"start_line":291,"start_character":51,"end_line":291,"end_character":52},"in_reply_to":"ba0121b8_dc484430","updated":"2016-03-30 18:05:38.000000000","message":"Done","commit_id":"3784db3b7bec6d6044e7aecc757827ff648f0e06"}],"manilaclient/shell.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d63814355833b932877bbc006445e2e63304ab9c","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        logging.basicConfig(level\u003dlogging.DEBUG, format\u003dstreamformat)"},{"line_number":419,"context_line":"        logging.getLogger(\u0027requests.packages.urllib3.connectionpool\u0027"},{"line_number":420,"context_line":"                          ).setLevel(logging.WARNING)"},{"line_number":421,"context_line":"        logging.getLogger(\u0027keystoneclient.session\u0027).setLevel(logging.WARNING)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _build_subcommands_and_extensions(self,"},{"line_number":424,"context_line":"                                          os_api_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_4dc92878","line":421,"updated":"2016-03-29 14:46:33.000000000","message":"This is not a related change.  Can you add descriptions of this change in the commit message?","commit_id":"01e5b4bc262e44f48b11ab5e7c22e8f745fb5e08"},{"author":{"_account_id":16212,"name":"Chuck Fouts","email":"fchuck@netapp.com","username":"cFouts"},"change_message_id":"b7c7d19e731c3b95bdccd29cc40f949e6ad8b5dd","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        logging.basicConfig(level\u003dlogging.DEBUG, format\u003dstreamformat)"},{"line_number":419,"context_line":"        logging.getLogger(\u0027requests.packages.urllib3.connectionpool\u0027"},{"line_number":420,"context_line":"                          ).setLevel(logging.WARNING)"},{"line_number":421,"context_line":"        logging.getLogger(\u0027keystoneclient.session\u0027).setLevel(logging.WARNING)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _build_subcommands_and_extensions(self,"},{"line_number":424,"context_line":"                                          os_api_version,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_d0414b0d","line":421,"in_reply_to":"ba0121b8_4dc92878","updated":"2016-03-29 14:58:24.000000000","message":"Basically logging did not work anywhere except in shell.py. I will update the commit message to indicate that logging was fixed and we then needed to filter out log messages that were not previously displayed when using the --debug flag.","commit_id":"01e5b4bc262e44f48b11ab5e7c22e8f745fb5e08"}]}