)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5844b96f1cb4da638ffedd97d0817b97b44f1f27","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- share-snapshot-instance-show"},{"line_number":13,"context_line":"- share-snapshot-instance-reset-status"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":18,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_91f9b9cb","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"updated":"2016-04-12 13:05:26.000000000","message":"This is only for APIImpact in the manila project..","commit_id":"38486744f4d4201004a4c3a93f9aedba443ca9dc"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add snapshot instances admin APIs in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-detail"},{"line_number":11,"context_line":"- share-snapshot-instance-list"},{"line_number":12,"context_line":"- share-snapshot-instance-show"},{"line_number":13,"context_line":"- share-snapshot-instance-reset-status"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":16,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a122d0e_961c86c3","line":13,"range":{"start_line":10,"start_character":2,"end_line":13,"end_character":38},"updated":"2016-05-05 14:13:40.000000000","message":"Added shell commands do not have \"share-\" prefix.","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add snapshot instances admin APIs in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-detail"},{"line_number":11,"context_line":"- share-snapshot-instance-list"},{"line_number":12,"context_line":"- share-snapshot-instance-show"},{"line_number":13,"context_line":"- share-snapshot-instance-reset-status"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":16,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dab17558_2d046816","line":13,"range":{"start_line":10,"start_character":2,"end_line":13,"end_character":38},"in_reply_to":"1a122d0e_961c86c3","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ec2a33c3b0c95fe76395dd0dd0c5b410d7cf5d3d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- snapshot-instance-show"},{"line_number":13,"context_line":"- snapshot-instance-reset-status"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":18,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"dada55a8_cbc06a7f","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"updated":"2016-07-23 17:49:38.000000000","message":"I believe this is valid only for openstack/manila patches","commit_id":"b47f9a32e8af1c4698671871ce26281a978b9750"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e706f8fa464895de9c79459e2d4eda020044ebe2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- snapshot-instance-show"},{"line_number":13,"context_line":"- snapshot-instance-reset-status"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Implements: blueprint snapshot-instances"},{"line_number":18,"context_line":"Change-Id: Ica1e81012f19926e0f1ba9cd6d8eecc5fbbf40b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"dada55a8_9c0af924","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":9},"in_reply_to":"dada55a8_cbc06a7f","updated":"2016-07-26 02:55:25.000000000","message":"Done","commit_id":"b47f9a32e8af1c4698671871ce26281a978b9750"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"22ce1a502a96176a04302004b21ec589da32f57a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-03 18:15:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances admin APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"bacf61ea_33441a73","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":33},"updated":"2016-08-03 12:57:32.000000000","message":"CLIs?","commit_id":"e2e6f1f3c8de6cf7537b53bbdb7821016fc4d59b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ae3b2f878f19b9f58f8bd087b7327e012d7ee9b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhongjun \u003cjun.zhongjun@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-03 18:15:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances admin APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"bacf61ea_85af78e2","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":33},"in_reply_to":"bacf61ea_33441a73","updated":"2016-08-03 14:14:55.000000000","message":"Done","commit_id":"e2e6f1f3c8de6cf7537b53bbdb7821016fc4d59b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"22ce1a502a96176a04302004b21ec589da32f57a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances admin APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":"- share-snapshot-instance-show"},{"line_number":12,"context_line":"- share-snapshot-instance-reset-status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"bacf61ea_d34c9e9f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2016-08-03 12:57:32.000000000","message":"Support?","commit_id":"e2e6f1f3c8de6cf7537b53bbdb7821016fc4d59b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ae3b2f878f19b9f58f8bd087b7327e012d7ee9b1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add snapshot instances admin APIs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new API entry points for share snapshot instances:"},{"line_number":10,"context_line":"- share-snapshot-instance-list"},{"line_number":11,"context_line":"- share-snapshot-instance-show"},{"line_number":12,"context_line":"- share-snapshot-instance-reset-status"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"bacf61ea_65aa44d4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"in_reply_to":"bacf61ea_d34c9e9f","updated":"2016-08-03 14:14:55.000000000","message":"Done","commit_id":"e2e6f1f3c8de6cf7537b53bbdb7821016fc4d59b"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"05f611de54acaa54b6faf63674d5098dfd80e88f","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    @forbidden_wrapper"},{"line_number":723,"context_line":"    def delete_snapshot(self, snapshots, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot[s] by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        if not isinstance(snapshots, list):"},{"line_number":726,"context_line":"            snapshots \u003d [snapshots]"},{"line_number":727,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":728,"context_line":"        for snapshot in snapshots:"},{"line_number":729,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_3e1301ba","line":726,"range":{"start_line":725,"start_character":8,"end_line":726,"end_character":35},"updated":"2016-08-04 13:31:13.000000000","message":"if not isinstance (snapshots, (list, tuple, set)):\n    snapshots \u003d (snapshots, )","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e771ba4e4b9b7ead0c2cc4737ae7acc313e206ee","unresolved":false,"context_lines":[{"line_number":722,"context_line":"    @forbidden_wrapper"},{"line_number":723,"context_line":"    def delete_snapshot(self, snapshots, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot[s] by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        if not isinstance(snapshots, list):"},{"line_number":726,"context_line":"            snapshots \u003d [snapshots]"},{"line_number":727,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":728,"context_line":"        for snapshot in snapshots:"},{"line_number":729,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_ecfd43b2","line":726,"range":{"start_line":725,"start_character":8,"end_line":726,"end_character":35},"in_reply_to":"bacf61ea_3e1301ba","updated":"2016-08-04 16:10:22.000000000","message":"Done","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"05f611de54acaa54b6faf63674d5098dfd80e88f","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    def list_snapshots(self, all_tenants\u003dFalse, filters\u003dNone, columns\u003dNone,"},{"line_number":733,"context_line":"                       is_public\u003dFalse, microversion\u003dNone):"},{"line_number":734,"context_line":"        \"\"\"List snapshots.\"\"\""},{"line_number":735,"context_line":"        cmd \u003d \u0027list \u0027"},{"line_number":736,"context_line":"        if all_tenants:"},{"line_number":737,"context_line":"            cmd +\u003d \u0027--all-tenants \u0027"},{"line_number":738,"context_line":"        if is_public:"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_de1aa5c5","line":735,"range":{"start_line":735,"start_character":15,"end_line":735,"end_character":19},"updated":"2016-08-04 13:31:13.000000000","message":"It is list of manila shares.","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e771ba4e4b9b7ead0c2cc4737ae7acc313e206ee","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    def list_snapshots(self, all_tenants\u003dFalse, filters\u003dNone, columns\u003dNone,"},{"line_number":733,"context_line":"                       is_public\u003dFalse, microversion\u003dNone):"},{"line_number":734,"context_line":"        \"\"\"List snapshots.\"\"\""},{"line_number":735,"context_line":"        cmd \u003d \u0027list \u0027"},{"line_number":736,"context_line":"        if all_tenants:"},{"line_number":737,"context_line":"            cmd +\u003d \u0027--all-tenants \u0027"},{"line_number":738,"context_line":"        if is_public:"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_6c5cb37d","line":735,"range":{"start_line":735,"start_character":15,"end_line":735,"end_character":19},"in_reply_to":"bacf61ea_21a764be","updated":"2016-08-04 16:10:22.000000000","message":"Done","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e771ba4e4b9b7ead0c2cc4737ae7acc313e206ee","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    def list_snapshots(self, all_tenants\u003dFalse, filters\u003dNone, columns\u003dNone,"},{"line_number":733,"context_line":"                       is_public\u003dFalse, microversion\u003dNone):"},{"line_number":734,"context_line":"        \"\"\"List snapshots.\"\"\""},{"line_number":735,"context_line":"        cmd \u003d \u0027list \u0027"},{"line_number":736,"context_line":"        if all_tenants:"},{"line_number":737,"context_line":"            cmd +\u003d \u0027--all-tenants \u0027"},{"line_number":738,"context_line":"        if is_public:"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_2c663b51","line":735,"range":{"start_line":735,"start_character":15,"end_line":735,"end_character":19},"in_reply_to":"bacf61ea_de1aa5c5","updated":"2016-08-04 16:10:22.000000000","message":"Done","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8a30edf20d190c00f7389c437128a3c57fb8f0bc","unresolved":false,"context_lines":[{"line_number":732,"context_line":"    def list_snapshots(self, all_tenants\u003dFalse, filters\u003dNone, columns\u003dNone,"},{"line_number":733,"context_line":"                       is_public\u003dFalse, microversion\u003dNone):"},{"line_number":734,"context_line":"        \"\"\"List snapshots.\"\"\""},{"line_number":735,"context_line":"        cmd \u003d \u0027list \u0027"},{"line_number":736,"context_line":"        if all_tenants:"},{"line_number":737,"context_line":"            cmd +\u003d \u0027--all-tenants \u0027"},{"line_number":738,"context_line":"        if is_public:"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_21a764be","line":735,"range":{"start_line":735,"start_character":15,"end_line":735,"end_character":19},"in_reply_to":"bacf61ea_de1aa5c5","updated":"2016-08-04 13:38:47.000000000","message":"The fact that you have such bug here means you implement redundant thing. So, need either to cover it in tests or remove.","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"05f611de54acaa54b6faf63674d5098dfd80e88f","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        \"\"\"Get snapshot instance.\"\"\""},{"line_number":764,"context_line":"        cmd \u003d \u0027snapshot-instance-show %s \u0027 % id"},{"line_number":765,"context_line":"        snapshot_instance_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":766,"context_line":"        snapshot_instance_raw \u003d output_parser.details(snapshot_instance_raw)"},{"line_number":767,"context_line":"        return snapshot_instance_raw"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def reset_snapshot_instance(self, id\u003dNone, state\u003dNone, microversion\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_5e5cf57c","line":766,"range":{"start_line":766,"start_character":8,"end_line":766,"end_character":29},"updated":"2016-08-04 13:31:13.000000000","message":"From naming point of view, it is incorrect. \"raw\" means it is not parsed, something being as is. On line 775 you do it correctly.","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e771ba4e4b9b7ead0c2cc4737ae7acc313e206ee","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        \"\"\"Get snapshot instance.\"\"\""},{"line_number":764,"context_line":"        cmd \u003d \u0027snapshot-instance-show %s \u0027 % id"},{"line_number":765,"context_line":"        snapshot_instance_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":766,"context_line":"        snapshot_instance_raw \u003d output_parser.details(snapshot_instance_raw)"},{"line_number":767,"context_line":"        return snapshot_instance_raw"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"    def reset_snapshot_instance(self, id\u003dNone, state\u003dNone, microversion\u003dNone):"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_8ce5a7a5","line":766,"range":{"start_line":766,"start_character":8,"end_line":766,"end_character":29},"in_reply_to":"bacf61ea_5e5cf57c","updated":"2016-08-04 16:10:22.000000000","message":"Done","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            cmd +\u003d \u0027--snapshot %s\u0027 % snapshot_id"},{"line_number":738,"context_line":"        if columns is not None:"},{"line_number":739,"context_line":"            cmd +\u003d \u0027 --columns \u0027 + columns"},{"line_number":740,"context_line":"        if detailed:"},{"line_number":741,"context_line":"            cmd +\u003d \u0027 --detailed True \u0027"},{"line_number":742,"context_line":"        snapshot_instances_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":743,"context_line":"        snapshot_instances \u003d utils.listing(snapshot_instances_raw)"},{"line_number":744,"context_line":"        return snapshot_instances"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_8c1e190a","line":741,"range":{"start_line":740,"start_character":7,"end_line":741,"end_character":38},"updated":"2016-08-05 09:56:38.000000000","message":"It should be None by default and we should set it if it is not None. Currently, we are not able to test case \"detailed\u003dFalse\".","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":737,"context_line":"            cmd +\u003d \u0027--snapshot %s\u0027 % snapshot_id"},{"line_number":738,"context_line":"        if columns is not None:"},{"line_number":739,"context_line":"            cmd +\u003d \u0027 --columns \u0027 + columns"},{"line_number":740,"context_line":"        if detailed:"},{"line_number":741,"context_line":"            cmd +\u003d \u0027 --detailed True \u0027"},{"line_number":742,"context_line":"        snapshot_instances_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":743,"context_line":"        snapshot_instances \u003d utils.listing(snapshot_instances_raw)"},{"line_number":744,"context_line":"        return snapshot_instances"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_69658543","line":741,"range":{"start_line":740,"start_character":7,"end_line":741,"end_character":38},"in_reply_to":"bacf61ea_8c1e190a","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4ea7a29fd47f0ee43cb9d4d6300ead0553e6b3ca","unresolved":false,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    @not_found_wrapper"},{"line_number":714,"context_line":"    def get_snapshot(self, snapshot, microversion\u003dNone):"},{"line_number":715,"context_line":"        \"\"\"Returns a snapshot by its Name or ID.\"\"\""},{"line_number":716,"context_line":"        snapshot_raw \u003d self.manila(\u0027snapshot-show %s\u0027 % snapshot,"},{"line_number":717,"context_line":"                                   microversion\u003dmicroversion)"},{"line_number":718,"context_line":"        snapshot \u003d output_parser.details(snapshot_raw)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_0a8fcecc","line":715,"range":{"start_line":715,"start_character":11,"end_line":715,"end_character":18},"updated":"2016-08-10 19:35:34.000000000","message":"Retrieves","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    @not_found_wrapper"},{"line_number":714,"context_line":"    def get_snapshot(self, snapshot, microversion\u003dNone):"},{"line_number":715,"context_line":"        \"\"\"Returns a snapshot by its Name or ID.\"\"\""},{"line_number":716,"context_line":"        snapshot_raw \u003d self.manila(\u0027snapshot-show %s\u0027 % snapshot,"},{"line_number":717,"context_line":"                                   microversion\u003dmicroversion)"},{"line_number":718,"context_line":"        snapshot \u003d output_parser.details(snapshot_raw)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_796c4135","line":715,"range":{"start_line":715,"start_character":11,"end_line":715,"end_character":18},"in_reply_to":"9ad45d7e_0a8fcecc","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0961a5852275aad3f1a88d5e29e01b79df61fdfc","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    @not_found_wrapper"},{"line_number":722,"context_line":"    @forbidden_wrapper"},{"line_number":723,"context_line":"    def delete_snapshot(self, snapshots, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot[s] by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        if not isinstance(snapshots, (list, tuple, set)):"},{"line_number":726,"context_line":"            snapshots \u003d (snapshots, )"},{"line_number":727,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":728,"context_line":"        for snapshot in snapshots:"},{"line_number":729,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"},{"line_number":730,"context_line":"        return self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def list_snapshot_instances(self, snapshot_id\u003dNone, columns\u003dNone,"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_f827abc7","line":729,"range":{"start_line":724,"start_character":8,"end_line":729,"end_character":35},"updated":"2016-08-10 15:46:45.000000000","message":"\"do_snapshot_delete\" shell command does not support multiple snapshots be provided [1].\n\n[1] https://github.com/openstack/python-manilaclient/blob/093a2e69/manilaclient/v2/shell.py#L1704","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    @not_found_wrapper"},{"line_number":722,"context_line":"    @forbidden_wrapper"},{"line_number":723,"context_line":"    def delete_snapshot(self, snapshots, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot[s] by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        if not isinstance(snapshots, (list, tuple, set)):"},{"line_number":726,"context_line":"            snapshots \u003d (snapshots, )"},{"line_number":727,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":728,"context_line":"        for snapshot in snapshots:"},{"line_number":729,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"},{"line_number":730,"context_line":"        return self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"    def list_snapshot_instances(self, snapshot_id\u003dNone, columns\u003dNone,"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_59e69db0","line":729,"range":{"start_line":724,"start_character":8,"end_line":729,"end_character":35},"in_reply_to":"9ad45d7e_f827abc7","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4ea7a29fd47f0ee43cb9d4d6300ead0553e6b3ca","unresolved":false,"context_lines":[{"line_number":760,"context_line":"        return snapshot_instance"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def is_snapshot_deleted(self, snapshot, microversion\u003dNone):"},{"line_number":763,"context_line":"        \"\"\"Says whether snapshot is deleted or not."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        :param snapshot: str -- Name or ID of snapshot"},{"line_number":766,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_ea0eba39","line":763,"range":{"start_line":763,"start_character":11,"end_line":763,"end_character":15},"updated":"2016-08-10 19:35:34.000000000","message":"Indicates","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":760,"context_line":"        return snapshot_instance"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    def is_snapshot_deleted(self, snapshot, microversion\u003dNone):"},{"line_number":763,"context_line":"        \"\"\"Says whether snapshot is deleted or not."},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        :param snapshot: str -- Name or ID of snapshot"},{"line_number":766,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_9904954a","line":763,"range":{"start_line":763,"start_character":11,"end_line":763,"end_character":15},"in_reply_to":"9ad45d7e_ea0eba39","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"471648fa68ad2c167fa51bebb1e9678b0530a90d","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    def delete_snapshot(self, snapshot, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":726,"context_line":"        if snapshot:"},{"line_number":727,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"},{"line_number":728,"context_line":"        return self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def list_snapshot_instances(self, snapshot_id\u003dNone, columns\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_426ce1cf","line":727,"range":{"start_line":726,"start_character":8,"end_line":727,"end_character":35},"updated":"2016-08-11 09:20:42.000000000","message":"Are you aware that you never delete snapshot? Because you try to delete share here. You get correct 404 (share with snapshot ID is absent) and that\u0027s all.\n\nAlso, snapshot is required argument. This method should be as of following:\n\n\"\"\"\nreturn self.manila(\n    \"snapshot-delete %s\" % snapshot, microversion\u003dmicroversion)\n\"\"\"","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8b0557a5b3a33333de6237f60efaa2b39b36136d","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    def delete_snapshot(self, snapshot, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":726,"context_line":"        if snapshot:"},{"line_number":727,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"},{"line_number":728,"context_line":"        return self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def list_snapshot_instances(self, snapshot_id\u003dNone, columns\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_9de0f897","line":727,"range":{"start_line":726,"start_character":8,"end_line":727,"end_character":35},"in_reply_to":"9ad45d7e_426ce1cf","updated":"2016-08-11 13:11:56.000000000","message":"Done","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"413514f8166bb72f398dbb71235ca015559e54be","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    def delete_snapshot(self, snapshot, microversion\u003dNone):"},{"line_number":724,"context_line":"        \"\"\"Deletes snapshot by Names or IDs.\"\"\""},{"line_number":725,"context_line":"        cmd \u003d \u0027delete \u0027"},{"line_number":726,"context_line":"        if snapshot:"},{"line_number":727,"context_line":"            cmd +\u003d \u0027%s \u0027 % snapshot"},{"line_number":728,"context_line":"        return self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"    def list_snapshot_instances(self, snapshot_id\u003dNone, columns\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_c10e018b","line":727,"range":{"start_line":726,"start_character":8,"end_line":727,"end_character":35},"in_reply_to":"9ad45d7e_9de0f897","updated":"2016-08-11 13:14:34.000000000","message":"Not done.","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"}],"manilaclient/tests/functional/test_snapshot_instances.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@ddt.ddt"},{"line_number":23,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(SnapshotInstancesTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_ecaa3570","line":24,"updated":"2016-08-05 09:56:38.000000000","message":"New config options should be added to [1] that will allow us to disable that \"optional\" feature.\nIt could be named in the same way as it is done in manila project - \"run_snapshot_tests\".\n\n[1] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/config.py","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"@ddt.ddt"},{"line_number":23,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    @classmethod"},{"line_number":26,"context_line":"    def setUpClass(cls):"},{"line_number":27,"context_line":"        super(SnapshotInstancesTest, cls).setUpClass()"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_9ab8f5c9","line":24,"in_reply_to":"bacf61ea_ecaa3570","updated":"2016-08-05 15:30:26.000000000","message":"Done  Good Catch! Thanks","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":41,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027)"},{"line_number":42,"context_line":"        for el in snapshot_instances:"},{"line_number":43,"context_line":"            for key in expected_keys:"},{"line_number":44,"context_line":"                self.assertIn(key, el)"},{"line_number":45,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_8cc8d956","line":42,"range":{"start_line":42,"start_character":12,"end_line":42,"end_character":14},"updated":"2016-08-05 09:56:38.000000000","message":"Copy-pasted varname. In original loop it was acronym for \"Export Location\".","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":41,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027)"},{"line_number":42,"context_line":"        for el in snapshot_instances:"},{"line_number":43,"context_line":"            for key in expected_keys:"},{"line_number":44,"context_line":"                self.assertIn(key, el)"},{"line_number":45,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_e91df50f","line":42,"range":{"start_line":42,"start_character":12,"end_line":42,"end_character":14},"in_reply_to":"bacf61ea_8cc8d956","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":55,"context_line":"                         \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":56,"context_line":"                         \u0027Progress\u0027, \u0027Provider_location\u0027)"},{"line_number":57,"context_line":"        for el in snapshot_instances:"},{"line_number":58,"context_line":"            for key in expected_keys:"},{"line_number":59,"context_line":"                self.assertIn(key, el)"},{"line_number":60,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_acd2fdfd","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":14},"updated":"2016-08-05 09:56:38.000000000","message":"Same here.","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":55,"context_line":"                         \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":56,"context_line":"                         \u0027Progress\u0027, \u0027Provider_location\u0027)"},{"line_number":57,"context_line":"        for el in snapshot_instances:"},{"line_number":58,"context_line":"            for key in expected_keys:"},{"line_number":59,"context_line":"                self.assertIn(key, el)"},{"line_number":60,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_4919a121","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":14},"in_reply_to":"bacf61ea_acd2fdfd","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        for el in snapshot_instances:"},{"line_number":58,"context_line":"            for key in expected_keys:"},{"line_number":59,"context_line":"                self.assertIn(key, el)"},{"line_number":60,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_list_snapshot_instance_with_snapshot(self):"},{"line_number":63,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_8c24590d","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":61},"updated":"2016-08-05 09:56:38.000000000","message":"Why only this one is checked? snapshot_id, share_id, share_instance_id are UUID-like too.","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        for el in snapshot_instances:"},{"line_number":58,"context_line":"            for key in expected_keys:"},{"line_number":59,"context_line":"                self.assertIn(key, el)"},{"line_number":60,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_list_snapshot_instance_with_snapshot(self):"},{"line_number":63,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_2999cd79","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":61},"in_reply_to":"bacf61ea_8c24590d","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":68,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027)"},{"line_number":69,"context_line":"        for el in snapshot_instances:"},{"line_number":70,"context_line":"            for key in expected_keys:"},{"line_number":71,"context_line":"                self.assertIn(key, el)"},{"line_number":72,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_6c8005c0","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":14},"updated":"2016-08-05 09:56:38.000000000","message":"Same here.","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":68,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027)"},{"line_number":69,"context_line":"        for el in snapshot_instances:"},{"line_number":70,"context_line":"            for key in expected_keys:"},{"line_number":71,"context_line":"                self.assertIn(key, el)"},{"line_number":72,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(el[\u0027ID\u0027]))"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_c9dbd14d","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":14},"in_reply_to":"bacf61ea_6c8005c0","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":81,"context_line":"        expected_keys \u003d (\u0027Id\u0027, \u0027Status\u0027)"},{"line_number":82,"context_line":"        unexpected_keys \u003d (\u0027Snapshot ID\u0027)"},{"line_number":83,"context_line":"        for el in snapshot_instances:"},{"line_number":84,"context_line":"            for key in expected_keys:"},{"line_number":85,"context_line":"                self.assertIn(key, el)"},{"line_number":86,"context_line":"            for key in unexpected_keys:"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_4c8541cd","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":15},"updated":"2016-08-05 09:56:38.000000000","message":"and here.","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":81,"context_line":"        expected_keys \u003d (\u0027Id\u0027, \u0027Status\u0027)"},{"line_number":82,"context_line":"        unexpected_keys \u003d (\u0027Snapshot ID\u0027)"},{"line_number":83,"context_line":"        for el in snapshot_instances:"},{"line_number":84,"context_line":"            for key in expected_keys:"},{"line_number":85,"context_line":"                self.assertIn(key, el)"},{"line_number":86,"context_line":"            for key in unexpected_keys:"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_49752130","line":83,"range":{"start_line":83,"start_character":11,"end_line":83,"end_character":15},"in_reply_to":"bacf61ea_4c8541cd","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0961a5852275aad3f1a88d5e29e01b79df61fdfc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manilaclient import config"},{"line_number":21,"context_line":"from manilaclient.tests.functional import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_e3f8a0c5","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":46},"updated":"2016-08-10 15:46:45.000000000","message":"from manilaclient.tests.functional import utils","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manilaclient import config"},{"line_number":21,"context_line":"from manilaclient.tests.functional import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CONF \u003d config.CONF"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_1965451d","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":46},"in_reply_to":"9ad45d7e_e3f8a0c5","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0961a5852275aad3f1a88d5e29e01b79df61fdfc","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":28,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":29,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_231638f1","line":28,"updated":"2016-08-10 15:46:45.000000000","message":"@utils.skip_if_microversion_not_supported(\u00272.19\u0027)","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4ea7a29fd47f0ee43cb9d4d6300ead0553e6b3ca","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":28,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":29,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_29a9ff7b","line":28,"range":{"start_line":28,"start_character":22,"end_line":28,"end_character":49},"updated":"2016-08-10 19:35:34.000000000","message":"fits one line","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":28,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":29,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_596b3df1","line":28,"in_reply_to":"9ad45d7e_231638f1","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":28,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":29,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_397009dc","line":28,"range":{"start_line":28,"start_character":22,"end_line":28,"end_character":49},"in_reply_to":"9ad45d7e_29a9ff7b","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e6244cf01566a3f0e0df721a1bb5078276980fc0","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"@testtools.skipUnless(CONF.run_snapshot_tests,"},{"line_number":28,"context_line":"                      \u0027Snapshot tests disabled.\u0027)"},{"line_number":29,"context_line":"class SnapshotInstancesTest(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_8460a902","line":28,"in_reply_to":"9ad45d7e_596b3df1","updated":"2016-08-11 08:43:01.000000000","message":"\"fits one line\" is not done.","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0961a5852275aad3f1a88d5e29e01b79df61fdfc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":42,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_c3dbdc4d","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":55},"updated":"2016-08-10 15:46:45.000000000","message":"This and all other similar lines need to remove and just add single decorator for whole class as shown above.","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4ea7a29fd47f0ee43cb9d4d6300ead0553e6b3ca","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":42,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_f3a18447","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":55},"updated":"2016-08-10 19:35:34.000000000","message":"have you tried @utils.skip_if_microversion_not_supported(\u00272.19\u0027) ?\n\nfrom manilaclient.tests.functional import utils\n\nsame for all other occurrences","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":42,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_59421d69","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":55},"in_reply_to":"9ad45d7e_c3dbdc4d","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"dc040c82b15e3602ce707d46cffe2008c6dfecde","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":42,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_39476978","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":55},"in_reply_to":"9ad45d7e_f3a18447","updated":"2016-08-11 06:35:46.000000000","message":"Done","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"fb4a8c994461d692f063e50926e8e5ef4bf29d09","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":42,"context_line":"        self.skip_if_microversion_not_supported(\u00272.19\u0027)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"9ad45d7e_76462250","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":55},"in_reply_to":"9ad45d7e_f3a18447","updated":"2016-08-10 19:36:46.000000000","message":"Valeriy beat me to it","commit_id":"9caa96dcdb2faa5152c859c6f0e18fdf0599d033"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"471648fa68ad2c167fa51bebb1e9678b0530a90d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        for si in snapshot_instances:"},{"line_number":49,"context_line":"            for key in expected_keys:"},{"line_number":50,"context_line":"                self.assertIn(key, si)"},{"line_number":51,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027ID\u0027]))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_list_all_snapshot_instances_details(self):"},{"line_number":54,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_22b3adea","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":61},"updated":"2016-08-11 09:20:42.000000000","message":"Snapshot ID should not be UUID-like?","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8b0557a5b3a33333de6237f60efaa2b39b36136d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        for si in snapshot_instances:"},{"line_number":49,"context_line":"            for key in expected_keys:"},{"line_number":50,"context_line":"                self.assertIn(key, si)"},{"line_number":51,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027ID\u0027]))"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_list_all_snapshot_instances_details(self):"},{"line_number":54,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_b3288834","line":51,"range":{"start_line":51,"start_character":12,"end_line":51,"end_character":61},"in_reply_to":"9ad45d7e_22b3adea","updated":"2016-08-11 13:11:56.000000000","message":"Done","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"471648fa68ad2c167fa51bebb1e9678b0530a90d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        for si in snapshot_instances:"},{"line_number":75,"context_line":"            for key in expected_keys:"},{"line_number":76,"context_line":"                self.assertIn(key, si)"},{"line_number":77,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027ID\u0027]))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_list_snapshot_instance_with_columns(self):"},{"line_number":80,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_a2bf9da8","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":61},"updated":"2016-08-11 09:20:42.000000000","message":"ditto","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8b0557a5b3a33333de6237f60efaa2b39b36136d","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        for si in snapshot_instances:"},{"line_number":75,"context_line":"            for key in expected_keys:"},{"line_number":76,"context_line":"                self.assertIn(key, si)"},{"line_number":77,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027ID\u0027]))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_list_snapshot_instance_with_columns(self):"},{"line_number":80,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_531aec17","line":77,"range":{"start_line":77,"start_character":12,"end_line":77,"end_character":61},"in_reply_to":"9ad45d7e_a2bf9da8","updated":"2016-08-11 13:11:56.000000000","message":"Done","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"471648fa68ad2c167fa51bebb1e9678b0530a90d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        for key in expected_keys:"},{"line_number":105,"context_line":"            self.assertIn(key, snapshot_instance)"},{"line_number":106,"context_line":"        self.assertTrue(uuidutils.is_uuid_like(snapshot_instance[\u0027id\u0027]))"},{"line_number":107,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":108,"context_line":"            snapshot_instance[\u0027snapshot_id\u0027]))"},{"line_number":109,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":110,"context_line":"            snapshot_instance[\u0027share_id\u0027]))"},{"line_number":111,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":112,"context_line":"            snapshot_instance[\u0027share_instance_id\u0027]))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_snapshot_instance_reset_state(self):"},{"line_number":115,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_e21875d5","line":112,"range":{"start_line":106,"start_character":8,"end_line":112,"end_character":52},"updated":"2016-08-11 09:20:42.000000000","message":"for key in (foo, bar):\n    self.assertTrue(\n        uuidutils.is_uuid_like(snapshot_instance[key]))","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8b0557a5b3a33333de6237f60efaa2b39b36136d","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        for key in expected_keys:"},{"line_number":105,"context_line":"            self.assertIn(key, snapshot_instance)"},{"line_number":106,"context_line":"        self.assertTrue(uuidutils.is_uuid_like(snapshot_instance[\u0027id\u0027]))"},{"line_number":107,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":108,"context_line":"            snapshot_instance[\u0027snapshot_id\u0027]))"},{"line_number":109,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":110,"context_line":"            snapshot_instance[\u0027share_id\u0027]))"},{"line_number":111,"context_line":"        self.assertTrue(uuidutils.is_uuid_like("},{"line_number":112,"context_line":"            snapshot_instance[\u0027share_instance_id\u0027]))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_snapshot_instance_reset_state(self):"},{"line_number":115,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_73c0d050","line":112,"range":{"start_line":106,"start_character":8,"end_line":112,"end_character":52},"in_reply_to":"9ad45d7e_e21875d5","updated":"2016-08-11 13:11:56.000000000","message":"Done","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3680bcc47598a7bfd43e13a68832f78a4ff63c3b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        snapshot_ids \u003d []"},{"line_number":49,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027)"},{"line_number":50,"context_line":"        for si in snapshot_instances:"},{"line_number":51,"context_line":"            for key in expected_keys:"},{"line_number":52,"context_line":"                self.assertIn(key, si)"},{"line_number":53,"context_line":"            snapshot_ids.append(si[\u0027Snapshot ID\u0027])"},{"line_number":54,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_list_all_snapshot_instances_details(self):"},{"line_number":57,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":30,"id":"9ad45d7e_1c719c76","line":54,"range":{"start_line":44,"start_character":8,"end_line":54,"end_character":56},"updated":"2016-08-11 13:23:08.000000000","message":"Before you verified that \"share_instance_id\" is UUID-like. I asked for checking \"snapshot_id\" too. marking it as \"done\" you implemented following:\nremoved original check of \"share_instance_id\" for UUID-likeness.\ndidn\u0027t add UUID-likeness check for \"snapshot_id\"\nstarted verifying that created snapshot ID is listed.\nThe same below. So, I am confused about that \"done\" logic completely.","commit_id":"dfe362c593ba038aeb7cf69f1f25fc567de22de7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7177b49040b4cf5cb338cb8b3aa27ae9efb5056c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                           cleanup_in_class\u003dTrue)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_list_all_snapshot_instances(self):"},{"line_number":44,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        snapshot_ids \u003d []"},{"line_number":49,"context_line":"        expected_keys \u003d (\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027)"},{"line_number":50,"context_line":"        for si in snapshot_instances:"},{"line_number":51,"context_line":"            for key in expected_keys:"},{"line_number":52,"context_line":"                self.assertIn(key, si)"},{"line_number":53,"context_line":"            snapshot_ids.append(si[\u0027Snapshot ID\u0027])"},{"line_number":54,"context_line":"        self.assertIn(self.snapshot[\u0027id\u0027], snapshot_ids)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_list_all_snapshot_instances_details(self):"},{"line_number":57,"context_line":"        snapshot_instances \u003d self.admin_client.list_snapshot_instances("}],"source_content_type":"text/x-python","patch_set":30,"id":"9ad45d7e_179332fb","line":54,"range":{"start_line":44,"start_character":8,"end_line":54,"end_character":56},"in_reply_to":"9ad45d7e_1c719c76","updated":"2016-08-11 14:56:12.000000000","message":"Done","commit_id":"dfe362c593ba038aeb7cf69f1f25fc567de22de7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6d7ae94c8df9f99f1111293e1a0825d3972ea99","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":86,"context_line":"        expected_keys \u003d (\u0027Id\u0027, \u0027Status\u0027)"},{"line_number":87,"context_line":"        unexpected_keys \u003d (\u0027Snapshot ID\u0027)"},{"line_number":88,"context_line":"        for si in snapshot_instances:"},{"line_number":89,"context_line":"            for key in expected_keys:"},{"line_number":90,"context_line":"                self.assertIn(key, si)"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_a6f796d1","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":41},"updated":"2016-08-11 16:04:18.000000000","message":"it is string, to make it tuple, use comma:\n\n\"\"\"\nunexpected_keys \u003d (\u0027Snapshot ID\u0027,)\n\"\"\"","commit_id":"24bb675c78dfa3efa413fb161e6b9464a0ed58e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c48feb8786da0b79c0858e30a0220e9477abe700","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        self.assertTrue(len(snapshot_instances) \u003e 0)"},{"line_number":86,"context_line":"        expected_keys \u003d (\u0027Id\u0027, \u0027Status\u0027)"},{"line_number":87,"context_line":"        unexpected_keys \u003d (\u0027Snapshot ID\u0027)"},{"line_number":88,"context_line":"        for si in snapshot_instances:"},{"line_number":89,"context_line":"            for key in expected_keys:"},{"line_number":90,"context_line":"                self.assertIn(key, si)"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_7ca4ef49","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":41},"in_reply_to":"9ad45d7e_a6f796d1","updated":"2016-08-12 03:02:29.000000000","message":"Sorry, Done","commit_id":"24bb675c78dfa3efa413fb161e6b9464a0ed58e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a6d7ae94c8df9f99f1111293e1a0825d3972ea99","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        unexpected_keys \u003d (\u0027Snapshot ID\u0027)"},{"line_number":88,"context_line":"        for si in snapshot_instances:"},{"line_number":89,"context_line":"            for key in expected_keys:"},{"line_number":90,"context_line":"                self.assertIn(key, si)"},{"line_number":91,"context_line":"            for key in unexpected_keys:"},{"line_number":92,"context_line":"                self.assertNotIn(key, si)"},{"line_number":93,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027Id\u0027]))"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_061ae216","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":38},"updated":"2016-08-11 16:04:18.000000000","message":"Test will fail on this line.","commit_id":"24bb675c78dfa3efa413fb161e6b9464a0ed58e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9a0ccedab484fb1adf8217b958e2da2049480f30","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        unexpected_keys \u003d (\u0027Snapshot ID\u0027)"},{"line_number":88,"context_line":"        for si in snapshot_instances:"},{"line_number":89,"context_line":"            for key in expected_keys:"},{"line_number":90,"context_line":"                self.assertIn(key, si)"},{"line_number":91,"context_line":"            for key in unexpected_keys:"},{"line_number":92,"context_line":"                self.assertNotIn(key, si)"},{"line_number":93,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027Id\u0027]))"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_c6d1ea24","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":38},"in_reply_to":"9ad45d7e_061ae216","updated":"2016-08-11 16:05:15.000000000","message":"Not here, a little bit below.","commit_id":"24bb675c78dfa3efa413fb161e6b9464a0ed58e3"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9a0ccedab484fb1adf8217b958e2da2049480f30","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            for key in expected_keys:"},{"line_number":90,"context_line":"                self.assertIn(key, si)"},{"line_number":91,"context_line":"            for key in unexpected_keys:"},{"line_number":92,"context_line":"                self.assertNotIn(key, si)"},{"line_number":93,"context_line":"            self.assertTrue(uuidutils.is_uuid_like(si[\u0027Id\u0027]))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_get_snapshot_instance(self):"}],"source_content_type":"text/x-python","patch_set":32,"id":"9ad45d7e_46bdfad6","line":92,"range":{"start_line":92,"start_character":16,"end_line":92,"end_character":41},"updated":"2016-08-11 16:05:15.000000000","message":"Upd: test will fail here.","commit_id":"24bb675c78dfa3efa413fb161e6b9464a0ed58e3"}],"manilaclient/tests/unit/v2/test_share_snapshot_instances.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @ddt.data("},{"line_number":73,"context_line":"        (\"2.19\", type(\"InstanceUUID\", (object, ), {\"uuid\": \"1234\"})),"},{"line_number":74,"context_line":"        (\"2.15\", type(\"InstanceUUID\", (object, ), {\"uuid\": \"1234\"})),"},{"line_number":75,"context_line":"        (\"2.19\", type(\"InstanceID\", (object, ), {\"id\": \"1234\"})),"},{"line_number":76,"context_line":"        (\"2.15\", type(\"InstanceID\", (object, ), {\"id\": \"1234\"})),"},{"line_number":77,"context_line":"        (\"2.19\", \"1234\"),"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_6cb3e59a","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":69},"updated":"2016-08-05 09:56:38.000000000","message":"It should not work. It does not fail because microversion defined on line 39 is used, which is 2.19","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @ddt.data("},{"line_number":73,"context_line":"        (\"2.19\", type(\"InstanceUUID\", (object, ), {\"uuid\": \"1234\"})),"},{"line_number":74,"context_line":"        (\"2.15\", type(\"InstanceUUID\", (object, ), {\"uuid\": \"1234\"})),"},{"line_number":75,"context_line":"        (\"2.19\", type(\"InstanceID\", (object, ), {\"id\": \"1234\"})),"},{"line_number":76,"context_line":"        (\"2.15\", type(\"InstanceID\", (object, ), {\"id\": \"1234\"})),"},{"line_number":77,"context_line":"        (\"2.19\", \"1234\"),"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_09e04928","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":69},"in_reply_to":"bacf61ea_6cb3e59a","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e5bc3732100d1c62bd29694c653210cbb8ce1d31","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class SnapshotInstancesTest(utils.TestCase):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        super(SnapshotInstancesTest, self).setUp()"},{"line_number":37,"context_line":"        microversion \u003d api_versions.APIVersion(\"2.19\")"}],"source_content_type":"text/x-python","patch_set":27,"id":"9ad45d7e_305e0e46","line":34,"updated":"2016-08-08 09:57:02.000000000","message":"Please add negative case, that it raises error if we use not supported microversion such as 2.18 or 2.0","commit_id":"d5e80aeb92781b222da9aa76de2fec5d09af8dca"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"471648fa68ad2c167fa51bebb1e9678b0530a90d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            url \u003d \u0027/snapshot-instances/detail\u0027"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            url \u003d \u0027/snapshot-instances\u0027"},{"line_number":60,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027, mock.Mock()):"},{"line_number":61,"context_line":"            self.manager.list(detailed\u003ddetailed, snapshot\u003d\u0027snapshot_id\u0027)"},{"line_number":62,"context_line":"            self.manager._list.assert_called_once_with("},{"line_number":63,"context_line":"                (url + \u0027?snapshot_id\u003dsnapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_62af652a","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":67},"updated":"2016-08-11 09:20:42.000000000","message":"Instead of this you can used \"self.mock_object\" [1] approach, the same as in manila project.\n\n[1] https://github.com/openstack/python-manilaclient/blob/997cc434/manilaclient/tests/unit/utils.py#L37","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8b0557a5b3a33333de6237f60efaa2b39b36136d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            url \u003d \u0027/snapshot-instances/detail\u0027"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            url \u003d \u0027/snapshot-instances\u0027"},{"line_number":60,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027, mock.Mock()):"},{"line_number":61,"context_line":"            self.manager.list(detailed\u003ddetailed, snapshot\u003d\u0027snapshot_id\u0027)"},{"line_number":62,"context_line":"            self.manager._list.assert_called_once_with("},{"line_number":63,"context_line":"                (url + \u0027?snapshot_id\u003dsnapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_aed3ffd3","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":67},"in_reply_to":"9ad45d7e_62af652a","updated":"2016-08-11 13:11:56.000000000","message":"Done","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e0ecf14b608c88c5ad6b7a3bbd1b9fa4d449acab","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            url \u003d \u0027/snapshot-instances/detail\u0027"},{"line_number":58,"context_line":"        else:"},{"line_number":59,"context_line":"            url \u003d \u0027/snapshot-instances\u0027"},{"line_number":60,"context_line":"        with mock.patch.object(self.manager, \u0027_list\u0027, mock.Mock()):"},{"line_number":61,"context_line":"            self.manager.list(detailed\u003ddetailed, snapshot\u003d\u0027snapshot_id\u0027)"},{"line_number":62,"context_line":"            self.manager._list.assert_called_once_with("},{"line_number":63,"context_line":"                (url + \u0027?snapshot_id\u003dsnapshot_id\u0027),"}],"source_content_type":"text/x-python","patch_set":29,"id":"9ad45d7e_fd5f74e2","line":60,"range":{"start_line":60,"start_character":8,"end_line":60,"end_character":67},"in_reply_to":"9ad45d7e_62af652a","updated":"2016-08-11 09:21:35.000000000","message":"s/used/use/","commit_id":"e3cdb1aa5b159e9a2d1ef6a0c34451b2d8c27b92"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8fcf75f8c5245e3e861c53842888c612e552584d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manilaclient.v2 import share_snapshot_instances"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"extensions \u003d ["},{"line_number":28,"context_line":"    extension.Extension(\u0027share_snapshot_instances\u0027, share_snapshot_instances),"},{"line_number":29,"context_line":"]"},{"line_number":30,"context_line":"cs \u003d fakes.FakeClient(extensions\u003dextensions)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":33,"id":"3ac371cc_2d6875ba","line":30,"range":{"start_line":27,"start_character":0,"end_line":30,"end_character":44},"updated":"2016-08-14 00:55:26.000000000","message":"this isn\u0027t an extension API..","commit_id":"5f20e4f6333db6f9e3468df5233179d51e331e20"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"51455d3deb065c0fd151400c88f6eec51a91660f","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        self.assert_called("},{"line_number":1827,"context_line":"            \u0027POST\u0027, \u0027/share-replicas/1234/action\u0027,"},{"line_number":1828,"context_line":"            body\u003d{action_name: {attr: \u0027xyzzyspoon!\u0027}})"},{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"    def test_snapshot_instance_list_all(self):"},{"line_number":1831,"context_line":"        self.run_command(\u0027snapshot-instance-list\u0027)"},{"line_number":1832,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshot-instances\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_e5f671f8","line":1829,"updated":"2016-08-02 14:23:33.000000000","message":"snapshot-instance-list --columns ?","commit_id":"488a83b0d3c93428ac90e34942bd08c0213801d9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"29fac02ed53d7bea595bf26716ccce6d45f72d53","unresolved":false,"context_lines":[{"line_number":1836,"context_line":"        fsnapshot \u003d type(\u0027FakeSansphot\u0027, (object,),"},{"line_number":1837,"context_line":"                         {\u0027id\u0027: \u0027fake-snapshot-id\u0027})"},{"line_number":1838,"context_line":"        shell_v2._find_share_snapshot.return_value \u003d fsnapshot"},{"line_number":1839,"context_line":"        cmd \u003d \u0027snapshot_instance-list --snapshot-id %s\u0027"},{"line_number":1840,"context_line":"        self.run_command(cmd % fsnapshot.id)"},{"line_number":1841,"context_line":""},{"line_number":1842,"context_line":"        self.assert_called("}],"source_content_type":"text/x-python","patch_set":21,"id":"bacf61ea_055efa44","line":1839,"range":{"start_line":1839,"start_character":23,"end_line":1839,"end_character":24},"updated":"2016-08-03 09:09:55.000000000","message":"s/_/-/","commit_id":"488a83b0d3c93428ac90e34942bd08c0213801d9"}],"manilaclient/v2/share_snapshot_instances.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class ShareSnapshotInstance(common_base.Resource):"},{"line_number":22,"context_line":"    \"\"\"A share is an extra block level storage to the OpenStack instances.\"\"\""},{"line_number":23,"context_line":"    def __repr__(self):"},{"line_number":24,"context_line":"        return \"\u003cSnapshot: %s\u003e\" % self.id"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def reset_state(self, state):"},{"line_number":27,"context_line":"        \"\"\"Update snapshot instance\u0027s \u0027status\u0027 attr with the provided state.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_f6d17acd","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":25},"updated":"2016-05-05 14:13:40.000000000","message":"It should be \"SnapshotInstance\".","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class ShareSnapshotInstance(common_base.Resource):"},{"line_number":22,"context_line":"    \"\"\"A share is an extra block level storage to the OpenStack instances.\"\"\""},{"line_number":23,"context_line":"    def __repr__(self):"},{"line_number":24,"context_line":"        return \"\u003cSnapshot: %s\u003e\" % self.id"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def reset_state(self, state):"},{"line_number":27,"context_line":"        \"\"\"Update snapshot instance\u0027s \u0027status\u0027 attr with the provided state.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_cdf67c8e","line":24,"range":{"start_line":24,"start_character":17,"end_line":24,"end_character":25},"in_reply_to":"1a122d0e_f6d17acd","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \"\u003cSnapshot: %s\u003e\" % self.id"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def reset_state(self, state):"},{"line_number":27,"context_line":"        \"\"\"Update snapshot instance\u0027s \u0027status\u0027 attr with the provided state.\"\"\""},{"line_number":28,"context_line":"        self.manager.reset_state(self, state)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_36ff7235","line":27,"range":{"start_line":27,"start_character":39,"end_line":27,"end_character":45},"updated":"2016-05-05 14:13:40.000000000","message":"\"status\", \"state\" above. Please, be consistent.","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        return \"\u003cSnapshot: %s\u003e\" % self.id"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def reset_state(self, state):"},{"line_number":27,"context_line":"        \"\"\"Update snapshot instance\u0027s \u0027status\u0027 attr with the provided state.\"\"\""},{"line_number":28,"context_line":"        self.manager.reset_state(self, state)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_8d00f467","line":27,"range":{"start_line":27,"start_character":39,"end_line":27,"end_character":45},"in_reply_to":"1a122d0e_36ff7235","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareSnapshotInstanceManager(base.ManagerWithFind):"},{"line_number":32,"context_line":"    \"\"\"Manage :class:`ShareInstances` resources.\"\"\""},{"line_number":33,"context_line":"    resource_class \u003d ShareSnapshotInstance"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_56b02e8b","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":27},"updated":"2016-05-05 14:13:40.000000000","message":"s/Share/Snapshot/","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class ShareSnapshotInstanceManager(base.ManagerWithFind):"},{"line_number":32,"context_line":"    \"\"\"Manage :class:`ShareInstances` resources.\"\"\""},{"line_number":33,"context_line":"    resource_class \u003d ShareSnapshotInstance"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, instance):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_adfb387a","line":32,"range":{"start_line":32,"start_character":22,"end_line":32,"end_character":27},"in_reply_to":"1a122d0e_56b02e8b","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    resource_class \u003d ShareSnapshotInstance"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, instance):"},{"line_number":36,"context_line":"        \"\"\"Get a share instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance: either share snapshot object or text with its ID."},{"line_number":39,"context_line":"        :rtype: :class:`ShareSnapshotInstance`"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_169b5618","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":22},"updated":"2016-05-05 14:13:40.000000000","message":"s/share/snapshot/","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    resource_class \u003d ShareSnapshotInstance"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, instance):"},{"line_number":36,"context_line":"        \"\"\"Get a share instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance: either share snapshot object or text with its ID."},{"line_number":39,"context_line":"        :rtype: :class:`ShareSnapshotInstance`"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_cd3ddc2c","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":22},"in_reply_to":"1a122d0e_169b5618","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def get(self, instance):"},{"line_number":36,"context_line":"        \"\"\"Get a share instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance: either share snapshot object or text with its ID."},{"line_number":39,"context_line":"        :rtype: :class:`ShareSnapshotInstance`"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        snapshot_instance_id \u003d common_base.getid(instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_b6670224","line":38,"range":{"start_line":38,"start_character":32,"end_line":38,"end_character":53},"updated":"2016-05-05 14:13:40.000000000","message":"snapshot instance object","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def get(self, instance):"},{"line_number":36,"context_line":"        \"\"\"Get a share instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance: either share snapshot object or text with its ID."},{"line_number":39,"context_line":"        :rtype: :class:`ShareSnapshotInstance`"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        snapshot_instance_id \u003d common_base.getid(instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_ed40a0a7","line":38,"range":{"start_line":38,"start_character":32,"end_line":38,"end_character":53},"in_reply_to":"1a122d0e_b6670224","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @api_versions.wraps(\"2.16\")"},{"line_number":46,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"List all share instances.\"\"\""},{"line_number":48,"context_line":"        if snapshot:"},{"line_number":49,"context_line":"            snapshot_id \u003d \u0027?snapshot_id\u003d\u0027 + common_base.getid(snapshot)"},{"line_number":50,"context_line":"            url \u003d \u0027/share-snapshot-instances\u0027 + snapshot_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_367492cd","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":35},"updated":"2016-05-05 14:13:40.000000000","message":"ditto","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @api_versions.wraps(\"2.16\")"},{"line_number":46,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"List all share instances.\"\"\""},{"line_number":48,"context_line":"        if snapshot:"},{"line_number":49,"context_line":"            snapshot_id \u003d \u0027?snapshot_id\u003d\u0027 + common_base.getid(snapshot)"},{"line_number":50,"context_line":"            url \u003d \u0027/share-snapshot-instances\u0027 + snapshot_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_cd52fc66","line":47,"range":{"start_line":47,"start_character":20,"end_line":47,"end_character":35},"in_reply_to":"1a122d0e_367492cd","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @api_versions.wraps(\"2.16\")"},{"line_number":46,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"List all share instances.\"\"\""},{"line_number":48,"context_line":"        if snapshot:"},{"line_number":49,"context_line":"            snapshot_id \u003d \u0027?snapshot_id\u003d\u0027 + common_base.getid(snapshot)"},{"line_number":50,"context_line":"            url \u003d \u0027/share-snapshot-instances\u0027 + snapshot_id"},{"line_number":51,"context_line":"            return self._list(url, \u0027share_snapshot_instances\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            return self._list(\u0027/share-snapshot-instances\u0027,"},{"line_number":54,"context_line":"                              \u0027share_snapshot_instances\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @api_versions.wraps(\"2.16\")"},{"line_number":57,"context_line":"    def reset_state(self, instance, state):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_962be694","line":54,"range":{"start_line":48,"start_character":8,"end_line":54,"end_character":57},"updated":"2016-05-05 14:13:40.000000000","message":"url \u003d \u0027/share-snapshot-instances\u0027\nif snapshot:\n    url +\u003d \u0027?snapshot_id\u003d%s\u0027 % common_base.getid(snapshot)\nreturn self._list(url, \u0027share_snapshot_instances\u0027)","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @api_versions.wraps(\"2.16\")"},{"line_number":46,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":47,"context_line":"        \"\"\"List all share instances.\"\"\""},{"line_number":48,"context_line":"        if snapshot:"},{"line_number":49,"context_line":"            snapshot_id \u003d \u0027?snapshot_id\u003d\u0027 + common_base.getid(snapshot)"},{"line_number":50,"context_line":"            url \u003d \u0027/share-snapshot-instances\u0027 + snapshot_id"},{"line_number":51,"context_line":"            return self._list(url, \u0027share_snapshot_instances\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            return self._list(\u0027/share-snapshot-instances\u0027,"},{"line_number":54,"context_line":"                              \u0027share_snapshot_instances\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @api_versions.wraps(\"2.16\")"},{"line_number":57,"context_line":"    def reset_state(self, instance, state):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_8d5c747e","line":54,"range":{"start_line":48,"start_character":8,"end_line":54,"end_character":57},"in_reply_to":"1a122d0e_962be694","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\"Reset the \u0027status\u0027 attr of the snapshot instance."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param instance: either snapshot instance object or its UUID."},{"line_number":61,"context_line":"        :param state: state to set the replica\u0027s \u0027status\u0027 attr to."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        return self._action(\"reset_status\", instance, {\"status\": state})"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_160eb63c","line":61,"range":{"start_line":61,"start_character":39,"end_line":61,"end_character":46},"updated":"2016-05-05 14:13:40.000000000","message":"replica?","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\"Reset the \u0027status\u0027 attr of the snapshot instance."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        :param instance: either snapshot instance object or its UUID."},{"line_number":61,"context_line":"        :param state: state to set the replica\u0027s \u0027status\u0027 attr to."},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        return self._action(\"reset_status\", instance, {\"status\": state})"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_ed554050","line":61,"range":{"start_line":61,"start_character":39,"end_line":61,"end_character":46},"in_reply_to":"1a122d0e_160eb63c","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"431b69a35c3629a2a073ed18e9570fb6ef8c385f","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ShareSnapshotInstance(common_base.Resource):"},{"line_number":22,"context_line":"    \"\"\"A share is an extra block level storage to the OpenStack instances.\"\"\""},{"line_number":23,"context_line":"    def __repr__(self):"},{"line_number":24,"context_line":"        return \"\u003cSnapshotInstance: %s\u003e\" % self.id"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_59f07dfe","line":22,"updated":"2016-07-30 01:19:36.000000000","message":"Please change this to the snapshot instance resource description.","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ec06186ca5252135e27406493be9d396cfa7969","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ShareSnapshotInstance(common_base.Resource):"},{"line_number":22,"context_line":"    \"\"\"A share is an extra block level storage to the OpenStack instances.\"\"\""},{"line_number":23,"context_line":"    def __repr__(self):"},{"line_number":24,"context_line":"        return \"\u003cSnapshotInstance: %s\u003e\" % self.id"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_998675d9","line":22,"in_reply_to":"bacf61ea_59f07dfe","updated":"2016-07-30 02:19:18.000000000","message":"Done","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d78e9054f21cf0f984935291e21dfe19623a036d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Manage :class:`SnapshotInstances` resources.\"\"\""},{"line_number":33,"context_line":"    resource_class \u003d ShareSnapshotInstance"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, instance):"},{"line_number":36,"context_line":"        \"\"\"Get a snapshot instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance: either snapshot instance object or text with its ID."}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_ccb15f49","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":28},"updated":"2016-07-29 16:28:06.000000000","message":"Should be microversioned too.","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ec06186ca5252135e27406493be9d396cfa7969","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \"\"\"Manage :class:`SnapshotInstances` resources.\"\"\""},{"line_number":33,"context_line":"    resource_class \u003d ShareSnapshotInstance"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, instance):"},{"line_number":36,"context_line":"        \"\"\"Get a snapshot instance."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param instance: either snapshot instance object or text with its ID."}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_99f675f7","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":28},"in_reply_to":"bacf61ea_ccb15f49","updated":"2016-07-30 02:19:18.000000000","message":"Done","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"431b69a35c3629a2a073ed18e9570fb6ef8c385f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\"Reset the \u0027status\u0027 attr of the snapshot instance."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :param instance: either snapshot instance object or its UUID."},{"line_number":58,"context_line":"        :param state: state to set the snapshot instance\u0027s \u0027state\u0027 attr to."},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        return self._action(\"reset_status\", instance, {\"status\": state})"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_f9c69198","line":58,"range":{"start_line":58,"start_character":60,"end_line":58,"end_character":65},"updated":"2016-07-30 01:19:36.000000000","message":"status","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ec06186ca5252135e27406493be9d396cfa7969","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\"Reset the \u0027status\u0027 attr of the snapshot instance."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        :param instance: either snapshot instance object or its UUID."},{"line_number":58,"context_line":"        :param state: state to set the snapshot instance\u0027s \u0027state\u0027 attr to."},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        return self._action(\"reset_status\", instance, {\"status\": state})"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_f96fb128","line":58,"range":{"start_line":58,"start_character":60,"end_line":58,"end_character":65},"in_reply_to":"bacf61ea_f9c69198","updated":"2016-07-30 02:19:18.000000000","message":"Done","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5133b1c27d5f37f02f76704ac721ff0b22468550","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ShareSnapshotInstance(common_base.Resource):"},{"line_number":22,"context_line":"    \"\"\"A snapshot instance is instance of a snapshot.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __repr__(self):"},{"line_number":25,"context_line":"        return \"\u003cSnapshotInstance: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_8c0b957c","line":22,"range":{"start_line":22,"start_character":27,"end_line":22,"end_character":38},"updated":"2016-08-01 17:14:25.000000000","message":"is an instance","commit_id":"93e43131cf3b216f5def5360d3e218c3a2ad423c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"cbc1aeb46e09d8753abb655a72b1bebc1c2dbe75","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ShareSnapshotInstance(common_base.Resource):"},{"line_number":22,"context_line":"    \"\"\"A snapshot instance is instance of a snapshot.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __repr__(self):"},{"line_number":25,"context_line":"        return \"\u003cSnapshotInstance: %s\u003e\" % self.id"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_834231ac","line":22,"range":{"start_line":22,"start_character":27,"end_line":22,"end_character":38},"in_reply_to":"bacf61ea_8c0b957c","updated":"2016-08-02 01:18:57.000000000","message":"Done","commit_id":"93e43131cf3b216f5def5360d3e218c3a2ad423c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"05f611de54acaa54b6faf63674d5098dfd80e88f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \"snapshot_instance\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":48,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"List all snapshot instances.\"\"\""},{"line_number":50,"context_line":"        url \u003d \u0027/snapshot-instances\u0027"},{"line_number":51,"context_line":"        if snapshot:"},{"line_number":52,"context_line":"            url +\u003d \u0027?snapshot_id\u003d%s\u0027 % common_base.getid(snapshot)"},{"line_number":53,"context_line":"        return self._list(url, \u0027snapshot_instances\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":56,"context_line":"    def reset_state(self, instance, state):"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_1ed9dd57","line":53,"range":{"start_line":48,"start_character":4,"end_line":53,"end_character":52},"updated":"2016-08-04 13:31:13.000000000","message":"Please, add support of \"detail\" as it is done in shares [1].\n\nThen, cover it with shell command.\n\n[1] https://github.com/openstack/python-manilaclient/blob/8c2f3c3a/manilaclient/v2/shares.py#L376","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e771ba4e4b9b7ead0c2cc4737ae7acc313e206ee","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \"snapshot_instance\")"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":48,"context_line":"    def list(self, snapshot\u003dNone):"},{"line_number":49,"context_line":"        \"\"\"List all snapshot instances.\"\"\""},{"line_number":50,"context_line":"        url \u003d \u0027/snapshot-instances\u0027"},{"line_number":51,"context_line":"        if snapshot:"},{"line_number":52,"context_line":"            url +\u003d \u0027?snapshot_id\u003d%s\u0027 % common_base.getid(snapshot)"},{"line_number":53,"context_line":"        return self._list(url, \u0027snapshot_instances\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":56,"context_line":"    def reset_state(self, instance, state):"}],"source_content_type":"text/x-python","patch_set":24,"id":"bacf61ea_cedb0c7b","line":53,"range":{"start_line":48,"start_character":4,"end_line":53,"end_character":52},"in_reply_to":"bacf61ea_1ed9dd57","updated":"2016-08-04 16:10:22.000000000","message":"Done","commit_id":"4667279d8b3bbf608004bbaaa0c94fbe584004c8"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"    \u0027--snapshot\u0027,"},{"line_number":1747,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1748,"context_line":"    default\u003dNone,"},{"line_number":1749,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1750,"context_line":"    help\u003d\u0027Filter results by share snapshot ID.\u0027)"},{"line_number":1751,"context_line":"def do_snapshot_instance_list(cs, args):"},{"line_number":1752,"context_line":"    \"\"\"List share snapshot instances.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_1b789f7d","line":1749,"range":{"start_line":1749,"start_character":4,"end_line":1749,"end_character":26},"updated":"2016-05-05 14:13:40.000000000","message":"It is redundant. This arg does not have aliases.","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":1746,"context_line":"    \u0027--snapshot\u0027,"},{"line_number":1747,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":1748,"context_line":"    default\u003dNone,"},{"line_number":1749,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1750,"context_line":"    help\u003d\u0027Filter results by share snapshot ID.\u0027)"},{"line_number":1751,"context_line":"def do_snapshot_instance_list(cs, args):"},{"line_number":1752,"context_line":"    \"\"\"List share snapshot instances.\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_8028bb34","line":1749,"range":{"start_line":1749,"start_character":4,"end_line":1749,"end_character":26},"in_reply_to":"1a122d0e_1b789f7d","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":1765,"context_line":"@cliutils.arg("},{"line_number":1766,"context_line":"    \u0027snapshot_instance\u0027,"},{"line_number":1767,"context_line":"    metavar\u003d\u0027\u003csnapshot_instance\u003e\u0027,"},{"line_number":1768,"context_line":"    help\u003d\u0027Name or ID of the share snapshot instance.\u0027)"},{"line_number":1769,"context_line":"def do_snapshot_instance_show(cs, args):"},{"line_number":1770,"context_line":"    \"\"\"Show details about a share snapshot instance.\"\"\""},{"line_number":1771,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_5bc4d790","line":1768,"range":{"start_line":1768,"start_character":10,"end_line":1768,"end_character":18},"updated":"2016-05-05 14:13:40.000000000","message":"It does not have name.","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":1765,"context_line":"@cliutils.arg("},{"line_number":1766,"context_line":"    \u0027snapshot_instance\u0027,"},{"line_number":1767,"context_line":"    metavar\u003d\u0027\u003csnapshot_instance\u003e\u0027,"},{"line_number":1768,"context_line":"    help\u003d\u0027Name or ID of the share snapshot instance.\u0027)"},{"line_number":1769,"context_line":"def do_snapshot_instance_show(cs, args):"},{"line_number":1770,"context_line":"    \"\"\"Show details about a share snapshot instance.\"\"\""},{"line_number":1771,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance("}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_0015ebe3","line":1768,"range":{"start_line":1768,"start_character":10,"end_line":1768,"end_character":18},"in_reply_to":"1a122d0e_5bc4d790","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"72a98363fd6a40204342cb54de60c14fb7ab5f21","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"          \u0027will be used.\u0027))"},{"line_number":1788,"context_line":"@api_versions.wraps(\"2.16\")"},{"line_number":1789,"context_line":"def do_snapshot_instance_reset_state(cs, args):"},{"line_number":1790,"context_line":"    \"\"\"Explicitly update the \u0027status\u0027 of a share snapshot instances.\"\"\""},{"line_number":1791,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance("},{"line_number":1792,"context_line":"        cs, args.snapshot_instance)"},{"line_number":1793,"context_line":"    snapshot_instance.reset_state(args.state)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_dba0e7a7","line":1790,"range":{"start_line":1790,"start_character":30,"end_line":1790,"end_character":36},"updated":"2016-05-05 14:13:40.000000000","message":"Arg is called \"--state\", but here you say \"status\".","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"624e587cfdb1a806e42f58961d1aebf4d857e66c","unresolved":false,"context_lines":[{"line_number":1787,"context_line":"          \u0027will be used.\u0027))"},{"line_number":1788,"context_line":"@api_versions.wraps(\"2.16\")"},{"line_number":1789,"context_line":"def do_snapshot_instance_reset_state(cs, args):"},{"line_number":1790,"context_line":"    \"\"\"Explicitly update the \u0027status\u0027 of a share snapshot instances.\"\"\""},{"line_number":1791,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance("},{"line_number":1792,"context_line":"        cs, args.snapshot_instance)"},{"line_number":1793,"context_line":"    snapshot_instance.reset_state(args.state)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_60895726","line":1790,"range":{"start_line":1790,"start_character":30,"end_line":1790,"end_character":36},"in_reply_to":"1a122d0e_dba0e7a7","updated":"2016-05-16 07:15:39.000000000","message":"Done","commit_id":"f6952ef4173d8fc145c3c578c1255bb7cccc527d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ec2a33c3b0c95fe76395dd0dd0c5b410d7cf5d3d","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"def _print_share_snapshot_instance(cs, snapshot_instance):"},{"line_number":224,"context_line":"    info \u003d snapshot_instance._info.copy()"},{"line_number":225,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":226,"context_line":"    cliutils.print_dict(info)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_355529c6","line":225,"range":{"start_line":224,"start_character":4,"end_line":225,"end_character":27},"updated":"2016-07-23 17:49:38.000000000","message":"isn\u0027t it possible to use the original info without creating a copy?","commit_id":"b47f9a32e8af1c4698671871ce26281a978b9750"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e706f8fa464895de9c79459e2d4eda020044ebe2","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"def _print_share_snapshot_instance(cs, snapshot_instance):"},{"line_number":224,"context_line":"    info \u003d snapshot_instance._info.copy()"},{"line_number":225,"context_line":"    info.pop(\u0027links\u0027, None)"},{"line_number":226,"context_line":"    cliutils.print_dict(info)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dada55a8_fc03350e","line":225,"range":{"start_line":224,"start_character":4,"end_line":225,"end_character":27},"in_reply_to":"dada55a8_355529c6","updated":"2016-07-26 02:55:25.000000000","message":"Done","commit_id":"b47f9a32e8af1c4698671871ce26281a978b9750"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d78e9054f21cf0f984935291e21dfe19623a036d","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1565,"context_line":"    help\u003d\u0027Sort direction, available values are %(values)s. \u0027"},{"line_number":1566,"context_line":"         \u0027OPTIONAL: Default\u003dNone.\u0027 % {\u0027values\u0027: constants.SORT_DIR_VALUES})"},{"line_number":1567,"context_line":"@cliutils.arg("},{"line_number":1568,"context_line":"    \u0027--columns\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003ccolumns\u003e\u0027,"},{"line_number":1570,"context_line":"    type\u003dstr,"},{"line_number":1571,"context_line":"    default\u003dNone,"},{"line_number":1572,"context_line":"    help\u003d\u0027Comma separated list of columns to be displayed \u0027"},{"line_number":1573,"context_line":"         \u0027e.g. --columns \"id,name\"\u0027)"},{"line_number":1574,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":1575,"context_line":"    \"\"\"List all the snapshots.\"\"\""},{"line_number":1576,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_2cd75b4c","line":1573,"range":{"start_line":1567,"start_character":0,"end_line":1573,"end_character":36},"updated":"2016-07-29 16:28:06.000000000","message":"You may want to reuse this argument for your newly implemented \"list\" command.","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ec06186ca5252135e27406493be9d396cfa7969","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":1565,"context_line":"    help\u003d\u0027Sort direction, available values are %(values)s. \u0027"},{"line_number":1566,"context_line":"         \u0027OPTIONAL: Default\u003dNone.\u0027 % {\u0027values\u0027: constants.SORT_DIR_VALUES})"},{"line_number":1567,"context_line":"@cliutils.arg("},{"line_number":1568,"context_line":"    \u0027--columns\u0027,"},{"line_number":1569,"context_line":"    metavar\u003d\u0027\u003ccolumns\u003e\u0027,"},{"line_number":1570,"context_line":"    type\u003dstr,"},{"line_number":1571,"context_line":"    default\u003dNone,"},{"line_number":1572,"context_line":"    help\u003d\u0027Comma separated list of columns to be displayed \u0027"},{"line_number":1573,"context_line":"         \u0027e.g. --columns \"id,name\"\u0027)"},{"line_number":1574,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":1575,"context_line":"    \"\"\"List all the snapshots.\"\"\""},{"line_number":1576,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_790741ca","line":1573,"range":{"start_line":1567,"start_character":0,"end_line":1573,"end_character":36},"in_reply_to":"bacf61ea_2cd75b4c","updated":"2016-07-30 02:19:18.000000000","message":"Done","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"431b69a35c3629a2a073ed18e9570fb6ef8c385f","unresolved":false,"context_lines":[{"line_number":1760,"context_line":"                if args.snapshot else None)"},{"line_number":1761,"context_line":""},{"line_number":1762,"context_line":"    list_of_keys \u003d ["},{"line_number":1763,"context_line":"        \u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027"},{"line_number":1764,"context_line":"    ]"},{"line_number":1765,"context_line":"    instances \u003d cs.share_snapshot_instances.list(snapshot)"},{"line_number":1766,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_f9433140","line":1763,"updated":"2016-07-30 01:19:36.000000000","message":"Suggest adding \u0027Host\u0027, \u0027Availability Zone\u0027.\nAnd will this API list the snapshot instances for replicated?\nIf it is, also displaying the replica info which snapshot instances belong to would be better.","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ec06186ca5252135e27406493be9d396cfa7969","unresolved":false,"context_lines":[{"line_number":1760,"context_line":"                if args.snapshot else None)"},{"line_number":1761,"context_line":""},{"line_number":1762,"context_line":"    list_of_keys \u003d ["},{"line_number":1763,"context_line":"        \u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027"},{"line_number":1764,"context_line":"    ]"},{"line_number":1765,"context_line":"    instances \u003d cs.share_snapshot_instances.list(snapshot)"},{"line_number":1766,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_446b7485","line":1763,"in_reply_to":"bacf61ea_f9433140","updated":"2016-07-30 02:19:18.000000000","message":"Hi yingzhe, the snapshot instance list command only need to show the simple attr. If you want to see the more details, you could use \u0027manila snapshot-instance-show \u0027or \u0027manila snapshot-show\u0027 or \u0027manila show \u003cshare\u003e\u0027 to see most of the information. \nIf we add \u0027Host\u0027, \u0027Availability Zone\u0027, sounds like we need to add more and more information. \nLater Goutham Pacha Ravi will do something about replica snapshot instances.\n\nThanks for your review","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"be13488382ef52507b30c7b00bd1f30b616c2393","unresolved":false,"context_lines":[{"line_number":1797,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance("},{"line_number":1798,"context_line":"        cs, args.snapshot_instance)"},{"line_number":1799,"context_line":"    snapshot_instance.reset_state(args.state)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"@cliutils.arg("},{"line_number":1803,"context_line":"    \u0027share\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_6c9cb35d","line":1800,"updated":"2016-07-29 16:28:40.000000000","message":"Why force-delete is not added?","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ec06186ca5252135e27406493be9d396cfa7969","unresolved":false,"context_lines":[{"line_number":1797,"context_line":"    snapshot_instance \u003d _find_share_snapshot_instance("},{"line_number":1798,"context_line":"        cs, args.snapshot_instance)"},{"line_number":1799,"context_line":"    snapshot_instance.reset_state(args.state)"},{"line_number":1800,"context_line":""},{"line_number":1801,"context_line":""},{"line_number":1802,"context_line":"@cliutils.arg("},{"line_number":1803,"context_line":"    \u0027share\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_b96c19d1","line":1800,"in_reply_to":"bacf61ea_6c9cb35d","updated":"2016-07-30 02:19:18.000000000","message":"I discussed this with Goutham Pacha Ravi, please see https://review.openstack.org/#/c/234658/, patch 66 comment.","commit_id":"1ea649f2c2913b32e2c803991ad0aacb360879b0"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9835489001e2bf95fcd40c8cb1ddffd8d0cfbf3f","unresolved":false,"context_lines":[{"line_number":1760,"context_line":"    type\u003dstr,"},{"line_number":1761,"context_line":"    default\u003dNone,"},{"line_number":1762,"context_line":"    help\u003d\u0027Comma separated list of columns to be displayed \u0027"},{"line_number":1763,"context_line":"         \u0027e.g. --columns \"id,name\"\u0027)"},{"line_number":1764,"context_line":"def do_snapshot_instance_list(cs, args):"},{"line_number":1765,"context_line":"    \"\"\"List share snapshot instances.\"\"\""},{"line_number":1766,"context_line":"    snapshot \u003d (_find_share_snapshot(cs, args.snapshot)"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_3c33d063","line":1763,"range":{"start_line":1763,"start_character":28,"end_line":1763,"end_character":33},"updated":"2016-08-01 10:08:01.000000000","message":"Snapshot instances do not have names.","commit_id":"f545d4e5a7a7100f5f71048934df6f080381991a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"85c71971e385eb47add961a00352ed7e56de0c4a","unresolved":false,"context_lines":[{"line_number":1760,"context_line":"    type\u003dstr,"},{"line_number":1761,"context_line":"    default\u003dNone,"},{"line_number":1762,"context_line":"    help\u003d\u0027Comma separated list of columns to be displayed \u0027"},{"line_number":1763,"context_line":"         \u0027e.g. --columns \"id,name\"\u0027)"},{"line_number":1764,"context_line":"def do_snapshot_instance_list(cs, args):"},{"line_number":1765,"context_line":"    \"\"\"List share snapshot instances.\"\"\""},{"line_number":1766,"context_line":"    snapshot \u003d (_find_share_snapshot(cs, args.snapshot)"}],"source_content_type":"text/x-python","patch_set":18,"id":"bacf61ea_dc9b9416","line":1763,"range":{"start_line":1763,"start_character":28,"end_line":1763,"end_character":33},"in_reply_to":"bacf61ea_3c33d063","updated":"2016-08-01 10:11:34.000000000","message":"Done","commit_id":"f545d4e5a7a7100f5f71048934df6f080381991a"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0d9e418013a837ce8233b5bec0075a9eacc1229d","unresolved":false,"context_lines":[{"line_number":1771,"context_line":"    \"\"\"List share snapshot instances.\"\"\""},{"line_number":1772,"context_line":"    snapshot \u003d (_find_share_snapshot(cs, args.snapshot)"},{"line_number":1773,"context_line":"                if args.snapshot else None)"},{"line_number":1774,"context_line":"    if args.detailed:"},{"line_number":1775,"context_line":"        list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":1776,"context_line":"                        \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":1777,"context_line":"                        \u0027Progress\u0027, \u0027Provider_location\u0027]"},{"line_number":1778,"context_line":"    else:"},{"line_number":1779,"context_line":"        list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027]"},{"line_number":1780,"context_line":"    if args.columns is not None:"},{"line_number":1781,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    instances \u003d cs.share_snapshot_instances.list("},{"line_number":1784,"context_line":"        detailed\u003dargs.detailed, snapshot\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_6cc76598","line":1781,"range":{"start_line":1774,"start_character":4,"end_line":1781,"end_character":59},"updated":"2016-08-05 09:56:38.000000000","message":"In case you use detailed\u003dTrue and columns you do redundant actions,\nneed to rewrite it to something like following:\n\"\"\"\n    if args.columns is not None:\n        list_of_keys \u003d _split_columns(columns\u003dargs.columns)\n    elif args.detailed:\n        list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,\n                        \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,\n                        \u0027Progress\u0027, \u0027Provider_location\u0027]\n    else:\n        list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027]\n\n\"\"\"","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"fb78cf31a2f4cc18a6770c4adf8bf511cac60f99","unresolved":false,"context_lines":[{"line_number":1771,"context_line":"    \"\"\"List share snapshot instances.\"\"\""},{"line_number":1772,"context_line":"    snapshot \u003d (_find_share_snapshot(cs, args.snapshot)"},{"line_number":1773,"context_line":"                if args.snapshot else None)"},{"line_number":1774,"context_line":"    if args.detailed:"},{"line_number":1775,"context_line":"        list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":1776,"context_line":"                        \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":1777,"context_line":"                        \u0027Progress\u0027, \u0027Provider_location\u0027]"},{"line_number":1778,"context_line":"    else:"},{"line_number":1779,"context_line":"        list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027]"},{"line_number":1780,"context_line":"    if args.columns is not None:"},{"line_number":1781,"context_line":"        list_of_keys \u003d _split_columns(columns\u003dargs.columns)"},{"line_number":1782,"context_line":""},{"line_number":1783,"context_line":"    instances \u003d cs.share_snapshot_instances.list("},{"line_number":1784,"context_line":"        detailed\u003dargs.detailed, snapshot\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":26,"id":"bacf61ea_493361f6","line":1781,"range":{"start_line":1774,"start_character":4,"end_line":1781,"end_character":59},"in_reply_to":"bacf61ea_6cc76598","updated":"2016-08-05 15:30:26.000000000","message":"Done","commit_id":"5f54decd54b488290dc2fff853ae580f14ee1ee0"}],"releasenotes/notes/add-snapshot-instances-admin-api-3cf3114doe40k598.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"22ce1a502a96176a04302004b21ec589da32f57a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add list, show, and reset-status admin APIs for snapshot instances."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bacf61ea_3699a86f","line":3,"range":{"start_line":3,"start_character":43,"end_line":3,"end_character":47},"updated":"2016-08-03 12:57:32.000000000","message":"commands","commit_id":"e2e6f1f3c8de6cf7537b53bbdb7821016fc4d59b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ae3b2f878f19b9f58f8bd087b7327e012d7ee9b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add list, show, and reset-status admin APIs for snapshot instances."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"bacf61ea_6591a49a","line":3,"range":{"start_line":3,"start_character":43,"end_line":3,"end_character":47},"in_reply_to":"bacf61ea_3699a86f","updated":"2016-08-03 14:14:55.000000000","message":"Done","commit_id":"e2e6f1f3c8de6cf7537b53bbdb7821016fc4d59b"}]}
