)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e0926c67fdf183956f572b4dfdcebe19d735d209","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027manila list --all-tenants\u0027 command should show column Project ID."},{"line_number":10,"context_line":"Project/Tenant ownership of shares is vital information, e.g. when"},{"line_number":11,"context_line":"working project quota allocations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Non-admin form of this command, without the --all-tenants argument,"},{"line_number":14,"context_line":"is scoped to the project/tenant of the user issuing the command"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_cbaec280","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":7},"updated":"2016-05-03 13:04:10.000000000","message":"nit: working with","commit_id":"f550b93df25418afc27de2a4ee9872453b3a38b7"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e6e76e1f1589915b1ee257e09b3aa38622996d4f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Project/Tenant ownership of shares is vital information, e.g. when"},{"line_number":11,"context_line":"working with project quota allocations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Non-admin form of this command, without the --all-tenants argument,"},{"line_number":14,"context_line":"is scoped to the project/tenant of the user issuing the command"},{"line_number":15,"context_line":"so it would be redundant to display a column for this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Same fix has been put for snapshot-list too."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_7958fb56","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":53},"updated":"2016-05-04 12:00:17.000000000","message":"It is false. They also see \"public\" shares of other projects.","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f596f2554e9f2ecf96a88f7290d43b2710dab948","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Project/Tenant ownership of shares is vital information, e.g. when"},{"line_number":11,"context_line":"working with project quota allocations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Non-admin form of this command, without the --all-tenants argument,"},{"line_number":14,"context_line":"is scoped to the project/tenant of the user issuing the command"},{"line_number":15,"context_line":"so it would be redundant to display a column for this."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Same fix has been put for snapshot-list too."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_dda06ea8","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":53},"in_reply_to":"1a122d0e_7958fb56","updated":"2016-05-06 01:41:50.000000000","message":"I guess you should just update this commit message then","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0e2ea069d4aa71ce8f1860058c0e3293599fb2d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027manila list --all-tenants\u0027, \u0027manila list --public\u0027 both"},{"line_number":10,"context_line":"commands should show column Project ID. Project/Tenant ownership"},{"line_number":11,"context_line":"of shares is vital information, e.g. when working with project"},{"line_number":12,"context_line":"quota allocations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u0027manila list\u0027 doesn\u0027t show public shares of other projects."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dab17558_4d057f78","line":11,"updated":"2016-05-09 23:09:18.000000000","message":"Suggest:\n  Both \u0027manila list --all-tenants\u0027 and \u0027manila list --public\u0027 should show column Project ID.","commit_id":"3099169746b2588085327392f7a4075724ca52f4"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0e2ea069d4aa71ce8f1860058c0e3293599fb2d8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"quota allocations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u0027manila list\u0027 doesn\u0027t show public shares of other projects."},{"line_number":15,"context_line":"Without --all-tenants, without --public, result is scoped to"},{"line_number":16,"context_line":"the project/tenant of the user issuing the command."},{"line_number":17,"context_line":"so it would be redundant to display a column for this."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dab17558_c8a4bda7","line":15,"updated":"2016-05-09 23:09:18.000000000","message":"Suggest:\n  Without \u0027--all-tenants\u0027 and without \u0027--public\u0027 the result is scoped to ...","commit_id":"3099169746b2588085327392f7a4075724ca52f4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c980d469ab82756f4fa688e1009f79c01943830d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"is scoped to the project/tenant of the user issuing the command."},{"line_number":17,"context_line":"So, it would be redundant to display a column for this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Same fix has been put for snapshot-list too."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7afae542c391041d48c28e268ab59c83447bb940"},{"line_number":22,"context_line":"Closes-Bug: #1570085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bab6814e_8b7122ab","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":40},"updated":"2016-05-25 12:57:46.000000000","message":"nit: snapshot-list doesn\u0027t have --public argument because there\u0027s no concept of public snapshots..","commit_id":"7c500d8f203465529339f2327b8b65aadf043fe6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"0810fdf1496dce7ad58021b39a27d56fd0c05025","unresolved":false,"context_lines":[{"line_number":16,"context_line":"is scoped to the project/tenant of the user issuing the command."},{"line_number":17,"context_line":"So, it would be redundant to display a column for this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Same fix has been put for snapshot-list too."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7afae542c391041d48c28e268ab59c83447bb940"},{"line_number":22,"context_line":"Closes-Bug: #1570085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bab6814e_8b8642d9","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":40},"in_reply_to":"bab6814e_8b7122ab","updated":"2016-05-25 12:58:39.000000000","message":"it is said about snapshot-list --all-tenants","commit_id":"7c500d8f203465529339f2327b8b65aadf043fe6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5e865defcfcd70ac0ab8603eae8574c66933c5dd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"is scoped to the project/tenant of the user issuing the command."},{"line_number":17,"context_line":"So, it would be redundant to display a column for this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Same fix has been put for snapshot-list too."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7afae542c391041d48c28e268ab59c83447bb940"},{"line_number":22,"context_line":"Closes-Bug: #1570085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bab6814e_eb026e3d","line":19,"range":{"start_line":19,"start_character":26,"end_line":19,"end_character":40},"in_reply_to":"bab6814e_8b8642d9","updated":"2016-05-25 13:00:30.000000000","message":"yes.. it doesn\u0027t clarify that it\u0027s not for `--public` arg. it\u0027s a nit, i tried the command before reviewing the patch wondering if there was one.","commit_id":"7c500d8f203465529339f2327b8b65aadf043fe6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"81fca03bae05f4aa1c8f8c2e7c68866e2738df21","unresolved":false,"context_lines":[{"line_number":17,"context_line":"So, it would be redundant to display a column for this."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Same fix has been put for snapshot-list too."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I7afae542c391041d48c28e268ab59c83447bb940"},{"line_number":22,"context_line":"Closes-Bug: #1570085"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bab6814e_7f12ad0a","line":20,"updated":"2016-05-25 15:14:09.000000000","message":"Can you add a DocImpact flag?","commit_id":"7c500d8f203465529339f2327b8b65aadf043fe6"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6e26ec1233b5b6bdd713848ea29f39b250122bd","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                    \u0027k\u0027: self._stranslate_to_cli_optional_param(k), \u0027v\u0027: v}"},{"line_number":570,"context_line":"        if columns is not None:"},{"line_number":571,"context_line":"            cmd +\u003d \u0027--columns \u0027 + columns"},{"line_number":572,"context_line":"        if is_public:"},{"line_number":573,"context_line":"            cmd +\u003d \u0027--public\u0027"},{"line_number":574,"context_line":"        shares_raw \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":575,"context_line":"        shares \u003d utils.listing(shares_raw)"},{"line_number":576,"context_line":"        return shares"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_844ba286","line":573,"range":{"start_line":572,"start_character":8,"end_line":573,"end_character":29},"updated":"2016-05-16 11:37:53.000000000","message":"It will lead to failure if \"columns\" are set. Because space-separation is lost. Better to add it between line 565 and 566.","commit_id":"42ac80c846959e9f5a5711ba417b59abb2a68273"}],"manilaclient/tests/functional/test_shares_listing.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5167cbe82f26839da863f5dc789039f85b507ff7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_list_shares(self):"},{"line_number":154,"context_line":"        self._list_shares()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @ddt.data("},{"line_number":157,"context_line":"        {1, 0}"},{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    def test_list_shares_for_all_tenants(self, all_tenants):"},{"line_number":160,"context_line":"        print(\"NMH 1112 all_tenants is\", all_tenants)"},{"line_number":161,"context_line":"        shares \u003d self.user_client.list_shares(all_tenants\u003dall_tenants)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_9df1c6d0","line":158,"range":{"start_line":156,"start_character":4,"end_line":158,"end_character":5},"updated":"2016-05-06 01:40:46.000000000","message":"need not wrap","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6d7d4183e3e351a9d7832442b94306be3a782544","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        {1, 0}"},{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    def test_list_shares_for_all_tenants(self, all_tenants):"},{"line_number":160,"context_line":"        print(\"NMH 1112 all_tenants is\", all_tenants)"},{"line_number":161,"context_line":"        shares \u003d self.user_client.list_shares(all_tenants\u003dall_tenants)"},{"line_number":162,"context_line":"        self.assertTrue(len(shares) \u003e 1)"},{"line_number":163,"context_line":"        for s_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_992d1700","line":160,"updated":"2016-05-04 11:53:49.000000000","message":"Leftover debug that should be removed?","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"af2eb31dbfbd939a2b0748c9a0fd71265199f849","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        {1, 0}"},{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    def test_list_shares_for_all_tenants(self, all_tenants):"},{"line_number":160,"context_line":"        print(\"NMH 1112 all_tenants is\", all_tenants)"},{"line_number":161,"context_line":"        shares \u003d self.user_client.list_shares(all_tenants\u003dall_tenants)"},{"line_number":162,"context_line":"        self.assertTrue(len(shares) \u003e 1)"},{"line_number":163,"context_line":"        for s_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_b95f3374","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":53},"updated":"2016-05-04 11:56:21.000000000","message":"did you forget to remove this print? \n\nthe test name when running will include the all_tenants value.","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"69bd65e86f1bac5c127739899de8bd6bc98599ba","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        {1, 0}"},{"line_number":158,"context_line":"    )"},{"line_number":159,"context_line":"    def test_list_shares_for_all_tenants(self, all_tenants):"},{"line_number":160,"context_line":"        print(\"NMH 1112 all_tenants is\", all_tenants)"},{"line_number":161,"context_line":"        shares \u003d self.user_client.list_shares(all_tenants\u003dall_tenants)"},{"line_number":162,"context_line":"        self.assertTrue(len(shares) \u003e 1)"},{"line_number":163,"context_line":"        for s_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_f911ab5e","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":53},"in_reply_to":"1a122d0e_b95f3374","updated":"2016-05-04 12:02:01.000000000","message":"Ah!! my bad","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6e26ec1233b5b6bdd713848ea29f39b250122bd","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    def test_list_shares(self):"},{"line_number":154,"context_line":"        self._list_shares()"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @ddt.data({1, 0})"},{"line_number":157,"context_line":"    def test_list_shares_for_all_tenants(self, all_tenants):"},{"line_number":158,"context_line":"        shares \u003d self.admin_client.list_shares(all_tenants\u003dall_tenants)"},{"line_number":159,"context_line":"        self.assertTrue(len(shares) \u003e 1)"},{"line_number":160,"context_line":"        if all_tenants:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_24ed96b7","line":157,"range":{"start_line":156,"start_character":4,"end_line":157,"end_character":60},"updated":"2016-05-16 11:37:53.000000000","message":"Here you provide set of values and test only \"True\" case by the fact it is not empty. Same below.","commit_id":"42ac80c846959e9f5a5711ba417b59abb2a68273"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6e26ec1233b5b6bdd713848ea29f39b250122bd","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        if all_tenants:"},{"line_number":161,"context_line":"            for s_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027]):"},{"line_number":162,"context_line":"                self.assertTrue(any(s_id \u003d\u003d s[\u0027ID\u0027] for s in shares))"},{"line_number":163,"context_line":"            self.assertTrue(any(s[\u0027Project ID\u0027] is not None for s in shares))"},{"line_number":164,"context_line":"        else:"},{"line_number":165,"context_line":"            for s_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027]):"},{"line_number":166,"context_line":"                self.assertFalse(any(s_id \u003d\u003d s[\u0027ID\u0027] for s in shares))"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_e400ae36","line":163,"range":{"start_line":163,"start_character":28,"end_line":163,"end_character":31},"updated":"2016-05-16 11:37:53.000000000","message":"It should be \"all\", not \"any\". You expect that each share has project_id value. Moreover, it is incorrect to check for None. CLI will not return it. You should perform comparison to owner\u0027s project ID.","commit_id":"42ac80c846959e9f5a5711ba417b59abb2a68273"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a5833d9762758f26a56db40279efe04ea183ff8a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":123,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        cls.public_share \u003d cls.create_share("},{"line_number":126,"context_line":"            name\u003dcls.public_name,"},{"line_number":127,"context_line":"            description\u003dcls.public_description,"},{"line_number":128,"context_line":"            public\u003dTrue,"},{"line_number":129,"context_line":"            client\u003dcls.get_user_client(),"},{"line_number":130,"context_line":"            cleanup_in_class\u003dTrue)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        cls.admin_private_share \u003d cls.create_share("},{"line_number":133,"context_line":"            name\u003dcls.admin_private_name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_672de294","line":130,"range":{"start_line":125,"start_character":8,"end_line":130,"end_character":34},"updated":"2016-05-20 10:25:56.000000000","message":"This method will \"wait\", because it was \"last\". So, either add user new share above, or make this one not wait for status. Requests for creation of shares should be done without delay.","commit_id":"b7a54e20c2e34d01844a6ec9b3ee86fa6980b212"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a5833d9762758f26a56db40279efe04ea183ff8a","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"            self.assertTrue(all(\u0027Project ID\u0027 in s for s in shares))"},{"line_number":181,"context_line":"        else:"},{"line_number":182,"context_line":"            for s_id in (self.private_share[\u0027id\u0027], self.public_share[\u0027id\u0027]):"},{"line_number":183,"context_line":"                self.assertFalse(any(s_id \u003d\u003d s[\u0027ID\u0027] for s in shares))"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            self.assertTrue(any(self.admin_private_share[\u0027id\u0027] \u003d\u003d s[\u0027ID\u0027]"},{"line_number":186,"context_line":"                                for s in shares))"},{"line_number":187,"context_line":"            self.assertTrue(all(\u0027Project ID\u0027 not in s for s in shares))"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @ddt.data(True, False)"},{"line_number":190,"context_line":"    def test_list_shares_with_public(self, public):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_a79cea5d","line":187,"range":{"start_line":182,"start_character":12,"end_line":187,"end_character":71},"updated":"2016-05-20 10:25:56.000000000","message":"It fails because configuration allows to set single tenant for both users - admin and member. That is done here - in CI. It won\u0027t fail when admin has different tenant than member, that is, as I suspect, case of your local lab.","commit_id":"b7a54e20c2e34d01844a6ec9b3ee86fa6980b212"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4617ee3d61dd1fecb6ff3de5f63c2a34affc754c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            description\u003dcls.admin_private_description,"},{"line_number":120,"context_line":"            public\u003dFalse,"},{"line_number":121,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":122,"context_line":"            client\u003dNone,"},{"line_number":123,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        cls.private_share \u003d cls.create_share("}],"source_content_type":"text/x-python","patch_set":12,"id":"bab6814e_81993a22","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":24},"updated":"2016-05-24 14:59:30.000000000","message":"This looks redundant.","commit_id":"7c500d8f203465529339f2327b8b65aadf043fe6"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"db7e8ccbfc8eecfac46ae537b78bba7c38d97eac","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            description\u003dcls.admin_private_description,"},{"line_number":120,"context_line":"            public\u003dFalse,"},{"line_number":121,"context_line":"            cleanup_in_class\u003dTrue,"},{"line_number":122,"context_line":"            client\u003dNone,"},{"line_number":123,"context_line":"            wait_for_creation\u003dFalse)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        cls.private_share \u003d cls.create_share("}],"source_content_type":"text/x-python","patch_set":15,"id":"3aaa91ec_31516237","line":122,"range":{"start_line":122,"start_character":12,"end_line":122,"end_character":24},"updated":"2016-06-23 16:39:42.000000000","message":"redundant","commit_id":"3a7609d8fabd999e3ed260601488104ebcb96ce1"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6d7d4183e3e351a9d7832442b94306be3a782544","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            self.assert_called("},{"line_number":629,"context_line":"                \u0027GET\u0027, \u0027/snapshots/detail?all_tenants\u003d1\u0027)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":632,"context_line":"    def test_list_snapshots_all_tenants_key_and_value_0(self):"},{"line_number":633,"context_line":"        for separator in self.separators:"},{"line_number":634,"context_line":"            self.run_command(\u0027snapshot-list --all-tenants\u0027 + separator + \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_79dbdb1b","line":631,"updated":"2016-05-04 11:53:49.000000000","message":"I don\u0027t think this mock is needed (or used).","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":16305,"name":"NidhiMittalHada","email":"nidhimittal19@gmail.com","username":"nidhimittalhada"},"change_message_id":"69bd65e86f1bac5c127739899de8bd6bc98599ba","unresolved":false,"context_lines":[{"line_number":628,"context_line":"            self.assert_called("},{"line_number":629,"context_line":"                \u0027GET\u0027, \u0027/snapshots/detail?all_tenants\u003d1\u0027)"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":632,"context_line":"    def test_list_snapshots_all_tenants_key_and_value_0(self):"},{"line_number":633,"context_line":"        for separator in self.separators:"},{"line_number":634,"context_line":"            self.run_command(\u0027snapshot-list --all-tenants\u0027 + separator + \u00270\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_d914af4e","line":631,"in_reply_to":"1a122d0e_79dbdb1b","updated":"2016-05-04 12:02:01.000000000","message":"Done","commit_id":"b2b2423361ef7906cdc24decfe7175d8dad42d24"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6e26ec1233b5b6bdd713848ea29f39b250122bd","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            self.run_command(\u0027list --name\u0027 + separator + \u00271234\u0027)"},{"line_number":148,"context_line":"            self.assert_called(\u0027GET\u0027, \u0027/shares/detail?name\u003d1234\u0027)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    @mock.patch.object(cliutils, \u0027print_list\u0027, mock.Mock())"},{"line_number":151,"context_line":"    def test_list_all_tenants_only_key(self):"},{"line_number":152,"context_line":"        self.run_command(\u0027list --all-tenants\u0027)"},{"line_number":153,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/shares/detail?all_tenants\u003d1\u0027)"},{"line_number":154,"context_line":"        cliutils.print_list.assert_called_once_with("},{"line_number":155,"context_line":"            mock.ANY,"},{"line_number":156,"context_line":"            [\u0027ID\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Share Proto\u0027, \u0027Status\u0027, \u0027Is Public\u0027,"},{"line_number":157,"context_line":"             \u0027Share Type Name\u0027, \u0027Host\u0027, \u0027Availability Zone\u0027, \u0027Project ID\u0027])"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def test_list_all_tenants_key_and_value_1(self):"},{"line_number":160,"context_line":"        for separator in self.separators:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_38c65a9a","line":157,"range":{"start_line":150,"start_character":4,"end_line":157,"end_character":75},"updated":"2016-05-16 11:37:53.000000000","message":"Case with combination of \"columns\" set without Project ID and \"all-tenants\"/\"public\" is not covered.","commit_id":"42ac80c846959e9f5a5711ba417b59abb2a68273"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6e26ec1233b5b6bdd713848ea29f39b250122bd","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"        \u0027Share Type Name\u0027, \u0027Host\u0027, \u0027Availability Zone\u0027"},{"line_number":1278,"context_line":"    ]"},{"line_number":1279,"context_line":""},{"line_number":1280,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1281,"context_line":"    if all_tenants or args.public:"},{"line_number":1282,"context_line":"        list_of_keys.append(\u0027Project ID\u0027)"},{"line_number":1283,"context_line":""},{"line_number":1284,"context_line":"    columns \u003d args.columns"},{"line_number":1285,"context_line":"    if columns is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_d8f58eed","line":1282,"range":{"start_line":1280,"start_character":4,"end_line":1282,"end_character":41},"updated":"2016-05-16 11:37:53.000000000","message":"It will add it even if I use \"columns\" option where I specify expected ones. So, you introduce bug here.\n\nBetter to rewrite code to something following:\n\n\"\"\"\nall_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))\nif columns is not None:\n    list_of_keys \u003d _split_columns(columns\u003dcolumns)\nelse:\n    list_of_keys \u003d [\n        \u0027ID\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Share Proto\u0027, \u0027Status\u0027, \u0027Is Public\u0027,\n        \u0027Share Type Name\u0027, \u0027Host\u0027, \u0027Availability Zone\u0027\n    ]\n    if all_tenants or args.public:\n        list_of_keys.append(\u0027Project ID\u0027)\n\"\"\"\n\nSame below.","commit_id":"42ac80c846959e9f5a5711ba417b59abb2a68273"}]}
