)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35426c70f085795bcf4844bc1e3ddd1850fc5329","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The version of hacking in test-requirements.txt was beyond the stated"},{"line_number":10,"context_line":"in:"},{"line_number":11,"context_line":"github.com/openstack/requirements/blob/stable/liberty/test-requirements.txt"},{"line_number":12,"context_line":"With this patch python-manilaclient aligns rows."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Updated the version of hacking and fixed several pep8 issues due to the"},{"line_number":15,"context_line":"hacking version propagation."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_9cb500d2","line":12,"updated":"2016-05-04 13:42:32.000000000","message":"As written, lines 9-12 are confusing to me, maybe because I really don\u0027t know what \"aligns rows\" means. I suggest that you leave them out and change line 14 as indicated below.","commit_id":"f1de2d1b8d25f85b9cadabcab07c4e4f592086f3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35426c70f085795bcf4844bc1e3ddd1850fc5329","unresolved":false,"context_lines":[{"line_number":11,"context_line":"github.com/openstack/requirements/blob/stable/liberty/test-requirements.txt"},{"line_number":12,"context_line":"With this patch python-manilaclient aligns rows."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Updated the version of hacking and fixed several pep8 issues due to the"},{"line_number":15,"context_line":"hacking version propagation."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The list of fixed issues:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_9c5fc074","line":14,"updated":"2016-05-04 13:42:32.000000000","message":"Suggest:\n\n  \"Updated the version of hacking to match global requirements [1] and fixed several pep8 issues exposed with the new version.\"\n\nAnd then footnote as indicated at line 20.","commit_id":"f1de2d1b8d25f85b9cadabcab07c4e4f592086f3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"35426c70f085795bcf4844bc1e3ddd1850fc5329","unresolved":false,"context_lines":[{"line_number":17,"context_line":"The list of fixed issues:"},{"line_number":18,"context_line":"    - W292 no newline at end of file"},{"line_number":19,"context_line":"    - H238  old style class declaration"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2de0d2ed9d6e0a893290053998877ba30093f636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_9c1180b2","line":20,"updated":"2016-05-04 13:42:32.000000000","message":"Suggest:\n\n  [1] github.com/openstack/requirements/blob/master/test-requirements.txt\n\nThis change is to master so to me it makes sense to refer to the global requirements in master, not liberty, but you may have a reason for using liberty here that I\u0027m not aware of.","commit_id":"f1de2d1b8d25f85b9cadabcab07c4e4f592086f3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6f2cb6491fbc59eeaf0e44c833d4045d51306c0a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    - W292 no newline at end of file"},{"line_number":14,"context_line":"    - H238  old style class declaration"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] github.com/openstack/requirements/blob/master/test-requirements.txt"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2de0d2ed9d6e0a893290053998877ba30093f636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a122d0e_0a71790c","line":16,"updated":"2016-05-05 08:53:04.000000000","message":"https://github.com/openstack/requirements/blob/master/global-requirements.txt\n\nlooks to be the link you want.  It has pinned hacking requirement that matches what we see in the requirements gate test.","commit_id":"eb5a819b9e71e82b9ac8273ff2b6c32bfb09aa32"}],"test-requirements.txt":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6f2cb6491fbc59eeaf0e44c833d4045d51306c0a","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# hacking should be first"},{"line_number":6,"context_line":"hacking\u003c0.11,\u003e\u003d0.10"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"coverage\u003e\u003d3.6 # Apache-2.0"},{"line_number":9,"context_line":"ddt\u003e\u003d1.0.1 # MIT"}],"source_content_type":"text/plain","patch_set":5,"id":"1a122d0e_0ac21953","line":6,"updated":"2016-05-05 08:53:04.000000000","message":"Looks like we need: \u0027hacking\u003c0.11,\u003e\u003d0.10.2\u0027.  In the console log of  the failed job we see:\n\n2016-05-05 07:43:06.155 | Requirement for package hacking : \nRequirement(package\u003du\u0027hacking\u0027, location\u003d\u0027\u0027, specifiers\u003d\u0027\u003c0.11,\u003e\u003d0.10\u0027, markers\u003du\u0027\u0027, comment\u003d\u0027\u0027, extras\u003dfrozenset([])) does not match openstack/requirements value : set([Requirement(package\u003d\u0027hacking\u0027, location\u003d\u0027\u0027, specifiers\u003d\u0027\u003c0.11,\u003e\u003d0.10.2\u0027, markers\u003d\u0027\u0027, comment\u003d\u0027# Apache-2.0\u0027, extras\u003dfrozenset([]))])","commit_id":"eb5a819b9e71e82b9ac8273ff2b6c32bfb09aa32"}]}
