)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2db1ff559f8f5d5398ae2a4e088ee5c90fc0d4d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"user-facing name is provier-resource-metadata."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":"Implements: blueprint driver-private-storage"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I328cd2495c47431dd0005439daff74239256cbea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_1b52e213","line":16,"updated":"2016-07-04 10:05:36.000000000","message":"This commit depends on other unmerged commit. So, to make it run in CI properly, use \"Depends-On: %change-id%\". In that case other unmerged commit will be applied.","commit_id":"418bb53836ea1b23f609bc08ca2a06c93259cea8"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"01dc363e5671cdcad97b78fcc9ed34f891ecaad6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- provider-resource-metadata"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Internally the code name is driver-private-data, externally the"},{"line_number":13,"context_line":"user-facing name is provier-resource-metadata."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"APIImpact"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bacf61ea_c672faac","line":13,"range":{"start_line":13,"start_character":20,"end_line":13,"end_character":27},"updated":"2016-07-29 06:11:16.000000000","message":"provider","commit_id":"108558ada3585d3b6e017bb565e27d09b0996817"}],"manilaclient/tests/functional/test_driver_private_data.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c4c74ea4ce237f1037167cfd10c5caafa5f9eb5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_d617d1a0","line":1,"range":{"start_line":1,"start_character":11,"end_line":1,"end_character":16},"updated":"2016-07-07 15:39:04.000000000","message":"s/2015/2016?","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"a9fb0194cf385907c3633ad862c554f7b68084e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_c7ab2a88","line":1,"range":{"start_line":1,"start_character":11,"end_line":1,"end_character":16},"in_reply_to":"1aa78d24_d617d1a0","updated":"2016-07-11 08:42:26.000000000","message":"Done","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c4c74ea4ce237f1037167cfd10c5caafa5f9eb5c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from manilaclient.tests.functional import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"},{"line_number":22,"context_line":"class ManilaClientTestDriverPrivateDataReadOnly(base.BaseTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_get_by_admin(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_961a69c4","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":8},"updated":"2016-07-07 15:39:04.000000000","message":"ddt is not being used.","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"a9fb0194cf385907c3633ad862c554f7b68084e0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from manilaclient.tests.functional import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"@ddt.ddt"},{"line_number":22,"context_line":"class ManilaClientTestDriverPrivateDataReadOnly(base.BaseTestCase):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_get_by_admin(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_87b642da","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":8},"in_reply_to":"1aa78d24_961a69c4","updated":"2016-07-11 08:42:26.000000000","message":"Done.","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"809485a374d4c512a9f8f1d55928404ceb4298dd","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_get_by_admin(self):"},{"line_number":23,"context_line":"        dpd \u003d self.parser.listing("},{"line_number":24,"context_line":"            self.clients[\u0027admin\u0027].manila("},{"line_number":25,"context_line":"                \u0027provider-resource-metadata\u0027,"},{"line_number":26,"context_line":"                params\u003d\u0027entity1\u0027))"},{"line_number":27,"context_line":"        self.assertTableStruct(dpd, (\u0027Property\u0027, \u0027Value\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_dc3274a6","line":26,"range":{"start_line":24,"start_character":12,"end_line":26,"end_character":34},"updated":"2016-08-01 10:05:40.000000000","message":"1) Such things should be defined only via client.\n\n2) Such case should have returned 404.","commit_id":"108558ada3585d3b6e017bb565e27d09b0996817"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"0f69f6f90c4ef59b2e036a044595f5e302950ee2","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_get_by_admin(self):"},{"line_number":23,"context_line":"        dpd \u003d self.parser.listing("},{"line_number":24,"context_line":"            self.clients[\u0027admin\u0027].manila("},{"line_number":25,"context_line":"                \u0027provider-resource-metadata\u0027,"},{"line_number":26,"context_line":"                params\u003d\u0027entity1\u0027))"},{"line_number":27,"context_line":"        self.assertTableStruct(dpd, (\u0027Property\u0027, \u0027Value\u0027))"}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_c3946c38","line":26,"range":{"start_line":24,"start_character":12,"end_line":26,"end_character":34},"in_reply_to":"bacf61ea_dc3274a6","updated":"2016-08-05 03:35:29.000000000","message":"1) Thanks for your review, but I\u0027m a bit confused about what do you mean by \"such things\"? I was coping from other functional test cases, e.g. https://github.com/openstack/python-manilaclient/blob/master/manilaclient/tests/functional/test_quotas.py#L28, when I\u0027m writing this one.\n\n2) Currently querying to an empty entity returns {} rather than 404. I have commented it on https://review.openstack.org/#/c/315346/13/manila_tempest_tests/tests/api/admin/test_driver_private_data.py@43. It is also used here to verify table struct.","commit_id":"108558ada3585d3b6e017bb565e27d09b0996817"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"d25653af25802aa71766ed21736791e08f1b9688","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class ManilaClientTestDriverPrivateDataReadOnly(base.BaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def test_get_by_admin_non_exist(self):"},{"line_number":24,"context_line":"        self.assertRaises("},{"line_number":25,"context_line":"            exceptions.CommandFailed,"},{"line_number":26,"context_line":"            self.clients[\u0027admin\u0027].manila,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_35786ec4","line":23,"updated":"2016-08-09 15:17:53.000000000","message":"I have no way to write positive test case here. Because server side driver private data is empty (or I cannot assume certain entity_id exists). Any call will raises NotFound.\n\nIt would be grateful if someone could throw me some hints. Do I need to populate server side with some test data? And how? Thanks a lot!","commit_id":"232340fa6f090efb8fcb1da7fa5550f3bd2d5d1c"}],"manilaclient/tests/unit/v2/test_driver_private_data.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c4c74ea4ce237f1037167cfd10c5caafa5f9eb5c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"cs \u003d fakes.FakeClient(extensions\u003dextensions)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class DriverPrivateDataTest(utils.TestCase):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_4a0b327d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":8},"updated":"2016-07-07 15:39:04.000000000","message":"unused","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"a9fb0194cf385907c3633ad862c554f7b68084e0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"cs \u003d fakes.FakeClient(extensions\u003dextensions)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"@ddt.ddt"},{"line_number":33,"context_line":"class DriverPrivateDataTest(utils.TestCase):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_47c57a3a","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":8},"in_reply_to":"1aa78d24_4a0b327d","updated":"2016-07-11 08:42:26.000000000","message":"Done","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"d25653af25802aa71766ed21736791e08f1b9688","unresolved":false,"context_lines":[{"line_number":1830,"context_line":"        self.run_command(\u0027provider-resource-metadata entity1\u0027)"},{"line_number":1831,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/driver-private-data/entity1\u0027)"},{"line_number":1832,"context_line":""},{"line_number":1833,"context_line":"    def test_provider_resource_metadata_not_found(self):"},{"line_number":1834,"context_line":"        self.assertRaises("},{"line_number":1835,"context_line":"            exceptions.CommandError,"},{"line_number":1836,"context_line":"            self.run_command,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9ad45d7e_55736215","line":1833,"updated":"2016-08-09 15:17:53.000000000","message":"I\u0027m not sure this is the right way to test non found case. I have to add an get_driver_private_data_nonexistent_entity_id(self) in tests/unit/v2/fakes.py so that the test case here can run.\n\nIt would be grateful if someone could throw me some hints. Thanks!","commit_id":"232340fa6f090efb8fcb1da7fa5550f3bd2d5d1c"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c4c74ea4ce237f1037167cfd10c5caafa5f9eb5c","unresolved":false,"context_lines":[{"line_number":3470,"context_line":""},{"line_number":3471,"context_line":"@cliutils.arg("},{"line_number":3472,"context_line":"    \u0027host\u0027,"},{"line_number":3473,"context_line":"    metavar\u003d\u0027\u003chost@backend\u003e\u0027,"},{"line_number":3474,"context_line":"    help\u003d\u0027Host and backend to get the provider resource metadata.\u0027)"},{"line_number":3475,"context_line":"@cliutils.arg("},{"line_number":3476,"context_line":"    \u0027entity\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_99b8da12","line":3473,"range":{"start_line":3473,"start_character":14,"end_line":3473,"end_character":26},"updated":"2016-07-07 15:39:04.000000000","message":"s/host@backend/host","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"a9fb0194cf385907c3633ad862c554f7b68084e0","unresolved":false,"context_lines":[{"line_number":3470,"context_line":""},{"line_number":3471,"context_line":"@cliutils.arg("},{"line_number":3472,"context_line":"    \u0027host\u0027,"},{"line_number":3473,"context_line":"    metavar\u003d\u0027\u003chost@backend\u003e\u0027,"},{"line_number":3474,"context_line":"    help\u003d\u0027Host and backend to get the provider resource metadata.\u0027)"},{"line_number":3475,"context_line":"@cliutils.arg("},{"line_number":3476,"context_line":"    \u0027entity\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_e7abc61c","line":3473,"range":{"start_line":3473,"start_character":14,"end_line":3473,"end_character":26},"in_reply_to":"1aa78d24_99b8da12","updated":"2016-07-11 08:42:26.000000000","message":"As in https://review.openstack.org/339592, the \"host\" is no longer necessary here. Thanks all the same for making it clearer!","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c4c74ea4ce237f1037167cfd10c5caafa5f9eb5c","unresolved":false,"context_lines":[{"line_number":3471,"context_line":"@cliutils.arg("},{"line_number":3472,"context_line":"    \u0027host\u0027,"},{"line_number":3473,"context_line":"    metavar\u003d\u0027\u003chost@backend\u003e\u0027,"},{"line_number":3474,"context_line":"    help\u003d\u0027Host and backend to get the provider resource metadata.\u0027)"},{"line_number":3475,"context_line":"@cliutils.arg("},{"line_number":3476,"context_line":"    \u0027entity\u0027,"},{"line_number":3477,"context_line":"    metavar\u003d\u0027\u003centity\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_cae60243","line":3474,"range":{"start_line":3474,"start_character":10,"end_line":3474,"end_character":27},"updated":"2016-07-07 15:39:04.000000000","message":"Manila host to the provider resource metadata;\ntakes the form: host@backend","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"a9fb0194cf385907c3633ad862c554f7b68084e0","unresolved":false,"context_lines":[{"line_number":3471,"context_line":"@cliutils.arg("},{"line_number":3472,"context_line":"    \u0027host\u0027,"},{"line_number":3473,"context_line":"    metavar\u003d\u0027\u003chost@backend\u003e\u0027,"},{"line_number":3474,"context_line":"    help\u003d\u0027Host and backend to get the provider resource metadata.\u0027)"},{"line_number":3475,"context_line":"@cliutils.arg("},{"line_number":3476,"context_line":"    \u0027entity\u0027,"},{"line_number":3477,"context_line":"    metavar\u003d\u0027\u003centity\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_27a66e53","line":3474,"range":{"start_line":3474,"start_character":10,"end_line":3474,"end_character":27},"in_reply_to":"1aa78d24_cae60243","updated":"2016-07-11 08:42:26.000000000","message":"Ditto.","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c4c74ea4ce237f1037167cfd10c5caafa5f9eb5c","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"    metavar\u003d\u0027\u003centity\u003e\u0027,"},{"line_number":3478,"context_line":"    help\u003d\u0027ID of the entity.\u0027)"},{"line_number":3479,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3480,"context_line":"def do_provider_resource_metadata(cs, args):"},{"line_number":3481,"context_line":"    \"\"\"Show the private key-value metadata of the storage backend\"\"\""},{"line_number":3482,"context_line":"    dpd \u003d cs.driver_private_data.get(args.host, args.entity)"},{"line_number":3483,"context_line":"    _print_driver_private_data(cs, dpd)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_eaa65ebf","line":3480,"range":{"start_line":3480,"start_character":7,"end_line":3480,"end_character":33},"updated":"2016-07-07 15:39:04.000000000","message":"Why not just called driver_private_data_list ?","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"a9fb0194cf385907c3633ad862c554f7b68084e0","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"    metavar\u003d\u0027\u003centity\u003e\u0027,"},{"line_number":3478,"context_line":"    help\u003d\u0027ID of the entity.\u0027)"},{"line_number":3479,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3480,"context_line":"def do_provider_resource_metadata(cs, args):"},{"line_number":3481,"context_line":"    \"\"\"Show the private key-value metadata of the storage backend\"\"\""},{"line_number":3482,"context_line":"    dpd \u003d cs.driver_private_data.get(args.host, args.entity)"},{"line_number":3483,"context_line":"    _print_driver_private_data(cs, dpd)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_a7d41ebd","line":3480,"range":{"start_line":3480,"start_character":7,"end_line":3480,"end_character":33},"in_reply_to":"1aa78d24_eaa65ebf","updated":"2016-07-11 08:42:26.000000000","message":"Good idea. I agree that \"provider_resource_metadata\" is a bit weird. We got that name in previous discussion. I\u0027ll wait a little to collect some thoughts. Thanks!","commit_id":"26eda6b19af6ec9430f2951f6bd2212d5150814c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"809485a374d4c512a9f8f1d55928404ceb4298dd","unresolved":false,"context_lines":[{"line_number":3470,"context_line":"@cliutils.arg("},{"line_number":3471,"context_line":"    \u0027entity\u0027,"},{"line_number":3472,"context_line":"    metavar\u003d\u0027\u003centity\u003e\u0027,"},{"line_number":3473,"context_line":"    help\u003d\u0027ID of the entity.\u0027)"},{"line_number":3474,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3475,"context_line":"def do_provider_resource_metadata(cs, args):"},{"line_number":3476,"context_line":"    \"\"\"Show the private key-value metadata of the storage backend\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_dc955433","line":3473,"updated":"2016-08-01 10:05:40.000000000","message":"Better to add that it can be anything manila creates. Such things as, share, snapshot, their instances, etc ...","commit_id":"108558ada3585d3b6e017bb565e27d09b0996817"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"0f69f6f90c4ef59b2e036a044595f5e302950ee2","unresolved":false,"context_lines":[{"line_number":3470,"context_line":"@cliutils.arg("},{"line_number":3471,"context_line":"    \u0027entity\u0027,"},{"line_number":3472,"context_line":"    metavar\u003d\u0027\u003centity\u003e\u0027,"},{"line_number":3473,"context_line":"    help\u003d\u0027ID of the entity.\u0027)"},{"line_number":3474,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3475,"context_line":"def do_provider_resource_metadata(cs, args):"},{"line_number":3476,"context_line":"    \"\"\"Show the private key-value metadata of the storage backend\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"bacf61ea_e379b0fd","line":3473,"in_reply_to":"bacf61ea_dc955433","updated":"2016-08-05 03:35:29.000000000","message":"Done.","commit_id":"108558ada3585d3b6e017bb565e27d09b0996817"}]}
