)]}'
{"id":"openstack%2Fpython-manilaclient~340135","triplet_id":"openstack%2Fpython-manilaclient~master~I241d633fd63992d647843ee7fc60030c5eed2675","project":"openstack/python-manilaclient","branch":"master","topic":"instead_of_None","hashtags":[],"change_id":"I241d633fd63992d647843ee7fc60030c5eed2675","subject":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None","status":"ABANDONED","created":"2016-07-10 11:23:23.000000000","updated":"2016-07-15 14:20:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"719e730f060c449748281fa6bf68d491ec28289d","_number":340135,"virtual_id_number":340135,"owner":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":1,"date":"2016-07-10 12:12:23.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"all":[{"value":-1,"date":"2016-07-15 10:17:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-07-14 12:39:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},{"value":2,"date":"2016-07-15 09:05:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-10 12:12:23.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-07-14 12:39:43.000000000","updated_by":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"reviewer":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"state":"REVIEWER"},{"updated":"2016-07-15 09:05:46.000000000","updated_by":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"reviewer":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"state":"REVIEWER"},{"updated":"2016-07-15 10:17:21.000000000","updated_by":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"reviewer":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"state":"REVIEWER"}],"messages":[{"id":"6998edbf325c667c3735b7d68ba39b910ad18f55","author":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"date":"2016-07-10 11:23:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66b0d80751b76c229747c03b87223484a4a2ec10","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-10 12:12:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-manilaclient-docs http://docs-draft.openstack.org/35/340135/1/check/gate-python-manilaclient-docs/0495a91//doc/build/html/ : SUCCESS in 3m 42s\n- gate-python-manilaclient-pep8 http://logs.openstack.org/35/340135/1/check/gate-python-manilaclient-pep8/b98b8e0/ : SUCCESS in 2m 59s\n- gate-python-manilaclient-python27 http://logs.openstack.org/35/340135/1/check/gate-python-manilaclient-python27/98b52a3/ : SUCCESS in 5m 17s\n- gate-python-manilaclient-python34 http://logs.openstack.org/35/340135/1/check/gate-python-manilaclient-python34/0e2c160/ : SUCCESS in 5m 27s\n- gate-python-manilaclient-python35-nv http://logs.openstack.org/35/340135/1/check/gate-python-manilaclient-python35-nv/a7f2e79/ : SUCCESS in 5m 03s (non-voting)\n- gate-manilaclient-dsvm-neutron-functional http://logs.openstack.org/35/340135/1/check/gate-manilaclient-dsvm-neutron-functional/2736d2c/ : SUCCESS in 45m 40s","accounts_in_message":[],"_revision_number":1},{"id":"c0e0410f1ee7fd56253b08d2f5314912d0c53f40","author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"date":"2016-07-14 12:39:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"59c397b46b1e6843655a4d02ab3104f469291ead","author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"date":"2016-07-15 09:05:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"7ff45f1c7e404e4e2c85b0245114ff98188e9446","author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"date":"2016-07-15 10:17:21.000000000","message":"Patch Set 1: Code-Review-1\n\nAll code located in \"manilaclient/openstack\" was copied from oslo-incubator without any unit tests coverage, it was tested there. Yes, oslo-incubator was deprecated. But, you change a lot of code here and do not add any unit tests. In good case, we should rework its structure and add full unit tests coverage. But now, any code change to it should be covered with tests.","accounts_in_message":[],"_revision_number":1},{"id":"8191c40c8958a0306f15969a7b27bc72ab344a36","author":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"date":"2016-07-15 14:20:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d1a6658857bb51cb3e9c7b2440d6ff478f52eb53","revisions":{"d1a6658857bb51cb3e9c7b2440d6ff478f52eb53":{"kind":"REWORK","_number":1,"created":"2016-07-10 11:23:23.000000000","uploader":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"ref":"refs/changes/35/340135/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/35/340135/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/35/340135/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/35/340135/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/35/340135/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/35/340135/1"}}},"commit":{"parents":[{"commit":"947989952a55b622b28a108320cf4d9295f14dbc","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/947989952a55b622b28a108320cf4d9295f14dbc"}]}],"author":{"name":"PanFengyun","email":"fengyun.pan@easystack.cn","date":"2016-07-10 11:22:29.000000000","tz":480},"committer":{"name":"PanFengyun","email":"fengyun.pan@easystack.cn","date":"2016-07-10 11:22:29.000000000","tz":480},"subject":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None","message":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None\n\nClient prints \u0027None\u0027 when data is None , and client also prints\n\u0027None\u0027 when data is a string \u0027None\u0027. But string \u0027None\u0027 is  different\nto None. To clear the confusion, Client should print \u0027-\u0027 instead of\n\u0027None\u0027 when data is None. Nova Client and Cinder Client has cleared\nthe confusion.\n\nChange-Id: I241d633fd63992d647843ee7fc60030c5eed2675\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d1a6658857bb51cb3e9c7b2440d6ff478f52eb53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/d1a6658857bb51cb3e9c7b2440d6ff478f52eb53"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}