)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"907963c58c7f272c4584dd4ceb947dbca8b6e2f4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"the details of a specific backup."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implement: blueprint share-backup"},{"line_number":15,"context_line":"Depends-On: I7d10cf47864cd21932315375d84dc728ff738f23"},{"line_number":16,"context_line":"Change-Id: I2c3848cbbeb921ede74756e25e58ef82277e0d2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"cfabe3f8_5c00d2e7","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":53},"updated":"2023-08-24 20:24:11.000000000","message":"doesn\u0027t this have to depend on the follow up patch now?","commit_id":"cb62f5cea3071fa82da7ccf0d49d540c4aa81a0f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ddd9cfa8efa9b02645bcb28f948e07896341e143","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the details of a specific backup."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Implement: blueprint share-backup"},{"line_number":15,"context_line":"Depends-On: I7d10cf47864cd21932315375d84dc728ff738f23"},{"line_number":16,"context_line":"Change-Id: I2c3848cbbeb921ede74756e25e58ef82277e0d2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"896a7ea3_bba0a45c","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":53},"in_reply_to":"cfabe3f8_5c00d2e7","updated":"2023-08-26 13:22:39.000000000","message":"fixed","commit_id":"cb62f5cea3071fa82da7ccf0d49d540c4aa81a0f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"2dc03b537d5969b1a1cf7b201bc8e673271ea603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"02522c5d_7c5b8cb8","updated":"2023-01-02 17:33:56.000000000","message":"After merge of manila backup spec, updating PR to address spec comments.\n\nFYI, Steps to test on devstack :-\n1. Create share of 1 GB. e.g. name it tmp_backup. Export location of share (admin) is then added in /manila/data/drivers/nfs.py config option \u0027backup_share\u0027. e.g. 10.1.1.100:/shares/share-5c8bba9f-18ad-4e64-801e-204575e7a97a\n2. Add host IP in manila/data/helper.py config option \u0027data_node_access_ips\u0027 and restart manila service\n3. Add access-allow with ip type and value (controller node IP) to above temp share(tmp_backup). e.g. \u002710.1.1.50\u0027\n4. Create another share (e.g. share1) of 1GB, mount it, write some data to share. We will take backup of this share into tmp_backup in next steps.\n5. openstack share backup create share1 --name backup1\n6. mount tmp_backup and check the content. It should be same as data added in step4.\n7. unmount tmp_backup. Mount share1, delete its data and unmount it.\n8. openstack share backup restore backup1\n9. Mount share1 and and check the content. It should be same as data added in step6\n10. unmount share1\n11. openstack share backup delete backup1.\n","commit_id":"266bc8dc1981fd91046e8aadbe911af8f10a6055"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"92b4c92d9ca5534c97b15badbb29dd0a5959dd9b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a13c8fb3_993c9702","updated":"2023-07-06 17:26:04.000000000","message":"\"openstack share --help\" does not list backup commands.\n\"manila --help\" does, and \"manila backup-create\" works though the share is currently stuck in backup-creating phase, so I have not been able to test further commands besides list and show.","commit_id":"3d03b5f9d29b4809e701c8d1160a1f23f25dbc29"},{"author":{"_account_id":35507,"name":"Kiran Pawar","email":"kiranpawarpict2010@gmail.com","username":"kpawar"},"change_message_id":"52dce9887a6a6302371281ebdd86b062c4aef5e8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"e9e7eff2_78e05c71","in_reply_to":"a13c8fb3_993c9702","updated":"2023-07-08 05:57:29.000000000","message":"How are you testing ?\ncheck https://review.opendev.org/c/openstack/manila/+/343980/52#message-9f2bc2ccc1c0255ef09e2f5091f351d0e3e5ccf3\n\nat high level\n1. create big share of 20 GB and consider this as backup location. Add its export path in manila.conf\n2. Add data_node_access_ips which is devstack host admin network ip\n3. For backup location(which is share of 20 GB), enable access to 0.0.0.0 or host IP\n4. Create share and then create its backup\n5. rest of the testing e.g. create/delete/update/restore works well.","commit_id":"3d03b5f9d29b4809e701c8d1160a1f23f25dbc29"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"94a9ab1bc55b06ddcabc7b044569a6de5c2e784d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"addfdd07_fcf3fc26","in_reply_to":"e9e7eff2_78e05c71","updated":"2023-08-29 07:01:30.000000000","message":"Done","commit_id":"3d03b5f9d29b4809e701c8d1160a1f23f25dbc29"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"5f7b16dc_8de508f6","updated":"2023-08-15 22:26:44.000000000","message":"Thanks; now that the server side\u0027s merged it\u0027ll be good to clean this up and get it merged as well","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f56d903e930b8d803a92e8f94d00462bb873b054","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"11d32ba9_dadec4dd","updated":"2023-08-23 06:42:53.000000000","message":"at the end of file doc/source/cli/osc/v2/index.rst\nadd\n    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n    share backups\n    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\n    .. autoprogram-cliff:: openstack.share.v2\n        :command: share backup *","commit_id":"8a9ac6f01bd21373d5fa957250cfb9e784161b4a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"9b501198_975df7ae","updated":"2023-08-23 21:44:15.000000000","message":"Hi Kiran! Thanks for working on this change. While testing I realized a bunch of operations were not working properly (including the dummy driver itself). Please take a look at the issues and also fix the issues with the dummy driver. It will be needed for testing here and in the other change.\nI have also realized you have not proposed functional tests to this change. Could you please work on some?","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"370d0c4e_0c3365a4","updated":"2023-08-24 14:54:53.000000000","message":"I have added OSC functions tests. Please ignore changes related to shell client as this will be removed in future.","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"3d60b895a9f794db52230cdd2797b61cfd552aee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"efea4ff4_b4f7531c","updated":"2023-08-23 12:42:28.000000000","message":"renamed \u0027backup_state\u0027 to \u0027status\u0027 and added reset_status API support (only in OSC).","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f309c0dcd70c8ea5ffd30a70b4684e41345b63e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"0468d377_aab777e0","updated":"2023-08-25 02:01:33.000000000","message":"two comments.","commit_id":"cb62f5cea3071fa82da7ccf0d49d540c4aa81a0f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b29e65bad0cc2871011cdebe1873cccf85ef82ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"61857078_e4a3e348","updated":"2023-08-25 20:15:01.000000000","message":"Hi Kiran! Thank you for working on the changes.\nMost of the issues have been fixed, but there is something else:\navailability zone is still not being picked up in the detail list, it is being picked up only during show, please see:\nhttps://paste.opendev.org/show/b3pFL2QOgbcZi2yOJMMj/","commit_id":"4306c445e74796ed06b71f6dfa7049a5a8b19b92"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ddd9cfa8efa9b02645bcb28f948e07896341e143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"8ce31041_0202cac8","in_reply_to":"61857078_e4a3e348","updated":"2023-08-26 13:22:39.000000000","message":"it was spelling mistake, fixed.","commit_id":"4306c445e74796ed06b71f6dfa7049a5a8b19b92"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"063b31172f0a2621af89bb1e5aff80057d2e132a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"3bbacbe0_2ce3673b","updated":"2023-08-28 01:17:07.000000000","message":"functional test failed, please see  comment.","commit_id":"72dcffb8c5efb5de66162ab77a99d0fb2995ad19"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3445de772a4387ef572b5168f3f88a8acf786d9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"499fc5dc_f92142d3","updated":"2023-08-28 19:43:47.000000000","message":"LGTM, thanks Kiran","commit_id":"b9ee8ec2c03ebf8313a66ec39fefd2d0eb1289bf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3c4a920a6a41c8f89eba5737f64ead9e5779c01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"8c112d8b_f13cc48a","updated":"2023-08-29 18:34:16.000000000","message":"LGTM, thanks for working on this change, Kiran!","commit_id":"5e24577904927930489ddf6f879856c86d6fb440"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f387036688a9ff67f733a1d04a763fff8e3f0c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"0ceb5791_df548610","updated":"2023-08-29 08:52:03.000000000","message":"LGTM. thanks.","commit_id":"5e24577904927930489ddf6f879856c86d6fb440"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6c5e61eaa8888e40616c86637774d8ce8271ae4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ef760d88_319d2f6a","updated":"2023-08-30 01:11:36.000000000","message":"recheck","commit_id":"5e24577904927930489ddf6f879856c86d6fb440"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"dc3d15a046ff0cf13e6a35157d4e9fe406b0ed2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ff5ed884_01305fad","updated":"2023-08-31 12:23:05.000000000","message":"recheck","commit_id":"5e24577904927930489ddf6f879856c86d6fb440"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b5cfc0cfbdfd35bb599a2ff96d27af4e577998f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"15227361_ac7e1e33","updated":"2023-08-30 14:10:27.000000000","message":"recheck\nApparently issue with tox has been fixed.","commit_id":"5e24577904927930489ddf6f879856c86d6fb440"}],"manilaclient/api_versions.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3242256ffd5ea73a1604e2ac1307601ba771ea5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.19\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_1084bc08","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":19},"updated":"2016-08-12 00:54:01.000000000","message":"2.20","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.19\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_d0ede226","line":30,"range":{"start_line":30,"start_character":17,"end_line":30,"end_character":19},"in_reply_to":"9ad45d7e_1084bc08","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"}],"manilaclient/osc/v2/share_backups.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            metavar\u003d\"\u003cbackup\u003e\","},{"line_number":155,"context_line":"            help\u003d_(\"The last backup ID of the previous page\")"},{"line_number":156,"context_line":"        )"},{"line_number":157,"context_line":"        parser.add_argument("},{"line_number":158,"context_line":"            \u0027--sort\u0027,"},{"line_number":159,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":160,"context_line":"            default\u003d\u0027name:asc\u0027,"},{"line_number":161,"context_line":"            help\u003d_(\"Sort output by selected keys and directions(asc or desc) \""},{"line_number":162,"context_line":"                   \"(default: name:asc), multiple keys and directions can be \""},{"line_number":163,"context_line":"                   \"specified separated by comma\")"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        parser.add_argument("},{"line_number":166,"context_line":"            \u0027--detail\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"2f4a4416_44177de0","line":163,"range":{"start_line":157,"start_character":8,"end_line":163,"end_character":50},"updated":"2023-08-15 22:26:44.000000000","message":"this isn\u0027t compatible with how sorting is implemented elsewhere in OSC; we typically implement \"--sort-key\" and \"--sort-dir\" keys separately and allow manila API service to perform the sorting ;\n\nAlternatively, we can just rely on OSC\u0027s own sorting that\u0027ll always exist unless turned off: https://opendev.org/openstack/cliff/src/commit/72e81d7d846a8e306fd8d98e2f15270a8a537620/cliff/lister.py#L51-L81","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"384edbc0fa1c4bc0b6b3340176eb131876e896a4","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            metavar\u003d\"\u003cbackup\u003e\","},{"line_number":155,"context_line":"            help\u003d_(\"The last backup ID of the previous page\")"},{"line_number":156,"context_line":"        )"},{"line_number":157,"context_line":"        parser.add_argument("},{"line_number":158,"context_line":"            \u0027--sort\u0027,"},{"line_number":159,"context_line":"            metavar\u003d\"\u003ckey\u003e[:\u003cdirection\u003e]\","},{"line_number":160,"context_line":"            default\u003d\u0027name:asc\u0027,"},{"line_number":161,"context_line":"            help\u003d_(\"Sort output by selected keys and directions(asc or desc) \""},{"line_number":162,"context_line":"                   \"(default: name:asc), multiple keys and directions can be \""},{"line_number":163,"context_line":"                   \"specified separated by comma\")"},{"line_number":164,"context_line":"        )"},{"line_number":165,"context_line":"        parser.add_argument("},{"line_number":166,"context_line":"            \u0027--detail\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"b4c314cb_f9cc051c","line":163,"range":{"start_line":157,"start_character":8,"end_line":163,"end_character":50},"in_reply_to":"2f4a4416_44177de0","updated":"2023-08-16 09:49:38.000000000","message":"Done","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        share_client.share_backups.restore(share_backup)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class SetShareBackup(command.Command):"},{"line_number":252,"context_line":"    \"\"\"Set share backup properties.\"\"\""},{"line_number":253,"context_line":"    _description \u003d _(\"Set share backup properties\")"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"93687a7e_151a8d1b","line":251,"range":{"start_line":251,"start_character":6,"end_line":251,"end_character":20},"updated":"2023-08-15 22:26:44.000000000","message":"You need to implement \"Unset\" operation as well for the same attributes (name, description)","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"384edbc0fa1c4bc0b6b3340176eb131876e896a4","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        share_client.share_backups.restore(share_backup)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"class SetShareBackup(command.Command):"},{"line_number":252,"context_line":"    \"\"\"Set share backup properties.\"\"\""},{"line_number":253,"context_line":"    _description \u003d _(\"Set share backup properties\")"},{"line_number":254,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"a5551a39_10329b6d","line":251,"range":{"start_line":251,"start_character":6,"end_line":251,"end_character":20},"in_reply_to":"93687a7e_151a8d1b","updated":"2023-08-16 09:49:38.000000000","message":"Done","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f309c0dcd70c8ea5ffd30a70b4684e41345b63e8","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            default\u003dNone,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Optional share backup name. (Default\u003dNone).\u0027)"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--description\u0027,"},{"line_number":49,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":50,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":23,"id":"35804014_c97afae4","line":47,"updated":"2023-08-25 02:01:33.000000000","message":"we support like filter by name or description\n\n    parser.add_argument(\n            \"--name~\",\n            metavar\u003d\"\u003cname~\u003e\",\n            default\u003dNone,\n            help\u003d_(\"Filter results matching a share backup name pattern.\")\n    )\n    parser.add_argument(\n            \u0027--description~\u0027,\n            metavar\u003d\"\u003cdescription~\u003e\",\n            default\u003dNone,\n            help\u003d_(\"Filter results matching a share backup description.\")\n    )","commit_id":"8a9ac6f01bd21373d5fa957250cfb9e784161b4a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ddd9cfa8efa9b02645bcb28f948e07896341e143","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            default\u003dNone,"},{"line_number":45,"context_line":"            help\u003d_(\u0027Optional share backup name. (Default\u003dNone).\u0027)"},{"line_number":46,"context_line":"        )"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027--description\u0027,"},{"line_number":49,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":50,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":23,"id":"254b35a7_fb26da5d","line":47,"in_reply_to":"35804014_c97afae4","updated":"2023-08-26 13:22:39.000000000","message":"Done","commit_id":"8a9ac6f01bd21373d5fa957250cfb9e784161b4a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":true,"context_lines":[{"line_number":187,"context_line":"        if parsed_args.share:"},{"line_number":188,"context_line":"            share_id \u003d osc_utils.find_resource(share_client.shares,"},{"line_number":189,"context_line":"                                               parsed_args.share).id"},{"line_number":190,"context_line":"        columns \u003d ["},{"line_number":191,"context_line":"            \u0027ID\u0027,"},{"line_number":192,"context_line":"            \u0027Share ID\u0027,"},{"line_number":193,"context_line":"            \u0027Status\u0027"},{"line_number":194,"context_line":"        ]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if parsed_args.detailed:"},{"line_number":197,"context_line":"            columns.extend([\u0027Name\u0027, \u0027Description\u0027, \u0027Size\u0027, \u0027Created At\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5fdf8bff_15e8526e","line":194,"range":{"start_line":190,"start_character":8,"end_line":194,"end_character":9},"updated":"2023-08-23 21:44:15.000000000","message":"maybe we should display the name as well?","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if parsed_args.share:"},{"line_number":188,"context_line":"            share_id \u003d osc_utils.find_resource(share_client.shares,"},{"line_number":189,"context_line":"                                               parsed_args.share).id"},{"line_number":190,"context_line":"        columns \u003d ["},{"line_number":191,"context_line":"            \u0027ID\u0027,"},{"line_number":192,"context_line":"            \u0027Share ID\u0027,"},{"line_number":193,"context_line":"            \u0027Status\u0027"},{"line_number":194,"context_line":"        ]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        if parsed_args.detailed:"},{"line_number":197,"context_line":"            columns.extend([\u0027Name\u0027, \u0027Description\u0027, \u0027Size\u0027, \u0027Created At\u0027,"}],"source_content_type":"text/x-python","patch_set":24,"id":"a261860c_fa00c206","line":194,"range":{"start_line":190,"start_character":8,"end_line":194,"end_character":9},"in_reply_to":"5fdf8bff_15e8526e","updated":"2023-08-24 14:54:53.000000000","message":"this will need changes in manila. I will do it. Added here as well.","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":true,"context_lines":[{"line_number":206,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":207,"context_line":"        }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        backups \u003d share_client.share_backups.list("},{"line_number":210,"context_line":"            detailed\u003dparsed_args.detailed, search_opts\u003dsearch_opts,"},{"line_number":211,"context_line":"            sort_key\u003dparsed_args.sort_key, sort_dir\u003dparsed_args.sort_dir)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return (columns,"},{"line_number":214,"context_line":"                (osc_utils.get_item_properties(b, columns) for b in backups))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class ShowShareBackup(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":24,"id":"1d57d4a9_115d1960","line":214,"range":{"start_line":209,"start_character":8,"end_line":214,"end_character":77},"updated":"2023-08-23 21:44:15.000000000","message":"Not detailed this is not printing the status of the backup, please take a look:\nhttps://paste.opendev.org/show/bLhuGHBI7lHXleO0p94G/\n\nAlso, detailed is missing a lot of field:\nhttps://paste.opendev.org/show/bpJtmAJZx1JFAEqkC132/\n\nAlso, availability zone is not being saved in the database:\nhttps://paste.opendev.org/show/bqVhzJixllqi8BWjQdLy/","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            \u0027share_id\u0027: share_id,"},{"line_number":207,"context_line":"        }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        backups \u003d share_client.share_backups.list("},{"line_number":210,"context_line":"            detailed\u003dparsed_args.detailed, search_opts\u003dsearch_opts,"},{"line_number":211,"context_line":"            sort_key\u003dparsed_args.sort_key, sort_dir\u003dparsed_args.sort_dir)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        return (columns,"},{"line_number":214,"context_line":"                (osc_utils.get_item_properties(b, columns) for b in backups))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class ShowShareBackup(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":24,"id":"aed0366d_809cf470","line":214,"range":{"start_line":209,"start_character":8,"end_line":214,"end_character":77},"in_reply_to":"1d57d4a9_115d1960","updated":"2023-08-24 14:54:53.000000000","message":"Add host and topic in detailed, Might be you had tested with previous manila patch where field was \u0027backup state\u0027, it should work now as I pushed new manila patch.\n\nAvailability zone added in db call.","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class ShowShareBackup(command.ShowOne):"},{"line_number":218,"context_line":"    \"\"\"Show share backup.\"\"\""},{"line_number":219,"context_line":"    _description \u003d _(\"Show details about a backup\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def get_parser(self, prog_name):"},{"line_number":222,"context_line":"        parser \u003d super(ShowShareBackup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":24,"id":"bb158d91_556de498","line":219,"range":{"start_line":219,"start_character":35,"end_line":219,"end_character":42},"updated":"2023-08-23 21:44:15.000000000","message":"nit: of a","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"class ShowShareBackup(command.ShowOne):"},{"line_number":218,"context_line":"    \"\"\"Show share backup.\"\"\""},{"line_number":219,"context_line":"    _description \u003d _(\"Show details about a backup\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def get_parser(self, prog_name):"},{"line_number":222,"context_line":"        parser \u003d super(ShowShareBackup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":24,"id":"75bdb3dd_2727ad83","line":219,"range":{"start_line":219,"start_character":35,"end_line":219,"end_character":42},"in_reply_to":"bb158d91_556de498","updated":"2023-08-24 14:54:53.000000000","message":"Done","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            default\u003dNone,"},{"line_number":280,"context_line":"            help\u003d_(\"Set a description to the backup.\")"},{"line_number":281,"context_line":"        )"},{"line_number":282,"context_line":"        parser.add_argument("},{"line_number":283,"context_line":"            \"--status\","},{"line_number":284,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":285,"context_line":"            choices\u003d[\u0027available\u0027, \u0027error\u0027, \u0027creating\u0027, \u0027deleting\u0027,"},{"line_number":286,"context_line":"                     \u0027restoring\u0027],"},{"line_number":287,"context_line":"            help\u003d_(\"Assign a status to the backup(Admin only). \""},{"line_number":288,"context_line":"                   \"Options include : available, error, creating, \""},{"line_number":289,"context_line":"                   \"deleting, restoring.\")"},{"line_number":290,"context_line":"        )"},{"line_number":291,"context_line":"        return parser"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":24,"id":"bcbcf6f9_e49b8029","line":290,"range":{"start_line":282,"start_character":8,"end_line":290,"end_character":9},"updated":"2023-08-23 21:44:15.000000000","message":"this isn\u0027t working, please take a look:\nhttps://paste.opendev.org/show/bKw8CSmnrvcQY1eteVYP/","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            default\u003dNone,"},{"line_number":280,"context_line":"            help\u003d_(\"Set a description to the backup.\")"},{"line_number":281,"context_line":"        )"},{"line_number":282,"context_line":"        parser.add_argument("},{"line_number":283,"context_line":"            \"--status\","},{"line_number":284,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":285,"context_line":"            choices\u003d[\u0027available\u0027, \u0027error\u0027, \u0027creating\u0027, \u0027deleting\u0027,"},{"line_number":286,"context_line":"                     \u0027restoring\u0027],"},{"line_number":287,"context_line":"            help\u003d_(\"Assign a status to the backup(Admin only). \""},{"line_number":288,"context_line":"                   \"Options include : available, error, creating, \""},{"line_number":289,"context_line":"                   \"deleting, restoring.\")"},{"line_number":290,"context_line":"        )"},{"line_number":291,"context_line":"        return parser"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":24,"id":"c0bc06b7_18354203","line":290,"range":{"start_line":282,"start_character":8,"end_line":290,"end_character":9},"in_reply_to":"bcbcf6f9_e49b8029","updated":"2023-08-24 14:54:53.000000000","message":"Done","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":true,"context_lines":[{"line_number":304,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":305,"context_line":"        if parsed_args.description is not None:"},{"line_number":306,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        try:"},{"line_number":309,"context_line":"            share_client.share_backups.update(share_backup, **kwargs)"},{"line_number":310,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":24,"id":"056fc8ea_483d813d","line":307,"updated":"2023-08-23 21:44:15.000000000","message":"you\u0027re missing status here too","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":true,"context_lines":[{"line_number":304,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":305,"context_line":"        if parsed_args.description is not None:"},{"line_number":306,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        try:"},{"line_number":309,"context_line":"            share_client.share_backups.update(share_backup, **kwargs)"},{"line_number":310,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":24,"id":"5dbfce97_9055ad8f","line":307,"in_reply_to":"056fc8ea_483d813d","updated":"2023-08-24 14:54:53.000000000","message":"I had checked share_snapshots and its Unset also does not have status field. WDYT ?","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3445de772a4387ef572b5168f3f88a8acf786d9e","unresolved":false,"context_lines":[{"line_number":304,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":305,"context_line":"        if parsed_args.description is not None:"},{"line_number":306,"context_line":"            kwargs[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        try:"},{"line_number":309,"context_line":"            share_client.share_backups.update(share_backup, **kwargs)"},{"line_number":310,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":24,"id":"efc2dad7_077f1f09","line":307,"in_reply_to":"5dbfce97_9055ad8f","updated":"2023-08-28 19:43:47.000000000","message":"Sounds okay","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a60d864cbcdfc7e1e4a29de11056fe0ac741c3da","unresolved":true,"context_lines":[{"line_number":369,"context_line":"        if parsed_args.description:"},{"line_number":370,"context_line":"            kwargs[\u0027description\u0027] \u003d None"},{"line_number":371,"context_line":"        if not kwargs:"},{"line_number":372,"context_line":"            msg \u003d \"Must supply either name or description.\""},{"line_number":373,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"2e9475fa_445c8a25","line":372,"range":{"start_line":372,"start_character":19,"end_line":372,"end_character":57},"updated":"2023-08-23 21:44:15.000000000","message":"Either name or description must be provided.","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"35bc2a1be67fa29439aa73e99aa66f72dc8373c8","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        if parsed_args.description:"},{"line_number":370,"context_line":"            kwargs[\u0027description\u0027] \u003d None"},{"line_number":371,"context_line":"        if not kwargs:"},{"line_number":372,"context_line":"            msg \u003d \"Must supply either name or description.\""},{"line_number":373,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":24,"id":"d9c8ccb7_1a324163","line":372,"range":{"start_line":372,"start_character":19,"end_line":372,"end_character":57},"in_reply_to":"2e9475fa_445c8a25","updated":"2023-08-24 14:54:53.000000000","message":"Done","commit_id":"30366dfd20e271adddfae369751393c01ff05e8f"}],"manilaclient/tests/functional/osc/test_share_backups.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"063b31172f0a2621af89bb1e5aff80057d2e132a","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            \u0027Updated At\u0027,"},{"line_number":144,"context_line":"            \u0027Size\u0027,"},{"line_number":145,"context_line":"            \u0027Progress\u0027,"},{"line_number":146,"context_line":"            \u0027Remote Progress\u0027,"},{"line_number":147,"context_line":"            \u0027Host\u0027,"},{"line_number":148,"context_line":"            \u0027Topic\u0027,"},{"line_number":149,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":30,"id":"5bd16351_330e2731","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":28},"updated":"2023-08-28 01:17:07.000000000","message":"Restore Progress","commit_id":"72dcffb8c5efb5de66162ab77a99d0fb2995ad19"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"94a9ab1bc55b06ddcabc7b044569a6de5c2e784d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            \u0027Updated At\u0027,"},{"line_number":144,"context_line":"            \u0027Size\u0027,"},{"line_number":145,"context_line":"            \u0027Progress\u0027,"},{"line_number":146,"context_line":"            \u0027Remote Progress\u0027,"},{"line_number":147,"context_line":"            \u0027Host\u0027,"},{"line_number":148,"context_line":"            \u0027Topic\u0027,"},{"line_number":149,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":30,"id":"f065e6fe_6f26b4ea","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":28},"in_reply_to":"1784e02c_3dbad618","updated":"2023-08-29 07:01:30.000000000","message":"Done","commit_id":"72dcffb8c5efb5de66162ab77a99d0fb2995ad19"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"70fb7180237ba06383f2e7054b88135173442c09","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            \u0027Updated At\u0027,"},{"line_number":144,"context_line":"            \u0027Size\u0027,"},{"line_number":145,"context_line":"            \u0027Progress\u0027,"},{"line_number":146,"context_line":"            \u0027Remote Progress\u0027,"},{"line_number":147,"context_line":"            \u0027Host\u0027,"},{"line_number":148,"context_line":"            \u0027Topic\u0027,"},{"line_number":149,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":30,"id":"1784e02c_3dbad618","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":28},"in_reply_to":"5bd16351_330e2731","updated":"2023-08-28 07:35:41.000000000","message":"Not sure, Why I wrote Remote Progress, must be sleepy 😊. Updated.","commit_id":"72dcffb8c5efb5de66162ab77a99d0fb2995ad19"}],"manilaclient/tests/unit/osc/v2/test_share_backups.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from manilaclient import api_versions"},{"line_number":17,"context_line":"from manilaclient.api_versions import MAX_VERSION"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manilaclient.osc.v2 import share_backups as osc_share_backups"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manilaclient.tests.unit.osc import osc_utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"603c02d8_fd8c1533","line":18,"updated":"2023-08-15 22:26:44.000000000","message":"one group for all manilaclient imports..","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"384edbc0fa1c4bc0b6b3340176eb131876e896a4","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from manilaclient import api_versions"},{"line_number":17,"context_line":"from manilaclient.api_versions import MAX_VERSION"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manilaclient.osc.v2 import share_backups as osc_share_backups"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manilaclient.tests.unit.osc import osc_utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"6533cced_d1b11ca6","line":18,"in_reply_to":"603c02d8_fd8c1533","updated":"2023-08-16 09:49:38.000000000","message":"Done","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"}],"manilaclient/tests/unit/v2/test_share_backups.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5c655e32fc070df6a2a5a35a4b24f457187af0d1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Chuck Fouts."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d368338a","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":29},"updated":"2016-07-22 22:09:00.000000000","message":"need to update this","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ff72d05207ef51a9c942172b49db4205eab681d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Chuck Fouts."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_41acda8b","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":29},"in_reply_to":"dada55a8_d368338a","updated":"2016-07-27 08:52:54.000000000","message":"Done","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3242256ffd5ea73a1604e2ac1307601ba771ea5","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(ShareBackupsTest, self).setUp()"},{"line_number":34,"context_line":"        microversion \u003d api_versions.APIVersion(\"2.19\")"},{"line_number":35,"context_line":"        self.manager \u003d share_backups.ShareBackupManager("},{"line_number":36,"context_line":"            fakes.FakeClient(api_version\u003dmicroversion))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3098e069","line":34,"range":{"start_line":34,"start_character":50,"end_line":34,"end_character":52},"updated":"2016-08-12 00:54:01.000000000","message":"2.20","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        super(ShareBackupsTest, self).setUp()"},{"line_number":34,"context_line":"        microversion \u003d api_versions.APIVersion(\"2.19\")"},{"line_number":35,"context_line":"        self.manager \u003d share_backups.ShareBackupManager("},{"line_number":36,"context_line":"            fakes.FakeClient(api_version\u003dmicroversion))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_50c1f27f","line":34,"range":{"start_line":34,"start_character":50,"end_line":34,"end_character":52},"in_reply_to":"9ad45d7e_3098e069","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b535f1e482ff0eb73f201774b9a73254111bd502","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"class ShareBackupsTest(utils.TestCase):"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    class _FakeShareBackup(object):"},{"line_number":30,"context_line":"        id \u003d \u0027fake_share_backup_id\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_7d812e4a","line":27,"updated":"2016-09-05 09:39:30.000000000","message":"missing backup creation tests?","commit_id":"ca49f1032098a86a3d111eff2b9d5adf9f58cfe6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b535f1e482ff0eb73f201774b9a73254111bd502","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                share_backups.RESOURCE_PATH % FAKE_BACKUP,"},{"line_number":56,"context_line":"                share_backups.RESOURCE_NAME)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_restore(self):"},{"line_number":59,"context_line":"        with mock.patch.object(self.manager, \u0027_action\u0027, mock.Mock()):"},{"line_number":60,"context_line":"            self.manager.restore(FAKE_BACKUP, \u0027fake_share_id\u0027, False)"},{"line_number":61,"context_line":"            self.manager._action.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_ba22dcb7","line":58,"updated":"2016-09-05 09:39:30.000000000","message":"how about the scenario that share to restore is not specified.","commit_id":"ca49f1032098a86a3d111eff2b9d5adf9f58cfe6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":true,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":"from unittest import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from manilaclient import api_versions"},{"line_number":17,"context_line":"from manilaclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"e84e8a81_2418b5bd","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":25},"updated":"2023-08-15 22:26:44.000000000","message":"this is a stdlib import, please place in a separate group on the top","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"384edbc0fa1c4bc0b6b3340176eb131876e896a4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":"from unittest import mock"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from manilaclient import api_versions"},{"line_number":17,"context_line":"from manilaclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"f58fc657_349fcd4b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":25},"in_reply_to":"e84e8a81_2418b5bd","updated":"2023-08-16 09:49:38.000000000","message":"Done","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"}],"manilaclient/v2/share_backups.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3242256ffd5ea73a1604e2ac1307601ba771ea5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Chuck Fouts."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b0acd08c","line":1,"range":{"start_line":1,"start_character":11,"end_line":1,"end_character":29},"updated":"2016-08-12 00:54:01.000000000","message":"it doesn\u0027t seem like you copied the whole file, so I guess this is not valid.","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Chuck Fouts."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_25123a63","line":1,"range":{"start_line":1,"start_character":11,"end_line":1,"end_character":29},"in_reply_to":"9ad45d7e_b0acd08c","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3242256ffd5ea73a1604e2ac1307601ba771ea5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Manage :class:`ShareBackup` resources.\"\"\""},{"line_number":35,"context_line":"    resource_class \u003d ShareBackup"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":38,"context_line":"    @api_versions.experimental_api"},{"line_number":39,"context_line":"    def get(self, backup):"},{"line_number":40,"context_line":"        \"\"\"Get a share backup."}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d0bb44c2","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":29},"updated":"2016-08-12 00:54:01.000000000","message":"2.20","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Manage :class:`ShareBackup` resources.\"\"\""},{"line_number":35,"context_line":"    resource_class \u003d ShareBackup"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @api_versions.wraps(\"2.19\")"},{"line_number":38,"context_line":"    @api_versions.experimental_api"},{"line_number":39,"context_line":"    def get(self, backup):"},{"line_number":40,"context_line":"        \"\"\"Get a share backup."}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_05173e52","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":29},"in_reply_to":"9ad45d7e_d0bb44c2","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"757549c41c6ff9ebb63648b53ca8167cac01377e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"List all share backups or list backups belonging to a share."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param share: either share object or its UUID."},{"line_number":54,"context_line":"        :rtype: list of :class:`Sharebackup`"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        if share:"},{"line_number":57,"context_line":"            share_id \u003d \u0027?share_id\u003d\u0027 + common_base.getid(share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_6057b6ce","line":54,"range":{"start_line":54,"start_character":32,"end_line":54,"end_character":43},"updated":"2016-07-29 05:58:05.000000000","message":"ShareBackup","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \"\"\"List all share backups or list backups belonging to a share."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        :param share: either share object or its UUID."},{"line_number":54,"context_line":"        :rtype: list of :class:`Sharebackup`"},{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        if share:"},{"line_number":57,"context_line":"            share_id \u003d \u0027?share_id\u003d\u0027 + common_base.getid(share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_70134e5d","line":54,"range":{"start_line":54,"start_character":32,"end_line":54,"end_character":43},"in_reply_to":"bacf61ea_6057b6ce","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"757549c41c6ff9ebb63648b53ca8167cac01377e","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param share: The share to create the backup of. Can be the share"},{"line_number":70,"context_line":"        object or its UUID."},{"line_number":71,"context_line":"        :param driver_option:"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        share_id \u003d common_base.getid(share)"},{"line_number":74,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_e0272662","line":71,"updated":"2016-07-29 05:58:05.000000000","message":"Please finish the rest parameters.","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param share: The share to create the backup of. Can be the share"},{"line_number":70,"context_line":"        object or its UUID."},{"line_number":71,"context_line":"        :param driver_option:"},{"line_number":72,"context_line":"        \"\"\""},{"line_number":73,"context_line":"        share_id \u003d common_base.getid(share)"},{"line_number":74,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_b01dc668","line":71,"in_reply_to":"bacf61ea_e0272662","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5c655e32fc070df6a2a5a35a4b24f457187af0d1","unresolved":false,"context_lines":[{"line_number":3449,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":3450,"context_line":"    default\u003dNone)"},{"line_number":3451,"context_line":"@cliutils.arg("},{"line_number":3452,"context_line":"    \u0027--preserve_metadata\u0027,"},{"line_number":3453,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":3454,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3455,"context_line":"    required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_b395bf89","line":3452,"range":{"start_line":3452,"start_character":4,"end_line":3452,"end_character":25},"updated":"2016-07-22 22:09:00.000000000","message":"add \u0027--preserve-metadata\u0027 as well","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ff72d05207ef51a9c942172b49db4205eab681d","unresolved":false,"context_lines":[{"line_number":3449,"context_line":"    help\u003d\u0027Driver option key\u003dvalue pairs (Optional, Default\u003dNone).\u0027,"},{"line_number":3450,"context_line":"    default\u003dNone)"},{"line_number":3451,"context_line":"@cliutils.arg("},{"line_number":3452,"context_line":"    \u0027--preserve_metadata\u0027,"},{"line_number":3453,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":3454,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3455,"context_line":"    required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_06717d76","line":3452,"range":{"start_line":3452,"start_character":4,"end_line":3452,"end_character":25},"in_reply_to":"dada55a8_b395bf89","updated":"2016-07-27 08:52:54.000000000","message":"Done","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5c655e32fc070df6a2a5a35a4b24f457187af0d1","unresolved":false,"context_lines":[{"line_number":3453,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":3454,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3455,"context_line":"    required\u003dFalse,"},{"line_number":3456,"context_line":"    help\u003d\u0027Enables or disables preserve share metadata. \u0027"},{"line_number":3457,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":3458,"context_line":"    default\u003dTrue)"},{"line_number":3459,"context_line":"@cliutils.arg("},{"line_number":3460,"context_line":"    \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_13edab25","line":3457,"range":{"start_line":3456,"start_character":10,"end_line":3457,"end_character":23},"updated":"2016-07-22 22:09:00.000000000","message":"Please describe better what this option does","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ff72d05207ef51a9c942172b49db4205eab681d","unresolved":false,"context_lines":[{"line_number":3453,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":3454,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3455,"context_line":"    required\u003dFalse,"},{"line_number":3456,"context_line":"    help\u003d\u0027Enables or disables preserve share metadata. \u0027"},{"line_number":3457,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":3458,"context_line":"    default\u003dTrue)"},{"line_number":3459,"context_line":"@cliutils.arg("},{"line_number":3460,"context_line":"    \u0027--description\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_06c97d59","line":3457,"range":{"start_line":3456,"start_character":10,"end_line":3457,"end_character":23},"in_reply_to":"dada55a8_13edab25","updated":"2016-07-27 08:52:54.000000000","message":"Done","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5c655e32fc070df6a2a5a35a4b24f457187af0d1","unresolved":false,"context_lines":[{"line_number":3511,"context_line":"    \u0027backup\u0027,"},{"line_number":3512,"context_line":"    metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":3513,"context_line":"    help\u003d\u0027ID of backup to restore.\u0027)"},{"line_number":3514,"context_line":"@cliutils.arg("},{"line_number":3515,"context_line":"    \u0027--share-id\u0027,"},{"line_number":3516,"context_line":"    \u0027--share_id\u0027,"},{"line_number":3517,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":3518,"context_line":"    help\u003d\u0027Name or ID of share to which to restore. Default\u003dNone.\u0027,"},{"line_number":3519,"context_line":"    required\u003dFalse,"},{"line_number":3520,"context_line":"    action\u003d\u0027single_alias\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_53456315","line":3517,"range":{"start_line":3514,"start_character":4,"end_line":3517,"end_character":25},"updated":"2016-07-22 22:09:00.000000000","message":"shouldn\u0027t it be \u0027--share\u0027 and \u003cshare\u003e if you accept the name?","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ff72d05207ef51a9c942172b49db4205eab681d","unresolved":false,"context_lines":[{"line_number":3511,"context_line":"    \u0027backup\u0027,"},{"line_number":3512,"context_line":"    metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":3513,"context_line":"    help\u003d\u0027ID of backup to restore.\u0027)"},{"line_number":3514,"context_line":"@cliutils.arg("},{"line_number":3515,"context_line":"    \u0027--share-id\u0027,"},{"line_number":3516,"context_line":"    \u0027--share_id\u0027,"},{"line_number":3517,"context_line":"    metavar\u003d\u0027\u003cshare_id\u003e\u0027,"},{"line_number":3518,"context_line":"    help\u003d\u0027Name or ID of share to which to restore. Default\u003dNone.\u0027,"},{"line_number":3519,"context_line":"    required\u003dFalse,"},{"line_number":3520,"context_line":"    action\u003d\u0027single_alias\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_e6e429e1","line":3517,"range":{"start_line":3514,"start_character":4,"end_line":3517,"end_character":25},"in_reply_to":"dada55a8_53456315","updated":"2016-07-27 08:52:54.000000000","message":"Done","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5c655e32fc070df6a2a5a35a4b24f457187af0d1","unresolved":false,"context_lines":[{"line_number":3519,"context_line":"    required\u003dFalse,"},{"line_number":3520,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3521,"context_line":"    default\u003dNone)"},{"line_number":3522,"context_line":"@cliutils.arg("},{"line_number":3523,"context_line":"    \u0027--preserve_metadata\u0027,"},{"line_number":3524,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":3525,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3526,"context_line":"    required\u003dFalse,"},{"line_number":3527,"context_line":"    help\u003d\u0027Enables or disables preserve share metadata. \u0027"},{"line_number":3528,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":3529,"context_line":"    default\u003dTrue)"},{"line_number":3530,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3531,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_d3e31332","line":3528,"range":{"start_line":3522,"start_character":0,"end_line":3528,"end_character":25},"updated":"2016-07-22 22:09:00.000000000","message":"same as above","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ff72d05207ef51a9c942172b49db4205eab681d","unresolved":false,"context_lines":[{"line_number":3519,"context_line":"    required\u003dFalse,"},{"line_number":3520,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3521,"context_line":"    default\u003dNone)"},{"line_number":3522,"context_line":"@cliutils.arg("},{"line_number":3523,"context_line":"    \u0027--preserve_metadata\u0027,"},{"line_number":3524,"context_line":"    metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":3525,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3526,"context_line":"    required\u003dFalse,"},{"line_number":3527,"context_line":"    help\u003d\u0027Enables or disables preserve share metadata. \u0027"},{"line_number":3528,"context_line":"         \u0027Default\u003dTrue.\u0027,"},{"line_number":3529,"context_line":"    default\u003dTrue)"},{"line_number":3530,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3531,"context_line":"def do_backup_restore(cs, args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_a61351b7","line":3528,"range":{"start_line":3522,"start_character":0,"end_line":3528,"end_character":25},"in_reply_to":"dada55a8_d3e31332","updated":"2016-07-27 08:52:54.000000000","message":"Done","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"5c655e32fc070df6a2a5a35a4b24f457187af0d1","unresolved":false,"context_lines":[{"line_number":3533,"context_line":""},{"line_number":3534,"context_line":"     (Experimental)."},{"line_number":3535,"context_line":"    \"\"\""},{"line_number":3536,"context_line":"    cs.share_backups.restore(args.backup, args.share_id,"},{"line_number":3537,"context_line":"                             args.preserve_metadata)"},{"line_number":3538,"context_line":""},{"line_number":3539,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_f35457cb","line":3536,"range":{"start_line":3536,"start_character":4,"end_line":3536,"end_character":56},"updated":"2016-07-22 22:09:00.000000000","message":"I think you need to find the share and get its ID if you accept the name.","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ff72d05207ef51a9c942172b49db4205eab681d","unresolved":false,"context_lines":[{"line_number":3533,"context_line":""},{"line_number":3534,"context_line":"     (Experimental)."},{"line_number":3535,"context_line":"    \"\"\""},{"line_number":3536,"context_line":"    cs.share_backups.restore(args.backup, args.share_id,"},{"line_number":3537,"context_line":"                             args.preserve_metadata)"},{"line_number":3538,"context_line":""},{"line_number":3539,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_01a662ad","line":3536,"range":{"start_line":3536,"start_character":4,"end_line":3536,"end_character":56},"in_reply_to":"dada55a8_f35457cb","updated":"2016-07-27 08:52:54.000000000","message":"Done","commit_id":"f19839250d570a997c8af5b88f9407719720c4bc"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"757549c41c6ff9ebb63648b53ca8167cac01377e","unresolved":false,"context_lines":[{"line_number":3505,"context_line":""},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"def _find_share_backup(cs, backup):"},{"line_number":3508,"context_line":"    \"\"\"Get a backup by ID.\"\"\""},{"line_number":3509,"context_line":"    return apiclient_utils.find_resource(cs.share_backups, backup)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_86d48247","line":3508,"range":{"start_line":3508,"start_character":25,"end_line":3508,"end_character":26},"updated":"2016-07-29 05:58:05.000000000","message":"or by name.","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":3505,"context_line":""},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"def _find_share_backup(cs, backup):"},{"line_number":3508,"context_line":"    \"\"\"Get a backup by ID.\"\"\""},{"line_number":3509,"context_line":"    return apiclient_utils.find_resource(cs.share_backups, backup)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_1003fa74","line":3508,"range":{"start_line":3508,"start_character":25,"end_line":3508,"end_character":26},"in_reply_to":"bacf61ea_86d48247","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"757549c41c6ff9ebb63648b53ca8167cac01377e","unresolved":false,"context_lines":[{"line_number":3527,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3528,"context_line":"    required\u003dFalse,"},{"line_number":3529,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3530,"context_line":"    help\u003d\u0027Chooses whether backup should be forced to preserve all file \u0027"},{"line_number":3531,"context_line":"         \u0027metadata when moving its contents. Default\u003dTrue\u0027,"},{"line_number":3532,"context_line":"    default\u003dTrue)"},{"line_number":3533,"context_line":"@api_versions.wraps(\"2.19\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_802f4af5","line":3530,"range":{"start_line":3530,"start_character":26,"end_line":3530,"end_character":32},"updated":"2016-07-29 05:58:05.000000000","message":"restoring","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":3527,"context_line":"    choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":3528,"context_line":"    required\u003dFalse,"},{"line_number":3529,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3530,"context_line":"    help\u003d\u0027Chooses whether backup should be forced to preserve all file \u0027"},{"line_number":3531,"context_line":"         \u0027metadata when moving its contents. Default\u003dTrue\u0027,"},{"line_number":3532,"context_line":"    default\u003dTrue)"},{"line_number":3533,"context_line":"@api_versions.wraps(\"2.19\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_b00306b8","line":3530,"range":{"start_line":3530,"start_character":26,"end_line":3530,"end_character":32},"in_reply_to":"bacf61ea_802f4af5","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"757549c41c6ff9ebb63648b53ca8167cac01377e","unresolved":false,"context_lines":[{"line_number":3546,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":3547,"context_line":"    default\u003dNone,"},{"line_number":3548,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3549,"context_line":"    help\u003d\u0027List backups belonging to share.\u0027)"},{"line_number":3550,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3551,"context_line":"def do_backup_list(cs, args):"},{"line_number":3552,"context_line":"    \"\"\"List share backups (Experimental).\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_60221602","line":3549,"range":{"start_line":3549,"start_character":10,"end_line":3549,"end_character":41},"updated":"2016-07-29 05:58:05.000000000","message":"List all backups or belonging to a share.","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":3546,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":3547,"context_line":"    default\u003dNone,"},{"line_number":3548,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3549,"context_line":"    help\u003d\u0027List backups belonging to share.\u0027)"},{"line_number":3550,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3551,"context_line":"def do_backup_list(cs, args):"},{"line_number":3552,"context_line":"    \"\"\"List share backups (Experimental).\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_b0adc68a","line":3549,"range":{"start_line":3549,"start_character":10,"end_line":3549,"end_character":41},"in_reply_to":"bacf61ea_60221602","updated":"2016-08-15 08:19:59.000000000","message":"If you use this parameter, you can only list backups belonging to share.","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"757549c41c6ff9ebb63648b53ca8167cac01377e","unresolved":false,"context_lines":[{"line_number":3553,"context_line":"    share \u003d _find_share(cs, args.share) if args.share else None"},{"line_number":3554,"context_line":""},{"line_number":3555,"context_line":"    list_of_keys \u003d ["},{"line_number":3556,"context_line":"        \u0027ID\u0027,"},{"line_number":3557,"context_line":"        \u0027Status\u0027,"},{"line_number":3558,"context_line":"        \u0027Backup State\u0027,"},{"line_number":3559,"context_line":"        \u0027Share ID\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_9b2cdb03","line":3556,"updated":"2016-07-29 05:58:05.000000000","message":"\u0027name\u0027?","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3242256ffd5ea73a1604e2ac1307601ba771ea5","unresolved":false,"context_lines":[{"line_number":3573,"context_line":"    \u0027backup\u0027,"},{"line_number":3574,"context_line":"    metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":3575,"context_line":"    help\u003d\u0027ID of the share backup.\u0027)"},{"line_number":3576,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3577,"context_line":"def do_backup_show(cs, args):"},{"line_number":3578,"context_line":"    \"\"\"Show details about a backup (Experimental).\"\"\""},{"line_number":3579,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d0098496","line":3576,"range":{"start_line":3576,"start_character":23,"end_line":3576,"end_character":25},"updated":"2016-08-12 00:54:01.000000000","message":"2.20 and all other occurrences.","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":3573,"context_line":"    \u0027backup\u0027,"},{"line_number":3574,"context_line":"    metavar\u003d\u0027\u003cbackup\u003e\u0027,"},{"line_number":3575,"context_line":"    help\u003d\u0027ID of the share backup.\u0027)"},{"line_number":3576,"context_line":"@api_versions.wraps(\"2.19\")"},{"line_number":3577,"context_line":"def do_backup_show(cs, args):"},{"line_number":3578,"context_line":"    \"\"\"Show details about a backup (Experimental).\"\"\""},{"line_number":3579,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_d0d7a221","line":3576,"range":{"start_line":3576,"start_character":23,"end_line":3576,"end_character":25},"in_reply_to":"9ad45d7e_d0098496","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b535f1e482ff0eb73f201774b9a73254111bd502","unresolved":false,"context_lines":[{"line_number":3594,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":3595,"context_line":"    help\u003d\u0027Name or ID of share to which to restore. Default\u003dNone.\u0027,"},{"line_number":3596,"context_line":"    required\u003dFalse,"},{"line_number":3597,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3598,"context_line":"    default\u003dNone)"},{"line_number":3599,"context_line":"@cliutils.arg("},{"line_number":3600,"context_line":"    \u0027--preserve_metadata\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_e7813191","line":3597,"updated":"2016-09-05 09:39:30.000000000","message":"Is it necessary specify this while this argument only got one name?","commit_id":"ca49f1032098a86a3d111eff2b9d5adf9f58cfe6"},{"author":{"_account_id":16203,"name":"zengyingzhe","email":"zengyingzhe@huawei.com","username":"zengyingzhe"},"change_message_id":"b535f1e482ff0eb73f201774b9a73254111bd502","unresolved":false,"context_lines":[{"line_number":3621,"context_line":"    \u0027--share\u0027,"},{"line_number":3622,"context_line":"    metavar\u003d\u0027\u003cshare\u003e\u0027,"},{"line_number":3623,"context_line":"    default\u003dNone,"},{"line_number":3624,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":3625,"context_line":"    help\u003d\u0027List backups belonging to share.\u0027)"},{"line_number":3626,"context_line":"@api_versions.wraps(\"2.21\")"},{"line_number":3627,"context_line":"def do_backup_list(cs, args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_ba101c50","line":3624,"updated":"2016-09-05 09:39:30.000000000","message":"ditto","commit_id":"ca49f1032098a86a3d111eff2b9d5adf9f58cfe6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0d08779d_6e018603","updated":"2023-08-15 22:26:44.000000000","message":"I want to reiterate that we do not want to make feature changes to this client. We\u0027re actively deprecating it","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"94a9ab1bc55b06ddcabc7b044569a6de5c2e784d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"ba5ad1f3_e0332229","in_reply_to":"07f60532_550365ef","updated":"2023-08-29 07:01:30.000000000","message":"removed changes of shell.py","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"384edbc0fa1c4bc0b6b3340176eb131876e896a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"443fc6df_3d749eb4","in_reply_to":"0d08779d_6e018603","updated":"2023-08-16 09:49:38.000000000","message":"Ok, I will remove those in final iteration before merge.","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3445de772a4387ef572b5168f3f88a8acf786d9e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":20,"id":"07f60532_550365ef","in_reply_to":"443fc6df_3d749eb4","updated":"2023-08-28 19:43:47.000000000","message":"please remove :)","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f309c0dcd70c8ea5ffd30a70b4684e41345b63e8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":25,"id":"8f61902a_d6263c1f","line":7219,"updated":"2023-08-25 02:01:33.000000000","message":"add backup reste state;\n\n    @cliutils.arg(\n        \u0027backup\u0027,\n        metavar\u003d\u0027\u003cbackup\u003e\u0027,\n        help\u003d\u0027Name or ID of the backup to update.\u0027)\n    @cliutils.arg(\n        \u0027--state\u0027,\n        metavar\u003d\u0027\u003cstate\u003e\u0027,\n        default\u003d\u0027available\u0027,\n        help\u003d(\u0027Indicate which state to assign the backup. \u0027\n              \u0027Options include available, error, creating, deleting, \u0027\n              \u0027error_deleting. If no state is provided, \u0027\n              \u0027available will be used.\u0027))\n    def do_backup_reset_state(cs, args):\n        \"\"\"Explicitly update the state of a backup (Admin only).\"\"\"\n        backup \u003d _find_share_backup(cs, args.backup)\n        cs.share_backups.reset_status(backup, args.state)","commit_id":"cb62f5cea3071fa82da7ccf0d49d540c4aa81a0f"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"063b31172f0a2621af89bb1e5aff80057d2e132a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"6257b28c_e1f5ed5e","line":7219,"in_reply_to":"8e001021_e35b09ec","updated":"2023-08-28 01:17:07.000000000","message":"thanks.","commit_id":"cb62f5cea3071fa82da7ccf0d49d540c4aa81a0f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ddd9cfa8efa9b02645bcb28f948e07896341e143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"8e001021_e35b09ec","line":7219,"in_reply_to":"8f61902a_d6263c1f","updated":"2023-08-26 13:22:39.000000000","message":"Since there is PR of manilaclient removal, I stopped updating shell.py and related tests. But since you added here, I have added this function in shell.py. Thanks","commit_id":"cb62f5cea3071fa82da7ccf0d49d540c4aa81a0f"}],"releasenotes/notes/share-backup-35d4522f288836re.yaml":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"d3242256ffd5ea73a1604e2ac1307601ba771ea5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Added share backup feature."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9ad45d7e_70fb7879","line":3,"range":{"start_line":3,"start_character":23,"end_line":3,"end_character":30},"updated":"2016-08-12 00:54:01.000000000","message":"CLI","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a8c3f902790150d231fc6c997e39e33df876281b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Added share backup feature."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3ac371cc_0540de55","line":3,"range":{"start_line":3,"start_character":23,"end_line":3,"end_character":30},"in_reply_to":"9ad45d7e_70fb7879","updated":"2016-08-15 08:19:59.000000000","message":"Done","commit_id":"77f2dbc3fd602df1952256f4a1cc5c55a295eb60"}],"releasenotes/notes/share-backup-98e11c6a28897e94.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9f88e9b8be70e175da1571f60d347d4340c70e2d","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    With share-backup feature, backup of share can be created, deleted,"},{"line_number":5,"context_line":"    listed, queried for detail, updated its name/description and also"},{"line_number":6,"context_line":"    restored to original share. Available from microversion 2.80."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ab0d8a97_d0a6ea3f","line":5,"range":{"start_line":5,"start_character":31,"end_line":5,"end_character":60},"updated":"2023-08-15 22:26:44.000000000","message":"nit: grammatically incorrect; \n\n\n\"Added support for share backup APIs in the SDK and the openstackclient plugin.\n You can use the openstack client to create a backup, restore a backup, \n delete a backup, list backups with filters, and update the name and\n description fields of a backup.\"","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"384edbc0fa1c4bc0b6b3340176eb131876e896a4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    With share-backup feature, backup of share can be created, deleted,"},{"line_number":5,"context_line":"    listed, queried for detail, updated its name/description and also"},{"line_number":6,"context_line":"    restored to original share. Available from microversion 2.80."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ae675d3e_1307ab35","line":5,"range":{"start_line":5,"start_character":31,"end_line":5,"end_character":60},"in_reply_to":"ab0d8a97_d0a6ea3f","updated":"2023-08-16 09:49:38.000000000","message":"Done","commit_id":"e6f511dfc5a699ac9eda1d5fc6d24288b1fa4df7"}]}